Advance the progress value by the group's children count when
LoopUntil handler returns false on the first iteration.
Add a test for it.
Change-Id: I3783dd295dfaa16c09c5eda299f365ff981b3be7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
There are still tools around that have problems with such setups, so we
turn this warning on by default and let the user opt out.
Fixes: QTCREATORBUG-20834
Change-Id: I01a2e0fa931bec74add43b37cb042712635f3175
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Splits the functionality between plugin type specific and general.
Allows Plugins to be loaded after the first pass, e.g. for Lua scripted
plugins.
Change-Id: If2712817a672c49d554fdc308250cb06ca7eb3f8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
On session switch we cancel all the running tasks.
We connect to the SessionManager::aboutToLoadSession()
signal, as this one is emitted just before loading
new session's projects. We don't connect to
SessionManager::aboutToUnloadSession(), since after
this signal is emitted the unloading may be canceled
due to e.g. showing the dialog asking for saving
changed files in the unloaded session (the user may
cancel the process of unloading).
In contrast to what we do on shutdown, we don't wait
for futures being finished here - it's just enough we
cancel all of them.
Fixes: QTCREATORBUG-25583
Change-Id: I01eeca00d150f6e98a80a050c6a19efb848b9954
Reviewed-by: hjk <hjk@qt.io>
Rename namevaluemodel.{h,cpp} back to environmentmodel.{h,cpp}
Change-Id: Idfa528b0c1c307ef4cd9dd5869f18993647b98bc
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The abstraction is nowhere used (anymore?)
In order to keep the diff small, this here merges environmentmodel.{h,cpp}
into namevaluemodel.{h,cpp} which will be renamed back to env* in a
second step.
Change-Id: I1e7c14012ec3d3f54d8557f4b737a59ede2283e7
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Amends 1a84ae038d which enabled building
the Nanotrace library by default. The part that is used for startup
performance logging is only enabled at runtime with the `-trace` command
line argument, but some logging using the "hr" variant was automatically
created. Disable that part at compile time by default.
Fixes: QTCREATORBUG-30331
Change-Id: I8add207c760bfe2dde52534f55feb7b637ccb600
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
More direct communication of the meaning. Use 'length' when talking
about things like string lengths, and 'size' for sizes in bytes.
Task-number: QTCREATORBUG-30065
Change-Id: Ifed84a5dab4ed890973c1abf4d427655eb50a61a
Reviewed-by: David Schulz <david.schulz@qt.io>
This was not adding the length before.
The problem that the size is suddenly off by a factor of two for
QString as elision counts bytes is still present.
Change-Id: Ibcb595dc2d9aaa73b3feec955b4d14613307797f
Reviewed-by: David Schulz <david.schulz@qt.io>
Make it possible to PUT, POST and DELETE.
Add setWriteData() method, to be used with PUT and POST.
Change-Id: I99da38b60120b7efdab391db9b4d638f17d555df
Reviewed-by: hjk <hjk@qt.io>
- Consider qmlModules file like any other qml module
- Use ${CMAKE_PROJECT_NAME} when possible
- Break up big functions into smaller ones
- Reorder arguments for tpl files
Change-Id: Ie73cca8596b22adf67eba1019610a00c34976421
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
... in MiniProjectTargetSelector.
It's unclear what the intention was, but the effect was that the widget
was growing after every project switch.
Fixes: QTCREATORBUG-28954
Change-Id: Iea83243194c08ebb3caf78bc058774f17f23eced
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The c'tor of QmlJSEditorFactory allocates QmlJSCompletionAssistProvider
and sets it via setCompletionAssistProvider.
The QbsEditorFactory subclass allocates QbsCompletionAssistProvider
and overrides the previous one via setCompletionAssistProvider.
So, the old one was leaking.
Use std::unique_ptr to ensure the ownership.
Change-Id: I6fb7da2b97c50919e422482c858d3503403b788d
Reviewed-by: David Schulz <david.schulz@qt.io>
Fetch issues for all kinds of issues instead of just
style violations.
Change-Id: I23508ae3c051cabab644f359daec4924034cb65c
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Zoom must scale the component showing the preview, not the source
image. This way the effect stays consistent regardless of the zoom
level.
Fixes: QDS-11899
Change-Id: I550eb9ff693c24a853f5c25d9d79fa146448663f
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
This fixes drawing of search hits across the 2^31 boundary.
Searching itself is still buggy.
Change-Id: Icac1722e2693585aa7afe62076ccec9459c18f3a
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Regarding QTCREATORBUG-30288, before this change I was getting on macOS
presets for Linux and Windows.
Fixes: QTCREATORBUG-30236
Fixes: QTCREATORBUG-30288
Change-Id: I4772ab7d14dec857b68164d4c24e6e904f20c88b
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Both VcsBaseClient::vcsBinary() and VcsBaseClient::processEnvironment()
get an additional parameter "FilePath target" to allow selecting binaries
and environment based on where the repository is located.
This allows to select e.g. a git binary on a remote device, and the
environment of the remote device for each VCS operation.
A bunch of file path operations are either fixed or ported to actually use
FilePath correctly.
Change-Id: I6afc645772fde3dff3ec19c13efe538e5888e952
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
