Keep the user data outside of combo boxes.
Use addItems(), which should probably be the fastest
insertion method.
Change-Id: Iec7e3fbe551a30e6a0e477e93add9c474c7f41fc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The action is present for some time, but so far it had been
unimplemented.
Change-Id: I75722282cbe08aad6656e193822a5cb517ba17b3
Reviewed-by: David Schulz <david.schulz@qt.io>
For the users that have a space in their user name, the location of the
shellintegration.ps1 is a path with a space in it.
This patchset fixes the escaping of that space.
Change-Id: Iae84b2e8a8f1b4e2b7e523e28417caaeb77bc5cd
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Previously a "1" was printed every time a powershell terminal
was started.
Change-Id: Ibd6f9dc9de8ba11ede98e13ca2f65ba5a99536fb
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
The shellintegration script escape the current working dir.
We were missing the code to unescape the paths.
This was particularly visible on Windows powershell
where backslash was escaped by "\x5c".
Change-Id: If697722986c72ebbc19d5ec8e3930321f3af7b6a
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This seems to even out some of the huge lookup spikes here.
Change-Id: I594c84dfd053be5626cd1f8c423ef00c7c77f37c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This allows the user to reload the presets kits after editing
CMakePresets.json without configuring the project first.
Fixes: QTCREATORBUG-30238
Change-Id: Id448dd8e821591f6357ec9618f114733c13a3121
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This removes it from the central public header.
Change-Id: Icf1c552f9136a2e262e1bc48ae164b2fdd8edc79
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The classes derived from this had a dual role of implementing the
version control interface (IVersionControl) and as the plugin pimpls.
The name was focusing on the latter, but plugin pimpls are being phased
out in the new 'setupFoo()' world, so only the version control interface
part remains.
Change-Id: I60396f1729c736bc6c9e4fca250a5926e9d60f51
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Now effects made with effect composer can be hidden/shown using
visible property.
Fixes: QDS-11786
Change-Id: I44782246adfa3ba3cd0a8203fa67b3f5412535f7
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Move the initialization of the traceToken into c'tors.
Otherwise, the following error occurs:
internal compiler error: in assign_temp, at function.c:986
Change-Id: I20abfbf70e01fc6268ae6d4245272ef3a89daed5
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Previously returning std::nullopt from a StringAspect::ValueAcceptor
would not cancel the change.
Change-Id: I7a329f9fe32f6d798c10102a0b68dcd638fb2398
Reviewed-by: hjk <hjk@qt.io>
Useful for unnamed action builders that want to give access to their
command to outsiders.
Change-Id: I71ba40776eee1d2eaeeded7c2b912c8e1d07f466
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
It has been wrong forever, but it just doesn't make
sense to have an add action for remote branches.
Change-Id: Ia9a96d85f95821f27215e0a172435f38abcd685f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
We want to return an empty string when "Remote Branches"
is selected, instead of an empty optional.
Broken by 224e4eeb59
Change-Id: I5af06fafec48910226fdedf4a15079444cc54b6e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
The key is a pointer, so use QHash.
Simplify some lookups.
Change-Id: I58245193e9a94bca0629cced057ba1465214d812
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
When we ask QIcon for a pixmap, we should afterwards respect the
resulting pixmap's devicePixelRatio, regardless of what we requested.
Task-number: QTBUG-121764
Change-Id: I289823f7d1a5ae1e341a78cc7ce3ff897be092f3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Get rid of Q_DISABLE_COPY, as copy c'tor is implicitly deleted
anyway because of std::unique_ptr<> field.
This should fix the issue when compiling against C++20,
where the aggregate initialization is disabled for classes that
declare any c'tor, including "= default" or "= delete" declarations.
Change-Id: I9b08fd9c35ce91f8e7368995105f04b98f010c07
Reviewed-by: hjk <hjk@qt.io>
More similar to svn, cc, bzr, and Gives the user a chance to specify
something different. Plan is to make this also work with remote setups
[and possibly a per-device option, or automatism]
Change-Id: I18c1a90642c9cbe2ef9419103f3919c4a19122e5
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
If a new version of same effect is saved, remove files that are
no longer part of the effect from the effect import dir after the save.
Fixes: QDS-11737
Change-Id: Iae4da39f9f4713c2e26f1b90263881c8c9e13d78
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
When needed. Take a short cut on empty strings which can't have macros.
Change-Id: Icc2fb8f001da6be7a9dfec73951d9ac14d2f356f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Using the pid as the process group only works when the process created
it's own process group, which depends how it was started.
If no matching process group exists, kill returns with an error code
and we can try to kill the process itself using its pid instead.
Change-Id: I3ef775458edfb06c02b4445e079badd3ade691a6
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
For QDB devices make sure to only use `appcontroller --stop` when the
process was also started with the appcontroller.
Otherwise fall back to the SshProcessInterface implementation.
Change-Id: I482f7ac9783f57eb8d85bb2b536ff00d428a2c3f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
