feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity
89,589 Commits 108 Branches 368 Tags
afea900b966d202435292cb15101ee71b9299f19
Commit Graph

72811 Commits

Author SHA1 Message Date
hjk
9762f779e1 Debugger: Re-use state updating code on short cut paths 
Change-Id: I37ff47f4d9238abfc58929a9a2e7bd7e8a90385f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2024-02-05 09:08:06 +00:00
David Schulz
76e102a711 TextEditor: replace iterator loop with algorithm 
increases the readability...

Change-Id: I70873cca2e27e949525d0e7e4f29481f7e9eb133
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2024-02-05 09:05:53 +00:00
Jarek Kobus
554f68b573 DeviceUsedPortsGatherer: Introduce done() signal 
And get rid of error() and portListReady() signals.
Inline some internals to have a better overview on what's happening.

Change-Id: Ie8f0afc97b3315600a7fb2076208ba057aa041fa
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2024-02-05 08:58:08 +00:00
Jarek Kobus
f2dbd28165 CircularClipboard: Replace QSharedPointer with std::shared_ptr 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: I3ec37f65318fe1e41f6daf98238a543f85293c48
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
 2024-02-05 08:54:31 +00:00
hjk
ca2a4f771f Python: Remove pluginInstance() and convert users 
Change-Id: I43179961cdee855b710fc082568a7d0d9a0f0719
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2024-02-05 08:54:23 +00:00
Jarek Kobus
f589ed7f1e Diagnostics: Remove unused header 
Change-Id: I3e185a16211d5531c89b068cf0ab5ef93e40d6e0
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2024-02-05 08:53:50 +00:00
David Schulz
a45f058a37 TextEditor: Assert on nullptr bookmarks passed to gotoBookmark 
Task-number: QTCREATORBUG-30283
Change-Id: I1c49e57bbde098c1dda949d15d03d27349b9ce69
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
 2024-02-05 08:53:43 +00:00
Jarek Kobus
b0a0019beb Axivion: Remove axivionresultparser.{cpp,h} 
Rename ShortIssue into Issue and move it to axivionplugin.cpp.

Change-Id: I07a43d7ade7a06560ad130cabcf6933cd36c67e0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2024-02-05 08:52:14 +00:00
Jarek Kobus
3334dfcf53 Axivion: Fix showing marks on project opening 
Inside a slot connected to startupProjectChanged()
connect to Project::fileListChanged() instead of connecting
to ProjectManager::projectFinishedParsing().

Change-Id: I41059ae24138e79747eada1380c5970fbe30b666
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2024-02-05 08:52:09 +00:00
Jarek Kobus
ffcef524a6 Axivion: Use ProjectExplorer namespace 
Change-Id: I78172705c07a14cd4f9adf92e240c3d99b894b2d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2024-02-05 08:52:02 +00:00
Jarek Kobus
d21c550daa Axivion: Get rid of unused Project class 
Change-Id: Id000528f1dc99ffc569ae5f37880b0441843d6a6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2024-02-05 08:51:57 +00:00
Jarek Kobus
a87fcb9ff0 Axivion: Use ref when iterating 
Change-Id: I2fb674435141d1280bf6f36fbd1046ec69001dbc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2024-02-05 08:51:51 +00:00
Jarek Kobus
5f18fb6a2f Axivion: Use TextEditor namespace 
Change-Id: I898f2fb400c2aeba6319b1f350e7a1d8d2dfa15c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2024-02-05 08:51:43 +00:00
Jarek Kobus
547dc01b87 Axivion: Inline AxivionTextMark 
Change-Id: I2f20e8644587bd92db814588c14c14b41a8eeba0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2024-02-05 08:51:38 +00:00
Jarek Kobus
daedaf3d1c Axivion: Don't store issue id inside AxivionTextMark 
Pass it directly to internal lambdas instead.

Change-Id: I2f09004c0fe005e47610a054e308ded19619c438
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2024-02-05 08:51:32 +00:00
Jarek Kobus
6dc54d5506 Axivion: Remove curl setting 
Change-Id: Ib0405584dc14a9404958a5afd41748c8904a534b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2024-02-05 08:51:26 +00:00
Jarek Kobus
391fd0daed Axivion: Remove AxivionQuery 
Not needed anymore.

Change-Id: Ieaf25e3ff3291a6d233ce4542c1ec55a0a97e7b3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2024-02-05 08:51:05 +00:00
Jarek Kobus
6319cb64fe Axivion: Fix html content with the issue info 
Cut the unwanted content of the html received from the server.

Change-Id: If8d679282f4a4fafd3c2ab343c37e4774054f1b0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2024-02-05 08:50:57 +00:00
Jarek Kobus
f2f5c4346e Axivion: Use task tree for fetching issue info 
Change-Id: Ie44f5ea2b076742905d93ee2172b8bcd6bf65897
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2024-02-05 08:50:49 +00:00
Andreas Loth
999a2d7bf8 Axivion: Update generated Dashboard DTO 
* Fix error in the spec
* Rework (optional) enum handling
* Reduce code repetition (thanks to Jarek)
* Apply QtC coding conventions

Change-Id: Ie33773deb6c8fc6f0bb14306e4257d66990c4ca6
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
 2024-02-05 08:43:29 +00:00
hjk
1f5fef5132 Meson: Use Utils::FilePaths in parser 
Change-Id: Idb256110e519c642420580ebd159bcffa11c0f1b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
 2024-02-05 07:08:12 +00:00
hjk
435b35ccfe Ios: Use setup functions for a few factories 
Change-Id: Ide05c2ca859454c1745e5c243af6a3d05131194c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
 2024-02-05 07:06:55 +00:00
hjk
508189339d Meson: Consolidate parsers 
Change-Id: I9c09d22af12a116ea15fcda793bcccd5a12ff840
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
 2024-02-05 07:06:44 +00:00
hjk
df71c6a1f0 Python: Use setup function for remaining plugin items 
... and remove the now-empty plugin pimpl.

Change-Id: I0db27757e832a0e3ac52b938a4d6ad820adfc195
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
 2024-02-05 07:06:30 +00:00
hjk
8dded168fd EmacsKeys: Make plugin soft-loadable 
Change-Id: I42002f7410f165745ba7de68536f66a1653df63f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2024-02-05 06:57:25 +00:00
David Schulz
9296a7fb9c TextEditor: fix crash on activating bookmark in deleted file 
since 23908b283e bookmarks are opened on
double click. But double click also emits an activated. and both signals
are connected to gotoBookmark, so this slot got triggered twice. This is
problematic when the bookmark is not reachable anymore since the first
execution of gotoBookmark deletes unreachable bookmarks, and the second
execution has only a nullptr and passes it to functions not checking
this pointer.

Fixes: QTCREATORBUG-30283
Change-Id: Ia57d0469840d467af31fa5c89745c2ad33aa7e3f
Reviewed-by: Xavier BESSON (Personal) <developer@xavi-b.fr>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2024-02-05 05:41:06 +00:00
Jarek Kobus
e1251f4ac3 CompilerExplorer: Replace QSharedPointer with std::shared_ptr 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: I591de84b86f91adda73848729149e29004277df2
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2024-02-04 15:52:52 +00:00
Marcus Tillmanns
b50e77e858 ProParser: Guard against OOM 
When the pattern for a regular expression is empty, every character
of the source is replaced with a copy of the "after" part of a
"QString::replace(re, after)". If input and output are huge this results
in a bad_alloc. We catch that here.

Fixes: QTCREATORBUG-16957
Change-Id: If512f407a2170d93ae7e4182219d9926945b14de
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
 2024-02-04 13:54:18 +00:00
Jarek Kobus
f96365194c CMakeToolManager: Fix compile warning about unused function 
Amends e7e593b2f6

Change-Id: Ib1d1508294adb3d53a4aa445d00adc39bcc76bbd
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
 2024-02-02 22:15:34 +00:00
Jarek Kobus
ced3cecafa AndroidSdkPackage: Inline most of AndroidSdkPackage subclasses 
Change-Id: Ib3242f9602a352fe0d4b1a6eb19454370e6d046b
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2024-02-02 21:56:43 +00:00
Jarek Kobus
1c4ac36b6d AndroidSdkPackage: Do some cleanup 
Remove unused "parent" argument from c'tors.
Remove repeating "public:" sections.
Remove obvious comment about overrides.
Remove unneeded Q_OBJECT macros.

Change-Id: Ie823ea9b977fdf7f102ce301070a564fd9b44c76
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2024-02-02 21:47:57 +00:00
Jarek Kobus
531a65301e SdkManagerOutputParser: Use parsePackage() for SdkPlatform 
Change-Id: I8695ade91864a7f4cac3758c4d5fff96cc781266
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2024-02-02 21:47:02 +00:00
Cristian Adam
e7e593b2f6 CMakePM: Use junctions for source/build dirs on Windows 
This way we have fixed small (max 64 bytes) paths for CMake's configure
/ build / install steps.

This allows the user to have longer paths and still compile with MSVC /
GCC MinGW compilers.

Fixes: QTCREATORBUG-26786
Task-number: QTBUG-117413
Change-Id: I0cff6521626dd2ce78d0223d46f0b480e977d5c5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2024-02-02 18:51:47 +00:00
Jarek Kobus
656a30b407 IDevice: Replace QSharedPointer with std::shared_ptr 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Replace QWeakPointer with std::weak_ptr.
Replace QEnableSharedFromThis with std::enable_shared_from_this.
Use std::static_pointer_cast and std::dynamic_pointer_cast
for casts used with QSharedPointer before.

Change-Id: If255a100c790860934f36d52906b93f33c31cfe8
Reviewed-by: hjk <hjk@qt.io>
 2024-02-02 16:45:57 +00:00
Alessandro Portale
26c5d0eb29 Fonts: Use H4 instead of H3 
...where we don't want AllUppercase.

Change-Id: I6675833b7535fc8e25504fdb6e6683419e70ea4c
Reviewed-by: hjk <hjk@qt.io>
 2024-02-02 16:44:28 +00:00
hjk
bf69d6891d CppEditor: Move ClangdSettingsWidget definition to .cpp 
... and de-pimpl there.

Change-Id: Ie205ce68de0513184b87b5bf7b6b338435b6a4de
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
 2024-02-02 16:39:42 +00:00
Jarek Kobus
14ff95b1bf Utils: Replace the last QSharedPointer usage with std::shared_ptr 
Replace it in Pty::Data. Remove the usage of shared pointer
from PathListPlainTextEdit.

According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: I5f19edf438eed3dde17b0f9abf570d2b53df93d7
Reviewed-by: hjk <hjk@qt.io>
 2024-02-02 16:06:08 +00:00
Jarek Kobus
37dd482c3b CorePlugin: Replace QSharedPointer with std::shared_ptr 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: Id64f1033ed0a640bb3f02821b3b5f99c7fa3987d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
 2024-02-02 15:56:14 +00:00
Jarek Kobus
536046ebb2 McuSupport: Replace QSharedPointer with std::shared_ptr 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: I88a24afcca773e23d476466338543828337d65c2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
 2024-02-02 15:46:43 +00:00
Miikka Heikkinen
17f12979a6 QmlDesigner: Add extended View3D component library icons 
Fixes: QDS-11811
Change-Id: I0d33311e68b302a531d3e3273d10e6f4e3ff0932
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
 2024-02-02 14:56:22 +00:00
hjk
6f115faa05 CompilerExplorer: Remove unused class declaration 
Change-Id: Idbf95824e5d43eeff84f06c5b08e182d32bf7ef5
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
 2024-02-02 14:06:45 +00:00
Jarek Kobus
fc605d7a76 AutoTest: Replace QSharedPointer with std::shared_ptr 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Move TestParseResultPtr to the common place and don't repeat
this typedef.

Change-Id: Id8523b7898965ea9bfccb8a1bdc6a8ea23f090ed
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2024-02-02 14:05:18 +00:00
hjk
66f6b4c32e ProjectExplorer: Hide JsonWizardFactoryJsExtension in .cpp 
Change-Id: Ia540ce9f053b218e6986cc568cb287c98707d39d
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
 2024-02-02 13:42:38 +00:00
Jarek Kobus
534c1c94b6 SdkManagerOutputParser: Limit code repetition 
Introduce function template helper.

Change-Id: If29452ce3dc09ee1e63ac3b889341f573ae5af63
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2024-02-02 12:46:14 +00:00
Miikka Heikkinen
f985b1b091 EffectComposer: Allow 'define' properties to specify control type 
Control type is used to determine the control presented for the property
in UI. Currently only int and bool control types are supported.

Also fixed the issue that changing define wouldn't update preview.
This was because changing define requires rebaking shaders, which is
not normally triggered on property change.

Fixes: QDS-11770
Change-Id: I953d827195565f765df1a09550c4a49da9c93c29
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
 2024-02-02 12:15:18 +00:00
Eike Ziller
d93e95c942 iOS: Fix missing include 
Breaks the build with Qt 6.7

Change-Id: Ie3e940a26cbd982f7781cfe478b59fc44785efe2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
 2024-02-02 12:04:19 +00:00
Mahmoud Badri
7efab2c07e EffectComposer: Remove warnings and unused code from the model 
Change-Id: I8171467e70d8d716b0598b0b533f216e5e0afc25
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
 2024-02-02 11:52:30 +00:00
Jarek Kobus
72bcc0f260 ProjectExplorer: Replace QSharedPointer with std::shared_ptr 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: I3d76cf04f8b501417687f8111c88f4a1af451608
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2024-02-02 11:14:15 +00:00
Jarek Kobus
a2b3d4d302 ClangTools: Replace QSharedPointer with std::shared_ptr 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: I359429d01bce9b28f9d284833f5be1828d3a880e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
 2024-02-02 11:14:06 +00:00
hjk
223767a94a CppEditor: Hide most of LineForNewIncludeDirective implementation 
Change-Id: Ic70d28beb057359fcd028aca2ab49ecb66dd990d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
 2024-02-02 10:36:05 +00:00