Posh, and avoids an upcoming warning with C++20:
/data/dev/creator/src/plugins/clangcodemodel/clangdclient.cpp:907:40: warning: C++20 says that these are ambiguous, even though the second is reversed:
In file included from /data/dev/creator/src/plugins/clangcodemodel/clangdclient.h:6,
from /data/dev/creator/src/plugins/clangcodemodel/clangdclient.cpp:4:
/data/dev/creator/src/plugins/cppeditor/baseeditordocumentparser.h:37:14: note: candidate 1: 'bool CppEditor::BaseEditorDocumentParser::Configuration::operator==(const CppEditor::BaseEditorDocumentParser::Configuration&)'
/data/dev/creator/src/plugins/cppeditor/baseeditordocumentparser.h:37:14: note: candidate 2: 'bool CppEditor::BaseEditorDocumentParser::Configuration::operator==(const CppEditor::BaseEditorDocumentParser::Configuration&)' (reversed)
/data/dev/creator/src/plugins/cppeditor/baseeditordocumentparser.h:37:14: note: try making the operator a 'const' member function
Change-Id: I98ed9d907b673b9353f540bab2ff7239e018b4f2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The action has been present for some time, but so far it had been
unimplemented
Change-Id: I798a144116ffeba60fb368430b30705ffc9b3f1c
Reviewed-by: David Schulz <david.schulz@qt.io>
It was always zero as Detached HEAD is a special
branch that is not actively queried. It can be
enabled later, but the quick fix is to disable it.
Change-Id: Ib191e1b5551a13bc4911184e12e06a0b4dc28ddf
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Using HEAD is wrong as soon as the branch is not
checked out. Instead the branch name must be used.
Amends 960ac1adf4
Change-Id: Id10b4012455ccb9b393404413a369f241edc098e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Potentially more stable api long-term. Also simplifies the
user side code a bit.
Change-Id: I6913e27e2a5dc14907e72f252081cdbed34842a3
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Adds a postfix " (on ...)" to the default name of qt versions
if they are located on a remote device.
Makes it easier to distinguish Qt Versions
Change-Id: I02208f49d5a1b6b22294b8cc29348455808f342f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This can cause issues with CMake, since CMake uses slashes as directory
separator.
Fixes: QTCREATORBUG-30326
Change-Id: I0c03b3bcd32bddc99fb361eb8e6aaffd0b1f10b6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Previously a QMap with FilePath as key would return wrong
entries when comparing paths with and without scheme/host.
Change-Id: Icc5d119a18c1b7a2fdab9c89f162c48859926523
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
When the active project is on a remote device the working directory
is set to its root directory. In this case we need to find the right shell
binary from the remote device.
Change-Id: I6b541273d23a8de5442ac041b28d81984ed5ef65
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Since the CMake presets is built upon Imports, when loading the presets
it's better to only use the candidates from preset Kits and not any
matching Kit that could handle the build directory.
This makes working with CMake Presets a bit easier.
Task-number: QTCREATORBUG-29535
Change-Id: I895e2e9162763e4cf3af5cdef5c9d5b228211fab
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
The block might have had some highlighting before the update, so compare
the new ranges against the one from the layout and update the layout if
the format ranges differ.
Change-Id: Ia6a0025e74fa8941b1cccc00baa93d3d37cb9ff9
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
This way a project importer implementation can modify the filterText edit
field from the Project setup page.
Task-number: QTCREATORBUG-29535
Change-Id: I22b3d613ff84111b918c4a4447cd5656d7c593b9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Move clangformat output to infolabel in clangformatconfigwidget
to reduce noiziness in cli and to enhance the convenience of editing
the .clang-format file.
Fixes: QTCREATORBUG-30269
Change-Id: I78053bde9791122172f1d3d4ba712a9954ea9c4e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
- Fix add definition for templated/not templated function in templated
class inside namespace
Fixes: QTCREATORBUG-22076
Change-Id: I565cbdc8c6ab8d09727b4cd6f1c8fb45741c213f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... to a Qt meta-method invocation.
Fixes: QTCREATORBUG-15972
Change-Id: Id84c83c5832cef32a877a451b0931ec47d2afe9d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Create the editor parameter structures in-place, and also
include the other two parameters in the struct to simplify
the signature of the c'tor.
Change-Id: Iff7d5ddf3096f4a3ed18e53265ae74806823af32
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
When our window loses focus the editingFinished signal is triggered.
This can happen multiple times (QTBUG-121983) if the result of the edit
is a modal dialog and the user clicks outside our application.
This would call editingFinished again, resulting in multiple message
boxes being opened. (Easiest to reproduce is changing the build
directory of a project which displays a message box confirming the
change)
This patch checks, via a recursion Guard, that the slot is not already
in the process of being called.
Change-Id: I5e61e1b57680f0b1f2483a81682e791bfb5c0867
Reviewed-by: hjk <hjk@qt.io>
Will be propagated to the calling code further.
The minor inefficiency here is in my opinion outweighed by the more
common setup. The structure is small and we don't have thousands of
VcsEditors.
Change-Id: Ifc0d6e4acd5ef206d5fcadf55f9eb28bd567967c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
