This addresses the 30th point in the bugreport below.
Task-number: QTCREATORBUG-28741
Change-Id: Ifa157311b3aae413b19075d36e11c75e6066881d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
If a task or task's adapter sends done() signal directly
from the destructor (which isn't really desired),
ensure we disconnect from this signal beforehand,
otherwise this may start invoking normal handling of task done()
and interfere with the destruction.
Fix NetworkQuery d'tor.
Add a test for it.
Add some TODO items.
Fixes: QTCREATORBUG-30204
Change-Id: I56a34d0f00c961c15bd1bcffef45520a4be5bce0
Reviewed-by: hjk <hjk@qt.io>
For devices that that supports. The goal is that iostool will be
unneeded in the end for these.
Call `devicectl device install app` with the right device id and bundle
path and parse its output.
This doesn't use our custom provisioning check, but relies solely on the
errors that are returned by devicectl.
Task-number: QTCREATORBUG-29682
Change-Id: Ibae0908841004a12e1fc91b154bedea4b37db053
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
To the IosDevice. So other parts of the code know if the device can (and
should) be handled via devicectl instead of iostool.
Change-Id: I700bd1528fad505c3f4b6442d73e24b09ceba68a
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
In Preferences > Devices > Devices > Type Specific.
This makes it fit the style of other devices, and automatically makes it
possible to select and copy text from it.
Change-Id: I637858a939ada261504970611ffdb7eccf003c1c
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Queue the call to start() so that it's executed after the nested
event loop is started, otherwise it fails on Windows with QProcessImpl.
Fixes: QTCREATORBUG-30066
Change-Id: Ibb17ef0f668f52c05b26a521e18c94e637992ba5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
When a number of repeats is known in advance,
make the progress reporting aware of it.
Add a test for it.
Change-Id: I676a4aa9eb469cfe40a2729d231c706dff3ca07c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Let it have its way of partially rewriting the document.
Change-Id: I4ea3d6a5ae271356fe111bd5f5e9591d0f75b532
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
If the number of iterations is known in advance it may
help in calculation of total task numbers for progress
reporting purposes.
Change-Id: Ie36de67a4f3271820aca539afe0816974773a152
Reviewed-by: hjk <hjk@qt.io>
Amends 796053d7.
After all, the defaulted destructor of the class did some actual work
via the destructors of the QScopedPointer members.
Change-Id: If6dc8a3d57961ec263fced11f9fa9f7e9f8c54cc
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
I had to rename the BinEditor class as moc apparently
stumbles over the same-named namespace:
In file included from /data/dev/creator/src/plugins/bineditor/bineditorplugin.cpp:529:
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc: In member function 'virtual void* BinEditor::Internal::FactoryServiceImpl::qt_metacast(const char*)':
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:40: error: 'FactoryService' in 'class BinEditor::Internal::BinEditor' does not name a type
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:54: error: expected '>' before '*' token
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:54: error: expected '(' before '*' token
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:55: error: expected primary-expression before '>' token
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:62: error: expected ')' before ';' token
Change-Id: I736dc89c270f4245806792b0e350d7155f027a19
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
- Collection editor functions are moved to CollectionEditorUtils
namespace
- Collection import tools functions are also moved to
CollectionEditorUtils. Also, the former files of import tools are
deleted since their functions are moved.
Task-number: QDS-11391
Change-Id: I1ec1b2b7568658c1637a4c267989425189f07039
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
It's not meant to be used from the outside.
Change-Id: I94e46f95f896fa4b44e77e0196523beb8afdf8c3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* HelperWidgets.ToolTip is replaced by ToolTip in order to prevent
mouse are conflict
* The content of the tooltip is updated by activation
* CollectionDetailsModel notifies changes on column type
Fixes: QDS-11591
Change-Id: I0b5e42b7a8656e3119f7ac60f6be78d6ca46e055
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Shrief Gabr <shrief.gabr@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
It's not meant to be accessed from the outside.
Change-Id: I0652ec8309e678a9b28e05acab6d0f77a0b13639
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Before deploying we check if the provisioning information includes the
device that is deployed to. This suffers from the same issue as
QTCREATORBUG-21291: We use the USB identifier for the device ID in Qt
Creator, which cannot contain dashes, but the iOS hardware udid that
Apple uses can contain dashes (and the USB identifier then is that udid
without the dashes).
We need to use the iOS hardware udid when checking for the device in the
provisioning information.
Fixes: QTCREATORBUG-30158
Change-Id: I6f9e162ad6ece02370923ea59c046f439b8cc47a
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Instead keep a list of "vanished targets".
These are shown in Projects mode in a separate list under the list of
kits. Via the context menus of those items (or with single-click), the
user can choose to either copy the steps of the vanished target to
another kit (already configured or not), or to create a new replacement
kit for it (similar to the previous replacement kits, with the same
device type and the steps restored, but no other parameters from the
kit restored - the project doesn't save that information), or remove
them.
The vanished targets are not removed from the project's settings as
long as the user doesn't create a kit or copy the steps, so if the kit
re-appears on a later run of Qt Creator, the original target is
restored for that kit and the entry in the "vanished targets" list
automatically vanishes.
This has the advantage that in contrast to the replacement kits, the
vanished targets are clearly separate from "normal" kits, and that they
are local to the project. Nothing is left behind after closing the
project.
Change-Id: Iccec04fea38cd55ff683665c9cf4edc9a2388c82
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Not quite the standard setup yet, but getting closer.
Change-Id: Ifadc0b07b9d3f43381d5f49848c49bcc1d069861
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
