E.g. when renaming a class, the C++ model manager needs to know about
both renamings (.h and .cpp) at the same time. This way, it is able to
open the correct including file, even though the code model likely still
refers to the old, now-gone file path.
Fixes: QTCREATORBUG-30154
Change-Id: I583e77a4920c7cc3e642d7bebba46d734ae6bbe0
Reviewed-by: David Schulz <david.schulz@qt.io>
Individual debug messages got concatenated without a newline character
if multiple messages were received by the windebug interface thread
before they were handled in the main thread. The receiver of those
messages had no chance of handling those messages individually. This
gets fixed by using a list of messages instead of one concatenated
string.
Change-Id: Icfaf1b22db56829fcd143e574ee1033a63226c29
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This is quite special due to the extra signal, but at least that's
hidden in the implementation now.
Change-Id: Id1130669fd1fdfb631d89460cfb884fb53858eec
Reviewed-by: David Schulz <david.schulz@qt.io>
For temporary simplicity, take the strategy that only
zero-iterations (up to root) advance progress.
Task-number: QTCREATORBUG-30081
Change-Id: I7a0da2f141043622a07fa3e0cd03e3fb53417932
Reviewed-by: hjk <hjk@qt.io>
On multi-config systems CMake is reporting "ALL_BUILD" or "ZERO_CHECK"
as targets to add files to.
When issued from menu File > Add New ... the selected target is the
first target namely "ALL_BUILD", which is a utility target and cannot
have source files.
Fixes: QTCREATORBUG-30170
Change-Id: I7617978c01f0a2554a3ec7d52ef9baaa16ed7a84
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Export two functions doing the actual work instead.
Centralize some repeated code.
Change-Id: I7de674ef7ae5537663d1227d36cc556c4ee3ed74
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
When quickly selection text via double-clicking and moving the mouse to the left
it is possible that a selection is created where the start == end.
This was incorrectly reported as a warning.
Task-number: QTCREATORBUG-30144
Change-Id: I37b22f4ee725e5085ce0090c123ccfd9980b8a59
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Amends 92f7da917e.
Also, set it in all branches, not just remote execution, even if this
is the primary and currently actively used way.
Change-Id: I35149bd29b49dab419f83ec0cb424ae9b23827ed
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
9124833a63 introduced an optional
parameter to removeChildren to suppress signal emitting, and
a61f9162f1 reimplemented that in a ABI
compatible way with a new removeChildrenSilently method instead.
The code now uses removeChildrenSilently, so the parameter to
removeChildren is no longer needed.
Change-Id: I8411d80f90e83b8746c2553dddb41c3f40a2bfc7
Reviewed-by: David Faure <david.faure@kdab.com>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
The restoring of Kits was moved to a later stage of the startup
sequence. That is too late to connect to ICore::coreOpened.
This change calls askUserAboutAndroidSetup directly instead of via
connection.
Fixes: QTCREATORBUG-30131
Change-Id: I9b33df42177de05f2f9132ff3126fe03ffb8df20
Reviewed-by: hjk <hjk@qt.io>
Instead, iterate directly over the container.
Change-Id: I589e87b0ed86be778aec7679bedab28d709a7697
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The properties of DataStore.qml are read, So the property-name for
a collection name will not be changed if it's not like the
Collection-name.
* Unique names will be created only when a user adds a collection.
* Renaming a collection shouldn't affect the related property-name
of DataStore.
Fixes: QDS-11540
Change-Id: I797a29c116051f79cfa6680360e5b086154a1df6
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
This can prevent crashes, but is unexpected behaivour.
Change-Id: Ie0944652c230a25e18f5d740cf134bc3ef7e2f2f
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
... where the default implementation via stripAccellerator(action()->text())
would yield the same result.
Change-Id: Ie921863d472e0592a8c97830d67873ccfb1b57da
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Since we cannot make multiple dock widgets invivsible and visible at
once, the individual setVisible calls sometimes mess up the relative
dock widget sizes. That seems to also depend on which dock widgets take
part in that process. For example, when putting the Breakpoints view
together with other views into the right dock area in Debug mode, hiding
and showing that area would give the Breakpoints view more size than
before (similar with Threads and Stack views).
Remember the dock widget sizes and explicitly restore them when re-
showing an area.
Change-Id: I3868549ac7362a67f47fcf59b8fc3025befc86d2
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
