This can be re-used in a (augmented) copy of the factory via
BuildStepFactory::cloneStepCreator with the possibility to use
a new step id in the new factory. In that case the new factory
should create steps with the new id.
Change-Id: I661537408e32fdeda9c45bde1abb54d32b9cbac6
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Instead, iterate directly over the container.
Change-Id: I6a3cb7d623e083663a11389f15b8d51599f338a3
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This allows using file scheme in certain contexts.
E.g. starting Qt Creator with
qtcreator file:///tmp/dummy.txt:10
did not work before while just using the scheme-less
absolute path did.
Task-number: QTCREATORBUG-30143
Change-Id: I8f2b728e733792eb92295bff60b27aecb4b3b8ed
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This led to an assert in QSFPM because it got confused by the
nested reset signals.
Detected by adding
new QAbstractItemModelTester(this,
QAbstractItemModelTester::FailureReportingMode::Fatal);
to the OutlineModel constructor, and just opening QtCreator on a small
qmake-based project.
Fixes: QTCREATORBUG-30035
Change-Id: I41dbc81b5a2275521ece6b865115e1428e07ecf7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
(cherry picked from commit 9124833a63)
Reviewed-by: David Faure <david.faure@kdab.com>
Automatically hide the tooltip of the line column button in the editor
toolbar when the cursor leaves the widget.
Change-Id: Ia17f40029d0821584c8a804b44431a5d7e639066
Reviewed-by: hjk <hjk@qt.io>
New extra widgets for the right side were wrongly inserted between the
buttons for line-ending text-encoding.
Task-number: QTCREATORBUG-30166
Change-Id: I0f55c44344f9586e6aa97da20f5e25c28adf964c
Reviewed-by: David Schulz <david.schulz@qt.io>
Ctrl+K is a useful shortcut for some users, so we have to block the locator if the keyboard is locked.
Fixes: QTCREATORBUG-30032
Change-Id: I211e0bc449d3981513cc77bd14baf70a9acc3ae1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reset internal data after a call to stop().
Add a test for restarting the task tree.
Change-Id: Iedf11d97c33c9001c818078abc816e3c483c42b8
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
The place for invoking a possible repeater handler
is inside the TaskTreePrivate::startChildren().
Change-Id: Icc678967e695e9d5e0f494110d236b7caaa05c90
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Make it possible to run a nested task tree containing
the common storage from the outer task tree's handler.
This means we need to manage the stack of active storages
per thread.
Add a test for it.
This addresses the 4th point in the report below.
Task-number: QTCREATORBUG-29103
Change-Id: Ib0f925048197625a0eb9f83f262c7256a5756cc8
Reviewed-by: hjk <hjk@qt.io>
In case the g++ symbolic link does not point to any g++ executable it
should be possible to pick other installed g++ versions
Fixes: QTCREATORBUG-29891
Change-Id: I3070e38617a85489e1e6bfb3b1a6368af684829f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Use Utils::setWheelScrollingWithoutFocusBlocked() explicitly
when a QComboBox is placed inside a scroll area.
The Utils::setWheelScrollingWithoutFocusBlocked() is more
general and may be applied to other widgets, like QSpinBox.
This patch brings back the wheel scrolling without a modifier key
for combo boxes placed in dialogs.
Keep the unconditional scroll wheel behavior when ctrl (meta on mac)
modifier is pressed.
Change-Id: Ieea0f228cea6b59e276bd3256eb6ea5ecc5b7d14
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
CMAKE_SYSROOT is used by Qt Creator for cross-compiling, and also
selecting toolchain on macOS.
Whilst for iOS CMAKE_OSX_SYSROOT is used for the same task.
Make sure to pass these CMake variables to conan via the generated
toolchain file.
Qt Creator also uses for iOS the Xcode generator, which is a multi-
configuration generator. This patchset will set the "Debug" and "Release"
configurations that usually conan scripts use.
Fixes: QTCREATORBUG-29978
Change-Id: I23c5d94f830aaf81c5d27f821c09545ddfd45df6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This makes a difference when one wants to e.g. mark non existing files.
Fixes: QTCREATORBUG-29999
Change-Id: Id7c2a53fa91fb9638e9a08a746614a3f04da400f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
(cherry picked from commit 13f5367611)
Reviewed-by: David Schulz <david.schulz@qt.io>
It enables language server functionality for .clang-format files.
Change-Id: I911a254c777b4b5e15a73bf0abdb273156a0d0c7
Reviewed-by: David Schulz <david.schulz@qt.io>
This name corresponds better to e.g. SH_ComboBox_AllowWheelScrolling,
SH_TabBar_AllowWheelScrolling or wheelScrollLines.
Change-Id: I244774584e293ca45cc4be4d4526f925c2da9598
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
check the type after construcing the highlighter instead and save that
information.
Change-Id: I7d942dae4be8471dba90dd266267ff7fa1b6f440
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
It looks like GitHub creates heading IDs by
- converting spaces to '-'
- removing anything that is not '-', '_', a number, or a letter
- converting to lower case
Task-number: QTBUG-120518
Change-Id: If09a8e2e0d964e751869eaebd3326a6f983ac495
Reviewed-by: David Schulz <david.schulz@qt.io>
It is used more commenly in the code for that purpose.
Change-Id: I48112d2c80485d204137da36fadbe85ad1db802b
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Instead of consuming the wheel event, pass it to the target
widget's parent. This should allow for further scrolling
the possible parent scroll area.
Modify the focus policy only in case of WheelFocus.
Change-Id: I00c628a9e3d7608222b0700e71469c6cef6dea88
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Handle links ourselves since QTextBrowser doesn't do what we want.
- anchors without file path just jump to anchor
- local files (potentially relative to the markdown file) open in
Qt Creator (anchors ignored)
- otherwise QDesktopServices is used
Fixes: QTCREATORBUG-30120
Change-Id: I9a68607a0b32255ec075c698a1265cc6d1387e0c
Reviewed-by: David Schulz <david.schulz@qt.io>
Otherwise it generates the following:
"No relevant classes found. No output generated."
during compilation.
Change-Id: Ia0299db40412a8ba1543f6990a728b2ac3af07ac
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>