Commit Graph

80509 Commits

Author SHA1 Message Date
Thomas Hartmann
8d02bbf075 QmlDesigner: Add display name more feedback popup
Task-number: QDS-8870
Change-Id: Id8d1c98dec71e962b63a144c234642417e1df602
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-01-23 15:12:20 +00:00
hjk
87c3f08e52 CMake: Move settings storage closer to class implementation
Simpler in use.

Change-Id: I8cc929001035974b9b73566b206410bfd77f73a6
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-23 14:49:45 +00:00
Christian Kandeler
38faf098c8 QbsProjectManager: Refactor raw project part creation
No functional changes. Preparation for bugfix.

Change-Id: Ib391a597b2ba615250b1219451f7dc537476f8af
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-23 14:43:18 +00:00
hjk
3d32412271 ClangCodeModel: Remove unused files
Change-Id: Id9490ee1fcf16d16b6e675e9c5c09de47cb6dc09
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-01-23 14:34:54 +00:00
hjk
c3e44bb3bb QtSupport: Pass empty device root for local Qt
Fixes: QTCREATORBUG-28680
Change-Id: Id90b6b9427d4b85ebc4e9f097dfdd996062d4c85
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-01-23 14:29:31 +00:00
Miikka Heikkinen
fa6eea93f9 QmlDesigner: Fix texture editor preview inside subcomponent
Properly resolve relative path based on current document.

Fixes: QDS-8882
Change-Id: I2f71d3b55a29754e88aabd24049ffbe1fd51d93e
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-23 14:11:06 +00:00
David Schulz
9938fffe06 LanguageClient: close and reopen renamed documents
That is the way accoarding to https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_didRename

Change-Id: Ibed1873ac85eb2e9074481537a34f959a55a6f71
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-01-23 14:01:20 +00:00
hjk
ea1d729669 Utils: Move PathChooser::expandedDirectory() to its only user
... and simplify its use given the always empty base dir there.

Change-Id: Ieeff7f31653db1512edc2cc448f80efc9bb7222e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-23 13:49:16 +00:00
hjk
156ef28d90 Utils: Start migration of FileSystemWatcher to FilePath
This duplication of the interface is a first step, the
QString based part will be gone in the end.

Change-Id: I5e6378a92f96324188b917599b50def536f57bbe
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-01-23 13:46:42 +00:00
Miikka Heikkinen
af7ce87c2d QmlDesigner: Fix TypeError warning in material browser
Change-Id: I8150244aa5556340eea4cec8e4a15825280df742
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-01-23 13:25:32 +00:00
Assam Boudjelthia
5bbc7ea0f5 Android: Add option to set the build-tools version in project settings
Allow QC to directly set the build-tools version for the project.
Such setting could be in qmake/cmake, however, ideally this value
should be the latest available version, and doesn't need to be written
to the project file. Thus, it is convenient to have this selectable
from QC UI for convience, while developing.

Apart from the first reason for avoiding writing this into the project
file, there is QC limitation which doesn't allow writing such value
to CMake project file.

Task-number: QTBUG-97002
Change-Id: I5d54d36f7900f8445359188d6ae7a8ba14bd3a05
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2023-01-23 13:01:41 +00:00
Jarek Kobus
b1ef25b208 TestResult: Devirtualize the class - part 3 of 5
Step 3 - implement directParentHook.

Change-Id: I87518e700e9019ccd5b8a095b23971ae26eb776e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-23 12:43:17 +00:00
Christian Stenger
a7f0c8e81b AutoTest: Reduce parsing attempts
Do not check for code model parsing only, but take project
parsing as well into account.
Explicitly ignore more qml code model related files supposed
to hold no functional code.

Change-Id: I2dc8a6331ea508cbb287ea5000f5abe302069060
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-01-23 12:12:02 +00:00
Eike Ziller
2746b410d0 German translation: Git
Change-Id: I9ed345f452c72ac588a4df0d71ff2d92f117c8eb
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
2023-01-23 11:47:31 +00:00
Robert Löhning
270c0ffa3a Squish: Use consistent permissions
Change-Id: Id2849d4aaa2da181df0e674a971abd89c3083662
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-23 11:41:28 +00:00
Marcus Tillmanns
3873bcf2a4 AutoTest: Add option to disable derived checks
Previously the quick test parser would always check each symbol
its interested in to see if it might be derived from "TestCase".
This is very expensive.

This patch adds an option allowing the user to
enable or disable the check.

By default the check is disabled.

Change-Id: Ia6b230b344add672e53ad7fb52845c78a2914b99
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-23 11:32:01 +00:00
hjk
978639b995 Android: Use specific classes for run worker factories
Slimmer file interfaces.

Change-Id: I2cf846c04000eb29fe53219db9a97088b6b9a1aa
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-01-23 11:18:03 +00:00
Marcus Tillmanns
9c57ed6bd2 AutoTest: Only scan necessary files for tests
Change-Id: Idafd064694a7dfdd0fbca66bca1b9f848acb9b3f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-23 11:11:20 +00:00
Marcus Tillmanns
ab4689fbcb Autotest: Add ITestParser::supportedExtensions
Change-Id: I3bb0f9b2a989cc4c9b4f6ae95d36308bc192158d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-23 11:11:02 +00:00
Ali Kianian
cb9a592a45 QmlDesigner: Remove all icons for non-first-level menus in 2D Editor
All non-first-level menus should be removed from context-menu.

Task-number: QDS-8813
Change-Id: I8f1886bd79afeee1e3e03386bbb492d12ee28faf
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-23 11:04:07 +00:00
Ali Kianian
0c6326120f QmlDesigner: Remove "Add new signal handler" from the context menu
Task-number: QDS-8872
Change-Id: I7fd0e9f0cde00e0c97b2f56227ff528155828e58
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-01-23 11:02:12 +00:00
Thomas Hartmann
05053f4a26 QmlDesigner: Use new licensecheck
Change-Id: Ia77950ac1cefb9ca92222b8adf249894bf8414c0
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-01-23 10:53:32 +00:00
Thomas Hartmann
78ce13e688 QmlDesigner: Switch to basestate before setting expression in state
When setting an expression in a state then the revert list is not properly
managed. Therefore we have to temporarily enter the basestate
to set the expression.


Task-number: QDS-7801
Change-Id: I4f653e83db4a2d05b1cc0b67d22581cee84557ff
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-01-23 10:50:12 +00:00
David Schulz
f15cae2bac TextEditor: fix endless loop on adding cursor for selection
Since the find of QTextDocument is line based, it is not possible to
find selections spanning multiple lines in the editor. Triggering a find
on a search term containing a paragraph separator returnes an invalid
QTextCursor which always result in searching from the beginning of the
document in the add cursor for selection logic. Prevent that by checking
the selected text beforehand and add a safety net in the loop to verify
that we do not start over again on an invalid TextCursor.

Fixes: QTCREATORBUG-28709
Change-Id: I8c1b9d16e707fefbba6dc0a0a9ef21b8c82ebe19
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-01-23 09:58:25 +00:00
Christian Stenger
73c2c86c61 Utils: Fix unintended comment
Fixes various settings layouts.
Amends 642c593481.

Change-Id: I00351e60b8bee6f67fc5a8f35d5df983a63d13b3
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-01-23 09:45:56 +00:00
Jarek Kobus
d518ba1acd Compile fix for Windows
Amends 105fc92e19

Change-Id: If55d40401b286b2f9f7dc37354bd94f3eefb9afe
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-01-23 09:29:56 +00:00
Miikka Heikkinen
b40be0f8f5 QmlDesigner: Work around the issue in QtQuick3D 6.4 geometry caching
QQuick3DGeometry::updateSpatialNode can create QSSGRenderGeometry
object with exact same address as a previously created and subsequently
deleted QSSGRenderGeometry object (i.e. the memory location is reused).
If the previous node was not used for the exact same logical geometry,
then you get these artifacts, as QSSGBufferManager uses
QSSGRenderGeometry object pointers in QSSGBufferManager::loadRenderMesh
function to determine if it needs to reload the geometry and what
geometry gets used for each model. The cache still contains data for
the deleted node, which is then matched for the new node with same
address.

This workaround ensures that none of our selection box geometries will
have the same generation id with each other or any grid geometries
we create, and thus will never get improperly matched in
QSSGBufferManager cache.

Fixes: QDS-8843
Change-Id: Ib064e4c290cca37258e8f129b0f385d2c45f581e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-23 09:21:34 +00:00
Alessandro Portale
d8d24cac7d BinEditor: More Tr::tr
Change-Id: Ide1dfa4d8c1c1746e674856682be66a74522650b
Reviewed-by: hjk <hjk@qt.io>
2023-01-23 09:03:37 +00:00
Alessandro Portale
ea35f60633 ClassView: Tr::tr
Change-Id: Ib65355e5ba2c34720c48aafb4472b0cd9ce933c6
Reviewed-by: hjk <hjk@qt.io>
2023-01-23 09:03:30 +00:00
Alessandro Portale
457b53b95c FakeVim: Tr::tr
Change-Id: Idca64705f2058d22480da6a624008971c8d8aab4
Reviewed-by: hjk <hjk@qt.io>
2023-01-23 09:03:23 +00:00
Alessandro Portale
a0eb8493b9 Macros: Tr::tr
Change-Id: I16d875d238ea9ac14758148c867cbac74042c43c
Reviewed-by: hjk <hjk@qt.io>
2023-01-23 09:03:18 +00:00
Alessandro Portale
852a74c9c1 Python: Merge orphaned translation contexts with "::Python"
Change-Id: I3036d0efd6876118e7b48a6403f1b07ec3f861ae
Reviewed-by: hjk <hjk@qt.io>
2023-01-23 09:03:13 +00:00
Alessandro Portale
f99a340ea4 McuSupport: Tr::tr
Change-Id: Ia2f0e523a378bea82887bdb212acfdab47b408e9
Reviewed-by: hjk <hjk@qt.io>
2023-01-23 09:03:07 +00:00
Alessandro Portale
cd4e116dff Subversion: Tr::tr
Change-Id: Ic94722ec93b145eb8c78141b888797d70aed13fd
Reviewed-by: hjk <hjk@qt.io>
2023-01-23 09:02:57 +00:00
Alessandro Portale
eada41a393 SerialTerminal: Tr::tr
Change-Id: Iac630d03a27eb1599485a9b8044d794fc66c7bb2
Reviewed-by: hjk <hjk@qt.io>
2023-01-23 09:02:48 +00:00
Jarek Kobus
817553f3e5 TaskTree: Merge DynamicSetup with OnGroupSetup
Don't define 2 separate group setup items. Make OnGroupSetup
be able to handle also dynamic setup - like it's done with
CustomTask's setup handler.

Change-Id: I43e135f268ea96419b44ef5a4325707a124b4921
Reviewed-by: hjk <hjk@qt.io>
2023-01-23 08:07:36 +00:00
Jarek Kobus
105fc92e19 TaskTree: Simplify SFINAE code
Change-Id: Ic54be7ff780772f7c989b88aaab948f5fe9c3750
Reviewed-by: hjk <hjk@qt.io>
2023-01-23 08:07:19 +00:00
Orgad Shaneh
b95fee74bb QtSupport: Fix potential null dereference
Shouldn't happen in real life, but done to make Coverity happier.

Change-Id: I3316030f59ec74516d2271973ac53c41554c3893
Reviewed-by: hjk <hjk@qt.io>
2023-01-23 07:58:32 +00:00
Marcus Tillmanns
0c9d5903ef Utils: Fix crash in fsengine test
Change-Id: I6a28dfc907d34f1a6e20bc92f5cc506b308f1c0b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-01-23 07:46:35 +00:00
hjk
2336ff5570 Git: Some more FilePath proliferation
Change-Id: I8d3d97d0c7979d741a7da333f922ce93359afef8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-01-23 07:15:17 +00:00
Amr Essam
18f9ddc960 QmlDesigner: fix user cannot name new effects properly
Task-number: QDS-8705
Change-Id: Idef4a40efdc2bdf052e1f6daef5abe16d27bce99
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-01-20 15:00:53 +00:00
Thomas Hartmann
27925d5bc5 QmlDesigner: Use Instancers instead of Component
Task-number: QDS-8868
Change-Id: Ia4879a134b7f374dca66aecc4d46cc3d316835cb
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-01-20 14:25:25 +00:00
Jarek Kobus
ec28990dd5 TaskTree: Clear old storages on root setup
Change-Id: Ic32dedb1f427b238427df675e9c882c15d359da4
Reviewed-by: hjk <hjk@qt.io>
2023-01-20 14:19:01 +00:00
Jarek Kobus
98ff1d32f9 TaskTree: Remove GroupConfig / GroupAction
Use TaskAction for dynamic group setup. Get rid of possibility
of selecting group's children to be started inside group setup.
Use dynamic children's setup instead, so that each individual child
may decide itself whether it wants to be started or not.

Change-Id: Ie31f707791db0dc26be92663ca6238b8e49c3b98
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-01-20 14:18:56 +00:00
Jarek Kobus
01faf0843d TestResult: Devirtualize the class - part 2 of 5
Step 2 - implement findTestItemHook.

Change-Id: Iabc843740343e549f79b02f74f94f5b1b4713af3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-20 14:18:32 +00:00
Marcus Tillmanns
2d491591e2 Utils: Add FilePath.hasFileAccess()
FilePath::hasFileAccess allows a user to test if a specific device
can access files. This is faster than calling "exists()" as it does
not have to actually check anything on the device.

cherry picked from commit 21ef25a0f5

Task-number: QTCREATORBUG-28531
Change-Id: I363ca634d921464fe4ec68397c09fba49dccee25
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-20 13:31:51 +00:00
Jarek Kobus
6eb14c66c7 TestResult: Make createIntermediateResultFor() a const method
Change-Id: I60dc08117504611857885668d1ad0d565a0ee020
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-20 13:20:53 +00:00
Jarek Kobus
d03c4f77c9 TestResult: Devirtualize the class - part 1 of 5
The goal is to make the TestResult a value type without a need
to create these objects on heap.

Introduce a ResultHooks class that will replace all 5 virtual
methods.

Step 1 - implement outputStringHook.

Reorder constructor arguments of TestResult's subclasses so that
the first 2 args are always: id and name.

Change-Id: Iae93e5a348328414f057d1471afad8020b3c1171
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-20 13:20:39 +00:00
Mahmoud Badri
83f162f460 QmlDesigner: Enable drag-n-drop a bundle texture to material editor
Fixes: QDS-8340
Change-Id: If0aa8d34689825c253a7e679f6887cbd3b328604
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-01-20 13:15:16 +00:00
hjk
c8b9e4504e Update to upstream FilePath changes
Change-Id: I151fc9cb369bafd943dbfcfa17a301e09cd897df
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-01-20 13:02:58 +00:00