Commit Graph

80509 Commits

Author SHA1 Message Date
David Schulz
e592e0e83f Python: remove outdated pyls install toolbar earlier
Change-Id: I9ba67bffcff159523eb44b4f486c11fc37085fa8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-20 12:51:07 +00:00
hjk
642c593481 Utils: Flatten LayoutBuilder related hierarchies
Originally the idea was to only expose LayoutBuilder, but we
are getting more and more related items. Be consequent now,
and have everything in Utils::Layouting, but not in nested classes.

Change-Id: Ic0f98595882e5c60a25c30ec52df4a0ea79bc0ca
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-01-20 12:44:30 +00:00
Jarek Kobus
a37f2ae3a8 QdbStopApplicationService: Replace DynamicSetup with dynamic task setup
Change-Id: I5c02ea111afe604c61f11ff7a4677c825743ed80
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-20 12:43:13 +00:00
Alessandro Portale
6bcee998a5 CppEditor: Merge translation contexts of "CppTools" into ::CppEditor
CppTools was at some point an own module, which got merged into
CppEditor. This makes the translations follow suit.

Change-Id: Ifc1ca4db883316723b747da5bf810e0c45026b69
Reviewed-by: hjk <hjk@qt.io>
2023-01-20 12:21:13 +00:00
hjk
118b84ffd6 Use simpler Plugin::initialize() when feasible
Change-Id: I567965d266f20526bda9f823e31a04b354d53fb1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-20 12:13:10 +00:00
hjk
013ad1345e VcsBase: Proliferate use of FilePath
... and update user code.

Change-Id: I52c08e9e07238536d31fc72f97312ac582a1e32f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-01-20 12:02:32 +00:00
Jarek Kobus
7dd2fe689d GenericDirectUploadService: Replace DynamicSetup with dynamic task setup
Change-Id: Ic9befb63b51101803aef48911ae1d54a87eb98da
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-01-20 11:41:14 +00:00
hjk
ad0fcc60d2 ExtensionSystem: Add a less verbose way to *Plugin::initialize()
Barely any of our plugins use the arguments or report error on
initialization.

Use it to the Nim plugin for demonstration purposes.

Change-Id: I0aead51afff61648fe03ad7e1ef7b4100abd9ed6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-20 11:28:20 +00:00
Miikka Heikkinen
bca0c74f2e QmlDesigner: Handle drag ending properly in 2D and 3D views
Model::endDrag() needs to be called for drag ending to be
properly notified to other views if drop is accepted.

Fixes: QDS-8825
Change-Id: If090f914a88350351865376f260be64d76fcfed3
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-01-20 11:05:24 +00:00
Eike Ziller
7e9e103c53 Issues: Fix ugly error text when item is selected
Trying to make red text work on a various possibility of selection
colors is futile. Just use the normal "blended" text color, like for
file names that are found, for the selected item. Use the theme defined
error color for items that are not selected.

Fixes: QTCREATORBUG-27525
Change-Id: I423487fbf8b5333993774ccebcb488ffb156dc0e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-01-20 11:03:59 +00:00
Artem Sokolovskii
a20c4c4490 ClangFormat: Fix the "Open Used .clang-format File" function
- FilePathify related functions
- Logic of related functions were updated to use new configuration
files location and new settings variables

Change-Id: I9f5504fc72f5c051a83dc80e1feb2e13272de146
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-01-20 10:29:51 +00:00
David Schulz
f0f0cf129a Python: add interpreter selector to editor toolbar
Fixes: PYSIDE-2154
Change-Id: If5e90f5bf2923b61af37ebbfcd35c512b3b07db4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-20 10:16:36 +00:00
Thomas Hartmann
49955964f7 QmlJSCheck: Add missing comma
Change-Id: I5f26cbe50ecb47c088bab8b9cdea49d0103352eb
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-01-20 10:12:20 +00:00
Alessandro Portale
d92be80610 UpdateInfo: Tr::tr
Change-Id: I7167f675bf58793cb38e11bfd58902bb7537c4b9
Reviewed-by: hjk <hjk@qt.io>
2023-01-20 09:37:01 +00:00
Jarek Kobus
3244819d3a GitClient: Replace DynamicSetup with dynamic task setup
Change-Id: I1a56e34274c5d7ace8fb8866c128c8dee03d2ad8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-01-20 09:35:40 +00:00
Jarek Kobus
d96fbb3e54 SubversionClient: Replace DynamicSetup with dynamic task setup
Change-Id: I7f96ee1300c6d53afc85a4c22bc18bcfe744ebd3
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-01-20 09:35:27 +00:00
Amr Essam
0174e3495f QmlDesigner: Fix effects folder is not created when creating effect from new effect dialog
Task-number: QDS-8166
Change-Id: Ifa5569beae70423f3e936e639b001cf4f3dcc9fe
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-01-20 09:26:20 +00:00
Jarek Kobus
9dfd72017c TaskTree: Add more tests for recently added fixes
Change-Id: Ia71fa174380b484cbe07a23f8b641755c5edcc65
Reviewed-by: hjk <hjk@qt.io>
2023-01-20 09:20:14 +00:00
Jarek Kobus
6269c2cec8 TaskTree: Unwind execution properly on synchronous done
When task or group setup handler finishes synchronously
we may end up with mismatched execution order or may
grow call stack considerably. The fix is to detect
synchronous finishes and leave handling to the synchronous
caller.

Change-Id: Id72cf8cc98e2f53ff601a5e5226cd203a8470aaf
Reviewed-by: hjk <hjk@qt.io>
2023-01-20 09:20:03 +00:00
Jarek Kobus
e6ca18e194 TaskTree: Implement dynamic setup for tasks
Before it was possible to dynamically setup groups only.
This functionalily is probably good enough to replace
Group's DynamicSetup, as it seems much more convenient.

Change-Id: I56080f0ffa844847ca955cf52ccb07f3b4e4c731
Reviewed-by: hjk <hjk@qt.io>
2023-01-20 09:19:49 +00:00
David Schulz
42d7304d2b ClangCodeModel: Allow cancelling the background index
Restarts the client with temporarily disabled indexing. The block is
reset after starting clangd, so any subsequent changes to the
configuration or the project will start the client again with indexing
enabled.

Change-Id: I16c975b6ef0b56f27ce5b2ced01f534f8ae0b4d3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-01-20 08:44:57 +00:00
hjk
77054c2fa3 LanguageClient: Tr::tr
Change-Id: Idbd7c5cdadba4f269b2033df91db0e05bb5281d5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-01-20 07:56:04 +00:00
Alessandro Portale
6780a6ca50 ClangTools: Tr::tr
Change-Id: I61e2d961225e9699bffcee8e54bc201eeb9a70d9
Reviewed-by: hjk <hjk@qt.io>
2023-01-20 07:09:54 +00:00
Alessandro Portale
5a5a91f7d2 GenericProjectManager: Tr::tr
Change-Id: I7ed1fac9dd6b4517cbc90a8c03a1c67d1e5404ae
Reviewed-by: hjk <hjk@qt.io>
2023-01-20 07:09:48 +00:00
David Schulz
5516188290 Docker: validate clangd version
Do not automatically setup a clangd that is too old and mark them as
invalid if they are manually selected.

Change-Id: Ie9662a8821df8fc678eabc4b8a08375723b4d1c3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-01-20 05:36:32 +00:00
hjk
2e98acfdfd Incredibuild: Tr::tr and code cosmetics
Change-Id: Id2facedde38dd09311069711b9e621a95439d433
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-01-19 17:25:28 +00:00
Alessandro Portale
0fff2aa172 QmlProjectManager: Tr::tr
Change-Id: I219111bab487ad5f2d7d1cd7ae6f3e3e8a2a8d3f
Reviewed-by: hjk <hjk@qt.io>
2023-01-19 15:53:58 +00:00
Alessandro Portale
16ec720537 DiffEditor: Tr::tr
Change-Id: I71b9908ea332256044120b42ff6af2fc57a89a5e
Reviewed-by: hjk <hjk@qt.io>
2023-01-19 15:32:29 +00:00
Marcus Tillmanns
eeea7e8b6c ADS: Cleanup dockmanager
Change-Id: I752e98df60fd7265e51ba32795edb536c2055675
Reviewed-by: hjk <hjk@qt.io>
2023-01-19 15:08:18 +00:00
Tim Jenssen
2e87ee5865 qmlpuppet: better error when Qt is too old
Change-Id: I219f2f8ce551e36d2f749d60a6984c3ccc903e5c
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-01-19 13:56:11 +00:00
hjk
89591b7d3d ProjectExplorer: Make Node::pathOrDirectory work for remote files
Change-Id: I643456c0ba691ed4a89d4c6020dea148f6a47f1a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-01-19 13:49:37 +00:00
Tim Jenssen
b826acd53e utils: reduce default logging level of filesystemwatcher
Change-Id: I10d55e3f07eb461351b8c13cac01a9b0d5bd8b84
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-01-19 13:34:04 +00:00
hjk
cdc88b2571 RemoteLinux: Handle already remote local files
This is a bit hackish to support "true" remote builds.

Conceptually, that's more similar to a "local" (a.k.a.
"Desktop" configurations when it comes to (non-)deployment,
but the Desktop runconfigs are currently a bit too tied
to the host system, and we'd like to have the X11 forwarding
that's already available here.

Change-Id: I750b2cfe6b94ec8f60a0e879f3fe44ddaf86072e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-19 12:55:11 +00:00
Christian Stenger
13cf1ee948 Wizards: Re-enable using qt quick wizard for qbs
Change-Id: Ic1a3dfbb72096470b4cec2d7af967eba111c743f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-01-19 12:54:00 +00:00
hjk
117b6f1921 ClangCodeModel: Tr::tr
Change-Id: I60aeadd38471cc65de250f66f0f09ba2931b3da2
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-01-19 12:18:42 +00:00
hjk
0454e939e1 Utils: Make all labels created by the LayoutBuilder
... selectable with the mouse.

Change-Id: Ied2677a517239ca55a15daeae088bc09998d2b3b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-19 12:03:32 +00:00
Burak Hancerli
e6d34ed3eb QmlDesigner: DS crashes on exit
Invalid pointer access.

Task-number: QDS-8751
Change-Id: I983ae84c1b746768d10a06ab6a28eb080fdc48a0
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-01-19 11:03:13 +00:00
Thomas Hartmann
47c4fff724 QmlDesigner: Fix Select All in code editor
Because of the shortcut overrides we used the "shortcuts"
from QPlainTextEditor which leads to different behavior then
the rest of Qt Creator and a bug.

Without the override we use QActions defined in Qt Creator.

Task-number: QDS-8847
Change-Id: I90e2b86ad9b5c93302652dd7cdfbf2b51e3a3771
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
2023-01-19 11:01:09 +00:00
Thomas Hartmann
1a2de8b40b QmlDesigner: Add logging for urlSpecifics
Change-Id: I556b534e92a9fb9729f6aa610153a4f89122e51c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-01-19 10:57:03 +00:00
Tim Jenssen
8e69490dad Utils: improve filewatcher
Avoid internal calls of QFileSystemEngine::fillMetaData
which are expensive and especially on Windows trow
GetFileAttributesEx can hang for seconds.
(network drive or one drive which locks files)

Task-number: QDS-8820
Change-Id: I3269ade03d1c1ed65417eebf956080414c5d087b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-19 10:55:19 +00:00
Tim Jenssen
db7c1c6770 Utils: add Q_LOGGING_CATEGORY(fileSystemWatcher)
Change-Id: I554c50a47197a6a9a84427b62a528d87b9db5f19
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-01-19 10:53:36 +00:00
Jarek Kobus
bc7de78c84 Utils: Fix clazy "Mixing iterators with const_iterators" warnings
Cherry-picked from 7bc86a8b8d

Change-Id: I719272e0c094df424c08524e8e32a567d557bb3d
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-01-19 10:51:10 +00:00
David Schulz
ca2979ca52 LanguageClient: Do not untrack documents before restarting a client
shutdownClient removed the association between the document and the
client, but this is one of the information we would like to keep when
restarting a client. Also we never want to delete the client when
calling restart.

Change-Id: I0558c27ba4b9171c7933edaf2e17847d4e6f62b6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-19 10:10:42 +00:00
Jarek Kobus
9ff307253d ProgressIndicator: Remove fwd decl of non-existing class
Change-Id: I175c7811afdb44ed0e61ccc1f16424a1baed34b3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-01-19 09:55:40 +00:00
Christian Kandeler
7b5c5b774f LanguageClient: Fix renaming with pre-set replacement symbol
If a caller passes in a fixed new symbol name, it must not be overwritten
with one derived from the old symbol name.
The problem can be verified with the "convert to camel case" quickfix.

Change-Id: I3d3aca692cb8e73535e1ef657608fd13d18ee5df
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-01-19 09:04:51 +00:00
Eike Ziller
e9320a8122 Fix tab order in "file deleted" dialog on Windows/Linux
For some reason it doesn't like it if the order of adding the buttons
is different, though that works on macOS.

Fixes: QTCREATORBUG-28676
Change-Id: Iea7c595216140dd242cac0aa528699866c4bb1c7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-01-19 07:20:01 +00:00
Christian Stenger
534e1f34b2 AutoTest: Only write values that are not default to user files
Change-Id: I0e36cdbc850c148e5fa7c865f3f1136a4dc8a11f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-01-19 07:19:47 +00:00
Christian Stenger
435fe5e4db Adapt to upstream change
Change-Id: I0f0de2823eb338cbd327846347f3b3c8e2b61c89
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-01-19 07:19:08 +00:00
David Schulz
41294e70b4 TextEditor: prevent crash on updating the completion model
Prevent updating the model with something other than a generic proposal
model.

Change-Id: I3880c1ce4ae7cf0aa4fb72d59b75a40db3f53482
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-01-19 06:28:41 +00:00
Christian Stenger
d9de9db6f8 Utils: Adapt to change in FilePath
Change-Id: Ibd3c53c49390cbf77d8b0563bab7ddff216394c7
Reviewed-by: hjk <hjk@qt.io>
2023-01-19 05:34:48 +00:00