Commit Graph

61685 Commits

Author SHA1 Message Date
Orgad Shaneh
ba20c9134a QmlPuppet: Fix GCC warning
qt5informationnodeinstanceserver.cpp:115:71: warning: narrowing conversion of ‘keyEvent->QKeyEvent::modifiers().QFlags<Qt::KeyboardModifier>::operator QFlags<Qt::KeyboardModifier>::Int()’ from ‘QFlags<Qt::KeyboardModifier>::Int’ {aka ‘unsigned int’} to ‘int’ [-Wnarrowing]
  115 |         QPair<int, int> data = {keyEvent->key(), keyEvent->modifiers()};
      |                                                                       ^

Change-Id: I2f97e9ce11202cee386c2c6b4902c689e3411e30
Reviewed-by: hjk <hjk@qt.io>
2020-01-15 07:28:32 +00:00
Eike Ziller
c22a840b10 CMake build: Fix version number in library file names
Make it compatible with the qmake build, with just the major version.

Change-Id: I3134b21b4775e7e83d135652dd66a51f3bdf91ab
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-01-14 15:39:10 +00:00
Friedemann Kleint
7d096c4828 Fix errors in qtcreator_tutorials.xml
Use &amp; instead of &, fixing errors like:
ERROR Could not parse file as XML document (:/qtsupport/qtcreator_tutorials.xml):160:116: Expected '#' or '[a-zA-Z]', but got ' '.

Change-Id: I49e0846628a2291ce2d256c1a2668e0ad1c954b0
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-01-14 11:51:49 +00:00
Christian Stenger
fefdbdfcd8 Debugger: Do not waste CPU when using LLDB
Fixes: QTCREATORBUG-23311
Change-Id: I5b1c40663c7977322e806af2e0393a3730e70049
Reviewed-by: hjk <hjk@qt.io>
2020-01-14 10:02:13 +00:00
Friedemann Kleint
499115fd94 QtSupport/Example list parser: Improve error message
Output line, column and message.

Change-Id: I1fa0b3da6b20b27ce3e2f66442751ab31e21904b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-01-14 10:01:53 +00:00
Leena Miettinen
9d038362b2 Welcome: Update links to QtWS19 talks in Tutorials tab
Add links to new talks and remove some to older talks.

Fixes: QTCREATORBUG-23406
Change-Id: Iee33afb616072f4d6d7c4dc554873942f10153f7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-01-14 09:07:06 +00:00
David Schulz
69bc021380 Doc: fix ui text from settings dialog
Change-Id: I6c085cf8d555821850ade56785ce1181a09ce078
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2020-01-13 15:02:00 +00:00
Henning Gruendl
4a0da87a76 QmlDesigner: PropertyEditor Controls 1 cleanup
Change-Id: I52b83d50a99a7ff24718ed3d99f9ad7cb4415565
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-01-13 14:03:13 +00:00
Eike Ziller
c2398e3067 Prepare for Notarization on macOS
Applications need to be signed with "hardened runtime" for notarization
to be possible

Change-Id: I05eaef8ad32e2f3c56baea82969da8bc891a6afd
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-01-13 08:29:23 +00:00
Leena Miettinen
df60a47cdd Doc: Describe using the binding editor in the Design mode States pane
...to create when statements

Change-Id: Iec56f6aa76478ca1ffc9803df3dffd4cd7196e65
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-01-09 14:05:37 +00:00
Henning Gruendl
4ad3cdc115 QmlDesigner: Fix tooltip license header
- Fix tooltip license header
 - Remove gui-private from qbs and pri, no longer needed

Change-Id: I80bffccca825be2940dac8b0e07d2861e2f8b3d8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-01-09 11:47:40 +00:00
Eike Ziller
a4055f382c Add changes file for 4.11.1
Change-Id: I4fceef356ff83bcd4bf1e282eaad427feaf80038
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2020-01-08 19:13:55 +00:00
Marius Sincovici
9165119819 Debugger: Check if m_perspective is valid before using it
When debugging a remote machine using ssh, if the ssh connection returns
an error before other workers are fully started, and it will call
destroyPerspective(). Then the other workers will call setState() when
they are in EngineSetupOk and then in EngineRunRequested.
Before calling select() method check if m_perspective is valid.

Fixes: QTCREATORBUG-23415
Change-Id: Ib174015b1d11cdaa5f59e7ccb012b849d49672f1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2020-01-08 18:00:47 +00:00
Christian Stenger
04b3c56a2b CMakePM: Fix license header
QC uses GPL nowadays.

Change-Id: I6229deb09fadb1f7b1b210ba17ac4d0f3858023d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-01-08 14:10:13 +00:00
Christian Kandeler
4b62f2ebd3 ProjectExplorer: Do not access output window from non-UI thread
Amends b4022f90d5.

Fixes: QTCREATORBUG-23442
Change-Id: I9ef369193f32b06c29f43ed7484cb120e1dfc892
Reviewed-by: hjk <hjk@qt.io>
2020-01-08 11:42:41 +00:00
David Schulz
1ab9dc9464 CppEditor: generate valid code via "Convert to Pointer/Stack Variable"
Adding a "= new <TypeName>" after converting a stack variable without
assignment or initializer to pointer.
Also remove the assignment when converting from pointer to stack
variable as this works better with explicit constructors.

Fixes: QTCREATORBUG-23181
Change-Id: I377ec32a1b66cf4b96db14cfcb4b71fb96c80c98
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-01-08 09:21:25 +00:00
BogDan Vatra
15734ac5eb QBS: Fix template for Android
CppApplication sets usesNativeCode for android which it's needed to compile the C++ part of the application.

Change-Id: Ibf787fecd256e4f90c09b8e3061a23419feb526e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-01-08 09:00:27 +00:00
Thomas Hartmann
cd5f070844 Fix build of qmldesigner tests
NodeInstanceView is build as part of the the test and
cannot have depedencies on core or qmldesigner when build
in test mode.

Change-Id: I5f04ec7ff42fdd0704552c3e791dfabd20fc9317
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-01-08 05:44:57 +00:00
David Schulz
a163bcd8b0 Editor: always set format for visual whitespace
Change-Id: I2ab4cb9f77d649c1c7d51dec1ef11005325a4710
Fixes: QTCREATORBUG-23040
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-01-07 12:28:07 +00:00
hjk
dff4469baf Debugger: Use a more convenient way to create timing samples
Change-Id: I4ca983957c81a1f5f963a85b16a2d1b255b2cd2d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-01-07 12:14:27 +00:00
Henning Gruendl
c2c48598d4 QmlDesigner: GradientPreset cleanup
- Remove Controls 1 imports
 - Rework states
 - Utilize theme values

Change-Id: I2d7b818f450387ad0325aae41aac7f8c1b30ea5f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Aleksei German <aleksei.german@qt.io>
2020-01-07 11:59:13 +00:00
Henning Gruendl
887058f621 Fix compilation
Change-Id: I98fe164f32bbe8c65a76b853f12ce7765a1c0f7e
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2020-01-07 11:56:52 +00:00
David Schulz
f75c4ea3f1 QmlDesigner: Fix compile after bb02ab161c
and cleanup includes

Change-Id: Ia7f5bb2cb1c0ca18d5bffa3cac9ceea495592910
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2020-01-07 11:39:47 +00:00
Henning Gruendl
59f08de43a QmlDesigner: Fix tooltip build issue
Change-Id: I9513172560c7a2556cf49ed5609ce227d0d7b18f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Aleksei German <aleksei.german@qt.io>
2020-01-07 09:35:41 +00:00
Mahmoud Badri
bb02ab161c Enable common keyboard hotkey actions for the Edit View 3D
Clicking undo, redo, delete, or save keyboard hotkeys while the Edit View 3D
has focus is working now.

Additionally this commit introduces a generic command for carrying any
variant data from puppet to creator side. This significantly simplifies
and avoids the boiler plate work of sending actions from puppet to
creator side. Current commands can be ported to use this generic
command but this is not part of this commit. Also a similar command to
work the other way around could be implemented.

Task-number: QDS-1266
Change-Id: I40fdf6b215ce77402250a791ea49cbdcd2a9d6eb
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-01-07 09:16:19 +00:00
Andrzej Ostruszka
76eba270bf fakevim: fix indenting of continuation lines
Use tab settings for indenting of continuation lines from current
document instead of using default value.

Task-number: QTCREATORBUG-20876
Change-Id: Ied15226166483dc11672c930145564cf897def19
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-01-07 07:24:18 +00:00
Christian Stenger
b99a495b11 Fix qmake build
Amends 93c668926d.

Change-Id: I26a332036a2ce6ae7f29d495b9a95f516145e9c1
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-01-07 06:29:12 +00:00
Christian Kandeler
307b4fb97b QmlDesigner: Fix build with namespaced Qt
Change-Id: I1dd6da16165f4503da32bebafec6b43074442a29
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-01-07 05:48:08 +00:00
Christian Kandeler
93c668926d QmlDesigner: Fix qbs build
Change-Id: I2c3907f6368160e043a2e848e96f5cea30c407dd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-01-07 05:47:54 +00:00
Henning Gruendl
8687d65353 QmlDesigner: Remove tooltip dependency Controls 1
Task-number: QDS-619
Change-Id: I4e54ac43cd6d3052620a9e5ca48cf1fbc66c6181
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-01-06 14:45:27 +00:00
Henning Gruendl
91b491ffb9 QmlDesigner: Add error mode to ColorLogic
Task-number: QDS-1221
Change-Id: I95009dc3700f3e308280fadaea374e7ba6dfa08b
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-01-06 13:25:45 +00:00
Jarek Kobus
f6659f24df Fix layout of the code style settings editor
Fixes: QTCREATORBUG-23227
Change-Id: I1ae650ba1e66c9444ef0d7fe17d003e5d6662b77
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-01-06 10:54:13 +00:00
Eike Ziller
4a00f53c17 Work around high DPI issues on Windows
Task-number: QTBUG-80934
Change-Id: I4b7dbe7157145db3a9feee83f32be3babaca5ab9
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-01-03 07:53:24 +00:00
Nikolai Kosjar
26693e8212 Revert "Clang: Stop enabling exceptions explicitly"
This reverts commit b114f77d8a as
"--driver-mode=cl" apparently still disables exceptions.

Task-number: QTCREATORBUG-23000
Change-Id: I9c49d971fafda5e1aca8445f8921e50f323d368f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2019-12-20 22:46:02 +00:00
Nikolai Kosjar
4fdd944617 Clang: Fix removing gcc internal include paths
Amends 5165c037eb.

Gentoo has the standard library headers installed in e.g.
<installdir>/include/g++-v8 and we excluded those. MinGW with the
standard library headers in <installdir>/include/c++ was whitelisted.

Instead of whitelistening more dirs that could contain standard library
headers, regard

  <installdir>/include
  <installdir>/include-fixed

as gcc internal include paths to remove. These seem to be stable across
distributions.

Task-number: QTCREATORBUG-23330
Change-Id: I44965d2030b4ea5a9dd269400faf19c3df89f5a6
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2019-12-20 22:45:31 +00:00
Tobias Hunger
32018623a4 CMake: Nest nodes below SourceGroups in Project tree
Task-number: QTCREATORBUG-23372
Change-Id: I8eccc7b9ce812b3abc9bf3e0057aa9d572f4faf8
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2019-12-20 15:46:11 +00:00
David Schulz
8f9ff0c640 CMake build: disable some warnings for build against llvm
Add the same ignore warning flags to the compiler as in
clang_installation.pri

Change-Id: Ieb3f6ac861cba60b6c7fb3c74e4c9b46a62d22b9
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
qds/v1.4.0
2019-12-19 13:02:29 +00:00
Nikolai Kosjar
2de52cffb1 Clang: Fix c++98-compat warnings for MSVC toolchain
Clang invoked with --driver-mode=cl will map "-Wall" to "-Weverything",
thus enabling -Wc++98-compat-pedantic and way more options.

Fix this by escaping "-Wall" in the cl mode, effectively passing in
"/clang:-Wall" instead of "-Wall".

This fixes what 5675169e56 addressed also
for ClangTools.

Change-Id: Ideb7bab923d0359e8039b61e9d53c8765de79c29
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-12-19 12:04:56 +00:00
Christian Stenger
62fd368473 AutoTest: Fix stopping test debug run
If the Debugger gets into a corrupted state and is not
stopable cleanly we do not get the stopped signal.
This in turn leaves the test runner in an inconsistent
state which cannot be reset except with a restart of Qt Creator.

Fixes: QTCREATORBUG-23298
Change-Id: I9d7e7cbc847f8883d2e750f4436c5ef281106d3a
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-12-19 10:13:28 +00:00
Leena Miettinen
ae29b2794b Doc: Describe aligning and distributing items in Qt Quick Designer
Task-number: QDS-1307
Change-Id: I62d7e127ced887fec9dbfddb1a8607e74e846108
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-12-19 09:37:36 +00:00
Christian Stenger
694cc56ed3 Core: Avoid accessing nullptr
The output window does not own the formatter
but in case of an erroenous ramp down of the
run control it may miss the destruction of the
run control.
This had led to strange nullptr accesses to the
formatter when clicking into the respective
application output pane afterwards.

Change-Id: I16fdf0e68f1f02537495436a82c9888c53c78345
Reviewed-by: hjk <hjk@qt.io>
2019-12-18 13:06:03 +00:00
Robert Loehning
d9a26acbb8 Squish: Don't change suffix .qrc when testing renaming
...since it's not expected to work anyway.

Task-number: QTCREATORBUG-23167
Change-Id: I165dbcbc206372475a8d9128b1888b38b9f82367
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-12-18 12:40:03 +00:00
Richard Weickelt
f1ae3499df Mention Qbs version 1.15.0 in 4.11 changelog
Change-Id: Iefe032f5e12f5a25f292ca93873703bfa8e42ba9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2019-12-18 10:06:10 +00:00
Leena Miettinen
0341772445 Doc: Use HTTPS to access Qt WebAssembly
Fixes: QDS-1402
Change-Id: Id15771bb2dda8da81640f809b143a43388a7f661
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
2019-12-18 08:55:34 +00:00
Leena Miettinen
0f148f479d Doc: Add dependency to qtcmake for links to CMake docs to work
Fixes a QDoc warning.

Change-Id: I7248cbc6471830039f6399696416de40ceacb595
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
2019-12-18 08:20:28 +00:00
Leena Miettinen
d45142a0f4 Doc: Fix broken links to Qt docs
The Qt for MCU docs are currently not available online

Change-Id: I705f78b32c7723a29653b0407306406eee1a76a4
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
2019-12-18 08:20:10 +00:00
David Schulz
546d4a3b1a WinRT: Move some device detection output into a logging category
This hides the detection failing in the case when no winrtrunner.exe can
be found, which is given as soon as you do not have a UWP Qt installed.
So moving this output to logging category makes it still accessible, but
it doesn't confuse non UWP developer.

Change-Id: Ie1434f75086d435f8f033b58c010e35fe64658b0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-12-18 07:11:53 +00:00
Eike Ziller
6d4223c5d6 Do not show line ending option in read-only editors
This avoids showing the option for example in git log or blame views.
The user also should not be able to actually change the line ending
style of read-only editors.

Fixes: QTCREATORBUG-23276
Change-Id: Ifa5cc9f663539928b4d5422b020e348b439684fa
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Marius Sincovici <smaryus@gmail.com>
2019-12-18 06:42:10 +00:00
Tim Jenssen
ba7545f2ff fix missing comma in source include patterns
Task-number: QDS-1403
Change-Id: I907462f0978c1610ba2e7af10f386380f8ea18c7
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2019-12-17 13:33:35 +00:00
Andre Hartmann
6d0336f223 CheckableMessageBox: Forbid focus for text and pixmap
That allows changing between the buttons with the
cursor Left and Right keys, without loosing focus
from one of the buttons.

Before, that was impossible without intermediate
tab key pressing. E.g. when pressing Ctrl+W
to close the git commit editor, the focus was
outside the buttons. To select one of them,
Tab had to be pressed first, but after some
Key Right presses, the focus got away from the
buttons again and the game had to be repeated.

That behavior was different from QMessageBox,
where one of the buttons always has focus.

Change-Id: I9b12f794e8ba4aef1a68aaf249ba6dd6789cae4d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
qds/v1.4.0-rc2
2019-12-17 13:33:03 +00:00