Commit Graph

85353 Commits

Author SHA1 Message Date
Jarek Kobus
becd9b9856 TaskTree: Get rid of nextChild arg
Introduce RuntimeContainer::continueIndex() instead.

Change-Id: Iced7a7824addb84ea45bd1d632b4814ac4a95e06
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-08 08:09:09 +00:00
Jarek Kobus
91e2437112 TaskTree: Do internal renaming
Change-Id: I2c32156f553bc692d09c4f1b6f6e7bf5a4332f99
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-08 08:08:58 +00:00
Christian Stenger
79cde2741b QmlPreview: Fix qbs build
Change-Id: I355ad9ad793cb6aea5493335419f1db858400a01
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-08 07:27:24 +00:00
Jarek Kobus
23ed1977da TaskTree: Keep a stack of active storages
Make it possible to run a nested task tree containing
the common storage from the outer task tree's handler.
This means we need to manage the stack of active storages
per thread.

Add a test for it.

This addresses the 4th point in the report below.

Task-number: QTCREATORBUG-29103
Change-Id: Ib0f925048197625a0eb9f83f262c7256a5756cc8
Reviewed-by: hjk <hjk@qt.io>
2024-01-08 07:08:30 +00:00
hjk
81928443ad CPaster: Use ActionBuilder
Change-Id: I20d3e3f9feb1e610038594a1d8d54f2169b2b675
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-08 06:19:01 +00:00
hjk
74f523a692 QtSupport: Add some extra hint when qmake seems not usable
Change-Id: Ib7fdd894c9f99c67badcf50683237cf4ce080057
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-08 06:18:26 +00:00
Yasser Grimes
f7950acd94 McuSupport: Accept wildcards in detectionPath and executableVersionDetector
In case the g++ symbolic link does not point to any g++ executable it
should be possible to pick other installed g++ versions

Fixes: QTCREATORBUG-29891
Change-Id: I3070e38617a85489e1e6bfb3b1a6368af684829f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-05 16:32:48 +00:00
Tim Jenssen
435761fd0a Merge remote-tracking branch 'origin/qds/dev'
Change-Id: Ieb14c6311dbfe828a94981854b9ec8c18182b6cd
2024-01-05 14:18:18 +00:00
Leena Miettinen
158058ca3b Doc: Reorganize the "Designing UIs" section
- Create how-to and reference topics.
- Move the short descriptions of topics to "IDE Overview".

Task-number: QTCREATORBUG-29361
Change-Id: I11a334de6151350ce993e4135828a3eecaabf308
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
2024-01-05 13:35:43 +00:00
Jarek Kobus
2fca517068 Process test: Fix flakiness on linux / mac (2nd try)
It looks like when the running process outputs the newlines,
reading it may be split into separate chunks.

Avoid newlines in this test and use std::flush instead.

Amends bc3e30e7ec

Change-Id: I46be774b5509a1f0f60b289f6b6ffc9b46955b8f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-05 13:05:51 +00:00
Thomas Hartmann
81421c2c8e QmlDesigner: Do not warn about attached properties
Change-Id: I2a59f5133d1542766bcd82551c998d5cf4d38d56
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-05 12:41:53 +00:00
Jarek Kobus
3a9c5a3e7d ManhattanStyle: Remove a hack for QComboBox wheel scrolling
Use Utils::setWheelScrollingWithoutFocusBlocked() explicitly
when a QComboBox is placed inside a scroll area.

The Utils::setWheelScrollingWithoutFocusBlocked() is more
general and may be applied to other widgets, like QSpinBox.

This patch brings back the wheel scrolling without a modifier key
for combo boxes placed in dialogs.

Keep the unconditional scroll wheel behavior when ctrl (meta on mac)
modifier is pressed.

Change-Id: Ieea0f228cea6b59e276bd3256eb6ea5ecc5b7d14
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-05 12:09:29 +00:00
Jarek Kobus
b49c40181a GuiUtils: Apply wheel blocker to more widgets
Attach it to configuration and aspect widgets.

Change-Id: Ifd649f6dbf8bbb1ce1cf7251ac46b7cfac9798e3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-05 10:17:35 +00:00
Cristian Adam
c48c3110da GitHub Actions: Update macOS runner to version 13
This version comes with 4 CPUs instead of 3.

Change-Id: I0a5de644e668a77a9cbda9fa57b6a322351dafa4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-05 10:13:45 +00:00
Thomas Hartmann
87df3f1307 QmlDesigner: Catch exception when refactoring id
Task-number: QDS-11576
Change-Id: I1081be20e0885fc460852e1d51cb7e85cab73a99
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2024-01-05 07:18:21 +00:00
Jarek Kobus
bc3e30e7ec Process test: Fix flakiness on linux / mac
Since it's not clear why the flakiness existed, leave a TODO note.

Change-Id: Ief1104870c008e056d5b87880b508fd66266bce4
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-01-04 20:44:38 +00:00
Artem Sokolovskii
b3bdbf395b LanguageClient: Add mimetype for .clangformat
It enables language server functionality for .clang-format files.

Change-Id: I911a254c777b4b5e15a73bf0abdb273156a0d0c7
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-04 15:09:44 +00:00
Jarek Kobus
fc4a9a3897 DapEngine: Avoid using keys()
Iterate directly over container instead.

Change-Id: I6b7b6ba13f5fb3d7feeb0030fc2cc0d92e949e73
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2024-01-04 15:02:30 +00:00
Jarek Kobus
f53db77230 GuiUtils: Rename attachWheelBlocker into setWheelScrollingWithoutFocusBlocked
This name corresponds better to e.g. SH_ComboBox_AllowWheelScrolling,
SH_TabBar_AllowWheelScrolling or wheelScrollLines.

Change-Id: I244774584e293ca45cc4be4d4526f925c2da9598
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-04 14:15:32 +00:00
David Schulz
a4f9267df1 TextEditor: avoid creating an highlighter to check a type
check the type after construcing the highlighter instead and save that
information.

Change-Id: I7d942dae4be8471dba90dd266267ff7fa1b6f440
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2024-01-04 12:38:44 +00:00
David Schulz
e1535f5f39 TextEditor: simplify SyntaxHighlighterRunner::cloneDocument
Change-Id: I2cf2673bd79dd92de43392dc890f4f7482b483f6
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2024-01-04 12:38:39 +00:00
David Schulz
76ec7e1599 TextEditor: use blocknumber instead of position to identify blocks
It is used more commenly in the code for that purpose.

Change-Id: I48112d2c80485d204137da36fadbe85ad1db802b
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2024-01-04 11:55:37 +00:00
David Schulz
562cf9eb4f TextEditor: simplify SyntaxHighlighterRunnerPrivate contruction
Change-Id: I40e4df9f56b67f550e74c463b2f98a15740eb43b
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-04 11:54:50 +00:00
Jarek Kobus
3a53648209 GuiUtils: Make wheel blocker transitive
Instead of consuming the wheel event, pass it to the target
widget's parent. This should allow for further scrolling
the possible parent scroll area.

Modify the focus policy only in case of WheelFocus.

Change-Id: I00c628a9e3d7608222b0700e71469c6cef6dea88
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-04 11:22:58 +00:00
Jarek Kobus
e928c19d27 ClangFormat: Get rid of EXPLICIT_MOC
Otherwise it generates the following:
"No relevant classes found. No output generated."
during compilation.

Change-Id: Ia0299db40412a8ba1543f6990a728b2ac3af07ac
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-01-03 21:22:50 +00:00
Cristian Adam
d959a0c8c2 GitHub Actions: Update ccache to v4.9
Also use the upstream version since upstream has binaries for all
platforms.

Change-Id: I83e94c57149b27d54cb14390f6da678be365a2ed
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-03 16:21:27 +00:00
David Schulz
b825d97e1e LanguageClient: auto setup yaml and json ls
Change-Id: I8fff750594cfbd25a0401cd24068c89b86dcf5fc
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2024-01-03 14:04:34 +00:00
Eike Ziller
10d389f59f Merge remote-tracking branch 'origin/12.0'
Conflicts:
	src/plugins/clangformat/clangformatconfigwidget.cpp

Change-Id: I84fba4e6f952e9aca606951e7fb7763b451e35d9
2024-01-03 13:05:56 +01:00
Jarek Kobus
afd979a6d9 CMakeManager: Simplify mutable lambda
Make lambda non-mutable. Pass CMakeManager as a context object
into the connection.

Amends ed1568309b

Change-Id: I022a8c468374eaf694acd7d8dbab0579c37bd8df
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-01-03 11:17:03 +00:00
David Schulz
5117ca3280 Debugger: Adjust lldbbridge and test for lldb on windows
Since frame 0 points to the Windows DebugBreak function it does not hold
any usable locals, so we have to pass the correct frame to the
lldbbridge test infrastructure in order to get usable data.

Change-Id: I2595be87a718d73fda3429017efd564e5d0ed9be
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-03 10:06:21 +00:00
David Schulz
9f69a87523 Update .clang-format
Define the to be used schema and update various values.

Change-Id: Id99859914447825d65419b1d467e7d8cee5d69ca
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2024-01-03 06:10:55 +00:00
Leena Miettinen
acf5c2e602 Doc: Move sources for "Jump to the Code" to qtdesignstudio\src
To fix QDoc warnings.

Also, hide the topic from the Qt Creator Manual.

Change-Id: I499f338a6f4adc3fff7f6b38eb2363437f1a84d5
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Pranta Ghosh Dastider <pranta.dastider@qt.io>
2024-01-02 13:56:36 +00:00
Andre Hartmann
1481012f37 Git: Better error output when gitk cannot be launched
Error messages should stand out and not be hidden within
other output.

Before it looked like this (with the last sentence in red):
```
13:24:54 Running in "/home/user/project": /usr/bin/gitk .
Cannot launch "/usr/bin/gitk".
13:24:54 Running in "/home/user/project": /cmd/gitk .
Cannot launch "/cmd/gitk".Cannot launch "gitk".
```

and now like this (also last sentence in red):
```
13:28:07 Running in "/home/user/project": /usr/bin/gitk .
Cannot launch "/usr/bin/gitk".

13:28:07 Running in "/home/user/project": /cmd/gitk .
Cannot launch "/cmd/gitk".
Cannot launch "gitk".
```

Change-Id: If165a0a2ad800fde27c7252cf8af924c55b60197
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-12-25 04:53:41 +00:00
Shrief Gabr
9ca5b7fea2 QmlDesigner: Fix cells' unpredictable yellow outlines
Task-number: QDS-11573
Change-Id: I00a57e39804e54ce2fc25f4430975267c61a953a
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-22 13:24:59 +00:00
Dominik Holland
ca3fab3a93 CMake: Add information about all sourceFiles to the CMakeBuildTarget
Change-Id: I13b978b2cd344c499c405ce11213261bf224296a
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-12-22 10:25:01 +00:00
Jarek Kobus
a2567684d0 TaskTree: Don't activate the storage when calling storage handler
This addresses one of the TODOs.

Change-Id: I46dc978f83613ecb2e5668b8c8c2f24396e0f4f3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-12-22 09:33:50 +00:00
Jarek Kobus
778a17bb50 TaskTree: Simplify internals
Drop QSet from StorageThreadData. Drop some asserts that
require locking the mutex.

This change causes the task tree tests execute twice as fast.

Change-Id: I58f6ec509f5fdd26d7f9a95d1223fad3a790cd3d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-12-22 09:33:18 +00:00
Jarek Kobus
6af0f3cc60 TaskTree: Optimize storage activation
Drop hash lookup upon storage activation.

Change-Id: Idc963300e14ff95bb829e5942c73c409bc80b839
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-12-22 09:32:58 +00:00
Jarek Kobus
ec22f5e759 TaskTree: Adapt docs for the removed List element
Change-Id: I9adab7a12a590fac4ffb797564fe7cb8988c4584
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2023-12-22 09:32:51 +00:00
Jarek Kobus
7d3f50f784 TaskTree: Remove explicit List element
Replace it with additional GroupItem's c'tors.

This addresses the 27th point in the report below.

Task-number: QTCREATORBUG-28741
Change-Id: I7f0620993e7c9bf61868e7bc7b112eea4dae6471
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2023-12-22 09:32:26 +00:00
David Schulz
4b088bd226 Debugger: simpify cdb test setup
Change-Id: I196cee8fa6b35b78dae0b2e7db2c708736b39daa
Reviewed-by: hjk <hjk@qt.io>
2023-12-22 09:27:23 +00:00
Cristian Adam
aec3e7dbf2 Debugger: Enable lldb with MSVC binaries
This commit will enable running of tst_dumpers on Windows using a MSVC
setup and lldb.exe as debugger.

Change-Id: I17611cc90ba2a04ec21aae11af16f1d0ff8e894f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-12-22 09:25:37 +00:00
hjk
cf4f221065 CMakeProjectManager: Move CMakeIndenter class definition to .cpp
Leaner internal interface.

Change-Id: I297c74e667891efbeab0edabbfc82fb058501aa2
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-12-21 14:59:10 +00:00
hjk
bdeded45a9 CppEditor: Move CppQtStyleIndenter class definition to .cpp
Change-Id: I2803ab51bbfe6a23223d63ad28a75b732abc67bd
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2023-12-21 14:59:01 +00:00
hjk
2945dc379f ClangFormat: Dont create a style factory to only use the indenter
Change-Id: I2bfe7c7a68341a4a11439067581f5704b1388164
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2023-12-21 14:33:33 +00:00
hjk
37c9b41273 ClangFormat: Remove some unused includes
Change-Id: I8d382b91acc60f62be2055c0124704d38b3c7f46
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2023-12-21 14:33:26 +00:00
Ali Kianian
6e75d21f84 QmlDesigner: Fix lambda unique connections for CollectionSourceModel
Fixes: QDS-11572
Change-Id: I25f3cbd8b6f806c347102ddea3855c23b30bf8f9
Reviewed-by: Shrief Gabr <shrief.gabr@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-21 14:16:50 +00:00
David Schulz
0f30dcee1f TextEditor: avoid unnecessary highlighter creation
Change-Id: I6e5cdabab26eb9f2d026f073c3d3db3e299a6c80
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2023-12-21 13:18:58 +00:00
hjk
12065e70d5 Utils: Add comments to the PathChooser::Kind values
They are documented properly, but sometimes simpler to look here.

Change-Id: Ibe48a30bf0e7909c1cea1d414748a09962691615
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2023-12-21 13:17:55 +00:00
Tim Jenssen
238bc38f88 QmlDesigner: QDir -> FilePath to get a saver removeRecursively
Change-Id: I89bf782e8e6e119de44ee4540e8d2ab7dbef738c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-12-21 12:14:25 +00:00