Commit Graph

73670 Commits

Author SHA1 Message Date
hjk bf4b94e4b8 ProjectExplorer: Dissolve ApplicationLauncher
Make its members part of SimpleTargetRunnerPrivate.

Change-Id: Ib6f700f7b849db761a1bd0b5ea401bbe010c010f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-23 14:53:31 +00:00
Jarek Kobus b9e53428b5 Move SshKeyCreationDialog into RemoteLinux plugin
It's being used only there.

Change-Id: Ie2917f34268eba3ada4f152d3feeaa4130350236
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-05-23 13:36:45 +00:00
Christian Kandeler 760cf632af Move clang diagnostics config settings to clangd settings page
It was confusing to have both "Clang Code Model" and "clangd" project
settings pages, so we merge them.
Along the way, a lot of code dropped off.

Change-Id: I780850b716195c3729403ae59f0794c11b5c556d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-05-23 12:15:40 +00:00
The Qt Project c117e3d3c9 Merge "Merge remote-tracking branch 'origin/7.0'" 2022-05-23 12:07:34 +00:00
Jarek Kobus 87f3e7563c Ssh: Rename SshConnectionParameters into SshParameters
Move it to its own header.
Get rid of SshConnection and SshConnectionManager,
as they are not used anymore.

Change-Id: I52fe20d7816ea57e7a7158ab2ae9565d50a76e21
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-23 12:03:39 +00:00
David Schulz 0a30445181 LSP: Make the destructor of JsonRpcMessage virtual
Change-Id: I7e7f4f425d0cb7a9b720a539026781c524ab382c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-05-23 12:01:01 +00:00
hjk 5ca6116cfa ProjectExplorer: De-pimpl ApplicationLauncher
It's local in runcontrol.cpp nowadays.

Change-Id: I7fd4e78b4c282fb64b4c5f9c4428c9feac7af7d6
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-23 11:58:50 +00:00
David Schulz 7c86d1a195 LanguageClient: pimpl Client and cleanup includes
Change-Id: I653861e29baeaddcbcd21a5e738be6bd85514617
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-05-23 11:58:09 +00:00
Jarek Kobus 29a62ff35c RsyncDeployStep: Get rid of unused methods
Change-Id: If597b7cca7a5913c2c9bab663ddd4fcd098deb59
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-23 11:54:36 +00:00
Jarek Kobus edd9ddcd75 Get rid of SftpTransfer
Remove also sftpdefs.h. They are not used anymore.

Change-Id: I6c45a70cec2e01afdd1a668068e090f5d4abde9b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-23 11:51:35 +00:00
Jarek Kobus 283cd4690f Add FileTransfer test
Change-Id: I0e71a20823bd50e73f1b642c5183a3626d993e35
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-05-23 11:35:12 +00:00
hjk 1f022735d4 ProjectExplorer: Move ApplicationLauncher to runcontrol.cpp
It's the only remaining use.

Change-Id: Id631981945b4d1850ea880a583d99dbb1e3cf25c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-23 11:13:27 +00:00
Eike Ziller f14b1a484a Merge remote-tracking branch 'origin/7.0'
Change-Id: I7037b2b400617b0be0e1a010dd293e4f96d77328
2022-05-23 12:26:27 +02:00
Mats Honkamaa 2e8bfee966 Doc: Improve Repeater3D component documentation
- Added task topics
- Reorganized content a little bit to separate task
and concept content
- Minor changes to language to better fit target audience

Task-number: QDS-6910
Change-Id: Iaa3a3d85d5a647704033079444b303de13abeb55
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-05-23 10:16:40 +00:00
hjk 21d0175dab (Re-)Start replacing ApplicationLauncher in SimpleTargetRunner
This is a second attempt, as just replacing with QtcProcess lost
functionality. Try again with baby steps.

This here effectively reverts commit b05fc053ef
and starts with pimpl'ing SimpleTargetRunner instead. Plan is to
follow-up with dissolving the ApplicationLauncher in the pimpl,
combine combinable pieces, and finally clean up. Ideally, not much
more that a slightly customized QtcProcess should be left.

Change-Id: I69e7b01588259fe60bb76ef1ba741a183322c4de
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-05-23 09:51:03 +00:00
hjk f4b7faff18 Re-enable 'Run as Root'
Accidentally dropped in b05fc053ef.

Change-Id: I4cc9da1057ae9e19d3efd3b1d9482b18b7d847df
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-05-23 08:51:32 +00:00
Artem Sokolovskii 646254f460 VCSbase: Remove foreach / Q_FOREACH usage
Task-number: QTCREATORBUG-27464
Change-Id: I1088047513e7660907182e80303607d8c48919f5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-23 08:49:43 +00:00
Christian Kandeler 2c24dc03ac LanguageClient: Request semantic tokens right away on document save
There's a good argument to be made that a doument save should bypass the
usual waiting period for requesting new semantic tokens.

Fixes: QTCREATORBUG-27403
Change-Id: I8355147116bccdcbcd4f6689b4d9c7a282d324be
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-05-23 08:31:53 +00:00
Thomas Hartmann 1d6363d84d StudioWelcome: Move opening of dialogs to event loop
Opening those dialogs can crash, if the qmlengine is reset.
We reset the qmlengine if we download new data.

Task-number: QDS-6962
Change-Id: Ia717e0f4534639f083604e9e5f33800cfebbe769
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-05-23 08:31:05 +00:00
hjk b05fc053ef Replace ApplicationLauncher in SimpleTargetRunner
Change-Id: I9f258dc0c085fd5d4e7c57a7abb724e91a32060d
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-05-23 08:21:20 +00:00
David Schulz 94e2fa7df0 LanguageClient: Add option to always send hover requests
Even if we already have a diangostic visible at this location. This is
used in the coco server to display additional information inside the
coverage browser.

Change-Id: I0d75f2e9f469ebdf6df7d6948a8e3e6b0cc58969
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-05-23 07:59:02 +00:00
Fawzi Mohamed a802a633f6 qmljs: add # as comment
Change-Id: I87a043a39eae57306bc81b3c83f7a363d53be4bd
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2022-05-23 07:17:14 +00:00
Eike Ziller 3cd476e582 CMakeBuildSystem: Remove some left-overs
From removing the "first build in temporary directory" mechanics.

The method that would previously switch the build directory from
temporary to real now just ensures that the build directory exists and
passes the input build directory through. Name it encordingly and remove
the confusing return value.

Remove condition that now was always true.

Amends 0e613918b6

Change-Id: I8d4cff23b3fcba895bc7338e7277d44efb46e8e7
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-05-23 07:13:06 +00:00
Artem Sokolovskii ac352492ca CPlusPlus: Remove foreach / Q_FOREACH usage
Task-number: QTCREATORBUG-27464
Change-Id: Idbcedd9f9a2e148cb18e53c9dc0b82b52b372d64
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-20 17:13:51 +00:00
hjk d41fc4b329 Remove or replace a few unnecessary #includes
Change-Id: I0545533baab57a4383fda5fd680603fdc6459a01
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-20 16:57:26 +00:00
Jarek Kobus 9201a22f80 AbstractRemoteLinuxDeployService: Remove connection phase
It's not needed anymore. Current deployment processes do that
transparently.

Change-Id: I6fc1397e6dfec70306045b903d6c0f8efde0d8e6
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-20 16:17:10 +00:00
Jarek Kobus 82d84ea958 GenericLinuxDeviceTester: Replace connection test with echo
If the echo command succeeds, the connection is established
properly.
Remove the usage of SshConnection from this test.

Change-Id: I02c6bf9214e01353be938ed6cd87d625b37672ee
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-20 15:58:37 +00:00
Henning Gruendl ac1e86fe74 QmlDesigner: Fix missing reference to backendValue
While this fixes an error with a backendValue not being referenced
correctly, it also adds more strict referencing to the getBackendValue
function calls.

Change-Id: Ib1609c71e30fda6c6418d4542cf443b05d0bd6e8
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
v7.0.2
2022-05-20 15:57:35 +00:00
Thomas Hartmann 7b95988765 QmlDesigner: Bump version in wizard
Change-Id: I7919a3191775dfabedc9178cdbeb169c46bb1a53
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-05-20 15:50:52 +00:00
Thomas Hartmann 07cc95333f StudioWelcome: Use lastModified
Change-Id: Icb4ca8e4d69b61b12a038207c3a97c06b6f2140d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-05-20 14:31:57 +00:00
Eike Ziller b2f7529c39 CppEditor: Avoid capturing everything by reference
Some things will go out of scope, and only 'this' is actually needed.

Change-Id: Icd5740f925b2c869d933e5e64e5b21e9a9fb918d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-20 14:19:34 +00:00
Artem Sokolovskii c23aa1c656 CmakeProjectManager: Remove foreach / Q_FOREACH usage
Task-number: QTCREATORBUG-27464
Change-Id: Iabe3a621efa56282bf1511f540c98fdf5d8da270
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-20 12:55:20 +00:00
David Schulz 7173bd6190 LanguageClient: adjust LSP inspector size policies
Allow to shrink the message details and selector widgets.

Fixes: QTCREATORBUG-27558
Change-Id: I776673ebe5a036b9c1e5a45955d0179b0daa583e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-05-20 12:20:14 +00:00
David Schulz 29f8db31ff LanguageClient: fix semantic highlight after a server reset
Change-Id: I3a389ec82032d21e2eb932ae8d0e8d5678575427
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-05-20 11:24:09 +00:00
David Schulz 8174dabe57 LanguageClient: fix leak on restarting crashed client
Change-Id: I3107d0afc81e1511c5ca643919d074226f221170
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-05-20 11:24:00 +00:00
Artem Sokolovskii 7450bcb2b9 Valgrind: Remove foreach / Q_FOREACH usage
Task-number: QTCREATORBUG-27464
Change-Id: Ia507fb7aab405226a954b6059ef326e999a8171a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-20 10:13:59 +00:00
Jarek Kobus c31285d317 GenericLinuxDeviceTester: Use FileTransfer for sftp and rsync
Make ProcessArgs::prepareCommand() return false in case
when executable is a relative path and it can't be found.

Amends 13067a7d9c

Change-Id: I0c4cf1580be34894df01245eb2411cdd7a122651
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-20 09:19:59 +00:00
Jarek Kobus 79cacd354d FileTransfer: Make it possible to call stop() from done() handler
Don't delete the TransferInterface directly from stop().
Disconnect from it and delete it later.

Fix emitting done() signal when error occurred.

Fix passing the proper enum to RsyncTransferImpl.

Set proper parent for TransferInterface.

Change-Id: I430f0bf2507de8a9b7fb610641ca86e37ccd80d9
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-05-20 09:19:42 +00:00
Henning Gruendl 5294c3a23b QmlDesigner: Fix FilterComboBox same value submit
* Fix issue when same URL gets submitted twice in a row
* Fix selection of model item when submitting a custom URL that aligns
  with an item in the model

Change-Id: Ica8819f72a1f2dc0c239eb2ced25a11a1355d81f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-05-20 08:32:28 +00:00
Jarek Kobus 8fb4d058ec ProcessResult: Get rid of outdated enum values
Change-Id: Ifd7b7db313ebb0ada2d90318145a1ce969a2beff
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-20 08:19:18 +00:00
Jarek Kobus 0675fe05b9 QtcProcess: Guard emission of done() signal
Add a missing guard for emitting done signal. It was overlooked
during QtcProcess devirtualization.

Amends a717ff71f4

Change-Id: I62c38d2ba9f3e437b5ef088b8362e97d16e576e4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2022-05-20 08:18:55 +00:00
Eike Ziller 94e38f2348 CMakePM: Use QML debugging and profiling option for initial parameters
Before this, if you set "QML debugging and profiling" to "Enable" and
then triggered "Re-configure with initial parameters", it would at first
not have QML debugging enabled, and only at some later point if you want
to re-run CMake with the additional options.

Change-Id: I5e8de7ebadbcb5a44b507ab9b953d4cbd8a3d063
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-05-20 07:28:09 +00:00
hjk 54db0fc5da ProjectExplorer: Remove some unneeded #include
Change-Id: Id52f17dae88f681b46da88bbeec154aa325f1422
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-20 07:06:25 +00:00
hjk 8dacb123e0 Utils: Pass MacroExpander to ArgumentsAspect constructor
In the past we wanted to keep the aspect constructor simple but
it turned out that exceptions were needed and accumulating, so those
are likely here to stay.

By passing also the MacroExpander to the ArgumentsAspect constructor
allows other single-purpose warts like the ProjectConfiguration::doPostInit()
machinery can be removed.

Change-Id: I148b0ca1ab0740270eecd0d3134620de65a86d4f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-05-20 07:06:10 +00:00
David Schulz a493970e05 LanguageServerProtocol: remove IContent
Do not pretend to support multiple message types, while no other
messages are actually implemented by us or even known to exist in the
wild.

Change-Id: I49ee2118b2e10f265ac641c195df8a9e5c97951c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-05-20 06:35:47 +00:00
Thomas Hartmann e10b3bc98b QmlDesigner: Use single function trackWidgetFocusTime to track view usage
This is simpler and not all widgets get focus events.

Change-Id: I91769abee7ee73017ba57811c124ddc509cac3fe
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-05-19 19:48:13 +00:00
Henning Gruendl 21710b3bed QmlDesigner: Remove selection clear while dragging
Remove clearing of all selected nodes when dragging an asset across
the Form Editor.

Change-Id: Ibc67b6ff01955d0af0a3510b03c89d03b2c3db93
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-05-19 18:44:15 +00:00
Thomas Hartmann c977dee6fe QmlDesigner: Track time spend in design mode
Change-Id: Iabe982dcf2fc8c4ef3d10cf3d3df5b9e9b826548
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-05-19 18:40:52 +00:00
Alessandro Portale 6511bcdd72 ProjectExplorer: Introduce type-aliases for a "recent projects" entries
The code base has too many repetitions of "QPair<QString, QString>" and
for QLists of that. Also we might want to change one QString to
FilePath, at some point.

Change-Id: I4bd3ebe0f81aa77a6a380a96986d27f64522b4c5
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-05-19 18:21:31 +00:00
Jarek Kobus 0a8dbaf153 Utils lib: Remove unneeded includes from cpp files
It's a result of a team work consisting of yellow triangle and me.

Change-Id: I8b4812766da70e0785ae71bf0cb71357379e2514
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-05-19 12:37:20 +00:00