feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity
77,084 Commits 108 Branches 368 Tags
c01ab460c85a4282376946bc511b4580cadb3c97
Commit Graph

77084 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jarek Kobus
c01ab460c8 QdbMakeDefaultAppService: Reuse TaskTree 
Change-Id: I03ee1935e7b0b0cc82f139f7f435d3194ff29f01
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-11-25 13:21:41 +00:00
Jarek Kobus
9e810acfbe QdbStopApplicationService: Reuse TaskTree 
Change-Id: I6086ccda3b3b5489f9553fbd2cb7c7b8950e17f9
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-11-25 13:18:39 +00:00
Jarek Kobus
2853d39065 KillAppService: Reuse TaskTree 
Change-Id: I250542724d537219a8c1ce222d7e941474671adf
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
 2022-11-25 13:18:16 +00:00
Jarek Kobus
0c18fbc31f ProjectExplorer: Provide task tree adapter for DeviceProcessKiller 
Change-Id: I45133dcba07d5fc5fa721c0af13ba86f75985a5e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
 2022-11-25 13:17:48 +00:00
Jarek Kobus
c99dd6650d UpdateInfoPlugin: Readd vanished comment 
Amends d4871731bd

Change-Id: I34288f977ac913a77c98a201873783d3d879369d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
 2022-11-25 13:08:45 +00:00
Jarek Kobus
c38a00513e ProjectExplorer: Introduce DeviceProcessKiller 
It will be much easier to integrate it into TaskTree,
comparing to hierarchical DeviceProcessSignalOperation.

Change-Id: I6bc9580a3d88d7bfd01e641b09094c6fa8fb94d3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
 2022-11-25 13:03:52 +00:00
Jarek Kobus
d4871731bd UpdateInfoPlugin: Reuse TaskProgress 
Change-Id: I35ad1005adb269d016b35fabfbccf27e92d3dfb9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
 2022-11-25 13:03:36 +00:00
Jarek Kobus
7afe536a5c AdvancedDockingSystem: WorkspaceDialog: Use Layouting 
Change-Id: I998147908941b4390c810983a5676628f07b1250
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
 2022-11-25 12:56:15 +00:00
Jarek Kobus
bcdfe1cedc TaskProgress: Add missing features needed by UpdateInfoPlugin 
Change-Id: Iabfbebd07699fbe45da6007347ed45517d593cfd
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-11-25 12:49:19 +00:00
Jarek Kobus
d90b1946d4 TaskProgress: Improve fluency of progress 
Change-Id: I8efb0242c035223bb52cb2684a30b57f44b489f2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
 2022-11-25 12:49:14 +00:00
Jarek Kobus
16f671874f BuildStep: Remove unused runInThread() and cancelChecker() 
Change-Id: I9d4a858a25ab93b17f1018cecc785b42dd76ecc0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-11-25 12:15:32 +00:00
Jarek Kobus
1e632d0c25 AndroidDeployQtStep: Make it cancelable 
And use QFutureInterface for it.

Change-Id: I1145b70b119d92af7316977c813f4f29b1f20b74
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: hjk <hjk@qt.io>
 2022-11-25 12:15:18 +00:00
hjk
038771051d CppEditor: Switch to FilePath in IndexItem 
... and fix fallout.

Change-Id: I45d27146806bdcb5ceb728b710eca51c7cd32ee2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2022-11-25 11:16:38 +00:00
Jarek Kobus
dbdabf9c27 Use M_PI for 3.14 
Change-Id: I19078a791afa1c74cd34e59b033525e029755d7e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-11-25 10:10:37 +00:00
Jarek Kobus
0a925009a1 RemoteLinux: Fix const correctness 
Amends c88a829059
Amends f9b4bcd3d8

Change-Id: Ia9817d4f7ba7df495e55e8729ba34258c907a545
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-11-25 09:28:41 +00:00
hjk
4ad9f53989 Core: Rename DocumentModel::fileName() to filePath() 
That's what it returns nowadays.

Change-Id: Ia5b8b643ad37e773db9788d8391edbb021844aec
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
 2022-11-25 09:25:12 +00:00
hjk
40ba25b691 CPlusPlus: Return FilePaths from Document::includedFile 
... and fix fallout.

Change-Id: Ieaad57700fa48d0c4a0dd9bf2c284315579b9473
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
 2022-11-25 09:23:39 +00:00
hjk
ef97774122 Core: Rename ExternalTool::fileName() to filePath() 
Also, setFilePath(), and some code cosmetics.

Change-Id: If24aa2d75276eafac4d7494153c5fc223be1ee8b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-11-25 09:09:48 +00:00
hjk
67e9c2d7a0 CppEditor: Proliferate FilePath use 
Remove SnapShot::{find,contains}(QString) overloads and fix fallout.

Change-Id: I50c415826939e09ac111f33def611c7478fa5d97
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
 2022-11-25 09:01:05 +00:00
Jarek Kobus
74ba41f82c Qnx: Reuse setExtraTasks() 
Change-Id: Ia392015a7a410a1920e8e79637ac6ac51c988b74
Reviewed-by: hjk <hjk@qt.io>
 2022-11-25 08:57:06 +00:00
Jarek Kobus
fbe8d85401 Qnx: Reuse setExtraCommandsToTest() 
Change-Id: I09e6160c1cbff9d74ac1ad3e824a0137d5964aae
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-11-25 08:56:33 +00:00
Jarek Kobus
6dc1a1e98f LinuxDeviceTester: Avoid non-trivial global variables 
Change-Id: I1c3cf646ecbd6619f7c5a6eb117a0aca43d78534
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-11-25 08:55:44 +00:00
Jarek Kobus
b34fc8a420 LinuxDeviceTester: Make it possible to add extra tasks 
Change-Id: I8e1308aef73a6f81fcff092ba75c1c88479c2207
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
 2022-11-25 08:55:34 +00:00
Jarek Kobus
658c9f6f06 LinuxDeviceTester: Make it possible to test extra commands 
Change-Id: I1920457a4d97bf23865ad6c4842fbdbb40c2db23
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
 2022-11-25 08:51:48 +00:00
Jarek Kobus
7582b62ddf TextEditor: Remove unused findFallbackDefinitionsLocation() 
Change-Id: Ib5c02562087c2ee11b5aa1c19c823cf8fd2af828
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-11-25 07:25:38 +00:00
hjk
7fd3a5e66e CMake: Use FilePath::suffix() instead of manual construction 
Change-Id: Id2bc542047ce5f4ff1937be90b976d330b69c51a
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
 2022-11-25 06:53:20 +00:00
David Schulz
c10600134f Editor: do not paint rounded corners in editor overlay 
Calculating and optimizing a painter path with rounded corners can
freeze or under certain circumstances even crash Qt Creator. Since we
are using a less rounded design nowadays anyways we can also cut this
overhead.

Fixes: QTCREATORBUG-21056
Change-Id: I9cd5eaea00ab040d529f51ea6d2f337dd0a1f6b8
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-11-25 05:24:47 +00:00
Jarek Kobus
3d05611726 ModelingLib: Replace foreach with range-based for loops 
Change-Id: I3e51c9477b6995ec06b119fb4518a53aa1d71ec9
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
 2022-11-24 17:00:03 +00:00
hjk
a94f37c8b0 Utils: Add FilePath::{suffix,fileName}View functions 
Can save a few cycles in some cases.

Change-Id: I0da3ad9ae2127e20f8e90d68f924e87661028071
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2022-11-24 16:52:57 +00:00
Jarek Kobus
46cfdbf285 Slog2InfoRunner: Reuse TaskTree 
Change-Id: I820814de90ddf0a3094ed35481c488d36b059c31
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Marianne Yrjänä <marianne.yrjana@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-11-24 16:12:47 +00:00
Jarek Kobus
6fb0bebba9 AbstractRemoteLinuxDeployService: Simplify internal data 
Replace stopRequested field with Stopping state.

Change-Id: I75d098e5913b59fd7ace2881c6e0c42e70c06667
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-11-24 16:05:27 +00:00
Jarek Kobus
d2408fd389 Tests: Replace foreach with range-based for loops 
Change-Id: If813702db78f05701f0ef9378843a474da0aae6a
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-11-24 16:03:04 +00:00
Jarek Kobus
5bb46fc998 MakefileParser: Replace foreach with range-based for loops 
Change-Id: If1c2fecb68d732751ca8808c26e514e3cdffc842
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-11-24 16:02:57 +00:00
Jarek Kobus
68116ae4f1 GLSLEditor: Replace foreach with range-based for loops 
Change-Id: Ie28411ec0f69a4cee0feff61b11ed73a897174ea
Reviewed-by: hjk <hjk@qt.io>
 2022-11-24 16:02:47 +00:00
Jarek Kobus
6a20c52cc9 QtSupport: Replace foreach with range-based for loops 
Change-Id: Ia941c8dec41a73ca126c91304223d1fe98bc2972
Reviewed-by: hjk <hjk@qt.io>
 2022-11-24 16:02:28 +00:00
Jarek Kobus
849c902971 Qnx: Replace foreach with range-based for loops 
Change-Id: I590a6a4c6ee973307cbfb7d49b863a1492f6abcc
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
 2022-11-24 16:02:17 +00:00
hjk
9d80e23256 CppEditor: Proliferate FilePath use 
This includes one functional change: It drops some cleaning
of the path used to create the CppDocument, which is now
assumed to be done on the caller side.

Change-Id: I5e2a182028e4d5b56282ad85f4a5c665f081754f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
 2022-11-24 15:54:33 +00:00
hjk
8d645a506d ProjectExplorer: FilePathify extracompiler.cpp 
Change-Id: I74712eb4f7f73dd809edf3ca4cfa8a14572e0365
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-11-24 14:57:08 +00:00
David Schulz
decbb93069 MsvcToolChain: reduce severity of task for failed vcvars runs 
... if we can use cached environment modifications from previous Qt
Creator runs.

Change-Id: I2c570f3d3fc30adccf27339b2e21c5d00d4caa37
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2022-11-24 14:11:17 +00:00
Alessandro Portale
4536258c9e Android: Revive second half of AndroidManager::updateGradleProperties 
The extra "gradlew" which gets inserted into packageSourceDir makes all
paths that are subsequently based on packageSourceDir be invalid.

Amends: ded34daa2b

Change-Id: Ied7fe12a3d68c27b56eeb4d0ad4ce375ee228f4e
Reviewed-by: hjk <hjk@qt.io>
 2022-11-24 10:57:58 +00:00
Jarek Kobus
f2d50ba6ff GenericDirectUploadService: Reuse TaskTree 
Change-Id: Ib450274d3e73059bbc5e8f8e0d586ebb2a7a0dc4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
 2022-11-24 10:33:56 +00:00
Jarek Kobus
a6015a6216 LinuxDeviceTester: Use Storage for internal inter-process data 
Change-Id: If186c2cd83781a1de4c2a9d579611079ee7318b4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: hjk <hjk@qt.io>
 2022-11-24 10:33:25 +00:00
Christian Kandeler
bfecefabc0 CppEditor: Let users check for unused functions in (sub-)projects 
Note that especially in C++, there can be a lot of false positives,
especially in template-heavy code bases. We filter out the most notorious
offenders, namely:
    - templates themselves
    - constructors and destructors
    - *begin() and *end()
    - qHash()
    - main()
Since the code model does not know about symbol visibility, the
functionality is quite useless for libraries, unless you want to check
your test coverage.
The procedure is rather slow, but that shouldn't matter so much, as it's
something you'll only run "once in a while".

Fixes: QTCREATORBUG-6772
Change-Id: If00a537b760a9b0babdda6c848133715c3240155
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2022-11-24 09:27:03 +00:00
Marcus Tillmanns
43b21595e9 Utils: Disable broken commandline tests on windows 
Change-Id: I20e89877886b0f9416cca766a119b99191011d1b
Reviewed-by: hjk <hjk@qt.io>
 2022-11-24 09:00:32 +00:00
Christian Kandeler
b841d68a95 Wizards: Let "new file" wizard create subdirectories 
Change-Id: I1267025ab3db3803e10c6a5ebf78bb945fe19c71
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
 2022-11-24 08:18:17 +00:00
Jarek Kobus
953051b8bb UpdateInfoPlugin: Reuse TaskTree 
Change-Id: Ic54f6d829eb4c9257ecba183fa0d029289d00bdd
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
 2022-11-24 07:34:57 +00:00
Jarek Kobus
5e5d412fc4 GccToolChain: Create process on stack 
Amends 948f0070fa

Change-Id: I67c537f19da6cd012d1d51d80f0b987dd2b1fede
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
 2022-11-24 07:34:19 +00:00
Christian Kandeler
706b0ff9eb "New Project" wizard: Create project parent directory, if needed 
There's no reason to force users to the terminal if they want to create
their project in a new subdirectory.

Fixes: QTCREATORBUG-28346
Change-Id: Id92b2194c018274aac6f7f29c7304efa8c1d2d9e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
 2022-11-24 07:33:19 +00:00
Jarek Kobus
2e75492257 TextEditor: Replace qAsConst() with std::as_const() 
See 8eb4d52342

Change-Id: Ic96065a4bda4c9658d88bbab2e916e8f2525bcb2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
 2022-11-24 06:01:03 +00:00
Jarek Kobus
f9b4bcd3d8 TarPackageDeployService: Reuse TaskTree 
Change-Id: I74d19719f5a946a79409f04b4536fe9368747bc1
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2022-11-23 15:34:06 +00:00