qmlprofilertraceclient.cpp:280: warning: C4334: '<<' : result of 32-bit
shift implicitly converted to 64 bits (was 64-bit shift intended?)
qmlprofilertool.cpp:539: warning: C4554: '<<' : check operator
precedence for possible error; use parentheses to clarify precedence
Change-Id: Ifaa048d42bccf203e6587a474c197c22b0f69fec
Reviewed-by: Ulf Hermann <ulf.hermann@digia.com>
Root cause is trying to set the display name on a FolderNode that
is not in the tree yet.
Allow setting the displayname in the constructor and use that new
constructor where it makes sense.
Task-number: QTCREATORBUG-12897
Change-Id: I907e48cac837966e38524bfe88a87ef17d93f0b2
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Closing the dialog before the process terminates might lead to this.
Task-number: QTCREATORBUG-13075
Change-Id: I3b6ffcca010eb356b14d87f2a7d62090c158faba
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Namespaces; use QVector instead of QList for
QPair<QTextCursor, QTextCursor>.
Change-Id: I60c3bede66c404ded96b982299cf853b0b9d4f8e
Reviewed-by: David Schulz <david.schulz@digia.com>
The icon already includes the 'down' arrow, thus we need to set the 'noArrow' property to prevent
the theme from drawing a second arrow.
Change-Id: Ia910bcebb68b6faf4cc101685ba71e36069ef057
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
LLDB 320.* from XCode 601 was unhappy. This is an trial-and-error
to get it start up again.
Change-Id: I5dda0eef785d70abbb5798c3884ace89a8426969
(cherry picked from commit 1af0f77ea9)
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Introduces a "prepareSearch" method for locator filters that is called on
the UI thread prior to the threaded matching.
Fix various small thread-safety issues in the various filters.
Change-Id: If5ae7d205e126d367420936a93f8d9a84496edb8
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Remove plural to align with the other VirtualFunctionAssist* classes.
Change-Id: I986e564ab9080e6fbc75f524f89d98907792a48e
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Reviewed-by: David Schulz <david.schulz@digia.com>
...since build() is called multiple times for e.g. the global snapshot
(CppModelManager::projectPartFromDependencies,
CppModelManager::replaceDocument).
Change-Id: I03667496a5abc984ba976046dc7b76998a6e3336
Reviewed-by: hjk <hjk121@nokiamail.com>
LLDB 320.* from XCode 601 was unhappy. This is an trial-and-error
to get it start up again.
Change-Id: I5dda0eef785d70abbb5798c3884ace89a8426969
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>
The all/current project searches use metacalls on the UI thread to work
around thread-unsafety of the Project::allFiles method, so we cannot jus
t block the UI thread to wait for the old search to cancel.
On the other hand, many of the ILocatorFilter::matchesFor implementation
s do not work when they are run in multiple threads simultaneously (most
implementations access unguarded member variables, help index filter tend
s to crash), so we _do_ have to wait for the search to cancel before sta
rting a new thread.
Broke with 05c267673f and 6fc39f0c41
00c5673ae80d03d115bf3739
Change-Id: I93c607c879e8ba6ef60f94719812edb3df43a154
Task-number: QTCREATORBUG-12875
Task-number: QTCREATORBUG-12592
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
Re-produce the fixed problem with:
1. Shut down Qt Creator while having the include hierarchy sidebar
open.
2. Re-start Qt Creator - the side bar is displayed again, but the
"No include hierarchy available" label is not scaled at the full
sidebar size, but only to 50%.
Change-Id: I24e84bfd7cbb9dd9383a60179f5444de9401015d
Reviewed-by: Przemyslaw Gorszkowski <pgorszkowski@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Remove GenericProposalModel convenience constructor,
add GenericProposal instead. Less user side code.
Change-Id: I833f9943df27b50579485c93efb96943ec403f65
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Apparently setDefault must be called *after* the button is added to the
dialog.
Change-Id: I8351a666509bb4e92492388f80575ccea969c754
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
This is a generalization of the customwizard (using Json for its
configuration files since that is so easy to handle in Qt 5 and
since it is incompatible with the customwizard anyway).
It allows to define an arbitrary number of pages and generators to
generate the actual files.
Change-Id: I45a01cf7fb906701b627fa1471a898cad472f679
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
One signal less, one connection less, less indirection in user code.
Change-Id: Ie49d4a76982f2ff9d2b307ed541c33c6a7ea6480
Reviewed-by: hjk <hjk121@nokiamail.com>
Readd check for empty platform names that was removed in
b2ea6e1b9e
Task-number: QTCREATORBUG-13063
Change-Id: Ib509f0e736c33aca2987f2add65dd184b637dcbe
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
There was duplicated data hanging around, with the potential
of getting out-of-sync.
Change-Id: Ib4927a098b4905347faa203af323234b464be9cd
Reviewed-by: hjk <hjk121@nokiamail.com>
