Commit Graph

51480 Commits

Author SHA1 Message Date
Nikolai Kosjar
ca72c29462 Clang: Provide highlighting for identifier under cursor
Change-Id: I80ffe23cbcc84ab7323124581d9dd6afbe974fd0
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-06-14 12:49:05 +00:00
Nikolai Kosjar
9de9da7423 CppEditor: Do not start CppUseSelectionsUpdater for same identifier
Saves some cycles when navigating with the text cursor over the
characters.

Change-Id: Ie9a23d97ac09ca45a32178cae5b8945d0c623811
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-06-14 12:35:26 +00:00
Nikolai Kosjar
38789eb0a6 CppTools: Use class member prefix "m_" in builtincursorinfo.cpp
Change-Id: I8e4079734f9167dcc9da2ceff027f8559bab367f
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-06-14 12:33:22 +00:00
Nikolai Kosjar
fdf0a104ec CppEditor: Generalize CppUseSelectionsUpdater
Let CppUseSelectionsUpdater delegate the work to
*EditorDocumentProcessor so that the clang code model can also provide
results.

Change-Id: I6872afbfeea1a5c4a64fdf19fcb1992f134dde08
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-06-14 12:24:59 +00:00
Nikolai Kosjar
cd6bd3c4d8 Clang: Move completion test
Change-Id: I61cd72c131407415732ed1231a4614be57c1454b
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-06-14 12:24:52 +00:00
Christian Stenger
706da24733 QbsPM: Fix compile with Qt5.6
Change-Id: I21855bfd173ad6e85329d83b2337efc37359be6e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-06-14 12:22:20 +00:00
Nikolai Kosjar
18bdbe1b0f Clang: Do not expire job requests with newer document revision
...than currently reflected in documents. Otherwise such requests expire
immediately.

Needed for a follow-up change.

Change-Id: I456aea02a0fee9b9602a59a99943da13a01472d9
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-06-14 12:05:18 +00:00
Marco Bubke
bc22192813 Sqlite: Fix compile
Change-Id: I098ba3f2a896f3f1f675a81b48cd41364aeaa631
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-06-14 11:49:33 +00:00
Nikolai Kosjar
de5cbacae5 Clang: Rename JobRequest::Requirements to ExpirationsReasons
...to avoid ambiguity in regard to a new enum in a follow-up change.

Change-Id: I4f732b5200ed674b6708510ac8de0a795afe52da
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-06-14 11:48:54 +00:00
Nikolai Kosjar
e8ce2e62d2 CodeAssist: Do not retrigger completion when applying a snippet
This fixes the following case for the ClangCodeModel:

 1. Trigger non-member/non-prefix completion.
 2. Choose the generic "class" snippet.
    --> The snippet is inserted, cursor is right after "name", but it
        also triggers another completion that proposes e.g. the "namespace"
        snippet.

This does not happen with the built-in code model because at that cursor
position it provides "name" as completion result, which is a perfect
match and thus suppresses the completion list.

Change-Id: I2f797469b2a0952406b50c28f9704b113e19b16d
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-06-14 10:43:36 +00:00
Marco Bubke
43d6726c70 Clang: Add equal operators for ClangString
Converting them in a Utf8String in an inner loop can be quite heavy.

Change-Id: I4f2ccde47a6e3ca08ed054462eb7772ded9e55c9
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-06-14 10:14:07 +00:00
Marco Bubke
f22bd9dc4c Clang: Fix warning in HighlightingMark::punctuationKind
Actually mixing returns and not is not that well readable workflow. A other
option would be to use if.

Change-Id: I36f07adb77d50ddc6890b6292c7883a1b5f80f58
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-06-14 10:07:20 +00:00
Marco Bubke
451123beea Clang: Clean up keyword highlighting
Change-Id: I8c2737718282d047e487b8ed82a40dc256d39ce5
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-06-14 10:06:59 +00:00
Nikolai Kosjar
e6bf399003 Clang: Stop highlighting keywords in preprocessor directives
Task-number: QTCREATORBUG-15516
Change-Id: I30046ae7c1a73144985639800227012bf5a4e357
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-06-14 10:00:02 +00:00
Christian Kandeler
7ffdcd102d QbsProjectManager: Make the configuration name explicit
This is a prerequisite for being able to import builds.

Change-Id: I22bd8f201db943335edadc899bfe9fa64d39e845
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2017-06-14 09:11:56 +00:00
Marco Bubke
3fb25b28e3 Clang: Cleanup IPC code
Change-Id: I29571801b4093337e2c7cc1eec51cfcd07b3bdc5
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-06-14 08:46:21 +00:00
hjk
f97875a870 Utils: Make Port::number error out with -1 in the invalid case
That's more consistent with 'default' cases QUrl::port() and internal
Utils::m_port representation.

Change-Id: Ia6ee413f92e94c202f70d734e79976a0cda0d9ef
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-06-14 08:43:20 +00:00
Alessandro Portale
646abdd445 Utils: Make the progress indicator themable
Ensures a consistent visibility with light and dark backgrounds.

Change-Id: I8e825ccf05248abb2c94c4cd3af56d0226bc7e96
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-06-14 08:30:03 +00:00
Eike Ziller
0316219f8d asConst: Simplify with C++11/14 and fix for rvalue refs
add_const is available since C++11, add_const_t since C++14
Use universal reference && to enable uses like

for (const auto item : Utils::asConst(foo->items())) ...

Change-Id: I17ee19dae22a306ccf92035f43e60e91b32dffd7
Reviewed-by: hjk <hjk@qt.io>
2017-06-14 07:30:57 +00:00
Christian Stenger
6621f5594f iOS: Fix compile with Qt5.6
Change-Id: I0ee2e97b94da72140631df01c6ddf59252e5138e
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2017-06-13 13:40:48 +00:00
Christian Stenger
931d334392 AutoTest: Clean up includes
Change-Id: I55a2ac8d3d625cbdd6b03c6a0ee11996e45cf981
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-06-13 12:50:30 +00:00
Christian Stenger
c1555b1d7e AutoTest: Provide way to access the original test output
When running tests the original output is processed and not presented
to the user at all. For crashing tests this could mean that output
was not able to get processed completely (e.g. when having XML as
output and relying on well-formed code)
Unhandled output could also lead to incorrect results.
This patch adds another view to the results pane which contains
the complete output of the last test run.

Change-Id: I923496e9c440de4ea68bee55415777ea5c2379c2
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-06-13 12:50:22 +00:00
Tobias Hunger
e78324dc17 ColorSchemaEdit: Make layout of color selection dialog cleaner
Add some section headers, make widgets align with more other widgets,
get rid of useless margins and make hiding elements not leave random
amounts of space between elements.

Change-Id: I3d2ce7a00a92cdff5af5b7aa5e2784460d388c85
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-06-13 12:47:27 +00:00
Tobias Hunger
190f2d9e8d Mobile platforms: Do not use QLatin1String in BuildSteps
Change-Id: I3d67e94e7dc2d86ac1eba641562ee4a045f95d6c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2017-06-13 12:46:51 +00:00
Tobias Hunger
05e0b001d3 ProcessExplorer: Remove QLatin1String from AbstractProcessStep
Change-Id: I1eed445b2e0400272ded021123420eee279ea1df
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-13 12:46:41 +00:00
Tobias Hunger
9f4583756b ProcessExplorer: Do not use QLatin1String in ProcessStep
Change-Id: Ic72e1cfe6d164d5f137ce4451033a9992bc2fd13
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-13 12:46:36 +00:00
Eike Ziller
a456375187 Do not put locator manager into object pool
Users should use the static interface (and they do).

Change-Id: I2b8f6a379a45975d94fc8e77f86df9a16f2c9cf1
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-06-13 12:42:21 +00:00
Eike Ziller
247639d9c3 Remove 1-1 dependency between locator and locator input widget
Add possibility for filters to set a new search text when accepting
an entry.
Move placeholder text update from locator manager to widget.
Propagate filter update through signal-slot connection instead of directly.
LocatorManager::show is the only place left that directly references the locator widget.

Change-Id: Id61354d9f166c2af8c9d5528ad8998c7c6b8e1ab
Reviewed-by: David Schulz <david.schulz@qt.io>
2017-06-13 12:42:13 +00:00
hjk
19a47fed29 ProjectExplorer: Remove various RunControl::report* functions
The interface has now moved to the RunWorkers.

Change-Id: I1ebf74c081697b8e44926ab00053417f9f60647d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-13 11:07:15 +00:00
Tim Jenssen
0448ac5ce2 add style icons to wizards
Change-Id: Ia5741e68d9ce0a812080bfba7b120f5d5575c210
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2017-06-13 11:03:12 +00:00
Alessandro Portale
a1d4b63f8d CPlusPlus: Add a property icon
Properties have been so useful in Qt for Years, and they will
continue being so. Properties deserve a proper icon.

Change-Id: Ifd19c97470a48a033bbe4017855f7b150befb365
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2017-06-13 09:53:28 +00:00
Marco Bubke
be42d40c44 Fix text style name for output argument
Change-Id: Ibfc3584b60a073ba6518f78d2aa67b69bd6dd2a2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-06-13 09:16:40 +00:00
Orgad Shaneh
3eb36b556f Dumper: Add bitfield value in debugging message
Change-Id: I353e85b5b6999f85e93eed18ac0cf414c1c46066
Reviewed-by: hjk <hjk@qt.io>
2017-06-13 05:53:27 +00:00
David Schulz
e01f434722 ProjectExplorer: Fix build after removing wince* sources
Change-Id: Ic2e0149ceb6f83485c2ee81cc3e58cc1822e7c58
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-13 05:14:59 +00:00
Tim Jenssen
62f62fbe7a prepare "new file dialog" for bigger icons
Change-Id: If448374c2b62a1dd51469d0c54f250ba6a49c5b6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2017-06-12 21:22:32 +00:00
Alessandro Portale
29c95e3c3f ProjectExplorer, QtSupport: Remove wince* sources
WinCE support has not been maintained since a while.

Change-Id: Ieb388f981451a1178e70960f41e9db4bb3c789f9
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2017-06-12 19:37:46 +00:00
Thiago Macieira
80bdcb95de Add unnecessary break to switch statements that don't fall through
GCC 7 can't tell that it's unnecessary, so it complained.

 registerhandler.cpp:528:13: warning: this statement may fall through [-Wimplicit-fallthrough=]

Change-Id: Ia3e896da908f42939148fffd14c6a15f3ec05524
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-06-12 16:19:49 +00:00
Christian Kandeler
cbc5b21110 QbsProjectManager: Introduce QbsBuildInfo
We will need to pass additional build info data in order to
support importing builds.

Change-Id: Ic62d0da246f5a19b53632ef3dc61b1f4fc434e5b
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2017-06-12 15:10:55 +00:00
Alessandro Portale
d023014a5c ProjectExplorer: Remove unused cesdkhandler.h/.cpp
Must have been unused since a while.

Change-Id: I33adfe26d084f4990eef0b68371cf100e7e47e3e
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2017-06-12 14:48:44 +00:00
Orgad Shaneh
a9145e67ba Debugger: Prettify values for enum bitfields
Change-Id: I55329bba1864c9ebbbcb3b3bf1b940346507f8cd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-12 10:40:46 +00:00
hjk
4c29a31930 Ios: Convert to RunWorkers
This moves all of the RunControl implementation into a single
RunWorker, not yet splitting it up into separate RunWorkers
which is the final goal of this series.

Done-with: Vikas Pachdha
Change-Id: I9deaef48735c1c63c41dfae39d67f59387295273
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-06-12 10:37:12 +00:00
Robert Loehning
a3735eada4 BaseQtVersion: Check return value of QFile::open
Change-Id: Iba199ec29e4e8f4e74ffe6e76262eac0538c65ea
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-06-12 09:58:48 +00:00
Nikolai Kosjar
1f7403797a Snippets: Add struct snippet
Change-Id: I8c1e486d752ac0eaddbb1d7909a0e9b50382cc87
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2017-06-12 09:36:57 +00:00
Tobias Hunger
90c7427b15 ProjectExplorer: Make settingsaccessor more clear
Do not hide two strings getting concatenated inside long string lists,
use nullptr instead of 0.

Change-Id: I9b873295a24c1f5b0a9ce2c43ace050e3ff2329c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 09:33:36 +00:00
Tobias Hunger
623a9fc694 ProjectExplorer: Use member initialization in BuildStepsPage
Change-Id: I2834d3825b2737d036912e0d4b72fb57a926d139
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 09:33:12 +00:00
Tobias Hunger
f86ea447c3 ProjectExplorer: Use member initialization in CustomWizardParameters
Change-Id: Id461feb771990756adcaea98ac2f27f87f1b7ce9
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 09:32:55 +00:00
Tobias Hunger
5662f721e3 ProjectExplorer: Use member initialization in ToolChain test
Fixes a coverity warning.

Change-Id: Idac478b61abc1ac8e99e748fe5e6ee845c6312ff
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 09:31:56 +00:00
Eike Ziller
d21dde3b3c Merge "Merge remote-tracking branch 'origin/4.3' into master" 2017-06-12 09:00:10 +00:00
Tobias Hunger
aa0c2a5ef8 ProjectExplorer: Remove unused pointer member from EnvironmentAspectsWidget
Change-Id: I61ffc4e7f003212c8b0b4d2dfc187724ac4aabc8
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 08:50:23 +00:00
Tobias Hunger
ef72327495 Qmake: Use member initialization for GuiAppParameters
Change-Id: Ib438f41eb2e8c376fc1605046f416cd26f3503da
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-06-12 08:50:12 +00:00