This is done by the FutureSynchronizer d'tor, so no need to call
it explicitly. Move the FutureSynchronizer as the last field of
ClangModelManagerSupport so that its d'tor is executed first.
Change-Id: Id38b8ec08579be8e4ade99ecadb511850ff37f8c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Amends 6467797af2.
The created extra compilers were parented to their factories, who gained
a life time extension from 'end of plugin live' to static destruction
when the factories were made static. However, this that time the likewise
static QObjectCache in GeneratedCodeModelSupport::update might be
destroyed already, leading to a potential crash in m_cache.remove(dead).
This change here re-establishes the original timing by using the
plugin itself as parent for the extra compilers.
Change-Id: Id868b7b87f00440c67af551b71359c47a5c29cba
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Especially on Windows with VC2022 & Ninja, the output would often
display lines that ended in the middle until the next batch of output
was added.
This patch uses the Process facilities to only show full lines.
Change-Id: I38fcb2e8cb115637d15181b39374c533db150c1a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Remove wordiness and just explain what enabling the checkbox does.
Change-Id: Id4c03c1aa7fe7b87919036ffe39717e1a184d5f2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Update the latestVersion in the loop. Otherwise we always compare to
initial value and consequently the last installed version incorrecyly
becomes the latest version.
Fixes: QTCREATORBUG-30423
Change-Id: I7083928c5e371f0337677eacf1b3b4da50358a7c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Make the tool tip for useXMLOutput, quickCheckForDerivedTests, and
parseMessages consistent, use rich text instead of manual line breaks.
We use plural for the things that a locator filter locates (for filters
that don't trigger an action).
Beautify tool tip.
Change-Id: I6276e9a0894d59670a45937e1c4227405c346f38
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Make QFutureWatcher a child of the receiver / guard inside
the onResultReady() / onFinished() handlers.
This prevents the leak of QFutureWatcher when the receiver / guard
got deleted and the future never finishes.
Change-Id: I5653593777ee394dff8cc3c4b7506d8c1907232f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Settings labels are lower case and end with ":"
Change-Id: I729d25569790899a8d26966914ee8b872a48bcb0
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
The original version might have missed to recognize a @\r\n
combination or multi-byte UTF-8 code units when they were
split across to readyRead() handlers.
Change-Id: Ib543fa0070b63d25b44be429a3759964d65e878e
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Use std::unique_ptr instead, as QScopedPointer doesn't offer release().
Change-Id: Ifbe42dca5b266930e1000a50441995023b89b802
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
When resolving a conflit the key line got removed by mistake.
Amends 51998c5239
Change-Id: I74af26d23e7ac0180d1b351d7ecf6d6876499d89
Reviewed-by: hjk <hjk@qt.io>
With proper specifics sheet, the effect will show the available
properties nicely in property view.
Also introduced a new concept of FooBarSpecificsDynamic.qml
to provide property specifics. The difference to regular
FooBarSpecifics.qml file is that the dynamic version will
be reloaded always, which allows us to change it at runtime.
Fixes: QDS-11995
Change-Id: I744124182428c5c4607856e7970700d9a5e9972e
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
If the user clicks on a row's column holding a location
information then use this explicitly instead of always
using the first available link.
Change-Id: Ifecbecac632a4bfd4d31614a8c43ab6c80de4819
Reviewed-by: hjk <hjk@qt.io>
We were accumulating copies of the auto-detected system ninja setting
since the QVariantMap retrieved with toMap() was empty as it is a Store
nowadays.
Change-Id: Id983b5f1bf5ff18d6f43a71ebb406520e7655705
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
After encountering the namespace keyword, we have to backtrack the state
change introduced by the inline keyword.
Fixes: QTCREATORBUG-22071
Change-Id: I543976622d1a56b2c61d68da6ec3eee8b6d0d5b3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Palette colors may not be correctly populated depending on the
platform, so use some common available one.
Change-Id: I5f660aaefbd5882a255da4a25c3e15edc3fe3643
Reviewed-by: hjk <hjk@qt.io>
When vanished targets where shown in Projects, clicking on the project
specific settings showed a blank page.
There were hardcoded indices for the target and the misc settings. Get
the right child for the index directly instead.
Change-Id: I725d470ad04f8a227c91938efada76a757a7442c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This allows to get back to a 100% font zoom with the keyboard shortcuts
by zooming to an odd zoom factor by other means.
Change-Id: Ie90853367b17c207e9c47fc108b8d6f451e0f838
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
You cannot use a .shared file to share CMake project settings.
Change-Id: I605ead2f42ed012da789c1eef3a4e6a51de62243
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Since recently cdb seems to report messages without a final new line.
Change-Id: I6b15d6c5668b7a4bec207d56d86da5a0afa77cb4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This way the user can trigger the "Show Menu Bar" action when the
Ctrl+Alt+M doesn't work.
Task-number: QTCREATORBUG-30114
Change-Id: I4e1d14b7bf7554ce1a262c4b1d2671f8d0b81b85
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
