Commit Graph

88532 Commits

Author SHA1 Message Date
hjk
3b2a4fd3f2 Vcs: Remove VcsBaseEditorPrivate::m_describeFunc
Use the new copy inside m_parameters instead.

Change-Id: I85cddfd598fe8fc95af99c7c89dfdb5af49b137e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-02-07 15:29:30 +00:00
Cristian Adam
b9f546cf1b ProjectExplorer: Add kitFilterText virtual method to ProjectImporter
This way a project importer implementation can modify the filterText edit
field from the Project setup page.

Task-number: QTCREATORBUG-29535
Change-Id: I22b3d613ff84111b918c4a4447cd5656d7c593b9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-02-07 15:19:54 +00:00
Artem Sokolovskii
44c9074c0b ClangFormat: Move clangformat output to infolabel
Move clangformat output to infolabel in clangformatconfigwidget
to reduce noiziness in cli and to enhance the convenience of editing
the .clang-format file.

Fixes: QTCREATORBUG-30269
Change-Id: I78053bde9791122172f1d3d4ba712a9954ea9c4e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-02-07 15:14:02 +00:00
Artem Sokolovskii
8ee97b1e02 QuickFix: Fix add definition for templated function in namespace
- Fix add definition for templated/not templated function in templated
class inside namespace

Fixes: QTCREATORBUG-22076
Change-Id: I565cbdc8c6ab8d09727b4cd6f1c8fb45741c213f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-02-07 15:13:47 +00:00
Christian Kandeler
e2756fde8b CppEditor: Add quickfix for converting a function call
... to a Qt meta-method invocation.

Fixes: QTCREATORBUG-15972
Change-Id: Id84c83c5832cef32a877a451b0931ec47d2afe9d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-07 15:01:42 +00:00
hjk
2d37a7421f VCS: Simplify VcsEditor setup
Create the editor parameter structures in-place, and also
include the other two parameters in the struct to simplify
the signature of the c'tor.

Change-Id: Iff7d5ddf3096f4a3ed18e53265ae74806823af32
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-02-07 14:49:02 +00:00
hjk
be33c807a6 ProjectExplorer: Remove PEPlugin::finishedInitialization() signal
It was only used once in the debugger, connect more directly there.

Change-Id: I96923a308adfd343daeab6574e097f24bf0654d5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-07 14:23:46 +00:00
Christian Kandeler
91e72756fb CppEditor: Support wrapping strings in QByteArrayLiteral()
Fixes: QTCREATORBUG-12995
Change-Id: I9c0136b93fcfde0d2326bbd2bd6dbd5e75ae97a8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-07 14:21:56 +00:00
Marcus Tillmanns
5ae401b923 Aspect: Don't try to change value more than once
When our window loses focus the editingFinished signal is triggered.
This can happen multiple times (QTBUG-121983) if the result of the edit
is a modal dialog and the user clicks outside our application.

This would call editingFinished again, resulting in multiple message
boxes being opened. (Easiest to reproduce is changing the build
directory of a project which displays a message box confirming the
change)

This patch checks, via a recursion Guard, that the slot is not already
in the process of being called.

Change-Id: I5e61e1b57680f0b1f2483a81682e791bfb5c0867
Reviewed-by: hjk <hjk@qt.io>
2024-02-07 13:05:37 +00:00
Leena Miettinen
898190bd21 Doc: Add brackets and quotes that are automatically inserted
This works for single quotes, angle brackets, and square brackets, too.

Task-number: QTCREATORBUG-30209
Change-Id: Icb07d87fe95ee8779ffc29f4623a7dfbdfca9e4d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-02-07 12:52:12 +00:00
Eike Ziller
ef6f8df26d Merge remote-tracking branch 'origin/13.0'
Change-Id: Ica486867e95e4cfc98272cd34781ce770690fa17
2024-02-07 12:53:07 +01:00
hjk
738b654396 Subversion: More direct access to client singleton
Change-Id: I4263b07da9970101dbbc798dbf64359c1da5199b
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-02-07 11:42:46 +00:00
hjk
87f1114d21 Mercurial: Use more direct access to the client singleton
Change-Id: I32711a893bc5d5d655cf92637defaaf149f3f108
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-02-07 11:42:39 +00:00
David Schulz
a6eb6dd909 Debugger: try harder to find static meta object
Improves dumping of QObjects when the staticMetaObject is defined in a
different module than the object itself.

Change-Id: Ic02103016d14b4925978d8afeaf2dbcc5dcebf85
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-07 11:25:50 +00:00
Eike Ziller
2ea3f5382b Merge remote-tracking branch 'origin/12.0' into 13.0
Conflicts:
	cmake/QtCreatorIDEBranding.cmake

Change-Id: Id7ac4d8b397cc20356cfbe30abcf43f53c4d2ff4
2024-02-07 12:22:50 +01:00
Jarek Kobus
ff1aa20892 QmlDesigner: Fix remaining C++20 warnings about [=] captures
Change-Id: Ia54208e5e72016f6ca22e0b005d479aac8f49929
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2024-02-07 11:20:13 +00:00
Jarek Kobus
48bdf883dd Tasking: Fix some C++20 warnings about [=] captures
Change-Id: Ic49c9f393155acd16a2c116672fe73361f5c874d
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-02-07 11:20:04 +00:00
Thomas Hartmann
87dd0096b4 QmlDesigner: Disable share button in open source version
Task-number: QDS-11627
Change-Id: I3eb21fa84b6993aa783713ef5fa3beba1e3e030e
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-02-07 10:44:11 +00:00
Leena Miettinen
7d468a2686 Doc: Describe the Move Definition Here quick fix
Task-number: QTCREATORBUG-30209
Change-Id: I248b64ba13de61b2b1582a89f285653e02128fbc
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-02-07 10:38:08 +00:00
hjk
69caca1561 Vcs: Use const ref/copy to editor parameters instead of pointer
Will be propagated to the calling code further.

The minor inefficiency here is in my opinion outweighed by the more
common setup. The structure is small and we don't have thousands of
VcsEditors.

Change-Id: Ifc0d6e4acd5ef206d5fcadf55f9eb28bd567967c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-02-07 10:33:18 +00:00
hjk
fe251201fb ProjectExplorer: Hide a few factories behind a setup function
Change-Id: I2b688cee072d9983fbceb536063454a97dea3e60
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-02-07 10:33:03 +00:00
Marcus Tillmanns
7daee3d681 Remove unused qt-breakpad
Change-Id: I33937cc3e50d5dd03d38c64675dc3883c816290a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2024-02-07 10:17:49 +00:00
hjk
ad2230b1e1 Vcs: Move VcsEditorFactory closer to its product
Change-Id: Iaf2e6bdb4f04f0f1314ca7725feb63394a693511
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-02-07 09:58:23 +00:00
Leena Miettinen
80fa7ca453 Doc: Describe overriding system cursor for resizing editor views
- Update the screenshot of "Interface" preferences.
- Use the term "cursor" also when describing how to make the locator
  wider.

Task-number: QTCREATORBUG-29980
Task-number: QTCREATORBUG-30209
Change-Id: I5ca0d5c57932f32871a7354a2ea69f98482a2585
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-07 09:30:22 +00:00
Eike Ziller
a8ed2c505a Update copyright year, it's 2024 now
Change-Id: I183b87bf80332c789d000c37fd08f75297031b02
Reviewed-by: hjk <hjk@qt.io>
2024-02-07 09:27:02 +00:00
Jarek Kobus
d7d6f94c86 Axivion: Optimize combobox insertion
Keep the user data outside of combo boxes.
Use addItems(), which should probably be the fastest
insertion method.

Change-Id: Iec7e3fbe551a30e6a0e477e93add9c474c7f41fc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-07 09:25:19 +00:00
David Schulz
e4191b3219 LanguageClient: correctly unassign clients documents on project close
Change-Id: I82e041e787eb7a983de28b66b6ba6589a0548e42
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-02-07 09:23:52 +00:00
Christian Stenger
0e47028565 Squish: Fix missing impl for add shared script
The action is present for some time, but so far it had been
unimplemented.

Change-Id: I75722282cbe08aad6656e193822a5cb517ba17b3
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-02-07 09:09:31 +00:00
Cristian Adam
426dbc2f94 Terminal: Escape spaces for powershell paths
For the users that have a space in their user name, the location of the
shellintegration.ps1 is a path with a space in it.

This patchset fixes the escaping of that space.

Change-Id: Iae84b2e8a8f1b4e2b7e523e28417caaeb77bc5cd
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-02-07 08:24:40 +00:00
Cristian Adam
03c19e81ed CMakePM: Only overwrite Qt version for autodetected CMake versions
Amends b360776b1f

Change-Id: I6c52013096f156e05b647ca4c66d1b9bf16872c9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-02-07 08:23:45 +00:00
Marcus Tillmanns
3ec09a1c3d Terminal: Fix powershell integration
Previously a "1" was printed every time a powershell terminal
was started.

Change-Id: Ibd6f9dc9de8ba11ede98e13ca2f65ba5a99536fb
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-02-07 08:05:11 +00:00
Marcus Tillmanns
3259b1cb25 Terminal: Fix Cwd escaping
The shellintegration script escape the current working dir.
We were missing the code to unescape the paths.

This was particularly visible on Windows powershell
where backslash was escaped by "\x5c".

Change-Id: If697722986c72ebbc19d5ec8e3930321f3af7b6a
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-02-07 08:05:04 +00:00
hjk
a39d38d187 Vcs: Merge basevcssubmiteditorfactory.* into vcsbasesubmiteditor.*
Not worth a separate translation unit anymore.

Change-Id: I579c81c811cd84d89fd39755dca2fbeffae017de
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-02-07 08:03:26 +00:00
hjk
7da257e6c2 Core: Remove version control tests from public header
Change-Id: Ifc74b939fd8d9f1f1e4def7927ecfbef6a7fb7a3
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-02-07 08:03:18 +00:00
hjk
8b90a2b1cb TextEditor: Use more ActionBuilder
Change-Id: I959c973012873cb8d56442cfdfc86fac5db9faa0
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-02-07 08:02:47 +00:00
hjk
980605ecb0 Vcs: Make submit editor setup a bit more compact
Change-Id: I14c4c51a456f7b3b04b79b63b476f89eb58d3ea0
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-02-07 07:53:48 +00:00
Eike Ziller
c9ea3c6a51 OutputWindow: Add "clear" to all context menus
Change-Id: I989b15eb602d3224813510eacf020e3fdc90c650
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-02-07 07:52:21 +00:00
Michael Weghorn
941ad80d60 Debugger: Add debugging helper for std::string_view
Add debugging helpers for std::string_view,
std::basic_string_view and std::u16string_view
and add a corresponding dumper test for them.

With this in place, values of the local variables in the
"string_view.cpp" sample program from QTCREATORBUG-25865 are
shown as expected on both, Linux with GDB or LLDB and with
an MSVC build with CDB on Windows.

Fixes: QTCREATORBUG-25865
Change-Id: If8959e3225d9ce7f427a65ff6f1f134d3ad48e91
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-02-07 07:47:13 +00:00
David Schulz
42c8e82b4d CMakePM: fix optional check
Change-Id: I4145b1f29a63bd69fefb0385aff92c6a23939b5f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-07 04:12:01 +00:00
David Schulz
c28e37453e Debugger: always try GetSymbolTypeId before iterating over modules
This seems to even out some of the huge lookup spikes here.

Change-Id: I594c84dfd053be5626cd1f8c423ef00c7c77f37c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-07 03:59:04 +00:00
David Schulz
cf1e9db73b Debugger: ignore fields with a null address
cdb reports static members in fields sometimes with a null address.
Ignore those static entries since they cannot be visualized.

Change-Id: I0c58b2d75e95892185051e3c0a8dd9e6217596c3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-02-07 03:58:50 +00:00
Shrief Gabr
e43b0bcc1f QmlDesigner: Fix unchangeable data in cells
* Changes to the cell data are saved if Return or Enter keys are pressed.

Task-number: QDS-11894
Change-Id: Ia3a1ff8f6c9275906736fa1e0638b81c92bea910
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2024-02-06 19:12:24 +00:00
Cristian Adam
86b6d852b4 CMakePM: Allow CMake peset kits refresh without configuring first
This allows the user to reload the presets kits after editing
CMakePresets.json without configuring the project first.

Fixes: QTCREATORBUG-30238
Change-Id: Id448dd8e821591f6357ec9618f114733c13a3121
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-02-06 18:23:51 +00:00
hjk
c06dfdb237 ProjectExplorer: Move plugin unit tests definition to new class
This removes it from the central public header.

Change-Id: Icf1c552f9136a2e262e1bc48ae164b2fdd8edc79
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-02-06 17:17:59 +00:00
hjk
48d47faa4b Vcs: Rename VcsBasePluginPrivate to VersionControlBase
The classes derived from this had a dual role of implementing the
version control interface (IVersionControl) and as the plugin pimpls.
The name was focusing on the latter, but plugin pimpls are being phased
out in the new 'setupFoo()' world, so only the version control interface
part remains.

Change-Id: I60396f1729c736bc6c9e4fca250a5926e9d60f51
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-02-06 16:34:44 +00:00
Miikka Heikkinen
3e70980279 EffectComposer: Commit float and int fields on focus out
Fixes: QDS-11919
Change-Id: Id1750142d9a45b723f615d6a7da3989285f4b7aa
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2024-02-06 16:01:47 +00:00
Miikka Heikkinen
c5f86ea0b5 QmlDesigner: Implement effect item visibility handling
Now effects made with effect composer can be hidden/shown using
visible property.

Fixes: QDS-11786
Change-Id: I44782246adfa3ba3cd0a8203fa67b3f5412535f7
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-02-06 15:22:27 +00:00
Jarek Kobus
cf50a2d230 QmlDesigner: Compile fix against C++20
Move the initialization of the traceToken into c'tors.
Otherwise, the following error occurs:
internal compiler error: in assign_temp, at function.c:986

Change-Id: I20abfbf70e01fc6268ae6d4245272ef3a89daed5
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2024-02-06 15:17:31 +00:00
Jarek Kobus
947eaccea8 Various plugins: Fix remaining C++20 warnings about [=] captures
Change-Id: I3aab5f6fac0d30ff7e31dc524d2f42565b80bdb0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-02-06 13:08:30 +00:00
Marcus Tillmanns
d5c5e612d1 Aspects: Fix ValueAcceptor handling
Previously returning std::nullopt from a StringAspect::ValueAcceptor
would not cancel the change.

Change-Id: I7a329f9fe32f6d798c10102a0b68dcd638fb2398
Reviewed-by: hjk <hjk@qt.io>
2024-02-06 11:17:49 +00:00