feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity
88,532 Commits 108 Branches 368 Tags
cc05c1637778db8210ea901b8da71aeef1bde05e
Commit Graph

88532 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Andreas Loth
999a2d7bf8 Axivion: Update generated Dashboard DTO 
* Fix error in the spec
* Rework (optional) enum handling
* Reduce code repetition (thanks to Jarek)
* Apply QtC coding conventions

Change-Id: Ie33773deb6c8fc6f0bb14306e4257d66990c4ca6
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
 2024-02-05 08:43:29 +00:00
hjk
1f5fef5132 Meson: Use Utils::FilePaths in parser 
Change-Id: Idb256110e519c642420580ebd159bcffa11c0f1b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
 2024-02-05 07:08:12 +00:00
hjk
435b35ccfe Ios: Use setup functions for a few factories 
Change-Id: Ide05c2ca859454c1745e5c243af6a3d05131194c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
 2024-02-05 07:06:55 +00:00
hjk
508189339d Meson: Consolidate parsers 
Change-Id: I9c09d22af12a116ea15fcda793bcccd5a12ff840
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
 2024-02-05 07:06:44 +00:00
hjk
df71c6a1f0 Python: Use setup function for remaining plugin items 
... and remove the now-empty plugin pimpl.

Change-Id: I0db27757e832a0e3ac52b938a4d6ad820adfc195
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
 2024-02-05 07:06:30 +00:00
hjk
8dded168fd EmacsKeys: Make plugin soft-loadable 
Change-Id: I42002f7410f165745ba7de68536f66a1653df63f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2024-02-05 06:57:25 +00:00
David Schulz
9296a7fb9c TextEditor: fix crash on activating bookmark in deleted file 
since 23908b283e bookmarks are opened on
double click. But double click also emits an activated. and both signals
are connected to gotoBookmark, so this slot got triggered twice. This is
problematic when the bookmark is not reachable anymore since the first
execution of gotoBookmark deletes unreachable bookmarks, and the second
execution has only a nullptr and passes it to functions not checking
this pointer.

Fixes: QTCREATORBUG-30283
Change-Id: Ia57d0469840d467af31fa5c89745c2ad33aa7e3f
Reviewed-by: Xavier BESSON (Personal) <developer@xavi-b.fr>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2024-02-05 05:41:06 +00:00
Jarek Kobus
e1251f4ac3 CompilerExplorer: Replace QSharedPointer with std::shared_ptr 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: I591de84b86f91adda73848729149e29004277df2
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2024-02-04 15:52:52 +00:00
Marcus Tillmanns
b50e77e858 ProParser: Guard against OOM 
When the pattern for a regular expression is empty, every character
of the source is replaced with a copy of the "after" part of a
"QString::replace(re, after)". If input and output are huge this results
in a bad_alloc. We catch that here.

Fixes: QTCREATORBUG-16957
Change-Id: If512f407a2170d93ae7e4182219d9926945b14de
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
 2024-02-04 13:54:18 +00:00
Jarek Kobus
f96365194c CMakeToolManager: Fix compile warning about unused function 
Amends e7e593b2f6

Change-Id: Ib1d1508294adb3d53a4aa445d00adc39bcc76bbd
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
 2024-02-02 22:15:34 +00:00
Jarek Kobus
ced3cecafa AndroidSdkPackage: Inline most of AndroidSdkPackage subclasses 
Change-Id: Ib3242f9602a352fe0d4b1a6eb19454370e6d046b
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2024-02-02 21:56:43 +00:00
Jarek Kobus
1c4ac36b6d AndroidSdkPackage: Do some cleanup 
Remove unused "parent" argument from c'tors.
Remove repeating "public:" sections.
Remove obvious comment about overrides.
Remove unneeded Q_OBJECT macros.

Change-Id: Ie823ea9b977fdf7f102ce301070a564fd9b44c76
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2024-02-02 21:47:57 +00:00
Jarek Kobus
531a65301e SdkManagerOutputParser: Use parsePackage() for SdkPlatform 
Change-Id: I8695ade91864a7f4cac3758c4d5fff96cc781266
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2024-02-02 21:47:02 +00:00
Cristian Adam
e7e593b2f6 CMakePM: Use junctions for source/build dirs on Windows 
This way we have fixed small (max 64 bytes) paths for CMake's configure
/ build / install steps.

This allows the user to have longer paths and still compile with MSVC /
GCC MinGW compilers.

Fixes: QTCREATORBUG-26786
Task-number: QTBUG-117413
Change-Id: I0cff6521626dd2ce78d0223d46f0b480e977d5c5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2024-02-02 18:51:47 +00:00
Jarek Kobus
656a30b407 IDevice: Replace QSharedPointer with std::shared_ptr 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Replace QWeakPointer with std::weak_ptr.
Replace QEnableSharedFromThis with std::enable_shared_from_this.
Use std::static_pointer_cast and std::dynamic_pointer_cast
for casts used with QSharedPointer before.

Change-Id: If255a100c790860934f36d52906b93f33c31cfe8
Reviewed-by: hjk <hjk@qt.io>
 2024-02-02 16:45:57 +00:00
Leena Miettinen
9fe7922d3b Doc: Remove docs for View > Views > Automatically Hide View Titlebars 
Add the name of the removed option to the change log.

Task-number: QTCREATORBUG-30209
Change-Id: Ie526a3097ffec8077d042e919f01bbc348838041
Reviewed-by: hjk <hjk@qt.io>
 2024-02-02 16:45:42 +00:00
Alessandro Portale
26c5d0eb29 Fonts: Use H4 instead of H3 
...where we don't want AllUppercase.

Change-Id: I6675833b7535fc8e25504fdb6e6683419e70ea4c
Reviewed-by: hjk <hjk@qt.io>
 2024-02-02 16:44:28 +00:00
hjk
bf69d6891d CppEditor: Move ClangdSettingsWidget definition to .cpp 
... and de-pimpl there.

Change-Id: Ie205ce68de0513184b87b5bf7b6b338435b6a4de
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
 2024-02-02 16:39:42 +00:00
Jarek Kobus
14ff95b1bf Utils: Replace the last QSharedPointer usage with std::shared_ptr 
Replace it in Pty::Data. Remove the usage of shared pointer
from PathListPlainTextEdit.

According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: I5f19edf438eed3dde17b0f9abf570d2b53df93d7
Reviewed-by: hjk <hjk@qt.io>
 2024-02-02 16:06:08 +00:00
Jarek Kobus
f193aeed47 CPlusPlus: Replace QSharedPointer with std::shared_ptr 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: Id3228355c2883f9229cff3f878655736cc47204a
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2024-02-02 15:56:25 +00:00
Jarek Kobus
37dd482c3b CorePlugin: Replace QSharedPointer with std::shared_ptr 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: Id64f1033ed0a640bb3f02821b3b5f99c7fa3987d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
 2024-02-02 15:56:14 +00:00
Jarek Kobus
536046ebb2 McuSupport: Replace QSharedPointer with std::shared_ptr 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: I88a24afcca773e23d476466338543828337d65c2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
 2024-02-02 15:46:43 +00:00
Miikka Heikkinen
17f12979a6 QmlDesigner: Add extended View3D component library icons 
Fixes: QDS-11811
Change-Id: I0d33311e68b302a531d3e3273d10e6f4e3ff0932
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
 2024-02-02 14:56:22 +00:00
hjk
6f115faa05 CompilerExplorer: Remove unused class declaration 
Change-Id: Idbf95824e5d43eeff84f06c5b08e182d32bf7ef5
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
 2024-02-02 14:06:45 +00:00
Jarek Kobus
fc605d7a76 AutoTest: Replace QSharedPointer with std::shared_ptr 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Move TestParseResultPtr to the common place and don't repeat
this typedef.

Change-Id: Id8523b7898965ea9bfccb8a1bdc6a8ea23f090ed
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2024-02-02 14:05:18 +00:00
hjk
66f6b4c32e ProjectExplorer: Hide JsonWizardFactoryJsExtension in .cpp 
Change-Id: Ia540ce9f053b218e6986cc568cb287c98707d39d
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
 2024-02-02 13:42:38 +00:00
Brook Cronin
d83eeb0b8f Qml Designer: Add uniform cell size properties to layouts 
Change-Id: If2e0958c124cff259b1dbea57dd798711f0a0f1d
Reviewed-by: Pranta Ghosh Dastider <pranta.dastider@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
 2024-02-02 13:19:09 +00:00
Brook Cronin
916b78aa49 Qml Designer: fix start and end angle tooltips 
Change-Id: Ic854ae254512e5f1789d558bed02f7a020558ffd
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Pranta Ghosh Dastider <pranta.dastider@qt.io>
 2024-02-02 13:10:15 +00:00
Mahmoud Badri
6ff78b73ce EffectComposer: add zoom indicator 
Change-Id: Iaedd1ec9d6f7ee169a3b69fff4a33051786653bf
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
 2024-02-02 13:01:04 +00:00
Jarek Kobus
534c1c94b6 SdkManagerOutputParser: Limit code repetition 
Introduce function template helper.

Change-Id: If29452ce3dc09ee1e63ac3b889341f573ae5af63
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
 2024-02-02 12:46:14 +00:00
Mahmoud Badri
85f32353a9 EffectComposer: Fix pan/zoom not working after adding a node 
Also increase max zoom level to 3 instead of 2

Change-Id: Ia642bc65c0f902a0aff8fd81fc6f623981f2b249
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
 2024-02-02 12:26:42 +00:00
Miikka Heikkinen
f985b1b091 EffectComposer: Allow 'define' properties to specify control type 
Control type is used to determine the control presented for the property
in UI. Currently only int and bool control types are supported.

Also fixed the issue that changing define wouldn't update preview.
This was because changing define requires rebaking shaders, which is
not normally triggered on property change.

Fixes: QDS-11770
Change-Id: I953d827195565f765df1a09550c4a49da9c93c29
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
 2024-02-02 12:15:18 +00:00
Leena Miettinen
d35e567c92 Doc: Edit docs about navigating in Edit mode 
List code editing services in the Edit Mode topic.
Will remove the Writing Code topic when the reorg for
this part is ready.

Move info about locating files to the "Move between files"
topic.

Change-Id: I6c97d2778b74bba106a9d8e8b89376d5961e0a27
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
 2024-02-02 12:10:18 +00:00
Eike Ziller
d93e95c942 iOS: Fix missing include 
Breaks the build with Qt 6.7

Change-Id: Ie3e940a26cbd982f7781cfe478b59fc44785efe2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
 2024-02-02 12:04:19 +00:00
Mahmoud Badri
7efab2c07e EffectComposer: Remove warnings and unused code from the model 
Change-Id: I8171467e70d8d716b0598b0b533f216e5e0afc25
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
 2024-02-02 11:52:30 +00:00
Jarek Kobus
72bcc0f260 ProjectExplorer: Replace QSharedPointer with std::shared_ptr 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: I3d76cf04f8b501417687f8111c88f4a1af451608
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2024-02-02 11:14:15 +00:00
Jarek Kobus
a2b3d4d302 ClangTools: Replace QSharedPointer with std::shared_ptr 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: I359429d01bce9b28f9d284833f5be1828d3a880e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
 2024-02-02 11:14:06 +00:00
Mahmoud Badri
aaf1e193a7 EffectComposer: implement interactive preview 
Add panning and pivotted zoom

Fixes: QDS-11718
Change-Id: I516474a2ae700b8d1d486e0be96df27b3308e79d
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
 2024-02-02 11:12:01 +00:00
hjk
223767a94a CppEditor: Hide most of LineForNewIncludeDirective implementation 
Change-Id: Ic70d28beb057359fcd028aca2ab49ecb66dd990d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
 2024-02-02 10:36:05 +00:00
Jarek Kobus
e2e0a9a718 SdkManagerOutputParser: Hide subclasses for package parsers 
Change-Id: I05543aeb8b5f039cad349dad6fc3af557e487dfc
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2024-02-02 10:05:33 +00:00
hjk
5bddae2b62 Squish: Use MenuBuilder 
Change-Id: Ic17f5d0a39c1329b87f678c080e3010ff77672e0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2024-02-02 09:55:22 +00:00
hjk
4d00dc5ef6 Squish: Dissolve plugin pimpl 
Change-Id: I8e291e91c5d8c94274f39db40a625a796d8ad9b7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2024-02-02 09:55:01 +00:00
hjk
2667def8d2 Squish: Use setup function for remaining plugin pimpl items 
Change-Id: I5d74b0b0c4b25d580566a1d8687279990d3e9675
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
 2024-02-02 09:54:51 +00:00
Brook Cronin
6c7af1b41b Qml Designer: Add start and end angle properties to dial 
Change-Id: I15621fef552816a018aa5adf285ad9a1261a9294
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
 2024-02-02 09:11:29 +00:00
Leena Miettinen
24797179a7 Doc: Remove "Managing Projects" 
This topic is not used anymore.

Task-number: QTCREATORBUG-29361
Change-Id: Ia4d54a77fb3aac2e98fc00d697b045aee798b1ae
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2024-02-02 08:19:29 +00:00
Eike Ziller
02ee8b183e Fix some compiler warnings 
Unused lambda captures, unused private field, missing override.

Change-Id: I8b1d9d40af87fdfbd449841e9f112aad4682d8c5
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
 2024-02-02 08:18:03 +00:00
Eike Ziller
acf7d30cbd iOS 17: Print messages for starting and stopping 
In the application output, like we do when running elsewhere.

Change-Id: I842701162df20403e2b9757bc78bdd61176d581d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
 2024-02-02 08:16:55 +00:00
Eike Ziller
a7a06d6f79 iOS: Move launch result from devicectl to a function 
And add a test to document what we expect from devicectl.

Change-Id: I1a7f03c50393b99eddb2bfd34b5857e15b28d0a7
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
 2024-02-02 08:13:27 +00:00
Eike Ziller
e32d3da321 iOS: Move process id gathering from devicectl to a function 
And add a test to document what we expect from devicectl.

Change-Id: Ic69af99a472976a6c06801a646af59f8139d5624
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
 2024-02-02 08:13:15 +00:00
Jarek Kobus
a1039de35e DeviceProcessSignalOperation: Replace QSharedPointer with std::shared_ptr 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: I606a490be4d6ba2611288cced82ba8c72d146eec
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
 2024-02-02 08:03:15 +00:00