Commit Graph

88532 Commits

Author SHA1 Message Date
Jarek Kobus
1ad61f8da3 Axivion: Extract fetching table into the reusable recipe
Get rid of public fetchIssueTableLayout() method.
Introduce tableInfoRecipe() which takes a handler as an arg.
This decouples the plugin from AxivionOutputPane's API.

Change-Id: Iae3ce83e132e0769b45ed3db911bd1046cc7bcb8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-29 07:35:09 +00:00
Jarek Kobus
5c1ee4021a Axivion: Extract fetching issues into the reusable recipe
Get rid of public fetchIssues() method.
Introduce issueTableRecipe() which takes a handler as an arg.
This decouples the plugin from AxivionOutputPane's API.

Change-Id: I4a4e2fd14dfd4eed2d28648a227a1ed3a5fe90f3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-29 07:35:02 +00:00
Jarek Kobus
2759266e84 Axivion: Make IssuesWidget occupy more space
Change-Id: I65397b4c0ff280c3bfe436d8aa2f42dc86fb301e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-29 07:25:52 +00:00
hjk
675e8a4757 TextEditor: Use new setup pattern for PlainTextEditorFactory
Change-Id: Iad3b8574a51db3baf6db74353e58968a2f6a4315
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-29 06:41:41 +00:00
hjk
d81fb53b74 TextEditor: Use new setup pattern for TextEditorSettings class
Change-Id: I8980f21a3ea156d45ab68bad66b94fbc5bbad641
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-29 06:40:10 +00:00
Christian Stenger
c734012298 Axivion: Implement basic fetch more functionality
Scrolling to the bottom of the displayed issues should now
try to fetch more issues.

Change-Id: Ic01cdcb7e96d2d0be2f51096a70fbb2299a6722d
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-29 06:21:12 +00:00
Tim Jenssen
b3b6794dc8 qmlpuppet: fix missing return
Change-Id: Ib92ab8e5b2787db125a317e6eae38e2602777fa4
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2024-01-26 16:35:08 +00:00
hjk
0d4b3b5196 Utils: Add a FilePath::isResourceFile function
Change-Id: I281e91bc24f5c32a5d64c31e73b7fc2f31cbade2
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-26 16:07:38 +00:00
hjk
bb7a50e16e Utils: Promote a local conversion function to FilePath::fromUrl()
Change-Id: I748cceb50084a29b971f31a8bd2ad7159738d7fd
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-26 16:07:31 +00:00
Alessandro Portale
f1787812e3 Core: Introduce WelcomePageHelpers::drawCardBackground
Pulled out of the ExtensionManager. It will also be used by
the Welcomescreen pages.

Change-Id: Ic5c67759e7f3af6a3b51968b7ae072c7058109b3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-26 15:21:14 +00:00
Mahmoud Badri
555552e10e EffectComposer: Fix clearing effect name upon starting a new project
Fixes: QDS-11780
Change-Id: I89a1d39a3dab18992b5fa8fae3f1340d42becac1
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-26 14:25:28 +00:00
Eike Ziller
9fd732712e Projects mode: Fix invisible tool bar above build system output
Amends d2500dc77b

For some reason, even if the title widget returns a size hint of height
0, it is still painted, but doesn't even reserve space in the layout.
So, the title was painted over the tool bar that we add to the dock
widget for the build system output in projects mode (in the right side
bar).

Set the visibility of the title widget in addition.

Change-Id: Ia00d73baba22294a57d689118565dc0fe3ee5617
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-26 14:12:22 +00:00
Alessandro Portale
2c45a3ffe4 Theming: Update of color tokens
Token_Background_Hover is gone.
Token_Foreground_Default, Token_Foreground_Muted and
Token_Foreground_Subtle were added.

Existing token colors were changed.

Change-Id: I9505ee54dd02f78bd722c0dcfe42ee6ae4e48d13
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-01-26 14:08:00 +00:00
Eike Ziller
cdef799321 Remove RestartDialog in favor of static function
The pattern was always to create the dialog and exec it, which can be
done as well with just a function call.

Change-Id: I3934cf5d869211713902abd333aa64d87ec59f32
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 13:59:14 +00:00
hjk
fca5c4fe96 TextEditor: Move BookmarkFilter class definition to .cpp
Change-Id: I6da2710afde7af153353e184de72df2325dc4644
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-26 13:50:08 +00:00
hjk
994e83b839 TextEditor: Move some functions from the plugin pimpl to the plugin
Since the plugin class is in the .cpp now pimpling is not really
useful, this goes a step into the direction of removing it.

Change-Id: Ia55d60749372d868a94884337f0e0f52ec2cc1b5
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-26 13:50:00 +00:00
Mahmoud Badri
33bbab25b6 QmlDesigner: Rename effect maker plugin files to effect composer
Change-Id: I1d09c1088b4067a479f2e7cc396a348f1b48614f
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-26 13:36:18 +00:00
Eike Ziller
bc145f2d36 ActionBuilder: Add documentation to adopt
Change-Id: I875ebac532a463572c4723e6973fd87ff27f4fe2
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 13:31:01 +00:00
David Schulz
73c03faa2d LanguageClient: add LanguageClientManager to object pool
instead of the language client plugin and make sure the same
functionality is still reachable from the outside.

Change-Id: Idff8db221e03afb4100c2e4879b7dfeb3e14e59b
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 13:12:23 +00:00
hjk
6218520b63 iOS: Move build configuration factory definitions to .cpp
Change-Id: Ia4a52e61488900fca013a50185ae534faa8816eb
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-26 12:58:53 +00:00
Christian Kandeler
79e323afbf Update qbs submodule to HEAD of 2.2 branch
Change-Id: Ibe9fab31e5dedac362aa469c6d2cd058015a6020
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-26 12:50:19 +00:00
hjk
7f061c723a CppEditor: Move CppHeaderSource implementation and test to same files
... and remove the now-empty cppeditorplugin.h

Change-Id: Ia28b180c280ba7b10ce0f2826f2ac69d128a453c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-26 12:44:53 +00:00
Christian Stenger
e71d16ef90 Axivion: Minor clean up
Change-Id: If2ed91a7778e18e25edb3bc05b0017e14b05fc27
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-26 12:36:57 +00:00
Christian Stenger
08e21a3346 Axivion: Refactor link handling a bit
Do the costly part only when necessary.

Change-Id: I9b884ee3411476e16569f09921409b33229de5e9
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-26 12:36:48 +00:00
hjk
109ec1e443 CMake: Hide CMakeManager implementation in .cpp
Change-Id: Ia66d73cd060d17c2d25a1d5b89155ab4e7a6b62b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-26 12:31:05 +00:00
Eike Ziller
acedf93ba3 Remove CommandButton
The same can be achieve with a factory method in `Command`, similar to
the existing ones for actions and buttons which synchronize their tool
tips with the shortcut.

Change-Id: I7e17654706b902dfa14f37b958fc2a60705d5cb5
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 12:25:26 +00:00
hjk
34087df11e CppEditor: Move plugin class definition to .cpp
Also remove the globale instance variable which is not used anymore.

Change-Id: Ia054f79570b2fb650db31bd8560a08b0c9fe4c8c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-26 12:20:52 +00:00
hjk
9cc3988acd CppEditor: Remove some CppEditorPlugin member functions
Inline renameSymbolUnderCursor() and  switchDeclarationDefinition()
implementation on the caller side. Also use the widget that's known
there instead of the currentCppEditorWidget().

Change-Id: I158bef34234ce199accf25861062c97491bea381
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-26 12:16:52 +00:00
hjk
3c9238d29a CppEditor: Cleanup plugin header a bit
Change-Id: Ifff36ba362d8f9376936a46050e9a01f7b80a26c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-26 12:08:34 +00:00
hjk
4df8101d4b CppEditor: Reduce visible CppIncludeHierarchy interface
... and remove related helpers from the plugin class itself.

Change-Id: Ide4b0596d0822b0737b341fa2fb08965f11cb018
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-26 12:04:37 +00:00
Mahmoud Badri
5c7090c90e QmlDesigner: Rename Effect Maker to Effect Composer
Only in the UI. No code renamings for now.

Fixes: QDS-11781
Change-Id: I257c649750ae30cbf4981073be2e6bfc9c92b4df
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-26 11:48:12 +00:00
Marcus Tillmanns
debee7cdf1 Utils: Add iterator check
Change-Id: I761f6e1871c092e35878f07a7c416c4e47781980
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-26 11:33:10 +00:00
Eike Ziller
a0716261a8 ModelEditor: Use namespace Core
Less noise

Change-Id: I3b1d42f1d269b7659be0a73ca5cec6bd5a835702
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 11:32:19 +00:00
Eike Ziller
4900ce90e3 Core: Remove CommandAction class
In favor to a method in the Command class that creates an action,
similar to how there are the methods augmentActionWithShortcutToolTip
and toolButtonWithAppendedShortcut already.

Change-Id: Id5f778bd01babb556cd9d3ed7ef0bb68d78887bd
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 11:32:11 +00:00
Eike Ziller
f22fa5275e Use ActionBuilder for Markdown editor
Also add method that sets the ParameterAction for the context action.
That is an alternative to "binding" the context action, and is useful in this
case, since we do not have a QObject that we can use as a parent for the
constructor that creates the ParameterAction from scratch.

Change-Id: I6ba05208d33460cfa2df9ce8247f7ca30624c22f
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 11:31:57 +00:00
David Schulz
d9404208da ProjectExplorer: declare only relevant aspects as features
This will disable python kits for all Wizards that require a valid Qt.

Change-Id: I4a8d6dd60629ddb556e49c067200acba8ef080d2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-26 11:27:32 +00:00
Jarek Kobus
bd81ef4127 SynchronizedValue: Limit code repetition
Change-Id: I7d76d80db3d7345ba989c9346030b07be9754b3f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-26 10:57:46 +00:00
hjk
17463757ce ResourceEditor: Remove some indirection
Change-Id: I930e7e35401e6c6d8b3e1245e6a7c663f131d345
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-26 10:45:14 +00:00
Marcus Tillmanns
dbee11f5b4 Environment: Fix incorrect usage of appendOrSet
appendOrSet will append to existing environment variables which is not
what we want for all the changed locations in this commit.

Change-Id: Icf6b110acc59261659839375672943ec21923da1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 10:33:34 +00:00
Eike Ziller
b8c9d79b9f Remove focus rect from some input fields on macOS
The focus rect on macOS needs some space around the widget itself,
otherwise it looks wrong. We already removed the focus rect for various
input fields like locator and search (cmd+f), also remove it from filter
input fields for the various output panes.

Change-Id: I048453c06264c51ec28b5a0c9368fad7c01dc5a7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-26 10:31:07 +00:00
Leena Miettinen
f8f82f259a Doc: Split up Using FakeVim into how-to and reference topics
- Move contents around
- Remove obsolete information about color scheme
- Fix keyboard shortcut for toggling FakeVim mode

Task-number: QTCREATORBUG-29361
Change-Id: Icb1c76e014b34d582e40d597bb1279df53e2c02b
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 10:13:54 +00:00
Marcus Tillmanns
a25bbf23c6 Utils: Fix error prone default value of appendOrSet
It was not readily clear that Environment::appendOrSet/prependOrSet
needed a value for "sep", otherwise it would just concat the values without separator. This got apparent when looking at usages of
appendOrSet.

Instead there are now three options, "Auto", "Colon" or "Semicolon"
with the default being "Auto", which determines the separator based on
the Environment::OsType.

Usages of appendOrSet and prependOrSet are also fixed with this commit.

Change-Id: I868e14ce38f50be9cd07292fe3f22663a62d116d
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 10:10:03 +00:00
Marcus Tillmanns
56f42c319e Terminal: Fix env separator
Change-Id: I738ff27d37df95170bbdc9f55fbaf6430ebb5a40
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-26 09:36:33 +00:00
Christian Kandeler
946efb14b1 QbsProjectManager: Move progress bar future to QbsProjectParser
It was very odd that it was held alongside the parser in a different
class.

Change-Id: I187b2260e079f0bf88bfc73447b7dec7f6497dca
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-26 09:32:45 +00:00
hjk
167cd3378d Qbs: Use Store instead of QVariantMap in a few places
Change-Id: I0636fad4ca032ec6657f2e35154c2e0ea4d0c9ca
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-26 09:20:33 +00:00
Artem Sokolovskii
e1f7469afb ClangFormat: Replace checks widget with editor
The existing approach utilizing the widget poses maintenance
challenges, primarily due to the dynamic nature of clang-format
settings across versions. The widget necessitates regeneration
for each new version, and compatibility issues arise when users
have different clang-format versions on their devices.

The updated solution adopts an Editor integrated with a yaml
language server, offering the ability to highlight and provide
code completion for the .clang-format file. This resolves the
widget regeneration issue and ensures compatibility with various
clang-format versions.

- Replaced the checks widget with an editor
- Introduced a line for yaml language server schema
in .clang-format files to enable autocompletion.
ToDo: Enhance schema accessibility without relying on this line.
- Added Ctrl+Space shortcut for autocompletion
- Added Ctrl+S shortcut for saving
- Eliminated outdated logic related to the checks widget
- Fixed copying and removal of clang-format settings

Change-Id: I2e3fbf19abe2f4df031f6ba5faffd47e07274346
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-26 09:19:25 +00:00
hjk
78a909390c RemoteLinux: Use more restrictive #include in linuxprocessinterface.h
Change-Id: Ib234ed21762b27064b7f062bd43f25bce8264d37
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-26 09:18:10 +00:00
hjk
841081d517 Utils: Remove odd QTreeView declaration from environmentfwd.h
... and use one when it is really needed.

Change-Id: I583fb775e5d625833816ac380ea74bf24b67d8e7
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-26 09:07:32 +00:00
Jarek Kobus
5ae37f2f84 ImageScaling: Reuse LoopList
Instead of LoopRepeat + container capture.

Change-Id: Ic37c4ff53c4ce2a217a258aa4af1272ac3d8ab29
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 07:51:27 +00:00
Jarek Kobus
e1f0da4e20 ClangToolRunner: Reuse LoopList
Instead of LoopRepeat + container capture.

Change-Id: I5bce612279cf63f6ad1237569b55baad9a98e2ce
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 07:51:22 +00:00