Commit Graph

88532 Commits

Author SHA1 Message Date
Jarek Kobus
507933467f AutoTest: Reuse LoopList
Instead of LoopRepeat + container capture.

Change-Id: Icb243d7ac902eed95503d7d1a5ac007f4f6c705d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 07:51:16 +00:00
Jarek Kobus
e826e3ad7e TaskTree: Use QMutex consistently
There is no noticeable difference between using QMutex vs std::mutex
in release build.

It looks like std::mutex is about 15% faster than QMutex in debug
build, but that's not relevant.

Get rid of #include <atomic>.

Change-Id: Iae67d5028c5ae3cb412e50d629bfc09b38417dfc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 07:51:05 +00:00
Christian Stenger
7c246f025c Axivion: Start handling total row counts
Include them only for the first fetch of an issue kind to
avoid costly additional access.

Change-Id: Icebbea5635b1f1d266238f99c43426dc22fb19b9
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-26 07:48:56 +00:00
Christian Stenger
eec7339af3 Axivion: Make issues clickable
For now just a simple approach of using the base directory
using the given path and line information.
Depending on the issue kind there might be multiple locations
but for now only handle one of them.

Change-Id: I046b7c42593aa4c30b843fa8f9145fae35e869d4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-26 07:46:45 +00:00
Christian Stenger
42c7f54c68 Core: Fix include
Amends 2796e69ab5.

Change-Id: I472ebca5de8c6e8b16133264b6b867a8abd10825
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-26 07:21:47 +00:00
Christian Stenger
921bb9c977 Axivion: Minor ui improvements
..for the issues view.
 * use display names if posssible
 * fill versions and owners
 * use progress indicator
 * extract more data from issues

Change-Id: I91197ce375b8d58a4a09a7a5a9ad005e012c4549
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-26 05:24:54 +00:00
David Schulz
6d715f15d8 TextEditor: Add case sensitivity checks in optimization
17e2a80e10 added some optimization for
prefix and infix matches of completion items in order to avoid the
expensive regular expression check for the fuzzy match, but ignored the
user configured case sensitivity for auto completions.

Change-Id: Ic340e48abc6636bd2e8abeeddcd880cbdc66d03e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-26 04:59:28 +00:00
Dominik Holland
681f039d79 AppMan: Fix dependencies of RunWorkers during QML Profiling
Change-Id: Id8a43d31369ae4cf150458dcab4693bf967decec
Reviewed-by: hjk <hjk@qt.io>
2024-01-25 16:47:15 +00:00
Cristian Adam
a8370aaf81 CMakePM: Allow adding files to OBJECT libraries
Amends 7a46bbe667 which only used
`cmakeTarget->productType() != ProductType::Other` which excludes OBJECT
libraries.

Now the fix actually includes all targets which are not UtilityType,
which was the intention of 7a46bbe667

Fixes: QTCREATORBUG-29914
Change-Id: If661828e43d5c566c876546f5527c0b670405e47
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-25 16:41:31 +00:00
Dominik Holland
e0088357d0 AppMan: Various small fixes
* Always use the correct symbol when debugging
* Fix the TargetInformation::isValid() function
* Optimize RunConfigurationFactory::supportsBuildKey()

Change-Id: I5f007d5c216ff9808adf9f8b878c9cbc9f47e3eb
Reviewed-by: hjk <hjk@qt.io>
2024-01-25 14:48:46 +00:00
Miikka Heikkinen
cebe5cecd7 EffectMaker: Add comment for _isEffectItem property
Fixes: QDS-11767
Change-Id: Id987af6bd13cd481c8dbe25cdf7090e5cbeb7db7
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-01-25 13:42:46 +00:00
Jarek Kobus
53de44444e Get rid of EXPLICIT_MOC
Otherwise it generates the following:

Generating moc_pluginmanager_p.cpp
[...]/pluginmanager_p.h: note: No relevant classes found.
No output generated.

The same for:
moc_cppquickfixprojectsettingswidget.cpp / cppquickfixprojectsettingswidget.h
moc_imageviewer.cpp / imageviewer.h
moc_vcpkg_test.cpp / vcpkg_test.h
moc_clangformat-test.cpp / clangformat-test.h

during compilation.

Change-Id: I65ea5a7caeb0607972c09de1de66337cb7df59b8
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-01-25 12:33:15 +00:00
Jarek Kobus
3932cdf8d4 GenericLinuxDeviceTester: Reuse LoopList
Instead of LoopRepeat + container capture.

Change-Id: Ie021c618808dad3ac3e0ba5993009074aa9a8313
Reviewed-by: hjk <hjk@qt.io>
2024-01-25 12:32:59 +00:00
Jarek Kobus
84315d5988 TaskTree: Introduce LoopList
A wrapper around container with convenient
"const T *operator->() const" and "const T &operator*() const" methods.
They mimic the const_iterator API.
Simplifies the usages, as it enough not to capture just
LoopList element inside task handlers without a container itself.

For now it handles just QList container.
To be generalized later.

Change-Id: I10ea3903985cf51529ec5909ac7c19c524de7c68
Reviewed-by: hjk <hjk@qt.io>
2024-01-25 12:32:50 +00:00
Jarek Kobus
e828ef1c13 GenericLinuxDeviceTester: Simplify the main recipe
It's now easily possible to mix GroupItems with the lists of
GroupItems on a common list.

Change-Id: I32b4061e45302e8532d39f84c4e6eb8c9e719faf
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-25 12:32:41 +00:00
Jarek Kobus
d9a71c1351 GenericLinuxDeviceTester: Reuse LoopRepeat element
Instead of creating quite huge recipe.

Change-Id: I8b4121d0a666f093885d1379f6f4c8093cd2619c
Reviewed-by: hjk <hjk@qt.io>
2024-01-25 12:32:31 +00:00
Miikka Heikkinen
6fb7f464ac QmlDesigner: Remove deleted effect usages from current document
If there are any imports or nodes of the deleted effects in use in the
current document, also remove those when deleting effects.

Fixes: QDS-11723
Change-Id: I87972b5fc38b35acb0fb71fd085d2a3fcf691318
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2024-01-25 12:29:04 +00:00
Marcus Tillmanns
273656c927 Terminal: Fix fish shell integration
Change-Id: Ib9156be851d092db2a28641a292ae32e76314bec
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-01-25 12:15:27 +00:00
Miikka Heikkinen
5db5ade17d EffectMaker: Round the integer slider value properly
Fixes: QDS-11772
Change-Id: I4d79c28784213695ea8e9a220f6fbd878bfb0cd4
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-01-25 11:54:47 +00:00
Marcus Tillmanns
6d672f7efa Aspects: Add TypedAspect<T>::valueType
Change-Id: I6da6d089d23df154c02994cc5d892b746a346b23
Reviewed-by: hjk <hjk@qt.io>
2024-01-25 11:23:07 +00:00
Marcus Tillmanns
bf1c332daf Aspects: Add missing default value to TextDisplay
Change-Id: I58432e1aac9b19bf49dc919ded90bee4fb4cb2cc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-25 11:22:18 +00:00
Xavier BESSON
2796e69ab5 Add display search results using relative paths to project root
Task-number: QTCREATORBUG-29462
Change-Id: Ic5d597846cfcc6589cbf1b81151e05c95ee8fab0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-25 10:46:43 +00:00
Jarek Kobus
905eaf8b1e TaskTree: Adapt docs to the stop() -> cancel() rename
Amends 983fc4bcf6

Change-Id: Id8406f5c8713d7cfb387f89bfb16d653e639ffb6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2024-01-25 10:23:30 +00:00
Cristian Adam
0197a2780a CMakePM: Do not force Xcode generator for iOS
"Xcode" will be set as default generator for iOS kits, but if the user
imports a iOS build from command line we shouldn't reset that generator
to "Xcode".

Amends b47a80c5ce

Fixes: QTCREATORBUG-30214
Change-Id: Idbdadcf24e87b861adf377975788e0146f7731cb
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-25 10:15:55 +00:00
Mahmoud Badri
621d7044b4 EffectMaker: Fix top bar width
Regression caused by cfe3828c53

Change-Id: I573da870c61ec0c5f3ba056ffd759acefd8c9389
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-25 09:54:10 +00:00
Mahmoud Badri
398676a360 EffectMaker: Make image value width fits the view width
Fixes: QDS-11752
Change-Id: Ia47c5076c32824628e700554a06803f50b82cd08
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-25 09:44:13 +00:00
Christian Kandeler
aa53543fa3 QmakeProjectManager: Remove more unused code
Amends fd1956a91c.

Change-Id: If6a3b2369a94caba2724bea0b3fe8e214cd87f61
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-25 09:36:02 +00:00
Dominik Holland
1deb31f295 AppMan: Use FilePathAspect::setDefaultPathValue(FilePath)
Change-Id: Ia8025bc707fd1d87b4066fcee98b8566f13726d6
Reviewed-by: hjk <hjk@qt.io>
2024-01-25 09:33:05 +00:00
Dominik Holland
07d347a0c3 RemoteLinux: Allow the deploy steps to be used in all deploy configurations
Instead of limiting them to a specific deployment configuration, they
are now limited to the RemoteLinux device.

Change-Id: I4a8eebd055985b63815ac6fbb3b9e04c297bd1ab
Reviewed-by: hjk <hjk@qt.io>
2024-01-25 09:32:57 +00:00
Jarek Kobus
983fc4bcf6 TaskTree: Rename stop() -> cancel()
This better corresponds to done handlers called
in this case with DoneWith::Cancel.

By the way, get rid of unused LocatorFilter::stop().

Change-Id: Ie4246b8d888fff95940a2ed41367d2817bd6339c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-25 09:26:12 +00:00
Mahmoud Badri
cfe3828c53 EffectMaker: Allow resizing effect preview area
Fixes: QDS-11724
Change-Id: I23081ab5a484cdb4a748e55231db2d20b0f9437c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-25 09:13:33 +00:00
Ali Kianian
715f0c544e QmlDesigner: Initialize column data type in the header edit dialog
Fixes: QDS-11757
Change-Id: I746516281857f3080fc7f5d6010582d42539bdb2
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-01-25 09:13:11 +00:00
Mahmoud Badri
b4eefcb64f EffectMaker: Fix preventing clicking outside bool checkbox
Fixes: QDS-11485
Change-Id: I122c45b665c5d086a863d0907878ca9be8189112
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-25 09:07:04 +00:00
Jarek Kobus
a525949a2c Axivion: Simplify onDone handler
The fix went with 6116605c4c.

Change-Id: I0e9cfe6ee3d55517af71379474a66b8106ca0cb3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-25 08:58:53 +00:00
Jarek Kobus
acf42bf90d Utils: Add synchronizedvalue.h into cmake and qbs
Amends 35a2d598ab

Change-Id: I64d76896c8bfbe4b48e2593118b209e3ae187a87
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-25 08:52:05 +00:00
Marcus Tillmanns
87999abead Terminal: Linkify git commits
Allows the user to Ctrl(Cmd)+Click "version like" text (e.g. text that
only contains 0-9 and a-f) and starts a "vcsDescribe" if a version control
can be found for the current directory.

Fixes: QTCREATORBUG-29213
Change-Id: I462092b58bf595a6968f4765f83a207506f0cf87
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-25 05:43:17 +00:00
Fabian Vogt
0e4af4b880 Register AutotoolsProject as handler for Makefiles again
95a3087a7b dropped the mime type registration by accident. Add it back to
make the plugin functional again.

Signed-off-by: Fabian Vogt <fvogt@suse.de>
Change-Id: I783429ce7883bad8b946ed1599098751d56cabad
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2024-01-24 20:55:19 +00:00
hjk
ee4d258776 CppEditor: Reduce visible CppTypeHierarchy interface
... and remove related helpers from the plugin class itself.

Change-Id: Ibc6af7518a2c90da93e619dde05edbd1eb7948f0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-24 16:48:08 +00:00
hjk
8b86fe239b ClangcodeModel: Move test creation closer to tested code
Change-Id: Ifb6771673aa8639d2ee23d1f34b1ff821000e348
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-24 16:38:09 +00:00
Christian Kandeler
4dba2a2f87 ClangTools: Add "edit as string" feature also for clazy
Fixes: QTCREATORBUG-24846
Change-Id: Id9931c0539ff1e03ab9cac7fb9b76f9694250536
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-24 16:20:13 +00:00
Christian Kandeler
1cc1d98601 CppEditor: Fix completion tests
Amends 2c91d4b472.

Change-Id: I6c4e8bc359acd2cd413fe86c1217ccce5321fa1e
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2024-01-24 16:16:10 +00:00
Dominik Holland
32d31b6eea AppMan: Add support for B2Qt devices
Change-Id: Icb18968b41a093a1330021b720252962aceb0bc6
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-24 16:05:54 +00:00
Dominik Holland
ee54315791 Boot2Qt: Allow the deploy steps to be used in all deploy configurations
Instead of limiting them to a specific deployment configuration, they
are now limited to the B2Qt device.

Change-Id: Ic27d3e4fc50cea0a838223eb41e0e422d7b17b82
Reviewed-by: hjk <hjk@qt.io>
2024-01-24 16:05:37 +00:00
Dominik Holland
57445ff12d AppMan: Remove the "Remote Package installation" step
Instead of having a local and a remote step, we can use a single step
for both cases. The code of the remote step is now used also locally.

Change-Id: I08d3b07761b77b3618f3db001a0d83d1eea65421
Reviewed-by: hjk <hjk@qt.io>
2024-01-24 16:05:26 +00:00
Dominik Holland
707886faac AppMan: Use device specific tool paths
This makes sure the RunConfiguration is correctly executed on the remote
device.
For steps executed on the host, a nullptr can be passed as device.

Change-Id: Ide5aa5a06402b137494c10108d09a4e7ffa32ec9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-24 16:04:53 +00:00
Jarek Kobus
fdb0ba0389 CppProjectUpdater: Simplify done handler
Call it only on success.

Change-Id: I8a9bea3768c1bd1d1f68ec852519b6e6dda1a2e9
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-24 15:39:21 +00:00
Cristian Adam
c05ad8b446 CMakePM: Fix bad "path" backtrace generation
CMake can generate backgraces with absolute paths, and the commit
246f33c20d removed this support from Qt
Creator.

This commit fixes this issue with absolute paths.

Fixes: QTCREATORBUG-29914
Change-Id: Ib911e80aee1ff9f4a26435f7e693f7766551cc90
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-24 15:02:49 +00:00
Marcus Tillmanns
0414c4b67e QmlJS: Fix deadlock when scanning apps
Change-Id: I7f8133eb634876b988675ed3b3cbebe596870a06
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
2024-01-24 15:01:17 +00:00
Jarek Kobus
428898e6ba Axivion: Load projectInfo with taken from DashboardInfo
Task tree variant.

Change-Id: Ie42573f78caa180ad9669e63bab8a6b920515927
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-24 13:41:42 +00:00
hjk
2beaba4627 Android: Use more direct access to current config singleton
Change-Id: Ica5ba556ac022fe39ed4439d023cda1742344eed
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-24 13:41:13 +00:00