Commit Graph

89631 Commits

Author SHA1 Message Date
Christian Stenger
cf7a03ef0d SquishTests: Adapt expectation
There is now an additional whitespace at the end of
the commit due to different formatting.

Change-Id: Ic3046fde626c8dcda3f902813c5474704af09c09
Reviewed-by: Jukka Nokso <jukka.nokso@qt.io>
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
2024-08-19 14:56:52 +00:00
Christian Stenger
ca1c7d11e6 SquishTests: Adapt to changed language display
Change-Id: Iff286316a26807e383073980de7ca58186a7de2e
Reviewed-by: Jukka Nokso <jukka.nokso@qt.io>
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
2024-08-19 14:37:01 +00:00
Christian Kandeler
5e3da690e2 CppEditor: Add syntax highlighting for C++ attributes
Fixes: QTCREATORBUG-31241
Change-Id: I7583c3cd08c2ec58ca7702e7758aad6c0e142574
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-08-19 13:15:42 +00:00
Marcus Tillmanns
42925652f1 Utils: Fix crash in tests without QCoreApplication
Change-Id: Iefe451d75668a68ce86a5c4b80f738acd5d6e8e4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-08-19 12:30:51 +00:00
hjk
f170552244 BinEditor: Use LayoutBuilder for toolbar
Change-Id: Ibdddde7be1df94112013f59561955e54ec45052d
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-08-19 11:33:11 +00:00
Christian Kandeler
3a2bcefca0 Android: Use toolchain bundles for setting up the kits
Change-Id: I46f436cc9ccdb84543abf7bf78a93ed6fe27561c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-08-19 10:40:46 +00:00
Marcus Tillmanns
d4f0da4c35 LuaLS: Improve error reporting
Changes LSP.Client:documentVersion() and LSP.Client:hostPathToServerUri()
to return ok and error message in case of errors.

Also fixes the binding to take a self parameter so it fits to the function
documentation.

Change-Id: I605b7bacba2822c3efd5291d1f7bacf1ecb863d5
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-08-19 08:13:17 +00:00
Orgad Shaneh
318e1ccc09 Zip: Suppress MSVC warnings
For Example:
3rdparty\zlib\src\gzlib.c(235): warning C4996: 'open': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _open. See online help for details.

Change-Id: Ifd89210cf782e9bbdbe5253e7dcef613e29e5f1f
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-08-19 05:17:27 +00:00
Christian Stenger
fb09f85622 SquishTests: Adapt to changed template name
Change-Id: I5f50019df33cb83f7f8618e1e390daf08b368143
Reviewed-by: Jukka Nokso <jukka.nokso@qt.io>
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
2024-08-16 22:15:39 +00:00
Christian Stenger
270a0026ae SquishTests: Adapt to changed ui
C and C++ compiler are now treated as related and are used
as bundled unit.

Change-Id: I3d2539067eb9245d734c6b98c46e8e479fdef965
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
2024-08-16 21:34:38 +00:00
Jarek Kobus
ed577701dd Android: Make ports const and hide them in cpp
Change-Id: I9ab41e9fea2e80a8ff78000687f700ed079440b7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-08-16 09:42:49 +00:00
Jarek Kobus
b02a708a5f Android: Fix removeForwardPortRecipe
Amends 0067d5a445

Change-Id: I6fb4cd58c3a430979133987ccb2f5c2e39efd53d
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-08-16 09:42:37 +00:00
Artem Sokolovskii
343e206b48 Syntaxhighlighter: Fix folding for function definition
The issue was: when the user removes the function definition and
insert it back folding isn't changed.
Now it triggers rehighlighting of the next line.

Change-Id: I5dcc67ed2e09a20d54e3a38c9605a4a24ad79177
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-08-16 08:55:51 +00:00
Marcus Tillmanns
4ec324af0b LanguageClient: Add option to hide settings
Change-Id: Iefc9398bdc4ffcf498eb66a702994e9e143beb74
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-08-15 12:54:03 +00:00
Alessandro Portale
1547396848 QDS wizards: Use current import version for DirectoryFontLoader
Change-Id: I792cc4882b60e3e2049aebafe0822b545bbbe0c7
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
2024-08-14 17:42:21 +00:00
Lukasz Papierkowski
6b8b151ee6 AI Assistant: Update description
Change-Id: I6bca5ea7be30d21660dd8c85cbda7363674e4a20
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-08-14 07:57:24 +00:00
Lukasz Papierkowski
805c3c315c AI Assistant: aiassistantserver installation based on platform (linux)
Change-Id: Ifbebac39d453c0e162c62d1b0aa9754d6e57f106
Reviewed-by: <mua@spyro-soft.com>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-08-14 07:04:06 +00:00
Christian Stenger
39512cd2b2 Axivion: Make some function members static
Change-Id: Id47c7188ff4a79aca3078756a65bcf14b3ec10bc
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-08-13 07:52:39 +00:00
Andre Hartmann
a76a4036f7 Git: Fix topic while pushing to newer Gerrit servers
The Syntax "%topic=foo" was already introduced in
Gerrit 2.6, but until recently Gerrit supported
the old "refs/for/master/topic" syntax.

This support was dropped at some time, I was not
able to find when exactly.

[1] http://gerrit-documentation.storage.googleapis.com/ReleaseNotes/
ReleaseNotes-2.6.html

Fixes: QTCREATORBUG-31411
Change-Id: I96674abf4ce946f1064a5f01173f4ea81f5317f3
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-08-12 16:07:21 +00:00
Lukasz Papierkowski
78e7059442 LUA: Lock CyclicSuggestion when writing over an aligned suggestion
Change-Id: I8081af587a77b28254fe9bb38f811caaf060e10f
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-08-12 08:10:38 +00:00
Jarek Kobus
56ffedc547 TaskTree: Change the return type of waitForBarrierTask
In this way it's possible to attach the executable item's additions,
like withTimeout() or withLog().

Change-Id: Iff668627413a0d1e6499374cf74a545b2f166d62
Reviewed-by: hjk <hjk@qt.io>
2024-08-09 16:37:07 +00:00
Christian Stenger
86b179143d Axivion: Prepare filtering of columns
This adds a filter icon on the column header if the column
is marked as filterable.
Beside this the header view now only adjusts the width when
necessary.

Change-Id: Ib25bc7ba64689209b113cd5a7b4d4e8a615b3282
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-08-09 13:45:39 +00:00
Christian Stenger
56f143eb82 Axivion: Implement multi sort for issues table
The issue table can be sorted by multiple columns. The
sorting itself happens on the server side, so it is
only necessary to reflect the sort state and adapt the
search according to the sort columns.
Sorting may now happen the following way:
  * click sort ascending or descending marker to set
    the column as sort column or remove the marker
    if it is set
  * hold Shift while click appends the column to the
    current sort columns with the respective sort
    order or removes it from the list if this marker
    was set already

Change-Id: I180f14bc6b4785d13a6fd4669830dc323c0c32a7
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-08-09 13:45:23 +00:00
Christian Stenger
fd94f03c3d Axivion: Consolidate column information
Splitting the column information across multiple lists
was not smart as it complicates the handling and the
planned extension.
No change in functionality intended yet.

Change-Id: I968edf28a6a279a14dbe223bf21e007b3e42f843
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-08-09 13:42:31 +00:00
Eike Ziller
281f9c28d6 Merge remote-tracking branch 'origin/14.0'
Conflicts:
	cmake/QtCreatorIDEBranding.cmake
	qbs/modules/qtc/qtc.qbs

Change-Id: I00c2cdccf7f2fa9203d1018e90511133b2e08310
2024-08-09 15:11:49 +02:00
hjk
cbe503a904 BinEditor: Don't register editor factory in global object pool
Only the service factory is needed.

Change-Id: I40840d6948075f8656eb0cf7113fcc6b95b8f037
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-08-09 11:49:12 +00:00
hjk
6ef00a1fd6 Core: Move the only data member of ICore to ICorePrivate
Also change the caller side of the setter cosmetically.

Change-Id: I1422d90c3ede016ff872d23ad2291ae5b2b02264
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-08-09 11:31:25 +00:00
hjk
e1c66ead66 BinEditor: Remove bineditorconstants.h
Not needed for the single remaining entry.

Change-Id: I521f3284c4ca77d08cc61cdc4e7577c416e7285b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-08-09 11:30:47 +00:00
Christian Kandeler
407b8c08f3 ProjectExplorer: Give GCC a higher priority than clang on Linux
... for purposes of kit auto-detection. This likely matches user
expectations.

Fixes: QTCREATORBUG-29913
Change-Id: I0319216d0692200190ca5e2bc3b46b0c3bcf7362
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-08-09 11:28:23 +00:00
hjk
596af52731 BinEditor: Move action setup from factory to editor
Change-Id: Ic4b2318b79a76c1fb4964737ca21564739460485
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-08-09 11:21:59 +00:00
Marcus Tillmanns
960f202c42 Utils: Add guardedCallback() helper
Change-Id: Ia307a4431a759f008faece8ab06400f9af2b9ea4
Reviewed-by: hjk <hjk@qt.io>
2024-08-09 11:06:35 +00:00
hjk
cdb6a5339e CppEditor: Some code cosmetics in cppcodemodelinspectordialog.cpp
Remove some unneeded Q_OBJECTs and indirection.

Change-Id: I37a149714440b1efeabdaee0231400f28e78d0dc
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-08-09 10:50:47 +00:00
hjk
c2a82f9d93 CppEditor: Hide CppCodemodelinspectorDialog definition in .cpp
Change-Id: I4fd839cc8c0ad20ff70dab2066a08ca19eab8ad1
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-08-09 10:50:39 +00:00
Christian Kandeler
d26ae1d102 ProjectExplorer: Move back accidentally moved code
Amends 9d0c144892.

Change-Id: Iaff9ca224f199e32a73f4801e951f0b51d14289a
Reviewed-by: hjk <hjk@qt.io>
2024-08-09 09:22:24 +00:00
hjk
bace373e5b Utils: Don't bark on nullptr in dynamic tree item check
Amends da35026af8.

Change-Id: I758dbba028149259b24425f144d596881f9cd3fe
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-08-09 07:23:48 +00:00
Cristian Adam
afea900b96 CMakePM: Add directory icon overlay for know source groups
This way the CMake Project Manager will behave in the same way as QMake
Project Manager!

Change-Id: I3c4bd6b2f4f0f5d4dfc73edb2049d6e251154d54
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-08-09 07:08:55 +00:00
Cristian Adam
716c1d03f2 CMakePM: Treat "Forms" and "State charts" as special source groups
Amends 76dcc069d6

As a user I expect that the "Forms" and "State charts" source groups
should go away if I select the filter "Hide Source and Header Groups" in
Projects view.

They are not meant to be user defined source groups.

Change-Id: I17db9eb7e1da17b93a45f6093782add19c2b5cb1
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-08-09 07:08:46 +00:00
Cristian Adam
6fd9a3c807 CMakePM: Refactor display of CMakeLists.txt
All CMakeLists.txt from the Project view are marked as generated, except
the root one. This means that in normal case they will be hidden.

Every CMake Target (except Utility) will get a CMakeLists.txt:<number>
entry with the definition line of the target.

The CMake Folders will get an entry with the CMakeLists.txt which can be
accessed via context menu and "Open...".

The CMake Folder that only had a CMakeLists.txt will be removed when the
filter "Hide Empty Directories" is checked. This for example makes a
reduced plugin Qt Creator only display the enabled plugins, and not all
plugins!

With this change the "Simplify Tree" view will no longer have many
CMakeLists.txt entries, which makes the view more useful.

Fixes: QTCREATORBUG-31362
Change-Id: I708171e4b114100fae6fb592044a19fc36239261
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-08-09 07:08:40 +00:00
Eike Ziller
696129296a JsonWizard: Show error if some files fail to generate
Do not overwrite error messages by an empty string, if the last file in
the list successfully is determined.

Also do not show the error message twice by avoiding the
summarySettingsHaveChanged() call at the end of initialize(), which
tries to contruct the generated file list again.

Change-Id: Icaa329fcdd8882d49c4776aaced23e0094cfe857
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-08-09 06:58:24 +00:00
Christian Kandeler
7c28f17481 QtSupport: Re-use ToolchainManager::isBetterToolchain()
... and upstream the additional check.

Change-Id: I6443987174f39e0953238cf2e8e07b4b1d8129bd
Reviewed-by: hjk <hjk@qt.io>
2024-08-08 15:03:21 +00:00
Christian Kandeler
b6299edf1f ProjectExplorer: Factor out function to compare toolchain suitability
... and use in ToolchainKitAspect in addition to KitManager.

Change-Id: I4c9221735a660697baab667877cc335ee0ee3e78
Reviewed-by: hjk <hjk@qt.io>
2024-08-08 14:47:30 +00:00
Christian Kandeler
077de5aab6 ProjectExplorer: Handle registering of auto-created bundle toolchains
... in the bundle itself, whenever possible.
It's very annoying to have to add this stanza in all places where
bundling takes place, and it's also easily forgotten, introducing memory
leaks.
This also nicely self-documents the expectations of the calling code as
to whether new toolchains can or cannot be created in the given context
as a side effect of bundling.

Change-Id: I78d2d4cdfc1010568f61f201b0d930b01f79a88b
Reviewed-by: hjk <hjk@qt.io>
2024-08-08 14:34:47 +00:00
Marcus Tillmanns
bdf21f9dde Utils: Fix watching deleted files
On linux, when a file is deleted and re-created, inotify will no longer
signal changes to the file. We have to check and possibly add the
path again after each notifcation.

See also: https://doc.qt.io/qt-6/qfilesystemwatcher.html#fileChanged

Fixes: QTCREATORBUG-31353
Change-Id: Ibaa94aced33089160fe5cf81faca9a9b72045d30
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-08-08 13:34:30 +00:00
hjk
a5de0bd651 ProjectExplorer: Change language and language cateegory display storage
Effectively from container of pairs to pairs of containers.

Saves a few transformations and temporary lists at the price of
effectively storing the keys twice. This is all small stuff, so
it should not matter performance or memory-wise at all, but helps
me to reason about potential complexity on higher levels.

Change-Id: Idf9e235b64d97b1168278ea3dcda34a476c20c08
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-08-08 13:29:33 +00:00
Christian Kandeler
9a8cba372b CPlusPlus: Allow empty initializer lists in placement new
Fixes: QTCREATORBUG-30798
Change-Id: Ib9945e4e721aca5f88665bd8a289ae3c54c69e65
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-08-08 13:17:34 +00:00
Marcus Tillmanns
759bd41702 CmdClient: Guard against invalid Futures
Change-Id: I6e9f5371baa8a0444e2bd8b965bd8138f4aaa579
Reviewed-by: hjk <hjk@qt.io>
2024-08-08 13:13:17 +00:00
Marcus Tillmanns
a6f7613a9f CmdClient: Re-watch removed files
Change-Id: Iea103133a504e8ca0752b3841ca1b61de5449247
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-08-08 13:13:13 +00:00
Artem Sokolovskii
c671cd7fbc Wizard: Improve GitHub Workflow for loading plugin to the server
The goal is to create a workflow that allows building the plugin on
GitHub and uploading it to the server, making the plugin available
in the QtCreator Extension Manager.

Added registerPlugin.js script:
- This script creates a plugin.json file compatible with the server API.
- The file can be sent to the server, requiring TOKEN_QT in GitHub
  secrets and API_URL set in the script.

Updated main build_cmake script:
- Added a state that generates plugin.json and includes it in artifacts
  and releases.
- Gives possibility use GitHub releases directly in QtCreator to load
  the plugin, even if the plugin data wasn't uploaded to the server.

Added ./build directory to .gitignore.

To use workflow:
- Create in github repository->settings->Secrets and variables->Actions
  ->Repository secrets new TOKEN and set the value from your Qt Account
- Add to the Repository secrets API_URL from your Qt Account
- In github reposytory->Settings->Actions->General->Workflow permissions
  ->Read and write permissions set to true
- Create relase tag in format "vx.x.x" e.g. "v0.0.1" by git tag v0.0.1
- Push chages and tag git push --tag origin main

Change-Id: I2135e0684bd3560736ecf7be1d25199713661c39
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-08-08 12:55:21 +00:00
Marcus Tillmanns
44accdf8b0 Utils: Document FilePath::watch()
Change-Id: Ifb5811348e3b3e2883fcbe775a28ee7126767064
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-08-08 12:52:13 +00:00
Christian Kandeler
9cf9e0aa34 ProjectExplorer: Improve ToolchainKitAspect::setup()
- Use toolchain bundles.
- De-obfuscate the code.
- Add explanatory comments.

Change-Id: I19f4b5fde317ffabf06c762e1987b0314c52e646
Reviewed-by: hjk <hjk@qt.io>
2024-08-08 12:33:15 +00:00