Commit Graph

88653 Commits

Author SHA1 Message Date
Thomas Hartmann
fedb38a0f5 QmlDesigner: Priotize 3D related properties
Task-number: QDS-10682
Change-Id: Ib75877257ea34edfa539a198e56d9499810aca15
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-15 15:12:46 +00:00
Thomas Hartmann
1a1e898f0f QmlDesigner: Set Core::ICore::dialogParent() for QML windows
Change-Id: Ie09c7255495456cb76e94504392c9474e2a88688
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-15 15:12:38 +00:00
Knud Dollereder
b18b7920bb Refuse to add properties from unselected nodes
... and select property after adding it to the model.

Change-Id: I4210e9b1e27b3d396ba5f421629a2b90d2771f50
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-15 13:23:02 +00:00
Thomas Hartmann
5ca59da1af McuSupport: Do not regularly restet code mode in QDS context
Resetting the code model on a regular base has quite a
negative performance impact and also generates unexpected
code paths and updates.

Change-Id: I5a62166d714beb6cc6c9a64333abf093a5a87ac6
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
2023-09-15 13:11:45 +00:00
David Schulz
85cba79cd2 ClangCodeModel: fix setting refactoring markers for clangd
LanguageClient::updateCodeActionRefactoringMarker overwrites previously
set refactoring markers.

Fixes: QTCREATORBUG-29493
Change-Id: I156b4e2ff65aed5928251bfea184e093df686818
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-15 13:09:09 +00:00
David Schulz
0b85fc5aa0 ProjectExplorer: reduce the perceived startup time
... by moving restoreKits to the delayed initialize phase.

Change-Id: If72e41b64ee71f2917b3f7a317d9887afc6e29e8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-15 13:08:49 +00:00
Christian Kandeler
f1fa1ad3d9 CppEditor: Speed up findFilesInProject()
This function had a number of serious performance problems. As it is
executed by several quickfix factories, it could cause freezes on right-
clicking a symbol.
Measures taken:
  - Check file type before file path.
  - Do not collect all files in the project first, but filter earlier.
  - Check all candidate file names at once.
In an example project, I observed a speed-up of factor ~100.
Some FilePath-ification was done as well.

Task-number: QTCREATORBUG-29611
Change-Id: Ic5dc48ffd86f22263d1caea4b6bfea5f49e589a4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-15 13:07:36 +00:00
Marcus Tillmanns
67bd5fc359 Utils: Add StringSelectionAspect
Change-Id: I73b5c964be1222f56fcc01f30d17506f92d1f6b2
Reviewed-by: hjk <hjk@qt.io>
2023-09-15 13:02:07 +00:00
Marcus Tillmanns
b81026488c Docker: Improve error reporting
Change-Id: I1a1ad824b4084ce7203357acf9ec19ccfe91b5cd
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2023-09-15 13:00:39 +00:00
Miikka Heikkinen
f3036d52e5 QmlDesigner: Fix dragging 3D snap configuration spinboxes
Changed to use HelperWidgets.DoubleSpinBox, which has the proper drag
support built into it and implemented required context functions.

Fixes: QDS-10639
Change-Id: I6fce39251d7f754985f95bba5784784fc6eb8fae
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-09-15 12:52:30 +00:00
Henning Gruendl
b73b94d27a QmlDesigner: Remove anchors from positioner child
Change-Id: Ibff848d5f80ac74491ab77e88baffb4d0e1454bf
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-15 12:48:05 +00:00
Henning Gruendl
954385c34d QmlDesigner: Fix wrong role name
Change-Id: I195ead9ade9c4bc430bdee630f533e6e04e15027
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-15 12:47:54 +00:00
Thomas Hartmann
b0a9481049 QmlDesigner: Remove qDebug from ConnectionView
Change-Id: I495525286ff96331ce560d468bf1445fcf7a061e
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-15 11:59:08 +00:00
Henning Gruendl
6d5ceadccf QmlDesigner: Improve type selection
* Disable custom item in Connection Editor type selection
* Rename Unknown to Custom

Change-Id: I9fa8c9ab6284503d5ccc61813454b9d10f291a06
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-15 11:33:49 +00:00
Henning Gruendl
5ed667c554 QmlDesigner: Add chevron to items with children
Add chevron to the ItemDelegates of the SuggestionPopup if items have
children. This indicates that the user can click on it and go deeper.

Change-Id: I905769b8190b81a92025861a3fc38817de5b56ed
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-15 11:33:41 +00:00
Thomas Hartmann
fc981ee54a QmlDesigner: Fix crash
Check for existing device.

Task-number: QDS-10137
Change-Id: I00065b63f09fb5691c52acaefd75fee0c4315d75
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-15 11:21:25 +00:00
David Schulz
aab39532f3 TextEditor: Collect the comment position setting from highlighter
Change-Id: I802b9e263a3515fe340459329a8c8d8f309cfa0e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-15 10:50:44 +00:00
Christian Kandeler
b9191e9d15 Update qbs submodule to HEAD of 2.1 branch
Change-Id: I3435d412498021ab432aeb9f295d25846d39a0ee
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-15 10:46:28 +00:00
hjk
de42485b8f Core: Cosmetics and unused #includes
Change-Id: I5838b7340b9f5fca6d43a49026c8fc82f0d0a494
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-09-15 10:32:57 +00:00
hjk
4ecf769293 Core: Remove SettingsDatabase QObject base
Was not really needed except for the ownership.

Change-Id: I88e32123cbb85a8217ade9450b5b578845736311
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-09-15 10:32:44 +00:00
hjk
680d77bc35 Core: Remove some unneeded #include
Change-Id: I642b578964ee18677d344201e47ba45312938807
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-09-15 10:32:32 +00:00
Alessandro Portale
c9eeca39d0 AdvanceDockingSystem: Skip, if QuickWidgets is not installed
If Qt is built without QuickWidgets, skip building the ADS library.

Change-Id: I0b31de0ba7f1f7c6dcb19e5c75f2345acca48416
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-09-15 10:11:28 +00:00
Andreas Loth
cddc4b3d32 Axivion: Use QUrl.resolved to build path instead of string concatenation
Change-Id: I1e80cc83bd7fcf2ede34bff6764ff3af4d89aac6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-09-15 09:26:23 +00:00
Tim Jenssen
da63a14481 Revert "Tests: Fix cmake build"
This reverts commit a263d3de89.

Reason for revert: QmlDesigner dependency was wrong

Change-Id: I2b67861ab81720649394045b68e2476bb51dd333
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-15 09:25:12 +00:00
Christian Stenger
6233c8ce80 Qbs: Fix build after DS merge
Change-Id: I5188d1654584ba88789472fe1f0c81b2b1a33a55
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-15 08:54:43 +00:00
Christian Kandeler
d46cd711d3 Update perfparser submodule
Change-Id: I68a4f5475eb150431203aca1ce74ef21bf510b08
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-15 08:42:02 +00:00
Miikka Heikkinen
ac6d875d12 QmlDesigner: Display informative string for 3D support in Qt5 projects
Fixes: QDS-10661
Change-Id: I91ba32e478039711758e19c11d385af9fac4c99f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
2023-09-15 08:28:22 +00:00
Alessandro Portale
601ab522a2 ScreenRecorder: Show a ComboBox with display names instead of a SpinBox
This turns the IntegerAspect into a SelectionAspect. Easy.

Change-Id: I421765e6c6c81759f31e3c8e3781170c1fd1fbc5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2023-09-15 07:25:29 +00:00
Alessandro Portale
7de9667a7f Themes: Update DS* roles for all non-QDS themes
Update non-QDS "dark" themes with DS* values from "design".
Update non-QDS "light" themes with DS* values from "design-light".

Change-Id: I7561d5f9e5ad22cd791b5d9772a3ad2f7c2bb399
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-15 07:20:29 +00:00
Marcus Tillmanns
7b3dbfc21f CompilerExplorer: Fix load/save
Change-Id: I2bc1bdbab73b37a5af9bc1fcd040c8ec0c7f363a
Reviewed-by: hjk <hjk@qt.io>
2023-09-15 06:26:49 +00:00
Marcus Tillmanns
16f7652717 Utils: Add AspectList::addToLayout
Added a new, clean IconButton that mimiks the ToolButton
with the compact/relaxed background.

Change-Id: I582c6aac404724af5459bab2ca9023aa63171f93
Reviewed-by: hjk <hjk@qt.io>
2023-09-15 06:26:42 +00:00
Marcus Tillmanns
85f00b243f Utils: Fix DeviceShell error handling
Change-Id: I5e519ffa9672841d84e565ea5fd222d21ca354bd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-09-15 06:26:30 +00:00
Marcus Tillmanns
26b436f46f Utils: Fix constness in AspectList functions
Change-Id: I960e02e1a193856de3ed0e090fdf694884a28ac5
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-15 06:25:22 +00:00
Cristian Adam
78f89fc777 CMakePM: Proper support for Unity builds
A Unity build can be enabled by specifying CMAKE_UNITY_BUILD set to ON
globally or per target bases via the UNITY_BUILD property.

CMake would then add unity_NN_[cxx|c].[cxx|c] sources files that would
include the existing project files.

The existing project files would then be added as "headers" to the
project and exported via the CMake file-api.

This patch makes sure that these new "headers" are added to the Qt
Creator's code model and have proper syntax highlighting, be available
to plugins (e.g. Todo) and so on.

Fixes: QTCREATORBUG-23635
Fixes: QTCREATORBUG-26822
Fixes: QTCREATORBUG-29080
Change-Id: Ie8dd542504f632c01f91691f8736e51be8b19a01
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-14 18:10:27 +00:00
Cristian Adam
4d358ae337 CMakePM: Jump to function/macro/option definitions in CMake editor
Fixes: QTCREATORBUG-25523
Change-Id: If9ab6651a858e5fa08e8a1c321cb1f757831e14a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-09-14 18:10:22 +00:00
Henning Gruendl
6fbf77b027 QmlDesigner: Fix open/close Connections Editor
Improve the selection mechanism in all 3 Connections Editor tabs. When
a new item is added automatically select it and open the popup. When the
current item is removed, close the dialog. When the dialog is closed
deselect the item.

Change-Id: I918bbff6b290b38d496de8c2fa5f31d617f4d21c
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-14 17:17:28 +00:00
Thomas Hartmann
32f8fc4311 QmlDesigner: Show dot properties if combobox is used
Change-Id: I3ea4539f178349551854843838948bf02740eb5b
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-14 17:17:15 +00:00
Aleksei German
26ac6c2606 QmlDesigner: Integrate Editor into Connections
Task-number: QDS-10530
Change-Id: I579c5e5d55b2136b96e32a448315dda8e720f2fb
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-14 17:16:47 +00:00
Knud Dollereder
3a7f41b78c Prevent creation of nonexistent binding expressions
Change-Id: Id6f9f35cd40667d694fcdf06d51c4642ae71afcd
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-14 17:09:42 +00:00
The Qt Project
8f2221cee8 Merge "Merge remote-tracking branch 'origin/qds/dev'" 2023-09-14 15:41:22 +00:00
Tim Jenssen
1a3a8ecc96 Merge remote-tracking branch 'origin/qds/dev'
Change-Id: Id242ab4ca485527defdcc1555d204e12e50ddb7a
2023-09-14 17:37:24 +02:00
Henning Gruendl
9be23b73ea QmlDesigner: Align code preview properly
Change-Id: I05599041b69edf7c8ecaeeff0144d1a4ed6117c3
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-14 15:04:21 +00:00
Alessandro Portale
b5684ee490 Utils: Fix warning regarding incompatible signedness
Change-Id: I0b035ec53d65d636ace121d0d155249eebad2f8d
Reviewed-by: Xavier BESSON <developer@xavi-b.fr>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-14 14:37:15 +00:00
Eike Ziller
e76ec76c0f Remove unused variable
Amends 7f908d737b

Change-Id: I5e28f850c6a4d836ba7c48bd117a91aab64f478c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-09-14 14:35:25 +00:00
Christian Stenger
1701172c30 SquishTests: Fix opening cascaded menus
Change-Id: Ieae5d24f60b9e67c602dbf43737ee3a712a7908c
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-14 13:27:30 +00:00
The Qt Project
3473d9d388 Merge "Merge remote-tracking branch 'origin/11.0' into qds/dev" into qds/dev 2023-09-14 12:52:09 +00:00
Miikka Heikkinen
2598e788cc QmlDesigner: Block import of 3D types for Qt5 projects
Quick3D is not supported anymore for Qt5 projects, so we shouldn't
allow 3D imports, either.

Fixes: QDS-10662
Change-Id: I40da07a67e57527c7ad85443f2463e3f7783693f
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-09-14 12:43:23 +00:00
Tim Jenssen
a603b65f18 Merge remote-tracking branch 'origin/11.0' into qds/dev
Change-Id: I2bf1a2a72d9765d9b4088840414b4933644db47a
2023-09-14 12:23:01 +00:00
Christian Kandeler
93273af6dc qbs build: Move pluginjson replacements property to the module
... where it clearly belongs.

Change-Id: I22d098b701e4921cde53ab34d11ab0078326ab94
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-14 12:21:46 +00:00
Miikka Heikkinen
77a1c0fb15 QmlDesigner: Allow snap back to 0 rotation during drag
Start rotation should be restored when desired angle for rotation is 0.

Fixes: QDS-10652
Change-Id: I8e733b714f6a0f14561c270aefc5049bdfaff39e
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-09-14 12:19:19 +00:00