- Show a unique name when the dialog appears
- Unify and simplify the unique name generation methods
- Fix name field left border cut
- Remove warning on dialog open
- Clear lot of clutter
Change-Id: Ie5b9711c704e68bb41c4f7c3ff63091d9bd11175
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
It doesn't take part in format() processing function, so move this
field outside. The format() may be called in separate thread, so,
just for safety, don't keep this field there so that nobody accesses
it from non-main thread.
Remove the c'tor of FormatTask and use list-initialization instead.
Change-Id: I54daf1461243a46bbd7f58c91ba051909b6cf280
Reviewed-by: David Schulz <david.schulz@qt.io>
... following an argument with an array subscript operator.
Fixes: QTCREATORBUG-29225
Change-Id: Iba38043d94be718efee30ce50f5b55aac4ba6ecd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
These are tools of the 3D view and shouldn't be reflected on reflection
probes added to the scene.
Fixes: QDS-11963
Change-Id: I6d32ed737e3801fbab81a746306de571a25ff363
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Qml basic types seem to have "QML." prefixed to the type sometimes,
so check for those as well when determining the metainfo type.
Fixes: QDS-12030
Change-Id: I944f9a247927b952bb76aaa9f5eaa31334cc10c8
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
If the horizontal scroll bar is not at position 0 we got the
wrong offset for the position of the column.
Change-Id: Id333584f9d509b67eeef39bc7966f095b577e0fe
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Edited the tutorial and added or updated images.
Fixes: QDS-11188
Change-Id: I9db7bacd28b9899fcfbf51e2d3447c060c578013
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
This is done by the FutureSynchronizer d'tor, so no need to call
it explicitly. Move the FutureSynchronizer as the last field of
ClangModelManagerSupport so that its d'tor is executed first.
Change-Id: Id38b8ec08579be8e4ade99ecadb511850ff37f8c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Amends 6467797af2.
The created extra compilers were parented to their factories, who gained
a life time extension from 'end of plugin live' to static destruction
when the factories were made static. However, this that time the likewise
static QObjectCache in GeneratedCodeModelSupport::update might be
destroyed already, leading to a potential crash in m_cache.remove(dead).
This change here re-establishes the original timing by using the
plugin itself as parent for the extra compilers.
Change-Id: Id868b7b87f00440c67af551b71359c47a5c29cba
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Especially on Windows with VC2022 & Ninja, the output would often
display lines that ended in the middle until the next batch of output
was added.
This patch uses the Process facilities to only show full lines.
Change-Id: I38fcb2e8cb115637d15181b39374c533db150c1a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Remove wordiness and just explain what enabling the checkbox does.
Change-Id: Id4c03c1aa7fe7b87919036ffe39717e1a184d5f2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Update the latestVersion in the loop. Otherwise we always compare to
initial value and consequently the last installed version incorrecyly
becomes the latest version.
Fixes: QTCREATORBUG-30423
Change-Id: I7083928c5e371f0337677eacf1b3b4da50358a7c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Make the tool tip for useXMLOutput, quickCheckForDerivedTests, and
parseMessages consistent, use rich text instead of manual line breaks.
We use plural for the things that a locator filter locates (for filters
that don't trigger an action).
Beautify tool tip.
Change-Id: I6276e9a0894d59670a45937e1c4227405c346f38
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Make QFutureWatcher a child of the receiver / guard inside
the onResultReady() / onFinished() handlers.
This prevents the leak of QFutureWatcher when the receiver / guard
got deleted and the future never finishes.
Change-Id: I5653593777ee394dff8cc3c4b7506d8c1907232f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Settings labels are lower case and end with ":"
Change-Id: I729d25569790899a8d26966914ee8b872a48bcb0
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
The original version might have missed to recognize a @\r\n
combination or multi-byte UTF-8 code units when they were
split across to readyRead() handlers.
Change-Id: Ib543fa0070b63d25b44be429a3759964d65e878e
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Use std::unique_ptr instead, as QScopedPointer doesn't offer release().
Change-Id: Ifbe42dca5b266930e1000a50441995023b89b802
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
When resolving a conflit the key line got removed by mistake.
Amends 51998c5239
Change-Id: I74af26d23e7ac0180d1b351d7ecf6d6876499d89
Reviewed-by: hjk <hjk@qt.io>