Commit Graph

88653 Commits

Author SHA1 Message Date
hjk
45bb4a5f76 Autotest: Move unit plugin test creation closer to the tested code
The current pattern.

Change-Id: I52354584734755b3b0f3d2c9596801dc050300fc
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-19 12:33:33 +00:00
Christian Kandeler
f9f43f7492 ProjectExplorer: Let KitAspect pre-select a settings page item
... when the "Manage" button is clicked.
Make use of this in the device settings page.

Fixes: QTCREATORBUG-25077
Change-Id: I1173a72d4c538c839c3e8df278a698b74bd6fca2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-19 11:47:26 +00:00
Christian Kandeler
3fc1b5f57b Core: Let callers specify which part of an options page to pre-select
... and use it for the "Manage kits" functionality.
We will make use of this in other contexts as well.

Task-number: QTCREATORBUG-25077
Change-Id: I79c622075b9385b060aed73534d39acc23fd765e
Reviewed-by: hjk <hjk@qt.io>
2024-01-19 11:27:11 +00:00
Friedemann Kleint
b9cce1a0ba Brush up task file conversion scripts
Modernize them by using f-strings and print out the issue count.
Make flake2tasks.py include the error number in the warning text.

Change-Id: I2d736c27dd3b2356e2b0d0d20f95112e7c37d3f9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
2024-01-19 11:02:34 +00:00
Mahmoud Badri
24c82bbb1f EffectMaker: Prevent scrolling when section context menu is open
Fixes: QDS-11368
Change-Id: Ibdb5e143241374bf68d09fa83074e5bf0e4068d4
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-19 10:58:55 +00:00
Mahmoud Badri
6265b6643d EffectMaker: Add node description tooltips to the 'add nodes' ComboxBox
Fixes: QDS-11414
Change-Id: Ic047c591933a050a4c94147c6c228d7174522353
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-19 10:42:26 +00:00
Eike Ziller
73475480f7 iOS: Do not decorate the iOS Simulator device with "ready to use" icon
The iOS Simulator device is always there, and always usable, it never
can be unavailable. Since now the device state leads to a decoration in
the device selector(s), always having a "connected" bubble there looks
confusing. Remove it.

Change-Id: Ia218e05367a18841e966ea8566e16ad859a09597
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-19 10:32:36 +00:00
hjk
3f224291e6 Debugger: Move plugin tests to extra file pair
Change-Id: I1ce7c9e9b2b680ea8f5a80a3b9556916e7d3d180
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-19 10:29:43 +00:00
hjk
d234e71643 All: More ToolChain->Toolchain renamings
And removal of one unused function declaration.

Change-Id: I594e23401d8f247d3be081ce850005574951899d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-19 10:29:33 +00:00
Artem Sokolovskii
bb88c8c9be ClangFormat: Separate ClangFormat and Standard Indenter UI
The combined UI was a bit misleading for the user and cause
bunch of synchronization problems.

The synchronization between old CodeStyle settings and ClangFormat
settings was removed. Corresponding classes and functions
were also cleared.

The behavior now:
When "Indenting only" or "Full Formatting" modes are chosen then
The ClangFormat settings page is visible and the ClangFormat indenter
is used.
For "Disable" mode standard CodeStyle pages are shown and standard
indenter respectively.

Change-Id: Idb4974c68ceb16ef2e55b108043cc6f56f859840
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-19 10:26:09 +00:00
Mahmoud Badri
c512c9b91d EffectMaker: Limit hovering and clicking the CheckBox to its area
Fixes: QDS-11485
Change-Id: Ia7b719e7e2210a4af8a7935780dead6bacc1f104
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-19 10:25:43 +00:00
Jarek Kobus
2ff533b499 CppProjectUpdater: Reuse TaskTreeRunner
Change-Id: I204041d44bce386b75c43b5d6686671e04bd2b30
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-19 10:21:16 +00:00
Christian Kandeler
b34a8130bb ProjectExplorer: Show device status when displaying lists of devices
Fixes: QTCREATORBUG-20941
Change-Id: Ibc24785ae2afc174d13c22231f2c8e7e6923d64c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2024-01-19 10:07:47 +00:00
Christian Kandeler
37d3c4ed78 CppEditor: Fix ModelManagerTest
Amends 69571427a3.

Change-Id: I07fa0acb34b8277a6790bbd529a7d39190ce846f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-19 10:04:50 +00:00
Mahmoud Badri
2a34e0ae47 EffectMaker: Use correct names in the effect nodes combobox
Fixes: QDS-11418
Change-Id: I965672aaedd8f730f788215561d3749e9295a983
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-19 10:00:10 +00:00
Eike Ziller
2865f6eae0 Examples: Read and handle "documentation dependencies"
Some examples are defined in a Qt module (and therefore examples-
manifest), but have dependencies on other modules.

The example-manifests contain a `module` attribute for their
`instructionals` tag, and examples can contain "docdependencies" items
in their meta data, which are comma-separated lists of these module
names. Read the `module` attributes (the meta data is already
generically read) and check if the current set of examples-manifest
contains all required ones for an example. Hide it, if not.

Task-number: QTBUG-120759
Change-Id: Ib8ff80cf8a13965e57b5c4317e5d121c4127278b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
2024-01-19 09:44:53 +00:00
The Qt Project
716c68ac5a Merge "Merge remote-tracking branch 'origin/12.0'" 2024-01-19 09:02:32 +00:00
Jarek Kobus
604ccf4e23 NavigationWidget: Use find() instead of contains() + value()
In this way we lookup just once.

Change-Id: I8eb9e98980acc3f3b7f6734b04dd4c6b06ec40e1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-19 08:50:28 +00:00
Jarek Kobus
bd21612816 UpdateInfoPlugin: Reuse TaskTreeRunner
Change-Id: Ifc6ab7d17b2cb9569675e19e7493eacc35c8b9a5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-19 08:50:01 +00:00
Jarek Kobus
3a252ef86c PluginInstallWizard: Reuse TaskTreeRunner
Change-Id: I66e7909d1ec0ce04ca250f4bda42bf9b2630966f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-19 08:37:22 +00:00
Jarek Kobus
a94c4dc1fd Locator: Reuse TaskTreeRunner for running locator filters
Change-Id: I4bbbab0905a235df5601064b115edaaa73da047e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-19 08:36:09 +00:00
Jarek Kobus
0ac4e7f55f Locator: Reuse TaskTreeRunner for filters refreshing
Change-Id: I9db6c24491ce5f972707160bf84da01fce67657b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-19 08:35:53 +00:00
Jarek Kobus
61a8128512 TaskTreeRunner: Add setup and done handlers
They might be more convenient than runner's signals.

Change-Id: Ie50afd12f8db6a7f125b1b728a59297d85a48f34
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-19 08:35:43 +00:00
Eike Ziller
4936a89f16 Merge remote-tracking branch 'origin/12.0'
Conflicts:
	src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp

Change-Id: I7a2cfa35b5bc9070c66561bfba3e4b5a8e26917f
2024-01-19 09:33:04 +01:00
Christian Stenger
491b24de70 Ios: Fix qbs build
Amends 0ecab7e0d8.

Change-Id: I28c29fbe761e2d61861252e468484bc883a7575b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-19 08:16:25 +00:00
Eike Ziller
7e1b406229 Create a RunWorker for running apps on iOS 17 devices
That uses the various devicectl commands for starting and stopping the
app, and polling it's state for Qt Creator's stop button.

Getting app output and debugging and profiling are not supported, since
devicectl doesn't provide the necessary functionality.

Fixes: QTCREATORBUG-29682
Change-Id: Ied63b280458e5c109446a140a7774c2909aad62f
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2024-01-18 18:46:32 +00:00
Eike Ziller
0ecab7e0d8 iOS: Extract basic devicectl output processing
Put creating the JSON document and error parsing into a separate
function.

Change-Id: I257f82249a07220467c33220c6b8e4650266b8d9
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2024-01-18 18:46:18 +00:00
hjk
c475cdf42d Ios: Use setup function for toolchain factory
Change-Id: I5c78061327fd57acb1e5803a67dd0a619c26a60c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-18 17:46:08 +00:00
Jarek Kobus
cb6a2da372 VcsCommand: Fix clearing repository
Move a call to setRepository() from c'tor into the setup() method,
as it should be called just before the process is started.

Add an accompanying call to clearRepository() into
the cleanup() method.

Remove other manual calls to setRepository() and clearRepository().

Change-Id: I35b9d4ea72cc885bb8ae34950987a8ca18584fd1
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-18 16:33:04 +00:00
Cristian Adam
5e6f1f5dac CMakePM: Fix adding qml files to targets using ${PROJECT_NAME}
Instead of looking after the target name reported by CMake's file api
e.g. mytarget, take the parameter name from the function that created
the target.

This way if the user used ${PROJECT_NAME} to mark the name of the target
for qt_add_executable and qt_add_qml_module, when adding a qml file the
proper function would be picked.

Fixes: QTCREATORBUG-30218
Change-Id: I920f16d9f5a6b8a7a2fddb3ef7e97e0e3bccd464
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-18 16:13:50 +00:00
Jarek Kobus
64fb116082 ExtraCompiler: Reuse TaskTreeRunner
Change-Id: I68e6c23d73149bf710b0c30ac027fb8c24949486
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-18 15:25:40 +00:00
hjk
6aa6463f75 WebAssembly: Hide WebAssemblyToolchain class definition in .cpp
Change-Id: I7fbff6ff6e48b5b971b490a058b5406d011411b0
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-18 15:12:17 +00:00
hjk
a92a4aad9a ProjectExplorer: Reduce GccToolchain interface a bit
Change-Id: I6c867869d2157611bc8b08b1309d0bce43417f2f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-18 15:05:42 +00:00
Christian Kandeler
636faf30db CppEditor: Do not look for unnamed function parameters in comments
Task-number: QTCREATORBUG-30155
Change-Id: Idc0c7b7c68c99ffda52a4fee2c3dfe5ee52ce099
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2024-01-18 14:31:08 +00:00
hjk
6d4bbba27a QmlProjectPlugin: Dissolve QmlProjectPluginPrivate
Not really used anymore.

Change-Id: I125ca6573cb0fd56cc925379dc0e97b0564e1b7c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-18 14:20:24 +00:00
hjk
aad933c09d Android: Hide AndroidToolchainFactory in .cpp
Change-Id: Ic820eea1b597eefc850407d75fd4a4c3a0a9985d
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-18 14:20:15 +00:00
hjk
3526d38be8 ProjectExplorer: Use setup function for CustomToolChain
Change-Id: I05eeaad0914285c31928e9fad126b27ad78a0fa6
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-18 14:19:57 +00:00
Christian Stenger
c75e55c090 AppMan: Fix include
Do not include *tr.h inside headers to avoid accidentally using
the wrong translation context.

Change-Id: Ie22aa8c077388716e0b028aa5a33126060df5279
Reviewed-by: hjk <hjk@qt.io>
2024-01-18 13:55:51 +00:00
Miikka Heikkinen
2a746ff742 QmlDesigner: Block dragging anything under effect items
Effect items created by Effect maker are not valid parents for any
kind of node, so block dragging anything under them.

Fixes: QDS-11690
Change-Id: I9f6c8a6360d74d04ea871c57e7696466e4b7e41c
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-01-18 13:16:05 +00:00
Miikka Heikkinen
e0bd133296 EffectMaker: Replace old effect with new effect
If a new effect is dragged under a node that already has an effect,
the old effect is deleted, as only one effect per node is supported.

Fixes: QDS-11687
Change-Id: I9be26c8134151895d6d258f5a873ebc85dddb7cf
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2024-01-18 13:15:00 +00:00
hjk
94a2a6f96e QtSupport: Clean up TranslationWizardPage a bit
Change-Id: I70426403d5937ff00b4587e4999f4f0ab092d2e4
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-18 12:41:46 +00:00
hjk
129d6a7f79 QtSupport: Use setup function for TranslationWizardPageFactory
And remove the plugin pimpl which is not needed anymore.

Change-Id: Ib23405b09a389d1b1c99548969fe542461139c36
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-18 12:33:35 +00:00
hjk
670116f2c3 QtSupport: Use setup functions for linguist and designer factories
Change-Id: I5083544dd7e8e16e8b5ed349d23fdcfc0d022330
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-18 12:32:04 +00:00
The Qt Project
5772a85751 Merge "Merge remote-tracking branch 'origin/qds/dev'" 2024-01-18 12:32:01 +00:00
Jarek Kobus
d51e116ac4 CodeGenSettings: Set autoApply to false
Otherwise, the following assert is issued:
"!aspect->isAutoApply()" in [...]coreplugin/dialogs/ioptionspage.cpp:170

The assert appeared after pressing Apply button when
the Preferences... | C++ | Qt Class Generation tab was visible.

Change-Id: I6c5daf2a5f9f00c5edd7dca925447452bd9869bd
Reviewed-by: hjk <hjk@qt.io>
2024-01-18 12:22:40 +00:00
Christian Kandeler
cdfdb5cb9b QmlProjectManager: Fix include
Change-Id: I68d45d49d55487585423793bb01c522bc08b9557
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-18 12:11:59 +00:00
Jarek Kobus
221031a93a RunControl: Reuse TaskTreeRunner
Change-Id: Iad7731a1f124a08bcd81529d5fafd0960462de8d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-18 12:07:20 +00:00
David Schulz
ec6732511f TextEditor: fix autoIndent
e70b99c7da broke the auto indent for all
indenters because those indenters are all based on the text indenter.

Add a fallback indenter that is used if no other indenter is configured
for a document, and avoid the auto indentation only if that fallback
indenter is used.

Change-Id: I00e04a07ab14c5fc433a71d1b9826f8e4cc5c0a0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-18 12:01:35 +00:00
Tim Jenssen
399f7a1968 Merge remote-tracking branch 'origin/qds/dev'
Change-Id: I5d593fc74785958886453dc0b452c25356a8c65f
2024-01-18 11:15:29 +00:00
Tim Jenssen
4e16d1a07d Merge remote-tracking branch 'origin/12.0' into qds/dev
Change-Id: I264d3ce1a2d568c9f68c12c9ecd58fefd4c672a5
2024-01-18 11:08:33 +00:00