Drop errorMessage arg. There are 2 callers of this method
1. PerforcePluginPrivate::printOpenedFileList() was ignoring this arg.
2. PerforceEditorWidget::findDiffFile() was just printing qWarning().
In this case, instead of printing a warning, append a relevant
error message to the VcsOutputWindow. Note, that this is done
in case the passed quiet is false. Once, it's done implicitly
by the call to runP4Cmd() and passing ErrorToWindow flag.
The second possible message is explicitly sent to VcsOutputWindow
in case of !quiet.
Change-Id: I257d474b958b09965ffabdd09ff2e0fb253a0bf8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
The setter setTimeoutS() is going to be removed soon.
It's going to be replaced by the extra arg to runBlocking().
Change-Id: I60b8c952ba5e27e36183f8652aaa92059e08746e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Avoid using readAllStandard{Output,Error} mutable methods if possible.
Use non-mutable methods when we are not connected to
readyReadStandard{Output,Error} signals.
Change-Id: I2e830e571b9eab2177fd856bbe06dfc5137d9c01
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
The timeout is only used with runBlocking(), otherwise it's no-op.
Change-Id: I7d81e4a73c7182bd19c435c112a2d64c3f40ba2e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Use Job's timeoutS field instead.
The Process::timeoutS() is going to be removed, soon.
Change-Id: I2f2fc7ed99e51242d364a423234321e00ae52b75
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This is not the same as process timeout, so make these two
settings orthogonal.
Change-Id: I3fc774c183282fe770feb49258d77d0ce3637b38
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
It was only needed for runBlocking() in event loop mode.
Handle it locally from the runBlocking() function.
Change-Id: I6eb0830b223977bbf0fc73f0cdf4f3b4cab962b5
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
When process finished while the message box querying for
a process to be stopped after a timeout was visible,
don't try to stop it and don't report a hang.
Change-Id: I74a819244a96d9e0209cabc6d58c0a1c4fe1ac31
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Get rid of two internal fields: m_hangTimerCount and m_waitingForUser.
Rename m_maxHangTimerCount into more meaningful m_timeoutInSeconds.
Fire single shot timers instead of a timer with interval.
Change-Id: I10890101273719f55a591eaecf818067aa5c503c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Needs to be done only once, and fixes a dangling
pointer if setup() was called twice.
Change-Id: I02722daf5dffdfb2d4bb70de77436eb8d930806d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Move document changed to slot and make sure it is a
unique connection to prevent multiple slot calls
* Still we get two changed signals after save, which
caused two blame calls, avoid this with a marker
Change-Id: I8f09ebc8c3cf9f9832fe2725c69acbea9a6b8c28
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Get rid of unused errorMessage arg.
Return the stash list directly.
Change-Id: I9bf156c5ecda476a5def3c3490d6cb13d011a3cd
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Get rid of unused errorMessage arg.
Return the stash name directly.
Change-Id: I11e7b0ef4dcaa38293cbf5d20b7213cc06850257
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Parse the version string with base 10 now.
Amends abee98b44817d1aee63b5cd9b673d0c3aa1733ba
Change-Id: I2f0b47380a9714b3f3de475ddabe78875db3b608
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Qml string for preview component is not regenerated every time
uniform values change, so we must always create the Image element
for sampler uniforms.
Fixes: QDS-11709
Change-Id: Idf82a7c69a5a79389f755c45119c97ba54f4581f
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
If left uninitialized, this randomly hides items in 2D view,
when parent is incorrectly detected as effect.
Fixes: QDS-11367
Change-Id: Ie504fce80dcebd7da943a3107b760c80218e9f91
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
No longer set position for reparented effect nodes.
Don't allow reparenting effect node if the new parent already has an
effect node.
Fixes: QDS-11686
Change-Id: I8428311d31e3f243f595938dc44c11e4b1fd04bc
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Fix the Connections syntax to avoid warning:
QML Connections: Implicitly defined onFoo properties in Connections are
deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
Change-Id: I8ff33445443b0d5b36a7ce40f7d5a0b6b99abdcb
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Shrief Gabr <shrief.gabr@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
This avoids the large-scale exposure of #include <clang/Format/Format.h>
which otherwise confuses moc.
Change-Id: I1d48174bd5f940e03986b58a7efa5e537cc99781
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Since the book mark support is nowadays part of the text editor plugin
we can directly access the bookmark manager from within the editor
without the indirection over the TextEditorPluginPrivate.
Change-Id: I5c04679d6583c06d615d489d3891431adcb64834
Reviewed-by: hjk <hjk@qt.io>
