This better corresponds to done handlers called
in this case with DoneWith::Cancel.
By the way, get rid of unused LocatorFilter::stop().
Change-Id: Ie4246b8d888fff95940a2ed41367d2817bd6339c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Allows the user to Ctrl(Cmd)+Click "version like" text (e.g. text that
only contains 0-9 and a-f) and starts a "vcsDescribe" if a version control
can be found for the current directory.
Fixes: QTCREATORBUG-29213
Change-Id: I462092b58bf595a6968f4765f83a207506f0cf87
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
95a3087a7b dropped the mime type registration by accident. Add it back to
make the plugin functional again.
Signed-off-by: Fabian Vogt <fvogt@suse.de>
Change-Id: I783429ce7883bad8b946ed1599098751d56cabad
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
... and remove related helpers from the plugin class itself.
Change-Id: Ibc6af7518a2c90da93e619dde05edbd1eb7948f0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Instead of limiting them to a specific deployment configuration, they
are now limited to the B2Qt device.
Change-Id: Ic27d3e4fc50cea0a838223eb41e0e422d7b17b82
Reviewed-by: hjk <hjk@qt.io>
Instead of having a local and a remote step, we can use a single step
for both cases. The code of the remote step is now used also locally.
Change-Id: I08d3b07761b77b3618f3db001a0d83d1eea65421
Reviewed-by: hjk <hjk@qt.io>
This makes sure the RunConfiguration is correctly executed on the remote
device.
For steps executed on the host, a nullptr can be passed as device.
Change-Id: Ide5aa5a06402b137494c10108d09a4e7ffa32ec9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
CMake can generate backgraces with absolute paths, and the commit
246f33c20d removed this support from Qt
Creator.
This commit fixes this issue with absolute paths.
Fixes: QTCREATORBUG-29914
Change-Id: Ib911e80aee1ff9f4a26435f7e693f7766551cc90
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This patch updates the old image to include lock the views features
in the document screenshot.
Fixes: QDS-11560
Change-Id: I886c2cdd385117791ac7f45f7477a7bf5458ac66
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
This patch updates the old image to include new topbar
in the document screenshot.
Fixes: QDS-11567
Change-Id: I07573874a1bfa428e377c394ade0cf556ce6b056
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Remove all variables we don't need and convert them to FilePaths where
it makes sense.
Change-Id: I4842bcf23f81db8c86f7e305113c24034b361d80
Reviewed-by: hjk <hjk@qt.io>
... as a convenience function for .setDefaultValue(filePath.toUserOutput());
The case that someone already has FilePaths should not look (much)
uglier on the user side than the QString "raw" case.
Direct overloading setDefaultValue(FilePath) causes resolution
conflicts, which are solvable, but I'd rather keep it explicit now.
Change-Id: I03d71e4f99005a1d1f76ebf23080bebe46a9351d
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
The regression was introduces in one of the refactoring patches.
Amends 37b6cb7f90
Change-Id: Ieb2350a024249d1ea9a50c7e2c3d05ce4faaf74a
Reviewed-by: hjk <hjk@qt.io>
Enrich the DashboardInfo structure.
Use dashboardInfoRecipe() for fetching the project list.
Change-Id: Ibbc14d0fae31a8930cec6051e412af15bec71fea
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
It isn't necessary to export the class (which would then best have a d-
pointer etc). Just provide a function that asks the user for a codec and
returns their decision. This makes the whole dialog an implementation
detail.
Change-Id: I7d574561cbe7f079a6d383ba65ba70f6868bbf05
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
... for e.g. function insertion. In some contexts, the insertion
position is on the last line of some unrelated code (e.g. a preceding
function implementation) and the inserted code starts with a newline. In
that case, advance the position of the formatting cursor, so that we do
not accidentally format the existing code.
Fixes: QTCREATORBUG-30229
Change-Id: Id0be7f22e1797affa0602bb1d392a5e0802cbdcd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
UI preparation which may change when adding the functionality
of retrieving respective information from the dashboard.
Change-Id: I9ec8069d780f925b00ba63982af6b410ddec9a5a
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This patch updates the old image to include lock the views features
in the document screenshot. Also it updates the text description to match
the change.
Fixes: QDS-11565
Change-Id: I262be3392552920607725becda6e21d3e571c122
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
You should either use begin() and end(), or data() and size(), and
either way you shouldn't dereference the first iterator if the size is
zero.
Roberto's parser in 3rdparty/cplusplus assumes you've passed at least
one character (I'm guessing the null terminator) and does pointer
manipulation there:
void Lexer::setSource(const char *firstChar, const char *lastChar)
{
_firstChar = firstChar;
_lastChar = lastChar;
_currentChar = _firstChar - 1;
_currentCharUtf16 = ~0;
_tokenStart = _currentChar;
_yychar = '\n';
}
Note the _firstChar - 1 math is technically UB if firstChar is the
actual first character of any buffer allocation or string.
Fixes: QTCREATORBUG-30044
Change-Id: I76ffba14ece04f24b43efffd17abcb8102497813
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* If all of the columns are deleted, all of the objects will be deleted
and a single column, with one empty row will be created.
* A bug is fixed for the cases that we have invalid selected column.
Task-number: QDS-11649
Fixes: QDS-11678
Change-Id: I8bdbd0176ad76dd761e98b5030cdc77379a8642b
Reviewed-by: Shrief Gabr <shrief.gabr@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
In practice this applied only to "Mipmap Drop Shadow"
Fixes: QDS-11717
Change-Id: Ia731370a1101a9bce17ae558ae8761b99afcd896
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Files with same name but different path will now be removed from
UrlChooser combobox on the assumption that they are in fact copies of
the same file.
Fixes: QDS-11471
Change-Id: Ic65153a1a65865982ee1c11e4e20171d66221b76
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
