Commit Graph

88653 Commits

Author SHA1 Message Date
hjk
4df8101d4b CppEditor: Reduce visible CppIncludeHierarchy interface
... and remove related helpers from the plugin class itself.

Change-Id: Ide4b0596d0822b0737b341fa2fb08965f11cb018
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-26 12:04:37 +00:00
Mahmoud Badri
5c7090c90e QmlDesigner: Rename Effect Maker to Effect Composer
Only in the UI. No code renamings for now.

Fixes: QDS-11781
Change-Id: I257c649750ae30cbf4981073be2e6bfc9c92b4df
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-26 11:48:12 +00:00
Marcus Tillmanns
debee7cdf1 Utils: Add iterator check
Change-Id: I761f6e1871c092e35878f07a7c416c4e47781980
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-26 11:33:10 +00:00
Eike Ziller
a0716261a8 ModelEditor: Use namespace Core
Less noise

Change-Id: I3b1d42f1d269b7659be0a73ca5cec6bd5a835702
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 11:32:19 +00:00
Eike Ziller
4900ce90e3 Core: Remove CommandAction class
In favor to a method in the Command class that creates an action,
similar to how there are the methods augmentActionWithShortcutToolTip
and toolButtonWithAppendedShortcut already.

Change-Id: Id5f778bd01babb556cd9d3ed7ef0bb68d78887bd
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 11:32:11 +00:00
Eike Ziller
f22fa5275e Use ActionBuilder for Markdown editor
Also add method that sets the ParameterAction for the context action.
That is an alternative to "binding" the context action, and is useful in this
case, since we do not have a QObject that we can use as a parent for the
constructor that creates the ParameterAction from scratch.

Change-Id: I6ba05208d33460cfa2df9ce8247f7ca30624c22f
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 11:31:57 +00:00
David Schulz
d9404208da ProjectExplorer: declare only relevant aspects as features
This will disable python kits for all Wizards that require a valid Qt.

Change-Id: I4a8d6dd60629ddb556e49c067200acba8ef080d2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-26 11:27:32 +00:00
Jarek Kobus
bd81ef4127 SynchronizedValue: Limit code repetition
Change-Id: I7d76d80db3d7345ba989c9346030b07be9754b3f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-26 10:57:46 +00:00
hjk
17463757ce ResourceEditor: Remove some indirection
Change-Id: I930e7e35401e6c6d8b3e1245e6a7c663f131d345
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-26 10:45:14 +00:00
Marcus Tillmanns
dbee11f5b4 Environment: Fix incorrect usage of appendOrSet
appendOrSet will append to existing environment variables which is not
what we want for all the changed locations in this commit.

Change-Id: Icf6b110acc59261659839375672943ec21923da1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 10:33:34 +00:00
Eike Ziller
b8c9d79b9f Remove focus rect from some input fields on macOS
The focus rect on macOS needs some space around the widget itself,
otherwise it looks wrong. We already removed the focus rect for various
input fields like locator and search (cmd+f), also remove it from filter
input fields for the various output panes.

Change-Id: I048453c06264c51ec28b5a0c9368fad7c01dc5a7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-26 10:31:07 +00:00
Leena Miettinen
f8f82f259a Doc: Split up Using FakeVim into how-to and reference topics
- Move contents around
- Remove obsolete information about color scheme
- Fix keyboard shortcut for toggling FakeVim mode

Task-number: QTCREATORBUG-29361
Change-Id: Icb1c76e014b34d582e40d597bb1279df53e2c02b
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 10:13:54 +00:00
Marcus Tillmanns
a25bbf23c6 Utils: Fix error prone default value of appendOrSet
It was not readily clear that Environment::appendOrSet/prependOrSet
needed a value for "sep", otherwise it would just concat the values without separator. This got apparent when looking at usages of
appendOrSet.

Instead there are now three options, "Auto", "Colon" or "Semicolon"
with the default being "Auto", which determines the separator based on
the Environment::OsType.

Usages of appendOrSet and prependOrSet are also fixed with this commit.

Change-Id: I868e14ce38f50be9cd07292fe3f22663a62d116d
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 10:10:03 +00:00
Marcus Tillmanns
56f42c319e Terminal: Fix env separator
Change-Id: I738ff27d37df95170bbdc9f55fbaf6430ebb5a40
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-26 09:36:33 +00:00
Christian Kandeler
946efb14b1 QbsProjectManager: Move progress bar future to QbsProjectParser
It was very odd that it was held alongside the parser in a different
class.

Change-Id: I187b2260e079f0bf88bfc73447b7dec7f6497dca
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-26 09:32:45 +00:00
hjk
167cd3378d Qbs: Use Store instead of QVariantMap in a few places
Change-Id: I0636fad4ca032ec6657f2e35154c2e0ea4d0c9ca
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-26 09:20:33 +00:00
Artem Sokolovskii
e1f7469afb ClangFormat: Replace checks widget with editor
The existing approach utilizing the widget poses maintenance
challenges, primarily due to the dynamic nature of clang-format
settings across versions. The widget necessitates regeneration
for each new version, and compatibility issues arise when users
have different clang-format versions on their devices.

The updated solution adopts an Editor integrated with a yaml
language server, offering the ability to highlight and provide
code completion for the .clang-format file. This resolves the
widget regeneration issue and ensures compatibility with various
clang-format versions.

- Replaced the checks widget with an editor
- Introduced a line for yaml language server schema
in .clang-format files to enable autocompletion.
ToDo: Enhance schema accessibility without relying on this line.
- Added Ctrl+Space shortcut for autocompletion
- Added Ctrl+S shortcut for saving
- Eliminated outdated logic related to the checks widget
- Fixed copying and removal of clang-format settings

Change-Id: I2e3fbf19abe2f4df031f6ba5faffd47e07274346
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-26 09:19:25 +00:00
hjk
78a909390c RemoteLinux: Use more restrictive #include in linuxprocessinterface.h
Change-Id: Ib234ed21762b27064b7f062bd43f25bce8264d37
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-26 09:18:10 +00:00
hjk
841081d517 Utils: Remove odd QTreeView declaration from environmentfwd.h
... and use one when it is really needed.

Change-Id: I583fb775e5d625833816ac380ea74bf24b67d8e7
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-26 09:07:32 +00:00
Jarek Kobus
5ae37f2f84 ImageScaling: Reuse LoopList
Instead of LoopRepeat + container capture.

Change-Id: Ic37c4ff53c4ce2a217a258aa4af1272ac3d8ab29
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 07:51:27 +00:00
Jarek Kobus
e1f0da4e20 ClangToolRunner: Reuse LoopList
Instead of LoopRepeat + container capture.

Change-Id: I5bce612279cf63f6ad1237569b55baad9a98e2ce
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 07:51:22 +00:00
Jarek Kobus
507933467f AutoTest: Reuse LoopList
Instead of LoopRepeat + container capture.

Change-Id: Icb243d7ac902eed95503d7d1a5ac007f4f6c705d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 07:51:16 +00:00
Jarek Kobus
e826e3ad7e TaskTree: Use QMutex consistently
There is no noticeable difference between using QMutex vs std::mutex
in release build.

It looks like std::mutex is about 15% faster than QMutex in debug
build, but that's not relevant.

Get rid of #include <atomic>.

Change-Id: Iae67d5028c5ae3cb412e50d629bfc09b38417dfc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 07:51:05 +00:00
Christian Stenger
7c246f025c Axivion: Start handling total row counts
Include them only for the first fetch of an issue kind to
avoid costly additional access.

Change-Id: Icebbea5635b1f1d266238f99c43426dc22fb19b9
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-26 07:48:56 +00:00
Christian Stenger
eec7339af3 Axivion: Make issues clickable
For now just a simple approach of using the base directory
using the given path and line information.
Depending on the issue kind there might be multiple locations
but for now only handle one of them.

Change-Id: I046b7c42593aa4c30b843fa8f9145fae35e869d4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-26 07:46:45 +00:00
Christian Stenger
42c7f54c68 Core: Fix include
Amends 2796e69ab5.

Change-Id: I472ebca5de8c6e8b16133264b6b867a8abd10825
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-26 07:21:47 +00:00
Christian Stenger
921bb9c977 Axivion: Minor ui improvements
..for the issues view.
 * use display names if posssible
 * fill versions and owners
 * use progress indicator
 * extract more data from issues

Change-Id: I91197ce375b8d58a4a09a7a5a9ad005e012c4549
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-26 05:24:54 +00:00
David Schulz
6d715f15d8 TextEditor: Add case sensitivity checks in optimization
17e2a80e10 added some optimization for
prefix and infix matches of completion items in order to avoid the
expensive regular expression check for the fuzzy match, but ignored the
user configured case sensitivity for auto completions.

Change-Id: Ic340e48abc6636bd2e8abeeddcd880cbdc66d03e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-26 04:59:28 +00:00
Dominik Holland
681f039d79 AppMan: Fix dependencies of RunWorkers during QML Profiling
Change-Id: Id8a43d31369ae4cf150458dcab4693bf967decec
Reviewed-by: hjk <hjk@qt.io>
2024-01-25 16:47:15 +00:00
Cristian Adam
a8370aaf81 CMakePM: Allow adding files to OBJECT libraries
Amends 7a46bbe667 which only used
`cmakeTarget->productType() != ProductType::Other` which excludes OBJECT
libraries.

Now the fix actually includes all targets which are not UtilityType,
which was the intention of 7a46bbe667

Fixes: QTCREATORBUG-29914
Change-Id: If661828e43d5c566c876546f5527c0b670405e47
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-25 16:41:31 +00:00
Dominik Holland
e0088357d0 AppMan: Various small fixes
* Always use the correct symbol when debugging
* Fix the TargetInformation::isValid() function
* Optimize RunConfigurationFactory::supportsBuildKey()

Change-Id: I5f007d5c216ff9808adf9f8b878c9cbc9f47e3eb
Reviewed-by: hjk <hjk@qt.io>
2024-01-25 14:48:46 +00:00
Miikka Heikkinen
cebe5cecd7 EffectMaker: Add comment for _isEffectItem property
Fixes: QDS-11767
Change-Id: Id987af6bd13cd481c8dbe25cdf7090e5cbeb7db7
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-01-25 13:42:46 +00:00
Jarek Kobus
53de44444e Get rid of EXPLICIT_MOC
Otherwise it generates the following:

Generating moc_pluginmanager_p.cpp
[...]/pluginmanager_p.h: note: No relevant classes found.
No output generated.

The same for:
moc_cppquickfixprojectsettingswidget.cpp / cppquickfixprojectsettingswidget.h
moc_imageviewer.cpp / imageviewer.h
moc_vcpkg_test.cpp / vcpkg_test.h
moc_clangformat-test.cpp / clangformat-test.h

during compilation.

Change-Id: I65ea5a7caeb0607972c09de1de66337cb7df59b8
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-01-25 12:33:15 +00:00
Jarek Kobus
3932cdf8d4 GenericLinuxDeviceTester: Reuse LoopList
Instead of LoopRepeat + container capture.

Change-Id: Ie021c618808dad3ac3e0ba5993009074aa9a8313
Reviewed-by: hjk <hjk@qt.io>
2024-01-25 12:32:59 +00:00
Jarek Kobus
84315d5988 TaskTree: Introduce LoopList
A wrapper around container with convenient
"const T *operator->() const" and "const T &operator*() const" methods.
They mimic the const_iterator API.
Simplifies the usages, as it enough not to capture just
LoopList element inside task handlers without a container itself.

For now it handles just QList container.
To be generalized later.

Change-Id: I10ea3903985cf51529ec5909ac7c19c524de7c68
Reviewed-by: hjk <hjk@qt.io>
2024-01-25 12:32:50 +00:00
Jarek Kobus
e828ef1c13 GenericLinuxDeviceTester: Simplify the main recipe
It's now easily possible to mix GroupItems with the lists of
GroupItems on a common list.

Change-Id: I32b4061e45302e8532d39f84c4e6eb8c9e719faf
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-25 12:32:41 +00:00
Jarek Kobus
d9a71c1351 GenericLinuxDeviceTester: Reuse LoopRepeat element
Instead of creating quite huge recipe.

Change-Id: I8b4121d0a666f093885d1379f6f4c8093cd2619c
Reviewed-by: hjk <hjk@qt.io>
2024-01-25 12:32:31 +00:00
Miikka Heikkinen
6fb7f464ac QmlDesigner: Remove deleted effect usages from current document
If there are any imports or nodes of the deleted effects in use in the
current document, also remove those when deleting effects.

Fixes: QDS-11723
Change-Id: I87972b5fc38b35acb0fb71fd085d2a3fcf691318
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2024-01-25 12:29:04 +00:00
Marcus Tillmanns
273656c927 Terminal: Fix fish shell integration
Change-Id: Ib9156be851d092db2a28641a292ae32e76314bec
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-01-25 12:15:27 +00:00
Miikka Heikkinen
5db5ade17d EffectMaker: Round the integer slider value properly
Fixes: QDS-11772
Change-Id: I4d79c28784213695ea8e9a220f6fbd878bfb0cd4
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-01-25 11:54:47 +00:00
Marcus Tillmanns
6d672f7efa Aspects: Add TypedAspect<T>::valueType
Change-Id: I6da6d089d23df154c02994cc5d892b746a346b23
Reviewed-by: hjk <hjk@qt.io>
2024-01-25 11:23:07 +00:00
Marcus Tillmanns
bf1c332daf Aspects: Add missing default value to TextDisplay
Change-Id: I58432e1aac9b19bf49dc919ded90bee4fb4cb2cc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-25 11:22:18 +00:00
Xavier BESSON
2796e69ab5 Add display search results using relative paths to project root
Task-number: QTCREATORBUG-29462
Change-Id: Ic5d597846cfcc6589cbf1b81151e05c95ee8fab0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-25 10:46:43 +00:00
Jarek Kobus
905eaf8b1e TaskTree: Adapt docs to the stop() -> cancel() rename
Amends 983fc4bcf6

Change-Id: Id8406f5c8713d7cfb387f89bfb16d653e639ffb6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2024-01-25 10:23:30 +00:00
Cristian Adam
0197a2780a CMakePM: Do not force Xcode generator for iOS
"Xcode" will be set as default generator for iOS kits, but if the user
imports a iOS build from command line we shouldn't reset that generator
to "Xcode".

Amends b47a80c5ce

Fixes: QTCREATORBUG-30214
Change-Id: Idbdadcf24e87b861adf377975788e0146f7731cb
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-25 10:15:55 +00:00
Mahmoud Badri
621d7044b4 EffectMaker: Fix top bar width
Regression caused by cfe3828c53

Change-Id: I573da870c61ec0c5f3ba056ffd759acefd8c9389
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-25 09:54:10 +00:00
Mahmoud Badri
398676a360 EffectMaker: Make image value width fits the view width
Fixes: QDS-11752
Change-Id: Ia47c5076c32824628e700554a06803f50b82cd08
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-25 09:44:13 +00:00
Christian Kandeler
aa53543fa3 QmakeProjectManager: Remove more unused code
Amends fd1956a91c.

Change-Id: If6a3b2369a94caba2724bea0b3fe8e214cd87f61
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-25 09:36:02 +00:00
Dominik Holland
1deb31f295 AppMan: Use FilePathAspect::setDefaultPathValue(FilePath)
Change-Id: Ia8025bc707fd1d87b4066fcee98b8566f13726d6
Reviewed-by: hjk <hjk@qt.io>
2024-01-25 09:33:05 +00:00
Dominik Holland
07d347a0c3 RemoteLinux: Allow the deploy steps to be used in all deploy configurations
Instead of limiting them to a specific deployment configuration, they
are now limited to the RemoteLinux device.

Change-Id: I4a8eebd055985b63815ac6fbb3b9e04c297bd1ab
Reviewed-by: hjk <hjk@qt.io>
2024-01-25 09:32:57 +00:00