Commit Graph

88653 Commits

Author SHA1 Message Date
hjk
ec983a6462 CMake: Some code cosmetics in cmakeeditor.cpp
Mostly namespaces and 'final'.

Change-Id: Ifda9fe2af0b83b4ebb71c936a5ab6352d650ccec
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-01-29 13:42:40 +00:00
hjk
5646aae859 CMake: Use setup functions for a few more cmake related items
Change-Id: I7a1bbea9507d7d168584348a51d557f4a910de47
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-01-29 13:42:27 +00:00
hjk
cc64c84b5f CMakeProjectManager: Use setup function for CMakeToolManager
Change-Id: I66078250029f87d64b7b31aba9049a8b0b68f3a5
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-29 13:28:33 +00:00
hjk
5f90065ea9 Core: Merge ActionBuilder::context{Parameter,}Action
They are practically the same now.

Change-Id: I3bdf04388ce22830f4a84f58a36f037399684701
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-29 13:02:15 +00:00
hjk
524167a936 TextEditor: Use new setup pattern for the finders
The FindInFiles definition cannot go yet to the .cpp yet as there
are some exported functions.

Change-Id: I2d2f02ae80b560e3147f461fcbee0fa62b8085a3
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-29 13:01:39 +00:00
hjk
66b50438d8 Utils: Rename ParameterAction into Action
It became the defacto-type for action when ActionBuilder started
creating them as default.

Change-Id: I1008d60b78ea83919ce1c80a7ef828527fe9902c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-29 13:01:29 +00:00
Leena Miettinen
fe35ee5c38 Doc: Split up Beautifying Source code
Describe the process in a how-to topic and the preferences in
a reference topic.

Task-number: QTCREATORBUG-29361
Change-Id: I9bf2b693590e0943a3bb6d5ed11dbc5a9d5cbd80
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-29 12:50:45 +00:00
Eike Ziller
fa55b29121 Core/Dialogs: Add privates and avoid inlines for exported classes
Makes it easier with ABI compatibility.

Change-Id: I6d51b7fe3425a292db8139604bb571eed5ec11ca
Reviewed-by: hjk <hjk@qt.io>
2024-01-29 12:29:45 +00:00
Eike Ziller
479f1f34ce iOS: Disable anything but running for iOS 17+ devices
We currently cannot support anything than running for devices with iOS
17 and later.

Make it possible for RunConfigurations to state that they are disabled
depending on run mode.

Change-Id: I13df4dd482f6381cda15168c38ede00d95e1d692
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-29 12:13:51 +00:00
Cristian Adam
76a8966739 CMakePM: Refactor CMakeLists|Cache.txt as constants
Change-Id: I7165fa1d219a0c59bc519a9af1cd194414c4311c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-29 11:50:21 +00:00
hjk
b953735b22 Boot2Qt: Use QmlProjectManager::Constants::QML_RUNCONFIG_ID constant
... expanding to "QmlProjectManager.QmlRunConfiguration.Qml" instead
of the "QmlProjectManager.QmlRunConfiguration" literal.

This is no change for the "QmlProjectManager.QmlRunConfiguration.Qml"
case as the worker factory still checks the id with 'startsWith()'
I can't see other RunConfiguration matching that.

Change-Id: I328683b8da441683991bd586b3580a7efb985c0b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-29 11:45:28 +00:00
hjk
a4de558e62 ScreenRecorder: Use ActionBuilder to create main action
Change-Id: Iceac6a287f2d5fc71617a67e89fcf7c59cdac31f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-29 11:41:54 +00:00
hjk
9d63fdac64 CPaster: Remove unnecessary QAction members
They were set but never needed again.

Change-Id: I4805405c28c9635a8607487bcc6975cf179446a1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-29 10:19:36 +00:00
hjk
544d68877c Boot2Qt: Use setup function for run worker creation
This is meant as a mechanical change, leaving intact the
"QmlProjectManager.QmlRunConfiguration" which seems to be wrong
("QmlProjectManager.QmlRunConfiguration.Qml" exists) and will
be addressed in a separate commit.

Change-Id: I0053ec66f43a2dd7d10bd21fcf3ef5e1534e7a1b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-29 09:39:18 +00:00
hjk
5d8bf13e25 Boot2Qt: Use setup functions for two factories
Change-Id: I39fc69f5ab0b1e808631e73c0d238a8ebe55473e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-29 09:38:59 +00:00
hjk
45a62e785a AutoTest: Use setupFunction for TestSettingsPage
Change-Id: Ib592b3fd92480a5e712cf7cd69d4b5c899a1f216
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-29 09:15:32 +00:00
Jarek Kobus
8b8e360ba8 CdbEngine: Keep multiple arg() for int arguments
Otherwise the second arg is interpreted as fieldWidth.

Change-Id: I6105386aa743bf172eaef4bafe6a350381c76ce5
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-29 08:44:13 +00:00
Jarek Kobus
d39f42c1f6 LanguageClient: Replace QMap with QHash
The key is a pointer, so use QHash.
Avoid double lookups.

Change-Id: Ia48109c909372b02727ce229974d721546766f50
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-29 08:44:00 +00:00
hjk
d373ff30d4 Conan: Use setup function for ConanInstallStep
Change-Id: I73f0555fb7310cc9d7f64d86c4a58d7075b6cc17
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-29 08:09:37 +00:00
Jarek Kobus
af0173b21f Valgrind: Keep multiple arg()
Otherwise the 2nd arg is interpreted as fieldWidth.

Amends cf2ea1b70a

Change-Id: I4ef199f1fc6bb204f603fb5cc0a813a33f3ba1a7
Reviewed-by: hjk <hjk@qt.io>
2024-01-29 07:49:06 +00:00
Jarek Kobus
11a8c55f38 Various plugins: Remove unused variables
Change-Id: Ie2e5eb38d81a7582c5715654f09f28deb4ab11c5
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-29 07:44:39 +00:00
Jarek Kobus
1ad61f8da3 Axivion: Extract fetching table into the reusable recipe
Get rid of public fetchIssueTableLayout() method.
Introduce tableInfoRecipe() which takes a handler as an arg.
This decouples the plugin from AxivionOutputPane's API.

Change-Id: Iae3ce83e132e0769b45ed3db911bd1046cc7bcb8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-29 07:35:09 +00:00
Jarek Kobus
5c1ee4021a Axivion: Extract fetching issues into the reusable recipe
Get rid of public fetchIssues() method.
Introduce issueTableRecipe() which takes a handler as an arg.
This decouples the plugin from AxivionOutputPane's API.

Change-Id: I4a4e2fd14dfd4eed2d28648a227a1ed3a5fe90f3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-29 07:35:02 +00:00
Jarek Kobus
2759266e84 Axivion: Make IssuesWidget occupy more space
Change-Id: I65397b4c0ff280c3bfe436d8aa2f42dc86fb301e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-29 07:25:52 +00:00
hjk
675e8a4757 TextEditor: Use new setup pattern for PlainTextEditorFactory
Change-Id: Iad3b8574a51db3baf6db74353e58968a2f6a4315
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-29 06:41:41 +00:00
hjk
d81fb53b74 TextEditor: Use new setup pattern for TextEditorSettings class
Change-Id: I8980f21a3ea156d45ab68bad66b94fbc5bbad641
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-29 06:40:10 +00:00
Christian Stenger
c734012298 Axivion: Implement basic fetch more functionality
Scrolling to the bottom of the displayed issues should now
try to fetch more issues.

Change-Id: Ic01cdcb7e96d2d0be2f51096a70fbb2299a6722d
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-29 06:21:12 +00:00
Tim Jenssen
b3b6794dc8 qmlpuppet: fix missing return
Change-Id: Ib92ab8e5b2787db125a317e6eae38e2602777fa4
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2024-01-26 16:35:08 +00:00
hjk
0d4b3b5196 Utils: Add a FilePath::isResourceFile function
Change-Id: I281e91bc24f5c32a5d64c31e73b7fc2f31cbade2
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-26 16:07:38 +00:00
hjk
bb7a50e16e Utils: Promote a local conversion function to FilePath::fromUrl()
Change-Id: I748cceb50084a29b971f31a8bd2ad7159738d7fd
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-26 16:07:31 +00:00
Alessandro Portale
f1787812e3 Core: Introduce WelcomePageHelpers::drawCardBackground
Pulled out of the ExtensionManager. It will also be used by
the Welcomescreen pages.

Change-Id: Ic5c67759e7f3af6a3b51968b7ae072c7058109b3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-26 15:21:14 +00:00
Mahmoud Badri
555552e10e EffectComposer: Fix clearing effect name upon starting a new project
Fixes: QDS-11780
Change-Id: I89a1d39a3dab18992b5fa8fae3f1340d42becac1
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-26 14:25:28 +00:00
Eike Ziller
9fd732712e Projects mode: Fix invisible tool bar above build system output
Amends d2500dc77b

For some reason, even if the title widget returns a size hint of height
0, it is still painted, but doesn't even reserve space in the layout.
So, the title was painted over the tool bar that we add to the dock
widget for the build system output in projects mode (in the right side
bar).

Set the visibility of the title widget in addition.

Change-Id: Ia00d73baba22294a57d689118565dc0fe3ee5617
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-26 14:12:22 +00:00
Alessandro Portale
2c45a3ffe4 Theming: Update of color tokens
Token_Background_Hover is gone.
Token_Foreground_Default, Token_Foreground_Muted and
Token_Foreground_Subtle were added.

Existing token colors were changed.

Change-Id: I9505ee54dd02f78bd722c0dcfe42ee6ae4e48d13
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-01-26 14:08:00 +00:00
Eike Ziller
cdef799321 Remove RestartDialog in favor of static function
The pattern was always to create the dialog and exec it, which can be
done as well with just a function call.

Change-Id: I3934cf5d869211713902abd333aa64d87ec59f32
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 13:59:14 +00:00
hjk
fca5c4fe96 TextEditor: Move BookmarkFilter class definition to .cpp
Change-Id: I6da2710afde7af153353e184de72df2325dc4644
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-26 13:50:08 +00:00
hjk
994e83b839 TextEditor: Move some functions from the plugin pimpl to the plugin
Since the plugin class is in the .cpp now pimpling is not really
useful, this goes a step into the direction of removing it.

Change-Id: Ia55d60749372d868a94884337f0e0f52ec2cc1b5
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-26 13:50:00 +00:00
Mahmoud Badri
33bbab25b6 QmlDesigner: Rename effect maker plugin files to effect composer
Change-Id: I1d09c1088b4067a479f2e7cc396a348f1b48614f
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-26 13:36:18 +00:00
Eike Ziller
bc145f2d36 ActionBuilder: Add documentation to adopt
Change-Id: I875ebac532a463572c4723e6973fd87ff27f4fe2
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 13:31:01 +00:00
David Schulz
73c03faa2d LanguageClient: add LanguageClientManager to object pool
instead of the language client plugin and make sure the same
functionality is still reachable from the outside.

Change-Id: Idff8db221e03afb4100c2e4879b7dfeb3e14e59b
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 13:12:23 +00:00
hjk
6218520b63 iOS: Move build configuration factory definitions to .cpp
Change-Id: Ia4a52e61488900fca013a50185ae534faa8816eb
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-26 12:58:53 +00:00
Christian Kandeler
79e323afbf Update qbs submodule to HEAD of 2.2 branch
Change-Id: Ibe9fab31e5dedac362aa469c6d2cd058015a6020
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-26 12:50:19 +00:00
hjk
7f061c723a CppEditor: Move CppHeaderSource implementation and test to same files
... and remove the now-empty cppeditorplugin.h

Change-Id: Ia28b180c280ba7b10ce0f2826f2ac69d128a453c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-26 12:44:53 +00:00
Christian Stenger
e71d16ef90 Axivion: Minor clean up
Change-Id: If2ed91a7778e18e25edb3bc05b0017e14b05fc27
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-26 12:36:57 +00:00
Christian Stenger
08e21a3346 Axivion: Refactor link handling a bit
Do the costly part only when necessary.

Change-Id: I9b884ee3411476e16569f09921409b33229de5e9
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-26 12:36:48 +00:00
hjk
109ec1e443 CMake: Hide CMakeManager implementation in .cpp
Change-Id: Ia66d73cd060d17c2d25a1d5b89155ab4e7a6b62b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-26 12:31:05 +00:00
Eike Ziller
acedf93ba3 Remove CommandButton
The same can be achieve with a factory method in `Command`, similar to
the existing ones for actions and buttons which synchronize their tool
tips with the shortcut.

Change-Id: I7e17654706b902dfa14f37b958fc2a60705d5cb5
Reviewed-by: hjk <hjk@qt.io>
2024-01-26 12:25:26 +00:00
hjk
34087df11e CppEditor: Move plugin class definition to .cpp
Also remove the globale instance variable which is not used anymore.

Change-Id: Ia054f79570b2fb650db31bd8560a08b0c9fe4c8c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-26 12:20:52 +00:00
hjk
9cc3988acd CppEditor: Remove some CppEditorPlugin member functions
Inline renameSymbolUnderCursor() and  switchDeclarationDefinition()
implementation on the caller side. Also use the widget that's known
there instead of the currentCppEditorWidget().

Change-Id: I158bef34234ce199accf25861062c97491bea381
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-26 12:16:52 +00:00
hjk
3c9238d29a CppEditor: Cleanup plugin header a bit
Change-Id: Ifff36ba362d8f9376936a46050e9a01f7b80a26c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-26 12:08:34 +00:00