... after opening a document with the x-shelscript mime type.
Change-Id: Ib98167fb4bbae144c359216f45aa22831079a12f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Some connects() in the CMakeToolManager ctor triggered accesses
to the s_instance there before it was assigned. Solve the issue
by moving the triggering code (CMakeKitAspect setup) out of the
class.
Change-Id: Ied0fc6b0b0eb87c29503ecb20e337289edecd203
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
If the DebuggerPane is closed while the menu is open / inside exec()
the final delete can result in an access violation.
Change-Id: Ie2694e209018f5a15d7fca203809b879fe184d3f
Reviewed-by: hjk <hjk@qt.io>
Mipmap effects need layer.smooth and layer.mipmap to work correctly.
Fixes: QDS-11793
Change-Id: I8f04ca9f144f51d0032d995c2bafdcb0c95ad73d
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
If imports are changed in transaction, the puppet restart should be
done after the transaction is completed, or the new types won't work
correctly until puppet is reset again.
Task-number: QDS-11811
Change-Id: Ie60945fbe9e7090b7fc27b55e1b6d23d5aa04a55
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
* If a column has both integer and real numbers, it will be considered
as a real type.
* The edit delegate for integer has no decimals, and it's limited to
integer range.
* Data types are ordered for the column editor dialog
Task-number: QDS-11675
Change-Id: I43364e8dddd3fc9c336723f4db337088ffdd97ed
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
And add a test to document what we expect from devicectl.
Change-Id: I2f5312ebadef60239b77308acb7114f1d55143b4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
No need to fiddle with whitespace manually (and make potentially invalid
assumptions about previously inserted code).
RefactoringFile takes care of formatting these days.
Change-Id: I6e566e6e4cd2a90b73c29365483b92f94e8c58ce
Reviewed-by: David Schulz <david.schulz@qt.io>
... of an "empty" line.
Otherwise previous leading whitespace will survive re-formatting.
Also reset the formatting cursors when setting a new change set.
Fixes: QTCREATORBUG-30244
Change-Id: I3fb8668b56c3823972d4acda8da9657fb0bbfe41
Reviewed-by: David Schulz <david.schulz@qt.io>
The key is a pointer type, so use QHash. Avoid double lookup.
Change-Id: I6c1c8e11b89256b550cda96b9128f8329470c7cf
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
And add a test to document what we expect from devicectl.
Change-Id: I395171bb5316c21b461a01dce5c9ec87d81fb0c4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
It can happen that this is triggered twice for the same device, or for
other devices when the dialog is still open. This looks funny and is not
necessary, so avoid it.
Task-number: QTBUG-121557
Change-Id: I0329104b3825b68b565ca1f8e00d785952c9d767
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reverts 6515f935d6 as this breaks
the dumper tests and moves the handling from the protocol to
the item, so this now only happens for the gui.
Change-Id: Ia15d5ead5c549585f4e90cc46d629961ea7d5974
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
This will allow saving effects when current document is saved for any
reason, including at application shutdown.
If effect is not yet saved once (i.e. it doesn't have a name yet), it
will not be saved in response to global save triggers to avoid
complications with requiring user input to provide the name.
Fixes: QDS-11436
Fixes: QDS-11446
Change-Id: I412ee4893e926d527b4f03f5f6c0c9b4e923bc1e
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Make updateEditorToolBar() a member of ClientPrivate.
Rename it to updateOpenedEditorToolBars() and operate
directly on m_openedDocument hash. In this way we avoid
2 calls to QHash::keys().
Change-Id: I0b1b9b89b20f9fdd185ea9a00d964514faeae0cd
Reviewed-by: David Schulz <david.schulz@qt.io>
