Commit Graph

88653 Commits

Author SHA1 Message Date
Alessandro Portale
8a4b3c0891 Icons Svg: Bump Inkscape version from 1.1.1 to 1.3.2
Let it have its way of partially rewriting the document.

Change-Id: I4ea3d6a5ae271356fe111bd5f5e9591d0f75b532
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-12 23:29:15 +00:00
Jarek Kobus
8e84809feb TaskTree: Add a special field for Repeat case
If the number of iterations is known in advance it may
help in calculation of total task numbers for progress
reporting purposes.

Change-Id: Ie36de67a4f3271820aca539afe0816974773a152
Reviewed-by: hjk <hjk@qt.io>
2024-01-12 18:16:09 +00:00
Jarek Kobus
db43e5d679 TaskTree: Introduce LoopUntil
In order to conform better with LoopRepeat and LoopForever.

Change-Id: Ic14cd072dc04951c0b142fd7379daf5541823a9a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-12 18:16:03 +00:00
hjk
d876123ff7 Cvs: Move plugin class definition to .cpp
Change-Id: Icb1e3644498c3e3acd26d88e87425f040132687a
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 17:49:04 +00:00
hjk
14ede71d62 CtfVisualizer: Destroy CtfTool earlier again
Amends 796053d7.

After all, the defaulted destructor of the class did some actual work
via the destructors of the QScopedPointer members.

Change-Id: If6dc8a3d57961ec263fced11f9fa9f7e9f8c54cc
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 17:48:59 +00:00
hjk
eeb8bf1ddf Android: Simplify SdkManagerOutputParserTest
And add the missing empty line.

Change-Id: I73d22c4e17193e04fe2aa405d348867a3cd8545c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 17:12:23 +00:00
hjk
8d6491e6ba Android: Have test class definitions closer to tested code
Change-Id: I92fbc2285a6d3f6d6b5e891f6727d5aa9778efa8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 17:01:38 +00:00
hjk
796053d766 CtfVisualizer: Convert to new standard plugin setup
Change-Id: Iaed31278cdbaf2933b325a3424d3c64e91f48d1c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 17:01:05 +00:00
hjk
bc14d32a8c CppCheck: Hide plugin class definition in .cpp
Change-Id: I960ec6e0e4d63cf0edf7af55d191ba666f44739b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 17:00:50 +00:00
Robert Löhning
db930b3c61 SquishTests: Update expected tree in tst_opencreator_qbs
Change-Id: I0b28b49bf2351ad37daf9702aaa1386b0c3514be
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-12 16:31:58 +00:00
hjk
a3bad897af CPaster: Hide plugin and service class definitions in .cpp
Change-Id: Ie1dd6362daea0de7dc363bb22cd7790374535387
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 16:10:50 +00:00
hjk
c90908dffb BareMetal: Add missing createIarParserTest() implementation
Amends b2bed13655.

Change-Id: Id6f1d5bd2f973fdb09f99f5be6629ae34ef77f01
Reviewed-by: hjk <hjk@qt.io>
2024-01-12 15:55:42 +00:00
hjk
39fc082472 CompilationDataBase: Hide plugin class definition in .cpp
Change-Id: Ib6c5f1a10479f8c27cc448c38fb5e3546f1e2239
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 15:18:17 +00:00
hjk
b2bed13655 BareMetal: Hide plugin test classes to .cpp
Change-Id: Idea4e2402eee0b3b0a4f3beba5f56b8e8020a34c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 15:17:55 +00:00
hjk
db2cfd175b Nim: Hide plugin class implementation in .cpp
Change-Id: I7f4bf2f46f1604c07e61d34d4d254801f356751f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 15:10:32 +00:00
hjk
4e4821cd05 Nim: Move parser test definition closer to the tested code
Change-Id: Ibc5b0ecd2258122155b72e95f4bd834897a0dbf1
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 15:10:25 +00:00
hjk
3abe587d42 BinEditor: Inline plugin and service classes in .cpp
I had to rename the BinEditor class as moc apparently
stumbles over the same-named namespace:

In file included from /data/dev/creator/src/plugins/bineditor/bineditorplugin.cpp:529:
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc: In member function 'virtual void* BinEditor::Internal::FactoryServiceImpl::qt_metacast(const char*)':
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:40: error: 'FactoryService' in 'class BinEditor::Internal::BinEditor' does not name a type
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:54: error: expected '>' before '*' token
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:54: error: expected '(' before '*' token
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:55: error: expected primary-expression before '>' token
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:62: error: expected ')' before ';' token

Change-Id: I736dc89c270f4245806792b0e350d7155f027a19
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 15:09:51 +00:00
hjk
f20782a945 GlslEditor: Hide GlslCompletionAssistProcessor implementation
Change-Id: I9eeed92396b9dab4b33aa23c015c744de1aacce0
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 14:55:02 +00:00
Ali Kianian
194a34a8f1 QmlDesigner: Move CollectionEditor functions to utils
- Collection editor functions are moved to CollectionEditorUtils
  namespace
- Collection import tools functions are also moved to
  CollectionEditorUtils. Also, the former files of import tools are
  deleted since their functions are moved.

Task-number: QDS-11391
Change-Id: I1ec1b2b7568658c1637a4c267989425189f07039
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-01-12 14:51:07 +00:00
David Schulz
22989d4d82 LanguageClient: fix compile with Qt 6.2
Change-Id: Iac02d004286641b95a6729c367c339bf94e70bed
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Mathias Hasselmann <mathias@taschenorakel.de>
2024-01-12 14:28:21 +00:00
David Schulz
83d2b82eb9 LSP: fix compile with Qt 6.2
Change-Id: Ia0b83166c9b859add450ae36001f3fa30cfb4b55
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mathias Hasselmann <mathias@taschenorakel.de>
2024-01-12 14:28:16 +00:00
Christian Kandeler
1e5212aa52 Update qbs submodule to HEAD of 2.2 branch
Change-Id: I31842bafbbc1dd391f694aef43a96ff861212a7e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2024-01-12 14:19:15 +00:00
hjk
f114df2bd3 Android: Hide plugin class definition in .cpp
It's not meant to be used from the outside.

Change-Id: I94e46f95f896fa4b44e77e0196523beb8afdf8c3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-12 13:56:41 +00:00
Shrief Gabr
191db5c9ae QmlDesigner: Fix data loss after saving collections
Task-number: QDS-11582
Change-Id: I69fbfbcebd880a4df1597bde25aac8372950cdfb
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-01-12 12:11:54 +00:00
Pranta Dastider
1e56f5d919 QmlDesigner: Update image in the Effect Maker document
This patch updates the old image to include the new topbar
in the Qt Quick Effect Maker document.

Fixes: QDS-11568
Change-Id: I90086b8fdb0f86947efcce40d2ef2171fa9b1c63
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
2024-01-12 12:01:43 +00:00
hjk
e04c11597f ClearCase: Hide plugin class definition in .cpp
Change-Id: I5ceea79b1c53b92cc141bf9be44803752e50f688
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-12 11:45:50 +00:00
Ali Kianian
208fa8f3e7 QmlDesigner: Select columns by left click on Model Editor
* HelperWidgets.ToolTip is replaced by ToolTip in order to prevent
mouse are conflict
* The content of the tooltip is updated by activation
* CollectionDetailsModel notifies changes on column type

Fixes: QDS-11591
Change-Id: I0b5e42b7a8656e3119f7ac60f6be78d6ca46e055
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Shrief Gabr <shrief.gabr@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2024-01-12 11:22:08 +00:00
Marcus Tillmanns
f33569bc80 TextEditor: Use FilePath::isWritableFile
Change-Id: I67850a4cb5f692765b0692a86252025e2fe64829
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-12 11:05:46 +00:00
hjk
ba8675d113 Bazaar: Hide plugin class definition in the .cpp
Change-Id: I5afde2006bdd8db0fe0b6b57a2d194db69011700
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-12 10:13:12 +00:00
hjk
cd2068e967 Axivion: Hide plugin class definition in .cpp
This is not meant to be accessed from the outside.

Change-Id: Ieae4d1ef760e1c6829ea8a1c2ae7945198198634
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-12 10:13:04 +00:00
Alessandro Portale
2a2772ba40 Utils: Add test case eventLoopMode to tst_Process
On Windows, Process::runBlocking(EventLoopMode::On) and
ProcessImpl::QProcess fails with ProcessResult::StartFailed.

Task-number: QTCREATORBUG-30066
Change-Id: I25317300023f4f7c16a8a62c4c3f1048482735a4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 10:02:25 +00:00
hjk
2047e64656 GlslEditor: Hide GlslCompletionAssistProvider implementation
Change-Id: I02a27e338cbbb149ed5d7883c87864de183f8b94
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 08:59:27 +00:00
hjk
3e3cf3f8a4 AutoTest: Hide plugin class definition in the .cpp
It's not meant to be accessed from the outside.

Change-Id: I0652ec8309e678a9b28e05acab6d0f77a0b13639
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-12 08:41:43 +00:00
hjk
bffd9a39b5 GlslEditor: Remove bogus global CompletionAssistProvider instance
This was never set to any editor.

Change-Id: Ia6397de67fdb02870e608c13a668f1a0be29c6e3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 08:33:19 +00:00
hjk
9cf58a5891 GlslEditor: Move shader file setup to GlslEditor
Change-Id: I2e8b3bc222ce0e0cfb79a96d90319e9cba44bac0
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 08:33:12 +00:00
Eike Ziller
fd4b8aa5a8 iOS: Fix provisioning profile check for "newer" devices
Before deploying we check if the provisioning information includes the
device that is deployed to. This suffers from the same issue as
QTCREATORBUG-21291: We use the USB identifier for the device ID in Qt
Creator, which cannot contain dashes, but the iOS hardware udid that
Apple uses can contain dashes (and the USB identifier then is that udid
without the dashes).

We need to use the iOS hardware udid when checking for the device in the
provisioning information.

Fixes: QTCREATORBUG-30158
Change-Id: I6f9e162ad6ece02370923ea59c046f439b8cc47a
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-12 08:10:36 +00:00
Eike Ziller
38da356153 ProjectExplorer: Do not create replacement kits automatically
Instead keep a list of "vanished targets".

These are shown in Projects mode in a separate list under the list of
kits. Via the context menus of those items (or with single-click), the
user can choose to either copy the steps of the vanished target to
another kit (already configured or not), or to create a new replacement
kit for it (similar to the previous replacement kits, with the same
device type and the steps restored, but no other parameters from the
kit restored - the project doesn't save that information), or remove
them.

The vanished targets are not removed from the project's settings as
long as the user doesn't create a kit or copy the steps, so if the kit
re-appears on a later run of Qt Creator, the original target is
restored for that kit and the entry in the "vanished targets" list
automatically vanishes.

This has the advantage that in contrast to the replacement kits, the
vanished targets are clearly separate from "normal" kits, and that they
are local to the project. Nothing is left behind after closing the
project.

Change-Id: Iccec04fea38cd55ff683665c9cf4edc9a2388c82
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-12 07:58:59 +00:00
hjk
052ea6d231 Python: Move highlighter and indenter class definitions to .cpp
Change-Id: Ib71d520977034ca66bd84c9188ffed5fe74e1ba0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-12 06:53:40 +00:00
hjk
460b1641e0 GlslEditor: Decouple shader file setup from plugin setup
Change-Id: I6c384970d2725ba4025be941a203e0732d78b073
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-12 06:22:51 +00:00
hjk
78ae3aad0a GlslEditor: New setup pattern for GlslEditorFactory
Change-Id: Id10dd541699160c699c7b39d05178560f25eebc5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-12 06:22:45 +00:00
hjk
1f1e31b4fc GlslEditor: Inline plugin class to .cpp
Not quite the standard setup yet, but getting closer.

Change-Id: Ifadc0b07b9d3f43381d5f49848c49bcc1d069861
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-11 17:28:55 +00:00
hjk
7f419fdf64 Insight: Inline plugin class definition into .cpp
Change-Id: Ic242139085bad644b98bd2355f8bf4b6796114dd
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-11 17:28:49 +00:00
hjk
3aee6b6985 ProjectExplorer: Move two json wizard factories closer to their products
... and clean up/modernize a bit and use new setup pattern.

Change-Id: Ie1b5f8da1fcc884a32869db2ce0f43e97e0f3aab
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-11 17:19:39 +00:00
Jarek Kobus
8487df5130 Process: Ensure the application is of QGuiApplication type
Checking the existence of qGuiApp isn't enough, since the
implementation just static_casts qApp to QGuiApplication.

The issue might happen in autotests if some function calls
methods of QGuiApplication. The autotests instantiate just
QCoreApplication by default.

Change-Id: Id384fb21b2a2ad66fac59bf5de35668ce50df1d1
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-11 17:16:24 +00:00
Pranta Dastider
fdcb29c711 QmlDesigner: Update image in the Managing Workspaces document
This patch updates the old image to include lock the views features
in the document screenshot. Also it updates the text description to match
the change.

Fixes: QDS-11562
Change-Id: I0e573be2f0e879bf4fb62a6f5120cd0b0aafa1d0
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
2024-01-11 15:16:42 +00:00
Pranta Dastider
f631c25d8b QmlDesigner: Update image in the Previewing Android Applications document
This patch updates the old image to include lock the views features
in the document screenshot. The image was updated from Png to Webp.

Fixes: QDS-11566
Change-Id: I28fc637a3fe78a8e82b6fb3474b1edb49a31c1ee
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
2024-01-11 15:16:06 +00:00
Jarek Kobus
a88dac86c0 ModelingLib: Avoid using keys()
Instead, iterate directly over the container.

Notably, sorting the result of keys() didn't play any
significant role in this contexts.

Change-Id: Iba82f3d503143ff0036509d0bf08c87747aeb40c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-11 14:30:41 +00:00
Jarek Kobus
b406bf36f5 ModelingLib: Hide areStackingRoles() in cpp
Make it static.

Change-Id: I05786425ade0d942b0e83349dc959a5dce72813e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-11 14:30:28 +00:00
hjk
792b1c5b3e AppMan: Inline plugin class definition in .cpp
Change-Id: Ib5ccfec0726497421d24e9892de822d7259bcd7a
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
2024-01-11 14:15:02 +00:00
hjk
1ab1ba02bf AppMan: Use new setup pattern for run related factories
Change-Id: I416d9a5f0b83770c7ef7673f499ed2f6b4529197
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
2024-01-11 14:08:56 +00:00