Commit Graph

88653 Commits

Author SHA1 Message Date
Jarek Kobus
96085f327b Coding rules: Add a note about avoiding sender() and QSignalMapper
Change-Id: Ifbc73b3c1e18484c692ee0e2a2999f2fe2e98f8b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2024-01-10 11:25:49 +00:00
Eike Ziller
b35f90d2aa Attributions: Do not use array for copyright
It is only supported for Qt 6.5 or later, but we still support earlier
Qt versions.

See qttools/687bbd584cc36fb8d213cb99a9098178e3701ce8

Change-Id: Ib186126c6b16fcf744f3ce1de9ee52c6b2a7aabe
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-10 11:23:37 +00:00
Christian Kandeler
69571427a3 CppEditor: Fix renaming include directives after bulk renamings
E.g. when renaming a class, the C++ model manager needs to know about
both renamings (.h and .cpp) at the same time. This way, it is able to
open the correct including file, even though the code model likely still
refers to the old, now-gone file path.

Fixes: QTCREATORBUG-30154
Change-Id: I583e77a4920c7cc3e642d7bebba46d734ae6bbe0
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-10 11:04:04 +00:00
David Schulz
9bcaf9ced9 ProjectExplorer: do not concatenate win debug messages
Individual debug messages got concatenated without a newline character
if multiple messages were received by the windebug interface thread
before they were handled in the main thread. The receiver of those
messages had no chance of handling those messages individually. This
gets fixed by using a list of messages instead of one concatenated
string.

Change-Id: Icfaf1b22db56829fcd143e574ee1033a63226c29
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-10 10:54:16 +00:00
Jarek Kobus
a6dea9091f TaskTree: Add static
Amends a50bc70b87

Change-Id: Ic0ea78fe8d9f74b50e4dc3310f3e17bdf520a5e8
Reviewed-by: hjk <hjk@qt.io>
2024-01-10 10:45:28 +00:00
Jarek Kobus
bc2faebe02 TaskTree: Reuse Repeat element in DataExchange example
Update the location of the target url so that it points to the
TaskTree wiki image.

Task-number: QTCREATORBUG-30081
Change-Id: Ic1c715c268b9e14711bc98415e747de8b75ed2dc
Reviewed-by: hjk <hjk@qt.io>
2024-01-10 10:45:21 +00:00
Jarek Kobus
ff46a9a8ef TaskTree: Reuse Repeat element in ImageScaling example
Task-number: QTCREATORBUG-30081
Change-Id: I281b6fe45c62045686ee215a5e03a5d8917a0282
Reviewed-by: hjk <hjk@qt.io>
2024-01-10 10:42:47 +00:00
Artem Sokolovskii
2d96d1a39f ClangFormat: Add parseConfigurationFile utility function
Change-Id: I7824e6bb77e9976aa212cdef478c4d40c4d8c56c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-10 10:26:51 +00:00
hjk
910126867d Squish: Use new setup pattern for SquishNavigationWidgetFactory
Change-Id: I44ac6a84f68b9b1fb22d9906921647e13d78de19
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-10 10:21:09 +00:00
Jarek Kobus
3f1a381c58 TaskTree: Add tests for Loop functionality
Task-number: QTCREATORBUG-30081
Change-Id: I999a5ea1fc887a2a5de6497acc3642abb187ef74
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-10 09:46:58 +00:00
Christian Kandeler
335c552bda Wizards: Always derive header guard from file name
Fixes: QTCREATORBUG-30140
Change-Id: Iad84bb49b26193f059f729009bc66832939f079c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-10 09:44:54 +00:00
hjk
cac955f2d7 TextEditor: Move OutlineFactory setup closer to new pattern
This is quite special due to the extra signal, but at least that's
hidden in the implementation now.

Change-Id: Id1130669fd1fdfb631d89460cfb884fb53858eec
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-10 09:41:32 +00:00
Jarek Kobus
52e0863bd2 TaskTree: Implement simple Loop functionality
Task-number: QTCREATORBUG-30081
Change-Id: I961d9c476d2af8742e461f92313ff0161d9de522
Reviewed-by: hjk <hjk@qt.io>
2024-01-10 09:38:15 +00:00
Jarek Kobus
a50bc70b87 TaskTree: Handle progress inside iterations
For temporary simplicity, take the strategy that only
zero-iterations (up to root) advance progress.

Task-number: QTCREATORBUG-30081
Change-Id: I7a0da2f141043622a07fa3e0cd03e3fb53417932
Reviewed-by: hjk <hjk@qt.io>
2024-01-10 08:56:02 +00:00
Jarek Kobus
1fe1055277 KitAspects: Avoid using keys()
Instead, iterate directly over the container.

Change-Id: Ie42136f29e5ddab8cd8da76e09616547187a2635
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-10 08:54:34 +00:00
hjk
00815e006d AutoTest: Use new setup pattern for TestNavigationWidgetFactory
Change-Id: I2d2c6f2a3dc8b416dae2e041f358a3f412216d4d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-10 08:22:40 +00:00
hjk
78a708f0fe Android: Move JavaIndenter class definition to .cpp
Change-Id: I0634062c22abfe592afb1be62616eaf05882519d
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-10 08:22:17 +00:00
Jarek Kobus
1610bb8ff4 TaskTree: Prepare infrastructure for iterators
Task-number: QTCREATORBUG-30081
Change-Id: I5ad78314445508f52c3fb2ab0fd696940fe7b6dd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-10 07:59:12 +00:00
Jarek Kobus
ebaa13e277 TaskTree: Fix typo in test cases
Change-Id: Ie65e68b61643a8de8eec8d039cd4f874ec6fdd1f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-10 07:58:15 +00:00
hjk
56ec7f8e69 LanguageClient: Use new setup pattern for CallHierarchyFactory
Change-Id: I1671498eb87f76a367cb52aa3dfd62c0b5ab7597
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-10 06:44:11 +00:00
hjk
317ca88e09 ClassView: Inline plugin class definition to .cpp
Change-Id: I0d9026fd2f6d98247eed2a44ab09ad7f1321ae64
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-10 06:40:50 +00:00
hjk
e87cd355d3 ClassView: Move setup of Manager class closer to new pattern
Change-Id: I2b836b839b1b082bdb6507082f689e2ef114eb9c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-10 06:40:44 +00:00
hjk
3873947c00 ClassView: Use new setup pattern for navigationwidget factory
Change-Id: I4e519d068c1ce85b6aee6e8743104703f6ddda8a
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-10 06:40:38 +00:00
hjk
31702189be Nim: Clean up some editor component creation
Change-Id: Ic14e7852b1cb6db47b689e59ad24b3d0eb9c4792
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-10 06:39:55 +00:00
hjk
941ebc84e9 ProjectExplorer: Use new setup pattern for ProjectTreeWidgetFactory
Change-Id: Id046dca1358547e21a2920eac62f5a694c7f6905
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-10 06:39:42 +00:00
David Schulz
76b61a7993 Python: register python infos to the kits macro expander
... and use the name in the autogenerated kits display name

Change-Id: I928533e6f8238189d64350463897a86ff5512ae7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-10 05:32:23 +00:00
Cristian Adam
7a46bbe667 CMakePM: Do not add files to utility targets
On multi-config systems CMake is reporting "ALL_BUILD" or "ZERO_CHECK"
as targets to add files to.

When issued from menu File > Add New ... the selected target is the
first target namely "ALL_BUILD", which is a utility target and cannot
have source files.

Fixes: QTCREATORBUG-30170
Change-Id: I7617978c01f0a2554a3ec7d52ef9baaa16ed7a84
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-09 18:21:26 +00:00
Jarek Kobus
8bfb6dbf35 TaskTree: Pass const ref into StorageBase c'tor
Change-Id: Ie915fbda3e3ac1b424c4dd5f4d25f2e3fad233c5
Reviewed-by: hjk <hjk@qt.io>
2024-01-09 17:04:33 +00:00
hjk
63374fb34d QmlJsEditor: Don't export Internal classes
Export two functions doing the actual work instead.
Centralize some repeated code.

Change-Id: I7de674ef7ae5537663d1227d36cc556c4ee3ed74
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-09 16:17:37 +00:00
Jarek Kobus
e98e5cc980 Android: Avoid using keys()
Instead, iterate directly over the container.

Change-Id: I722dcf811a112b1b4845dcbcd6efe78cfe3b2e49
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-09 15:14:26 +00:00
Cristian Adam
edb8b0aeb7 CMake: Add QTC_USE_LLVM_LINKER option
llvm-link is faster on macOS than ld64. llvm-link can also be used with
MinGW GCC's ld which is very slow in debug mode.

Change-Id: Ie519f3111e05cfc7dffab2676108a0d53ebe08b2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-09 14:28:12 +00:00
Marcus Tillmanns
a14cd5d702 Utils: Allow async CheckableMsgBox without guard
Change-Id: I76cb8dcb5aa89cc9b98410daeeeba668279c6e45
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-09 14:25:06 +00:00
Artem Sokolovskii
03bce22663 SyntaxHighlighter: Fix leaking
Change-Id: Icd9e6cb18facbcb28692db114b952e96a66e2836
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-09 14:17:57 +00:00
Artem Sokolovskii
0618df9ea2 SyntaxHighlighter: Connect signal to this not to document
Change-Id: I4e76c4e06f385075d64b9fee1eb71d6d5212935b
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-09 14:17:49 +00:00
Robert Löhning
72c0ff37fc SquishTests: Expect symlinked compilers
e.g. /usr/bin/clang links to ../lib/llvm-14/bin/clang
on Ubuntu 22.04.

Change-Id: I6facd3126045036124e6c79ee83bc7575cbb02d7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-09 13:33:12 +00:00
Cristian Adam
7fdfc2ac1d Auto-Setup: Forward CMAKE_MSVC_RUNTIME_LIBRARY to package manager
Fixes: QTCREATORBUG-30169
Change-Id: Icfbb497e067c5a5a4b57e91c9fa50bc0a2816bc3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-09 13:05:04 +00:00
Marcus Tillmanns
fcb752ff9c Utils: Add async methods to CheckableMessageBox
Change-Id: I296cb34453f5c12f712afedfe35b8962be8d7eec
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-09 12:59:20 +00:00
Leena Miettinen
c01129828f Doc: Split up "Refactoring" and "Applying Refactoring Actions"
Replace "refactoring actions" with "quick fixes", as they are
called that in the UI.

Task-number: QTCREATORBUG-29361
Change-Id: I6952bb1b222c340a6bccb175733c611907885a47
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-09 12:54:34 +00:00
hjk
cca5f07d35 GlslEditor: Move some class definitions to .cpp
Also, de-Q_OBJECT-ify GlslHighlighter and a bit of code cosmetics.

Change-Id: I17469acc950fc77055f68918b1362f01e8a8c8a3
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-09 12:41:06 +00:00
Marcus Tillmanns
060d4faed7 Terminal: Fix nullopt access
Fixes: QTCREATORBUG-30144
Change-Id: I9479d4cbfd8f930f405409c1c3f5252d23cca2da
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-09 12:02:52 +00:00
Marcus Tillmanns
99078778cc Terminal: Fix selection warning
When quickly selection text via double-clicking and moving the mouse to the left
it is possible that a selection is created where the start == end.
This was incorrectly reported as a warning.

Task-number: QTCREATORBUG-30144
Change-Id: I37b22f4ee725e5085ce0090c123ccfd9980b8a59
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-09 12:02:43 +00:00
Leena Miettinen
32e6f73119 Doc: Split "Completing Code" into several topics
Task-number: QTCREATORBUG-29361
Change-Id: Icbface3923c3d56ed54d53dc1e614f02269c30b2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-09 11:48:09 +00:00
hjk
a0ea8d4283 Appman: Add a appmanagertr.h
To be used as Tr::tr()

Change-Id: I473a44e70cbe745a4d60ee750ebcf87b5051f4ee
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-01-09 11:42:26 +00:00
hjk
7942c36ace Debugger: Fix passing of solib search path
Amends 92f7da917e.

Also, set it in all branches, not just remote execution, even if this
is the primary and currently actively used way.

Change-Id: I35149bd29b49dab419f83ec0cb424ae9b23827ed
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-09 11:42:10 +00:00
Eike Ziller
07a0ced947 TreeModel: Remove unused function overload
9124833a63 introduced an optional
parameter to removeChildren to suppress signal emitting, and
a61f9162f1 reimplemented that in a ABI
compatible way with a new removeChildrenSilently method instead.

The code now uses removeChildrenSilently, so the parameter to
removeChildren is no longer needed.

Change-Id: I8411d80f90e83b8746c2553dddb41c3f40a2bfc7
Reviewed-by: David Faure <david.faure@kdab.com>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-09 11:14:26 +00:00
Jarek Kobus
33ef73daf9 QtVersionManager: Make qtVersionsChanged args default
Change-Id: Ifb420ebdeefe18114f82c48c2c4c49d808caef0c
Reviewed-by: hjk <hjk@qt.io>
2024-01-09 10:57:34 +00:00
Jarek Kobus
1c8e88651c Squish: Avoid using keys()
Instead, iterate directly over the container.

Change-Id: I3fd55988fd3351f738e07c3b0611872279d929b4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-09 10:44:04 +00:00
Alessandro Portale
c4e938b407 Android: Resuscitate the "Configure Android options" InfoBar entry
The restoring of Kits was moved to a later stage of the startup
sequence. That is too late to connect to ICore::coreOpened.

This change calls askUserAboutAndroidSetup directly instead of via
connection.

Fixes: QTCREATORBUG-30131
Change-Id: I9b33df42177de05f2f9132ff3126fe03ffb8df20
Reviewed-by: hjk <hjk@qt.io>
2024-01-09 10:33:48 +00:00
Christian Stenger
d358589004 LSP: Fix building with Qt less than 6.4
Change-Id: I25f8be3a256328443dd42d72d05ce5b6b717bded
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-09 09:35:38 +00:00
Jarek Kobus
7b32c47494 QMakeProjectManager: Avoid using keys()
Instead, iterate directly over the container.

Change-Id: I589e87b0ed86be778aec7679bedab28d709a7697
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-09 09:34:07 +00:00