Rename the list overload. Make the single item overload use
the direct path to insertItem, hook the column resize requests
to the showing/hiding of the watchers pane.
Change-Id: I0a1940c8e1919341a815e6bccbcf55d989d663da
Reviewed-by: hjk <hjk@theqtcompany.com>
The only information ever used is whether it's c++ or not.
Change-Id: I4ca00663856dd66cbdf58c468f175a8c9e41d6a5
Reviewed-by: hjk <hjk@theqtcompany.com>
Only needed in the non-Python days. CDB didn't use it to start with.
Change-Id: Ia609218cc1a694f797e278c4d99ead68e6212938
Reviewed-by: hjk <hjk@theqtcompany.com>
The removed parts were only used with the non-Python engine.
Change-Id: Ia6858517b011c6f7ace8b2521beafdb4b03efc89
Reviewed-by: hjk <hjk@theqtcompany.com>
We don't need the remove/re-insert cycle in the new model,
so the expression modification can be done directly.
Change-Id: If9626f48fcfbcf75e61d332afb59b986da6c2dbc
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: hjk <hjk@theqtcompany.com>
This broke window recalculation when the window was clamped
against the trace end.
Change-Id: I6c62e1440476ea9e36b08a2edd3e0c3bb2dec931
Task-number: QTCREATORBUG-14105
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
... and replace at caller side it with the used parts
of the code.
Change-Id: Id612c66ac6d95bfc12aba16e9247cc81991dd779
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: hjk <hjk@theqtcompany.com>
There was only one user on GdbEngine::insertData left, and this
always took the !isSomethingNeeded branch.
Change-Id: Ibe51f7a7689be39ad3ffd60099a9cbe7b614648a
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
-> Renamed to diffSelectedRows()
This allows to use easily Qt5 connects, without ugly casting to
pick the right overload
Change-Id: Ifaa0242febccb4e1aadd53470cc4b3be79b07c18
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
(cherry picked from commit 12fac12e8f)
It's not really used for inheritance, so the virtuality of
everything was over-engineered.
Also remove the duplicated connection to QSpinBox.
The "cooked" connection was useless (and arguably wrong).
Change-Id: I917124d690b37166bb38ddd5399f11ec43a14f16
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Seeing an ill engine while trying to stop means that the stop failed.
Also, a finished master engine doesn't need further updates.
Task-number: QTCREATORBUG-14089
Change-Id: Icd5b090dfcdc0875953d8756a909b1405e05f71f
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
This was a regression introduced by the migration of the WatchHandler
to the new tree models.
Task-number: QTCREATORBUG-14098
Change-Id: Id97c3927e7e19d501a8e7e01e12b28ffe2a66c68
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Causes more confusion for users than actual trouble. A hint is
still left in the debugger log, so it's not completely gone.
Task-number: QTCREATORBUG-3918
Change-Id: I51244094811bcb5c436f0631cb02dbf41cc202bf
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
This also removes some of the "illegal" state transitions,
partially addressing QTCREATORBUG-14089.
Change-Id: I817d87a0b5e0a40285bc9b0880fef5bceaee3f16
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
This also deduplicates the validity checks on MIME magic data
Change-Id: I0ce0df61ca4459b3e1190f75b778abd04bc908bd
Task-number: QTCREATORBUG-13987
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
When starting the QML profiler for the first time there is no saved
state and the V8 view was shown by default because of the way the
dock widgets are created. This is not very useful.
Change-Id: I5f8873405b3ebc0683ce8d578466631499932c08
Task-number: QTCREATORBUG-14060
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
The details table can become quite large, so we elide the text.
However, as we don't know what kind of information we're hiding and
the user might want to see it it's quite practical to allow resizing.
Also, make sure that the detail window (and the range window) is on
top of everything else so that it can set the cursor shape.
Task-number: QTCREATORBUG-14054
Change-Id: I12850124c327c57c148b69960687b7402bdead90
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
... prominently with red color in the log.
Change-Id: Id9d86227bbcc269a0870ff93e372f28ab4b2618b
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
The secondSlaveEngineType was not really used, and the first
either NoEngineType or identical to the cppEngineType.
Change-Id: I1725728ca38636f228ff9b9d8ca7d643a34c64e8
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
As of Qt 5, the Qt Designer integration no longer relies on
private Qt Designer headers.
Change-Id: Ib2909e856232491e9067ccc9cad6df86e9da086b
Reviewed-by: hjk <hjk@theqtcompany.com>
New %{Debugger:Name} for global use, %{Debugger:{Type,Version,...}}
for expansion within the name. Also re-initialize from file if the
saved version is empty (e.g. if the debugger was registered before
the version field was present)
Change-Id: I45568d78147597b30074a2ce4ddcf569bce15192
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
...on OSX to make it possible to enter and leave with the same
shortcut. Adjust user command mapping as well to be able to
execute these from inside FakeVim mode as well.
Task-number: QTCREATORBUG-14082
Change-Id: Ib93f798a61b4ed16db7cca7b3c927e1fb6bd5d0f
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
QtVersion::hasDebugBuild() and QtVersion::hasReleaseBuild() don't work
as one might expect.
Task-number: QBS-757
Change-Id: I1f591750761c76a6d064f4e489ee21a6e1683ec6
Reviewed-by: Oliver Wolff <oliver.wolff@theqtcompany.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
