Commit Graph

86167 Commits

Author SHA1 Message Date
Dominik Holland
03acd8f109 AppMan: Enable debug support only for the "qml" and the "native" runtimes
Change-Id: I6858bebe172a8a4b0694b335eeaeb03e1404e8b0
Reviewed-by: hjk <hjk@qt.io>
2024-01-17 15:04:32 +00:00
Dominik Holland
1d4d9703a8 AppMan: Remove AppManagerMakeInstallStep
Change-Id: Ia14b925f513da507bda80ab4a4fc39b6e6deded7
Reviewed-by: hjk <hjk@qt.io>
2024-01-17 14:55:31 +00:00
Dominik Holland
16e6c8dcb9 AppMan: Fix getToolFilePath to return the correct tool path
Change-Id: I790d2b231b84ef55a0ae5e9502e29a6337e83db8
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-17 14:55:13 +00:00
Dominik Holland
4c52ed979e AppMan: Remove circular stopDependency in the DebugSupport
This prevented the debugger to stop correctly.

Change-Id: Ie7aab0d62662c03f8ad6bb6c3b49d590a127fa68
Reviewed-by: hjk <hjk@qt.io>
2024-01-17 14:55:02 +00:00
David Schulz
03958b5806 CppEditor: avoid endless loop in symbol name lookup
Passing and empty text to QString::indexOf returns a 0 index and we
advance the start index by the length of the symbol name so we check
again from the start. Just assert if we pass an empty symbol name to
symbolOccurrencesInText and return an empty list of occurrences to avoid
this.

Task-number: QTCREATORBUG-30155
Change-Id: I6ad672a3dc2ae9d937fdc436874d07c00997fbf5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-17 14:20:00 +00:00
Marcus Tillmanns
f5934d69de QtSupport: Remove dead code
"SourcePath" was meant to be set by the installer to make it easier
to find the installed source folder for a specific Qt version. This was
never implemented in the Installer and a workaround was later
created for it.

This patch removes the dead code.

Change-Id: I1c2f5c10e37a7df4643327d1071db9e2e62c8212
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-17 13:50:19 +00:00
David Schulz
45ef64f4f9 Python: fix venv check
FilePath::contains only checks whether the passed string is inside the
path, and not whether the path contains a folder or file with the passed
string.

Change-Id: I20a1a9a52a9f9a436433848ac2eccd38666274d7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-17 13:33:47 +00:00
Jarek Kobus
443ce8e164 Process: Get rid of ProcessInterpreter
Move it locally to the only one user: VcsCommand.

For the future similar usages: use ProcessTask
and tweak the DoneResult inside TaskDoneHandler.

Change-Id: Icdffee7f1963f3ff377bfa6309e14bd1862a2c1f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-17 13:27:55 +00:00
Jarek Kobus
6042f6fde4 VcsCommand: Interpret exit code locally
Don't pass it to the Process instance.

Change-Id: I0891f85414d52cdab1f95cc3f37610ebe06a5955
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-17 13:27:47 +00:00
Jarek Kobus
312e50d29b Process: Introduce exitMessage() helper
This is going to be used for tweaked process result.

Change-Id: I1e4117dcd6145e4748a55c285b2546974a6e7d00
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-17 13:27:41 +00:00
Cristian Adam
d5a5088996 QtSupport: Increase QtVersionData's version to 3
Qt Creator 12.0.0 has created presistent storage with empty QtAbis list.
Qt Creator 12.0.1 has fixed this issue.

By increasing the version number to 3 we force the saved data from Qt
Creator 12.0.0 to be recreated, and thus fix Android issues with empty
QtAbis lists.

Also make sure that an empty QtAbis is loaded.

Fixes: QTCREATORBUG-30208
Change-Id: I89a9a1ff810304127ff0387b80cb9a13f9740538
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-17 13:27:12 +00:00
Cristian Adam
7fa70da159 PE: Set Android ABI to the Abi object instantiation
640a4f0c9c introduced caching of qmake
output, which includes the supported abis.

Unfortunately the Abi::toString and Abi::fromString didn't serialize the
m_param value which was used by the Android plugin to specify the
Android ABI.

This commit will generate the Android ABI from the existing values.

Fixes: QTCREATORBUG-30146
Change-Id: I6770faa3953f7b423b36b9e3654a7e270d051571
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-01-17 13:26:49 +00:00
Jarek Kobus
4c0541ce2f CtfVisualizer: Reuse TaskTreeRunner
Change-Id: If893cdd260943a5e72b05595f15c3133e4340f8f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-17 13:14:01 +00:00
Jarek Kobus
0f67bbf872 Android: Reuse TaskTreeRunner in AndroidSdkDownloader
Change-Id: I3fca36d2cab44212d6a18daba68b7d27bf35b078
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-01-17 13:13:49 +00:00
Artem Sokolovskii
34e537a063 ClangFormat: Fix formatting for LineEnding CRLF
Change-Id: I10abc07f5d178a7114faba7174ea1bfc80965174
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-17 13:13:35 +00:00
Yasser Grimes
5aeeb74488 McuSupport: Support prioritizing import paths
Some QtQuick import paths in QtMCUs contain incomplete modules and
Used for other purposes but it shadows the correct import path

With this patch it will be possible to reshuffle the import by any
import provider

Fixes: QTCREATORBUG-29681
Change-Id: I5a17df6ca2587ae88643b1ca08f9e84998d51cc2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-17 12:37:32 +00:00
Dominik Holland
1d2ed65d93 Create RunConfiguration specific QmlProfilerWorkerFactories
Instead of relying on the QmlProfilerRunWorkerFactory to match for all
RunConfiguration, every plugin needs to create a WorkerFactory for
its own RunConfiguration.

Similar to the SimpleTargetRunnerFactory there is now a
SimpleQmlProfilerRunnerFactory which makes the setup easy.

Change-Id: I504ca5afe232cb4e3aa0bb0b67271637a7e7a9d0
Reviewed-by: hjk <hjk@qt.io>
2024-01-17 12:34:59 +00:00
hjk
fca33684a7 TextEditor: Simplify setup of line number filter
Change-Id: Ida977fc959f3fe6052151ba8e2461a64699d0a41
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-17 12:00:21 +00:00
hjk
a5d165aa82 TextEditor: Setup TextMarkFactory more canonically
Change-Id: Iaa360615c47ed7c4c3e2ace95ad53006e99aa2d0
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-17 11:59:46 +00:00
hjk
a9621ef1fd TextEditor: Hide plugin class definition in .cpp
Change-Id: Ib796333a0c46311fbead63de0e4562918d14a59f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-17 11:59:38 +00:00
hjk
f662009bca TextEditor: Move test setup closer to tested code
Change-Id: Ib6edee42b20830a322d47fc1ba071d3cdf2d7538
Reviewed-by: David Schulz <david.schulz@qt.io>
2024-01-17 11:59:26 +00:00
Pranta Dastider
0500a9e547 QmlDesigner: Update image in the Materials document
This patch updates the old image to include new top bar
in the document screenshot. Also it updates the old material
editor image to include more context to it.

Fixes: QDS-11563
Change-Id: I3e9c064702b50ce0a22628f1a12c28c2dbb1d0eb
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2024-01-17 11:30:13 +00:00
Shrief Gabr
1085c6fd6b QmlDesigner: Fix edit property dialog clipping issue
Task-number: QDS-11539
Change-Id: I32079b3778dc16bace63eeb29770e93f5def79e8
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-01-17 10:52:17 +00:00
David Schulz
e93948228a LanguageClient: Fix npm installs for newer npm versions
We used the bin command line parameter for npm to get the path to the
runnable cmd inside the install location, but it seems this command is
missing for newer npm versions. Just check the default install location
and fall back to parse the npm list output in order to find the language
server path.

Change-Id: Ie144b061552c4a26fa6d54b232cef308669f7dbd
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-17 10:44:44 +00:00
Dominik Holland
c81efc39c8 Create RunConfiguration specific DebugWorkerFactories
Instead of relying on the DebuggerRunWorkerFactory to match for all
RunConfiguration, every plugin needs to create a WorkerFactory for
its own RunConfiguration.

Similar to the SimpleTargetRunnerFactory there is now a
SimpleDebugRunnerFactory which makes the setup easy.

Change-Id: I25aaabcd70f7ac649baeab4eb4c7e88d53dac91e
Reviewed-by: hjk <hjk@qt.io>
2024-01-17 10:17:41 +00:00
Thomas Hartmann
b47e074f62 QmlDesigner: Add QML source
This adds the QML source for the Qt Design Studio Welcome page.
The source code was private before.

Change-Id: I5dcb900ed9a17b1bc3bbcaf50f649ebeb61cc8bf
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2024-01-17 09:46:02 +00:00
Shrief Gabr
3afe85fff8 QmlDesigner: Suppress datatype warning when creating new column
- Ignores datatype warnings for cells with null values and cells with Unknown datatype

Task-number: QDS-11645
Change-Id: I0f0247bcfcbd8bd2a7377e587351c1a984c269be
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-01-17 09:41:47 +00:00
Christian Stenger
5af310b4fb Doc: Update AutoTest plugin documentation a bit
Update information regarding wizards provided by the
AutoTest plugin.

Add a note for the missing wizard for adding Qt test
based test cases.

Task-number: QTCREATORBUG-30139
Change-Id: I33a3e176e8debcdff05d0183f3ad890996316584
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2024-01-17 09:31:21 +00:00
Jarek Kobus
33fbcf992d AutoTest: Reuse TaskTreeRunner for test scanner
Change-Id: I19db6d28c9d68e1394f089b7a58640db153cd7e9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-17 09:30:27 +00:00
David Schulz
0082cda044 TextEditor: Fix crash in SyntaxHighlighterRunner
Do not delete the pimpl before the thread had finished.
amends e4f5a0f50b

Change-Id: I3c0a27bd709ea759797e23f7e04e04a076012c3b
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-17 08:46:36 +00:00
Jarek Kobus
719d0f8335 Process: Rename processutils.{cpp,h} into processhelper.{cpp,h}
Make room for processutils.h which is going to contain
the exported stuff.

Change-Id: I87498c3a1d0708210aa970e2d45adaa0adb6e76a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2024-01-17 08:42:59 +00:00
hjk
87b040d852 SerialTerminal: Hide plugin class in .cpp
Change-Id: I9d1a179a9de4f0e95fe60b62b91743c540534246
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-17 08:30:04 +00:00
hjk
fdf1ad4ff8 Subversion: Move plugin class definition to .cpp
Change-Id: Idfbb9d59b6106054ee3541ab7b5cf393be285e21
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-17 08:29:53 +00:00
Sami Shalayel
17b64c7ccd qmldocumentparser: adapt to changes in Dom for Qt 6.6
Add an if-guard so that it compiles for both 6.5 and 6.6.

Change-Id: I0d539c8b6b193218786dce33ac2a7f386209b622
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2024-01-17 08:27:13 +00:00
hjk
9d72867ab6 ResourceEditor: Hide ResourceDocument class definition
... and simplify setup a bit.

Change-Id: Ib9aedbf9ed8449d76e2e6ceb7b4cc9063e4756ea
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-17 08:22:47 +00:00
Jarek Kobus
b5b356c680 AutoTest: Reuse TaskTreeRunner for test runner
Change-Id: Ifa0c4a6eee106ce4da6b588ad10b85d46e21418d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-17 08:10:33 +00:00
Jarek Kobus
b163f58305 AutoTest: Merge group setup with process setup
There is no need to have 2 separate handlers.

Change-Id: Ifb42d939b68abfb5a5e38c8aa6a8f9c7a262de9d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-01-17 08:10:03 +00:00
Jarek Kobus
185454bc9b VcsBase: Use more Core namespace
Drop also some Utils:: specifiers.
Drop superfluous typedef.

Change-Id: I0cb12fb3fe9336ca44849198db291dfbe278df4a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-17 08:07:49 +00:00
Jarek Kobus
f917905f30 VcsBase: Remove OutputWindowPlainTextEdit::parser()
Change-Id: I064b15708a9bacf92e83122021764df9b276995f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-17 08:07:42 +00:00
Jarek Kobus
af70c06f86 VcsBase: Merge appendLines() with appendLinesWithStyle()
Remove m_format member.

Change-Id: Ie643985a07e258f8f326e44e106f7a711d6d2967
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2024-01-17 08:07:36 +00:00
The Qt Project
ba2c95ce99 Merge "Merge remote-tracking branch 'origin/12.0'" 2024-01-17 08:06:06 +00:00
Eike Ziller
5395cc9b2c Merge remote-tracking branch 'origin/12.0'
Change-Id: I42e2cd3e14d9570c94ed2f5eb13d688191144767
2024-01-17 09:05:44 +01:00
Marcus Tillmanns
69bbfee3b8 LanguageClient: Fix wrong class name
Change-Id: I8a1d87c3f1140ba2172efd3d1a1cca40186b31dc
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-01-17 08:05:04 +00:00
Henning Gruendl
316e48fc50 QmlDesigner: Remove version number from imports
Task-number: QDS-11177
Change-Id: I94a537af1d55d503aa04dd79c6194ef1a0647e83
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2024-01-17 08:01:32 +00:00
Henning Gruendl
3ad3a5f197 QmlDesigner: Remove unnecessary imports
Remove QtQuickDesignerTheme import if not needed.

Task-number: QDS-11177
Change-Id: Ia72001855bb636bfc2ddf11cbb00359fbe123c90
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2024-01-17 08:01:09 +00:00
Henning Gruendl
00319468a6 QmlDesigner: Fix PopupDialog being obscured
Fix the PopupDialog being obscured by detached views.

Task-number: QDS-11657
Change-Id: Ifc0022159a65a110b6e7a25e442a41e3db692c14
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2024-01-17 08:00:45 +00:00
Jarek Kobus
24ad9e7056 DiffEditorController: Reuse TaskTreeRunner
Change-Id: Id294ce5f951c3c9f4a651d7fa52a021f507cba02
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2024-01-16 19:34:53 +00:00
hjk
956d6d1c45 ResourceEditor: Hide plugin class definition in .cpp
Change-Id: I43969235a6003cfa800c621447d6c754bbad4262
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-16 17:35:35 +00:00
hjk
a7bf47bf49 ResourceEditor: Move ResourceEditorW definition to .cpp
And simplify constructor.

Change-Id: Ib0526f468aed0604a6b71ac180c02e408318f4ce
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-16 17:28:35 +00:00
hjk
fc36218d39 ResourceEditor: Move editor action setup closer to editor
Not yet business as usual, but moving closer and cutting some
dependencies.

Change-Id: I6331b256cbbde0abcc67251b1d32521f234fca2b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-01-16 17:28:31 +00:00