This should improve results of CI tests where multiple creator instances
execute the plugin tests.
Change-Id: I557a0964568655662108df201589ba369096f4bf
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Now adding a new include directive by the refactoring action will cover
more cases.
This will also help us to simplity the corresponding tests, since it is
not necessary anymore to create actual files.
Change-Id: Id7612b13c392735d6ae1fb2ce3c36169eff3628e
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>
For the case that the document is based upon another one (see
Snapshot::preprocessedDocument(), the only client of FastPreprocessor)
the FastPreprocessor added extra unresolved includes.
Change-Id: I0a7719fa8806af59f87a48bc6914270efd653e84
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>
The idea behind NodesWatcher was that it was the central place
to catch node related signals, so that users didn't need to
connect to each individual node and the nodes didn't need to
be QObjects. Somehow Nodes ended up being QObjects anyway.
Both the recently added ProjectTree and the FlatModels consume
the signals the NodesWatcher sends. Unfortunately there's a
ordering dependency between the ProjectTree and the FlatModels.
This patch removes all NodesWatcher and instead makes the
ProjectTree singleton the emitter of various project tree
related signals. The ProjectTree also ensures that the ordering
between the FlatModel and itself is taken into account.
And it makes Node not derive from QObject, saving some memory
in that process.
Task-number: QTCREATORBUG-13756
Change-Id: I8b0d357863f1dc1d2d440ce8172502594138b9fb
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
On 64bit machines it should now have 48byte instead of 64.
Change-Id: I7a171864244e8faf26a2cf3c32abe9e705837fa3
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Using a (local) widget derived class for the main page all
keeps the .h cleaner and removes the need for the custom
model plus related signaling.
Change-Id: If1b118b56cc1cd06d459fd5491de673e2436dd77
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Clang 3.5 runs out of memory when trying to optimize
tst_Dumpers::dumper_data. So don't optimize.
Change-Id: Ic81aa6e491e132ee04bb51e9d443e836b5a7635a
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Take 2
Task-number: QTCREATORBUG-13757
Change-Id: I9c2558bf01121e53710db984a99d37c2c6cafaf4
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
Qt Creator has been showing them as errors, but they're little more than
noise in the output.
Creator still doesn't understand "remark" lines from ICC, but that's
something for another day.
Change-Id: Ic894fe41f92a677ddbe09beb0ea4c557edeb0547
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
The OutlineStackWidget stored its position in the outline to be able
to save/restore settings specific to the sub-widget (IOutlineWidget).
However, the index can get out sync if another NavigationWidget
with a lower index number is split, and the relative position changes.
The change therefore avoids saving an index, and rather keeps the sum
of all sub-widget settings in a QVariantMap, only reading and writing
to the global settings object if necessary.
The settings are also not stored in the [General] section anymore,
but in a subgroup [Sidebar.Outline.X], where X is the index of the
outline in the view. This avoids having to always iterate over all
keys. No effort has been made to take over the old settings. I doubt
anyone will notice, though.
Change-Id: I85017cbb3e32b0a16da43ce6339deb7a053d6b09
Task-number: QTCREATORBUG-13614
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
Make DeployConfigurationFactory a true base class. Introduce the
DefaultDeployConfigurationFactory as the implementation that
actually creates DefaultDeployConfigurations.
This mostly moves code around. The virtual canHandle method was
mostly unused and was removed from most classes.
Change-Id: I170d94c648e67f3fe52a76ffb5344f389ae49efc
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Make Vcs actions active again when a project is opened but no
document is open.
Task-number: QTCREATORBUG-13609
Change-Id: I3d5accc3dc65412b1af5fc8c6a2baa9ac97c6e25
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
ProjectTree::currentProject is not the right project to track.
Change-Id: Ia9da32a24e73565c4b9a3739c4000c13b803375f
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@theqtcompany.com>
Two major areas of improvement:
- Make connections last, so that the initial setup does not trigger any
unnecessary checks.
- Make fetching the list of android virtual devices a background
operation.
Together they reduce the time needed to open the settings for me by
roughly 10 times.
Task-number: QTCREATORBUG-13735
Change-Id: I0839853dcdbdfe20a183a27888e55d3c56a9b815
Reviewed-by: BogDan Vatra <bogdan@kde.org>
ProjectTree::currentProject was changed, update the code to
get the old behavior.
That behavior is most likely not the best to have, but that
is for another patch:-)
Change-Id: I8c84825443b8383f738c237ec67332e62199fe5e
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Collects all included files from any file of any project or
that is open in an editor. It has the same shortcut as the
files from any project filter and is also enabled by default.
Task-number: QTCREATORBUG-280
Change-Id: I7cd89ee68d2f8ec4e0ea03de0c11671f489c47dc
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
Make it possible to set or clear the file iterator while a search is
currently running.
Change-Id: I5309a8920057112375ce22e5fd24806fb6f09857
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
It was incorrectly updating cached results, so e.g. shortening the
search string was not forcing a new search.
Change-Id: Ie55fce72b7363258195423f5686f013aeafc7d57
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Also make a bit less dependent on main window:
- Menus do not need to start with main window as parent.
- Centering the presentation label on the main window is wrong in the
presence of extra windows anyhow. It should be centered on the active
window.
Unfortunately, actions still must be added to the main window, because
actions that are not children of visible widgets do not trigger.
Change-Id: Ibb99644a3723de476db465ebe6a9cdc0820ea692
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
The new layout that was supposed to give especially the files list more
space looked very unstructured with the different boxes in different sizes
everywhere.
Vertically align the description edit and file list. Even though it gives
the header much horizontal room, it has fewer visual breaks. Also use
MiniSplitter.
Change-Id: I62699d2b9e9142b9d2c3d01f29db9a3b49b79b00
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
