Commit Graph

58212 Commits

Author SHA1 Message Date
Nikolai Kosjar
da28d40030 TextEditor: Add more space before TextMarks' tooltip actions
Change-Id: I6331d60026da865f29c5ed2455f2399414f99900
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-02-15 14:15:56 +00:00
Eike Ziller
2bebfe9985 Help: Add fallback word lookup for context help to base text editor
If we do not have a hover handler, or that did not produce any result,
use the word under cursor and try with that.
This adds at least some help fallback mechanism to all text editors,
e.g. we get some context help (though a bit crude) for Pyside
"for free".

Change-Id: I1b6d91ad6f46bfd12e242b1aec9f4fcadae23403
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-02-15 14:06:50 +00:00
Christian Kandeler
b1e1c91e04 Update qbs submodule
To HEAD of 1.13 branch.

Change-Id: I1270f52a4a3ade4a9053c4b6d111b8de6b93243f
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-02-15 14:03:17 +00:00
Robert Loehning
28a14b5617 UI Tour: Fix plural
Change-Id: Ib84f8acda7701c5fb8efc29035c31ab047573e40
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2019-02-15 12:49:53 +00:00
Alessandro Portale
603191ba77 Application icons refresh: Qt Creator == "QC"
This change replaces the existing application icons with the newly
designed ones.

Task-number: QTBUG-70826
Change-Id: I379ac8b5f64c4394c45c95fc4f8d7feb8bdfac69
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-02-15 10:28:51 +00:00
Eike Ziller
c5be15cc06 Add changes file for 4.9
Change-Id: I650ff3c8792b4d1ae7e8ac25dad51de238c2169b
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2019-02-15 09:17:09 +00:00
Christian Stenger
f3110a4c1c Squish: Fix tests for Qml locals view
Nowadays the locals and expression view displays the
QQmlEngine as well, adapt tests accordingly.

Change-Id: Ide6d3ae4e6dd8a136e44f196773a88a8aa29c702
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2019-02-15 06:44:45 +00:00
Christian Stenger
f9b8f1471f Squish: Fix expected file content
Change-Id: Ie47b63593e5fae203fdf329ede46d425f27cf735
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2019-02-14 14:04:03 +00:00
David Schulz
b41b5a0714 move text document for file path convenience function
Move it from language client utils to a static function inside
the text document.

Change-Id: I91bc72d0e978c1d843082e12bb8a0fa60a1bbc5e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-02-14 13:19:19 +00:00
Christian Kandeler
fa4f925fda Update qbs type info
Change-Id: I9fab6156b6ce0a3c50be0c08b263f7a4c84dbfca
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2019-02-14 13:16:13 +00:00
Christian Stenger
a112ca317b Squish: Fix verification of tool tips
Change-Id: I12487c784cf784ca7ddf705895c99f0ed912b0f4
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2019-02-14 12:58:43 +00:00
Christian Stenger
ac4ec98735 Squish: Adapt test for wizard pages
There are nowadays two additional application templates
for Qt for Python.
Additionally remove no more existing template.

Change-Id: I717adb78e1873f0609a050364034694a7c270055
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2019-02-14 12:58:27 +00:00
Christian Stenger
605fe1dfd9 Squish: Update menu item for 'Find Usage'
Change-Id: I6fdf9f9a1c697ad403473b795d4848aa4e519cb0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2019-02-14 10:39:56 +00:00
Marco Bubke
a33bce9e91 Clang: Fix command line builder
Add "-nostdinc++" only for C++.

Change-Id: I21228fca80045b040877328f41ca0edb4f227fcc
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-14 10:09:38 +00:00
Marco Bubke
80cdc99737 ClangRefactoring: Move clang options to BeginInvocation
Change-Id: If4e90aa8e27b961026912bef3f0e81f972fbe0c7
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-14 10:09:27 +00:00
Christian Stenger
75d9b56c1a QmlJSEditor: Fix nullptr access
Avoids a crash when triggering 'Find Usage' on a Qml Item.

Change-Id: I3980e6a7aae891f853148017341a2f29a07e03ad
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-02-14 05:42:47 +00:00
Eike Ziller
667eb57169 UI Introduction: Allow left cursor key for "back"
Or right cursor in case of right-to-left layout direction

Change-Id: I058ad4ecc5e07f572cf16abc8a94da430b65fda3
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-02-13 15:47:49 +00:00
Robert Loehning
80cd9cfa8a Squish: Update tst_APTW03
Change-Id: Iace2557625f538ebac09191043ae0d653face121
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-02-13 14:43:54 +00:00
Christian Stenger
5e1167facd Tests: Fix contradicting declarations
Change-Id: I684bad06ff0f1dbc6375da96457135d6f7287120
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2019-02-13 13:58:40 +00:00
Eike Ziller
1ac9a91811 HelpItem: Fix usage of isFuzzyMatch
We may not access that before links are resolved.

Change-Id: I5e80190e41c220c6b70e5d391caaf173cd5b28d8
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-02-13 12:45:50 +00:00
Alessandro Portale
e985290444 Syntax highlighting: Add patches for KSyntaxHighlighting adaptation
The patches which lead from "syntax-highlighting"'s SHA
    e07306d9c22f6426d6b50287eee532555d74ac75
to the current state in qtcreator's repo

This is useful to document what changed, and to ease further code
merges from "syntax-highlighting".

Change-Id: I4be45d12aa4237558b6e381a70947326829e79cb
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-02-13 10:37:27 +00:00
Robert Loehning
4b8200086b Squish: Fix handling of "Take a Tour" in startCreatorVerifyingClang
Change-Id: Ica4414c6e284af69aedf06b7d56b7e72587c7e90
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-02-13 10:05:42 +00:00
Christian Kandeler
0b6a36df7e Update qbs submodule
To HEAD of 1.13 branch. Also adapt to API changes.

Change-Id: Ibe35dfd19dea5f8cde254656cd471618645a0b07
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2019-02-13 09:28:36 +00:00
Andre Hartmann
3d67de6b39 ProWriter: Fix some Clang warnings
There are more in this file (mostly sign conversion),
but not that easy to fix.

Change-Id: Icf4354836ad791982d442236077d7e1e5df18f74
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2019-02-12 21:04:54 +00:00
Alessandro Portale
a6e72c4c6e Docs: Acknowledge LLVM/Clang and Clazy
...Just as they are acknowledged in the README.md

Change-Id: Ia5ee50dbef98f9a9313c094f5daad7ee6f59c993
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2019-02-12 21:02:22 +00:00
Andre Hartmann
456bcc2da8 ProWriter: Remove foreach and forever
Change-Id: I817cbab3b126d2e246a00c36bf3ecfb138dffdbe
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2019-02-12 16:16:46 +00:00
Marco Bubke
406336bab7 ClangRefactoring: Fix PCH build
We have to generate a PCH which is not checked by size or data. For that
we have to remap the file so it get the overridden flag. If that flat is
set no checks will be performed.

Task-number: QTCREATORBUG-21958
Change-Id: Id9bff91b3ab64526dc109eb46d4a21766456abe5
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-12 14:02:49 +00:00
Marco Bubke
846ed7c50d ClangRefactoring: Add thread safety for progress report
Task-number: QTCREATORBUG-21950
Change-Id: Id067e23a501253f3b73671f6939164e314b5c8a9
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-12 14:02:36 +00:00
Marco Bubke
562b1eef5d Clang: Fix command line builder
Clang does not support c18, so we use c17

Change-Id: I272461cf70aa3d620900f76437cf4745f2a0e26c
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-12 14:02:20 +00:00
Marco Bubke
44d5e10185 ClangRefactoring: Fix progress counter
We use threads now and the code had to be adapted.

Task-number: QTCREATORBUG-21950
Change-Id: Ie96c5bea1fa045588d0c5a8b18bfd1ccb5d9fdd9
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-12 14:02:12 +00:00
Marco Bubke
97ec6b9ad2 ClangRefactoring: Don't update the database if something went wrong
We can get an compile error. In that case we should not update the
database. In the future we should have a mechanism to report about the
database state.

Task-number: QTCREATORBUG-21949
Change-Id: I203346d536b007171f7bf255047409431c44a85a
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-12 14:02:02 +00:00
Marco Bubke
c52c531c3f UnitTests: Move symbolscollector data to sub directory
Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-12 14:01:50 +00:00
Ulf Hermann
24c7a51811 PerfProfiler: Delay closing of perfparser's write channel
We don't want to do this from writeChunk() as that is directly connected
to QProcess::bytesWritten. closeWriteChannel() can delete the
QWindowsPipeWriter from which the bytesWritten signal originates, crashing
the event loop when it tries to resolve further receivers for the same
signal.

Change-Id: I66737572a33db364f0f61542343f0fc8dc696787
Task-number: QTCREATORBUG-21971
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-02-12 13:44:36 +00:00
Christian Kandeler
94425336fd ClangTools: Fix fall-through warning
GCC does not realize that all cases lead to a return statement.

Change-Id: I0b6fc7b349b8dc09b739f3423121d2e760c74701
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-02-12 13:43:22 +00:00
Nikolai Kosjar
ffd2fee26a ClangTools: Use std::unique_ptr in DiagnosticView
Change-Id: Iee8faf18178b6190b4d8b2bc2816ea00d680bd3f
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-12 13:36:35 +00:00
Ivan Donchevskii
4066dee257 ClangFormat: Improve formatting performance to reformat the whole file
Allows not to cut the file and removes extra logic.

To achieve that do "smart" formatting in one go by adding a trick
with comment to keep the last line break and provide the proper indent
for the current line together with formatting the code above.

Disable adding namespace comments because it causes one extra
formatting pass (not for the manual formatting).

Change-Id: I8f644129606238c5438e636f56e6097ab149aa0c
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2019-02-12 13:16:22 +00:00
Ulf Hermann
4b5841292e LinuxDeviceProcess: Only look for processId on freshly started process
There may be additional output being retrieved after the process is
finished. We don't want that to get mangled by the processId mechanism.

Change-Id: I9ad3146ace66288de1a4d8f1e94b9999719862c8
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-02-12 13:11:17 +00:00
David Schulz
c6415e2652 LSP: collect and execute quick fixes via shortcut
Fixes: QTCREATORBUG-21802
Change-Id: I611fac1c3fc5b094816441e36492ed57706c98b8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-02-12 12:57:31 +00:00
Ulf Hermann
0ec8a255d9 Update perfparser submodule
We need a version that set stdin to binary on windows.

Task-number: QTCREATORBUG-21971
Change-Id: I409c21d7362261b7babea7937612147a523443e3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-02-12 12:37:03 +00:00
Robert Loehning
c2f57e51d6 Squish: Small fixes in tst_APTW03
Change-Id: I3ef8de3c994b34368cbe218e8a5141e47e08723f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-02-12 12:20:33 +00:00
Ulf Hermann
9ad1d54e14 PerfProfiler: Give more verbose output on perfparser failures
The exit code can be very helpful. Also, if we get the Timeout signal we
want to know about it.

Change-Id: I598c069adf15cddef19edabbde14fffe90f48e10
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-02-12 11:50:18 +00:00
Nikolai Kosjar
9e57c5db5d CppTools: Allow to black list command line flags from project
...for debugging and workarounds if necessary.

Change-Id: If76cddb59fbd8e96f42d141bd5e5d03cd88ab30f
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-12 09:50:21 +00:00
Nikolai Kosjar
d74ce63ac9 ClangTools: Remove "note:" from the Explaining Steps text
...to make it consistent with the DiagnosticItem.

Change-Id: I66ce41441058879ee293f9ae177e7b50d4856234
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-12 09:32:49 +00:00
Nikolai Kosjar
45fd5a3f9e ClangTools: Fix plugin tests
The tests expected diagnostics from source files only, but provided also
the ones from the header.

FAIL!  : ClangTools::Internal::ClangToolsUnitTests::testProject(qt-widgets-app.qbs) Compared values are not the same
   Actual   (tool->diagnostics().count()): 4
   Expected (expectedDiagCount)          : 1
   Loc: [/d1/creator/4.9/source/src/plugins/clangtools/clangtoolsunittests.cpp(133)]
FAIL!  : ClangTools::Internal::ClangToolsUnitTests::testProject(qt-widgets-app.pro) Compared values are not the same
   Actual   (tool->diagnostics().count()): 4
   Expected (expectedDiagCount)          : 1
   Loc: [/d1/creator/4.9/source/src/plugins/clangtools/clangtoolsunittests.cpp(133)]

Change-Id: I9270ba8cb554af3a3254e21d55656e73bcae71dd
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-12 09:32:31 +00:00
Nikolai Kosjar
e8509cd858 ClangTools: Make space toggle the fixit state only
...instead of also going to the diagnostic location in the editor.

This allows to toggle desired fixits without loosing focus (analyzer
view -> editor widget).

Change-Id: Ie8a0379ee1e811c01a2f0666f3627e3a9b537b04
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-12 09:32:24 +00:00
Nikolai Kosjar
fd04104484 ClangTools: Toggle only filtered fixits by header check box
When toggling the check box in the diagnostic view header, toggle only
the filtered items instead of all.

This allows to easily check all the filtered items, which is useful for
creating separate commits.

Change-Id: I7589bc57e61a5560fd7de738a8ae63131a1a6fa6
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-12 09:32:17 +00:00
Nikolai Kosjar
4eaedac72f ClangTools: Move check box in diagnostic view to the left
...so it's closer to other related data and controls (expand/collapse
marker).

The details of the fixits status are displayed in the tooltip now.

Change-Id: I9f1a9e9562572195b52a097ae9278647fecf6cb8
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-12 09:32:10 +00:00
Eike Ziller
d4415b02af Add fallback help IDs to built-in model
Task-number: QTCREATORBUG-15959
Change-Id: I1e022450d09cb0e8565573079e412b26d09ce662
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-02-12 07:40:43 +00:00
David Schulz
4420190192 LSP: Visualize server capabilities in settings page
Change-Id: Ib83b8580e9758313285a6145b0925e051268f34b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-02-12 07:12:58 +00:00
Eike Ziller
9c492ce962 Move function to get fallback help IDs to CppTools
To be shared between Clang and Built-in model

Change-Id: Iebe132c93033c252c58da13b858a0dce61483eaf
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-02-12 06:17:58 +00:00