If we do not have a hover handler, or that did not produce any result,
use the word under cursor and try with that.
This adds at least some help fallback mechanism to all text editors,
e.g. we get some context help (though a bit crude) for Pyside
"for free".
Change-Id: I1b6d91ad6f46bfd12e242b1aec9f4fcadae23403
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
This change replaces the existing application icons with the newly
designed ones.
Task-number: QTBUG-70826
Change-Id: I379ac8b5f64c4394c45c95fc4f8d7feb8bdfac69
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Nowadays the locals and expression view displays the
QQmlEngine as well, adapt tests accordingly.
Change-Id: Ide6d3ae4e6dd8a136e44f196773a88a8aa29c702
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Move it from language client utils to a static function inside
the text document.
Change-Id: I91bc72d0e978c1d843082e12bb8a0fa60a1bbc5e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
There are nowadays two additional application templates
for Qt for Python.
Additionally remove no more existing template.
Change-Id: I717adb78e1873f0609a050364034694a7c270055
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Avoids a crash when triggering 'Find Usage' on a Qml Item.
Change-Id: I3980e6a7aae891f853148017341a2f29a07e03ad
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Or right cursor in case of right-to-left layout direction
Change-Id: I058ad4ecc5e07f572cf16abc8a94da430b65fda3
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The patches which lead from "syntax-highlighting"'s SHA
e07306d9c22f6426d6b50287eee532555d74ac75
to the current state in qtcreator's repo
This is useful to document what changed, and to ease further code
merges from "syntax-highlighting".
Change-Id: I4be45d12aa4237558b6e381a70947326829e79cb
Reviewed-by: David Schulz <david.schulz@qt.io>
To HEAD of 1.13 branch. Also adapt to API changes.
Change-Id: Ibe35dfd19dea5f8cde254656cd471618645a0b07
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
There are more in this file (mostly sign conversion),
but not that easy to fix.
Change-Id: Icf4354836ad791982d442236077d7e1e5df18f74
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
We have to generate a PCH which is not checked by size or data. For that
we have to remap the file so it get the overridden flag. If that flat is
set no checks will be performed.
Task-number: QTCREATORBUG-21958
Change-Id: Id9bff91b3ab64526dc109eb46d4a21766456abe5
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
We use threads now and the code had to be adapted.
Task-number: QTCREATORBUG-21950
Change-Id: Ie96c5bea1fa045588d0c5a8b18bfd1ccb5d9fdd9
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
We can get an compile error. In that case we should not update the
database. In the future we should have a mechanism to report about the
database state.
Task-number: QTCREATORBUG-21949
Change-Id: I203346d536b007171f7bf255047409431c44a85a
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
We don't want to do this from writeChunk() as that is directly connected
to QProcess::bytesWritten. closeWriteChannel() can delete the
QWindowsPipeWriter from which the bytesWritten signal originates, crashing
the event loop when it tries to resolve further receivers for the same
signal.
Change-Id: I66737572a33db364f0f61542343f0fc8dc696787
Task-number: QTCREATORBUG-21971
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
GCC does not realize that all cases lead to a return statement.
Change-Id: I0b6fc7b349b8dc09b739f3423121d2e760c74701
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Allows not to cut the file and removes extra logic.
To achieve that do "smart" formatting in one go by adding a trick
with comment to keep the last line break and provide the proper indent
for the current line together with formatting the code above.
Disable adding namespace comments because it causes one extra
formatting pass (not for the manual formatting).
Change-Id: I8f644129606238c5438e636f56e6097ab149aa0c
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
There may be additional output being retrieved after the process is
finished. We don't want that to get mangled by the processId mechanism.
Change-Id: I9ad3146ace66288de1a4d8f1e94b9999719862c8
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
We need a version that set stdin to binary on windows.
Task-number: QTCREATORBUG-21971
Change-Id: I409c21d7362261b7babea7937612147a523443e3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The exit code can be very helpful. Also, if we get the Timeout signal we
want to know about it.
Change-Id: I598c069adf15cddef19edabbde14fffe90f48e10
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
...for debugging and workarounds if necessary.
Change-Id: If76cddb59fbd8e96f42d141bd5e5d03cd88ab30f
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
...to make it consistent with the DiagnosticItem.
Change-Id: I66ce41441058879ee293f9ae177e7b50d4856234
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
The tests expected diagnostics from source files only, but provided also
the ones from the header.
FAIL! : ClangTools::Internal::ClangToolsUnitTests::testProject(qt-widgets-app.qbs) Compared values are not the same
Actual (tool->diagnostics().count()): 4
Expected (expectedDiagCount) : 1
Loc: [/d1/creator/4.9/source/src/plugins/clangtools/clangtoolsunittests.cpp(133)]
FAIL! : ClangTools::Internal::ClangToolsUnitTests::testProject(qt-widgets-app.pro) Compared values are not the same
Actual (tool->diagnostics().count()): 4
Expected (expectedDiagCount) : 1
Loc: [/d1/creator/4.9/source/src/plugins/clangtools/clangtoolsunittests.cpp(133)]
Change-Id: I9270ba8cb554af3a3254e21d55656e73bcae71dd
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
...instead of also going to the diagnostic location in the editor.
This allows to toggle desired fixits without loosing focus (analyzer
view -> editor widget).
Change-Id: Ie8a0379ee1e811c01a2f0666f3627e3a9b537b04
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
When toggling the check box in the diagnostic view header, toggle only
the filtered items instead of all.
This allows to easily check all the filtered items, which is useful for
creating separate commits.
Change-Id: I7589bc57e61a5560fd7de738a8ae63131a1a6fa6
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
...so it's closer to other related data and controls (expand/collapse
marker).
The details of the fixits status are displayed in the tooltip now.
Change-Id: I9f1a9e9562572195b52a097ae9278647fecf6cb8
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>