This helps tremendously in the not uncommon case of the same class being
implemented in several files (e.g. for different operating systems).
Until now, users would be completely at a loss as to which of the
results was the one they were interested in.
Change-Id: I3ef8c8dc93b89e68eaf323a7ad2067b075d8cfb1
Task-number: QTCREATORBUG-11125
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Use pragma once
* Use override
* Remove Q_DECLARE_PRIVATE as that makes no sense for QtCreator
Change-Id: Ic31d4868c172a0b8fcb50cc9a71a6e95639cf84c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
There is no need for the highlight files processor to be a Q_OBJECT, and
it can also be created on the stack (and moved to the thread).
Change-Id: Ic347b1b7e5ece50642b85654fb2701fe5994619b
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
We don't use std::thread anymore, so we don't need to avoid universal
references in the called function. (std::thread with MSVC2013 does not
correctly forward the function arguments.)
Change-Id: I2a2fb0bd9b4cfcfe47baecb0b53d78e67f97f442
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Test parser is normally disabled as long neither test tree nor results
pane is opened. The new setting allows the user to enable the parser
without the need to have one of these widgets opened.
Task-number: QTCREATORBUG-15669
Change-Id: I354e1a3cb91eeca2302f2344fd443c81c4b15406
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
The color role was already availabe in Utils::Theme, but
Utils::Icon didn't yet make use of it. That was a bug.
Change-Id: Ifb99e08567223c0999296fde34f61de21b764b14
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
It was only ever used to run second valgrindProcess()->setValgrindArguments
(fullValgrindArguments()) in the memcheck tool which was already done in
ValgrindRunner::start()
Change-Id: I95a6005e2131eea25215f17cd0e7244a3d8df12e
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
* Use override where appropriate
* Use pragma once
* Make more constructors explicit
Change-Id: I2865fe10f288e3de570826058e43b70a0cb4ee37
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
If the process is already finished, and cancel is triggered Creator crashes.
For example, search for "q" in qt-creator, wait for >200K popup, then wait a few
seconds for the process to finish and press Cancel.
The reason for the crash is that reportFinished() is called twice - one from
GitGrepRunner::finish() and another one from Utils::runAsyncImpl().
Change-Id: I61d379f5e3a5ae86c9a48a3751dbb2e00203516d
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
It is perfectly valid for a kit to not have a debugger. Do not
soft-assert in that case.
Change-Id: I89b7a125935188c0ce9479ea68cd403b59e72563
Reviewed-by: hjk <hjk@theqtcompany.com>
Not needed anymore. The combination works nevertheless.
Change-Id: I3e24be38061b78b1d107eed5b2f1ae4cc1cfc64f
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
Compiles fine with the generic base classes.
Change-Id: I39b669a1c85379ca938d35d753a19debb1fd59cd
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
Instead, use the copy in the RunControl base class.
Change-Id: Ib72876b131236de8cb8f5cecbad9ec381d7e0e3e
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
The base RunControl has now a copy of its own.
Change-Id: Ic830015603975891ef96335518f39b4cf032f29f
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
- also clean up some empty lines and include orders
Change-Id: Ia076951a6b0060ae70c53f213bdb5d6a12abd319
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
Qt 5.6 no longer pulls in the pthread library.
Change-Id: I8b266cf89e9e05aaff3d7cd5ea36707e49e8ccdb
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Make isLocal() less intrusively used and correct. Use the stored device
more often, also handle errors more quickly.
Change-Id: I146d1f5788ea79d0a9d7b058c81908d451cf00d0
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
There was operator==(const Utf8String &, const char *), but not the
counterpart with the argument types switched.
Change-Id: Ie9ef5c21da0c39881ecad7ea080b87eefe6c4d02
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
