Commit Graph

45338 Commits

Author SHA1 Message Date
Eike Ziller
9074a8c310 QmlJS: Change yet another call of QtConcurrent::run
Change-Id: I417c4dbdf8216e8372578775efe97a0510756520
Reviewed-by: Marco Benelli <marco.benelli@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2016-02-01 08:21:22 +00:00
Orgad Shaneh
3e4e462638 ProjectExplorer: WS fixes
Change-Id: I49c961159ad1d3ece0e55f453377daa879ef7703
Reviewed-by: hjk <hjk@theqtcompany.com>
2016-02-01 07:57:04 +00:00
Eike Ziller
40fd545bf6 ShellCommand: Cleanup includes
Change-Id: I87ccf8bed5a09bcd0f8572aa3999fbbf1a1db2b4
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2016-01-30 16:54:35 +00:00
Orgad Shaneh
ceaf0b72f5 CrashHandler: Resurrect
It has the wrong path, doesn't work at all...

Change-Id: I28a5fbb599e4b2c696898ca0260102e3f69ed92a
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
2016-01-30 16:38:51 +00:00
hjk
75b6dc018b Valgrind: Remove unused ValgrindRunner::Private:workingDirectory
This is covered now be the debuggee member.

Change-Id: Id2983e2b8d74236249263fdd4b867bd310bf20cc
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
2016-01-29 16:28:08 +00:00
Christian Kandeler
3d9409311f Valgrind: Quickfix for remote execution.
Lots of stuff is still horribly broken due to the weird confusion
between local/remote and "has project"/"does not have project" that
crept in at some point, but this at least makes remote, project-specific
memcheck work again.
Still broken:
    - Remote callgrind
    - All remote valgrinds for external projects.
    - Local remote valgrind is not even available (anymore), as
      the respective menu entries have disappeared at some point.

Change-Id: Iae6b60a0508d1b1b64fd0e0e5f776ea2c2e23598
Reviewed-by: hjk <hjk@theqtcompany.com>
2016-01-29 16:27:09 +00:00
hjk
3d82198031 Debugger: Fix startup with core files
Change-Id: I1dfb444543634839deb36d50609f1dc23d235717
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2016-01-29 14:02:38 +00:00
hjk
0fd3b3d60d Core: Remove dependency on gui-private again
Change-Id: Ia4a716e3cccb0accac9c1998a854824195c3583e
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2016-01-29 13:18:20 +00:00
hjk
6844d3f277 Find: Remove use of unsual QTextCursor constructors
Change-Id: If3b86d49c5b87974f7d40fcfa75e4a303ba55c1a
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
(cherry picked from commit 1edd6193ba)
2016-01-29 12:46:13 +00:00
Tobias Hunger
66bdd60947 ProjectExplorer: Sprinkle overrides over the code
Sprinkle overrides over code derived from classes in ProjectExplorer

Change-Id: Ia4cc25649f7dc00b0ea126d8176a59afbc5ed574
Reviewed-by: hjk <hjk@theqtcompany.com>
2016-01-29 12:34:19 +00:00
BogDan Vatra
221b03a162 Add AndroidRunnable
Using the AndroidRunnable is easy for other plugins to run custom adb
commands before intent is started and after it's stopped.

Change-Id: I012ae87c92cea16aa8074dce2dc6f2b0c4ebeb30
Reviewed-by: hjk <hjk@theqtcompany.com>
2016-01-29 12:29:07 +00:00
Orgad Shaneh
b5b328c331 CrashHandler: Prefer Qt Creator in PATH for debugging
If the current instance of Creator is crashing, it might not be a good idea to
use it for debugging...

Change-Id: I4c28b3960c0722184fc92a6d20fbff8badb1fea3
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
2016-01-29 12:07:43 +00:00
Eike Ziller
9dc6f8b47d runAsync: Fix issue with deleting thread
deleteLater schedules the event in the current thread, so we
may not use it directly on a thread from within the thread itself...
Instead connect the threads finished signal to its deleteLater slot.
To avoid problems if runAsync is not run from the main thread,
move the thread to the main thread before starting it.

Task-number: QTCREATORBUG-15688
Change-Id: Iea003d00c58d1f921fb0b4ddf9cf67dcb1379833
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2016-01-29 11:22:56 +00:00
hjk
1edd6193ba Find: Remove use of unsual QTextCursor constructors
Change-Id: If3b86d49c5b87974f7d40fcfa75e4a303ba55c1a
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2016-01-29 11:09:43 +00:00
Alessandro Portale
8dd902cfa3 Default Theme: less aggressive stop red
Change-Id: I3b490766b8423b8e575dee0e9efa6c7f9a061b05
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2016-01-29 11:04:22 +00:00
hjk
249a36b573 Analyzer: Remove AnalyzerRunControl::runnable() and .connection()
These re-implementations are conceptually "too specific". Rather let
the indiviual tools handle there expectations themselves.

Change-Id: I0bbea407b2241816a40d19eb1dbb0a7589cbda7b
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2016-01-29 09:39:47 +00:00
Christian Stenger
b2c6ea47b1 AutoTest: Display output of passes on test results pane...
...if possible. If passing tests had output beside the result
it had been omitted so far.

Change-Id: I37fd14714d00fe6a28f079f3fe2ca6e82606fa31
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
2016-01-29 08:34:41 +00:00
Alessandro Portale
2ff75813b2 TextEditor: Define Color Scheme entry per Theme
The TextEditor settings do not remember a global Color Scheme setting,
anymore, but rather a Color Scheme ber Theme. A .creatortheme can define
a default TextEditor Color Scheme (overridable in the settings). This
makes switching of schemes more pleasant.

Taks-number: QTCREATORBUG-15229
Change-Id: I3bd36a4dfa23feea2254be2df50fce064e8fe2af
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
2016-01-29 08:22:38 +00:00
Alessandro Portale
ff7b8ffcbb Gathering feedback about flat mode icons
No worries, this is not supposed to stay as default. I just enabled falt
icons in the default theme in order to get feedback about technical
issues as-well as comments about the look-and-feel. Send feedback to the
patch author's email.

The plan so far is to revert this mid-February, and just have flat mode
icons enabled for some alternative themes.

Change-Id: I371f4ede432597ad7f1bc4b9ae661c9f2bc8df3e
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
2016-01-29 07:54:22 +00:00
Eike Ziller
4a954c296e runAsync: Fix unexpected behavior for using singleShot/timers etc
Timers/singleShot etc can only be used in QThreads (they require the
event dispatcher). So we have to use QThreads instead of std::threads to
nicely interoperate with Qt features.

Task-number: QTCREATORBUG-15681
Change-Id: I851e2f102e15ccd3347d455cc9d8b7df935c2d5e
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2016-01-28 14:18:09 +00:00
hjk
2cf0060596 Debugger: Use StandardRunnable in DebuggerStartParameters
This is a mechanical replacement for the former executable, processArgs,
inferiorEnvironment and workingDirectory members.

Change-Id: I4160e01427ed801df9b729f1f31d0a2ca48159b5
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2016-01-28 14:15:54 +00:00
Eike Ziller
67e952e888 QMakeProjectManager: Reduce priority of parsing threads.
Task-number: QTCREATORBUG-14640
Change-Id: I32b47888ecf3627bc21649a0c922216fb9e714a6
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2016-01-28 13:50:14 +00:00
hjk
58be2708a3 ProjectExplorer: Use Runnable in DeviceProcess::start
Change-Id: I8ce5b536745db11980f43449a055b7ebf9da83d2
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
2016-01-28 13:27:30 +00:00
Eike Ziller
2a83564d62 QMakeProjectManager: Avoid usage of global thread pool.
Using a global thread pool does not really make sense, since we do not
want to block any completely unrelated task. But the qmake project
manager still wants to limit the number of simultaneous threads without
managing that itself. A shared thread pool in project explorer sounds
like a sensible middle ground.

Change-Id: Ide6fd546a56e8f4896c387168513b608dfe7e3e8
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2016-01-28 12:55:38 +00:00
Eike Ziller
349b49caaa RunExtensions: Allow running functions on arbitrary thread pools
Change-Id: Icf642e7365535e4b2ca6fa4dee90a7033eb39af7
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>
2016-01-28 12:41:37 +00:00
hjk
7345cc309c Utils: Introduce a 'Port' class
To be used as type safe wrapper around a 16 bit port number.

Change-Id: I20a26be69e8b6b7dc9a7975fbe41c76ef89afbea
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2016-01-28 12:10:08 +00:00
Eike Ziller
f64d7e6ad4 Add qmake-generated wrapper scripts to .gitignore
Change-Id: Idb82c78436335db70bc6caf906b9aa1ea212c68b
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
2016-01-28 12:01:55 +00:00
Orgad Shaneh
a6e6c88ed8 Revert "QmlJS: Exchange unsafe meta calls with QTimer::singleShot"
QTimer::singleShot with a member function pointer or a lambda does
not schedule the invocation directly on the receivers event loop,
even if the timeout is 0. It actually creates a timer in the thread
where QTimer::singleShot is called, which requires an event dispatcher
to be available. Only the timer's timeout() signal then schedules the
invocation on the receivers thread.

We do not want to actually run an event loop here until a timer fires.
Even if a timer with timeout 0 might directly schedule the timeout
event on the event dispatcher without involving actual timers, and
even if that event dispatcher makes sure all events are handled before
deleting itself, it would feel like relying on an implementation
detail.

This reverts commit a2e19ba1be.

Task-number: QTCREATORBUG-15681
Change-Id: I19846ce089d72c971d3cc5927c2ddf563e06de14
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2016-01-28 11:50:18 +00:00
hjk
d5ecd4cf8b ProjectExplorer: Use StandardRunnable in ApplicationLauncher
Change-Id: I7092d748207762d3dbd6c69c01cc06c88cbf63d8
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2016-01-28 11:35:51 +00:00
hjk
9ffae7f4ba De-noise QmlJSPreviewRunner definition
Change-Id: I0a5c88e91f0e70f0a7bb73454d64056855fed47f
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
2016-01-28 10:59:16 +00:00
Robert Loehning
9dabbdceb7 TextEditor: Show new zoom factor when resetting
...mainly to not show the old zoom factor anymore.

Change-Id: I01c3050ff38b0b328774e6d05bcc2fe913ee4f56
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2016-01-28 10:54:50 +00:00
hjk
a2732a347d Analyzer: Remove explicit environment and runMode
Instead, use the one in its (Standard)Runnable.

Change-Id: I14dbe91c50d083d11e18d514ec391875c64e3851
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2016-01-28 10:04:42 +00:00
Christian Stenger
76ef8e3c75 QmlProfiler: Fix missing environment for profiling Quick UI
Change-Id: I006802132db3a2d970f028306def16f953fabf53
Reviewed-by: hjk <hjk@theqtcompany.com>
2016-01-28 09:45:35 +00:00
Nikolai Kosjar
2745ecea20 TextEditor: Assume rich text for completion details tooltip
...since that's

 1. easier to handle (see e.g. QTCREATORBUG-15630, where a "&amp;" was
    not properly auto-detected).
 2. consistent with the tooltip that is used for function signatures
    (FunctionHintProposalWidgetPrivate)

Change-Id: I66aab253e13c5c7f63a0d9ddaf297b890567f335
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
2016-01-28 09:34:04 +00:00
hjk
07332eecb3 QmlProfiler: Use StandardRunnable in LocalQmlProfilerRunner
Change-Id: I8c59f9dfe562717edd86453b0154b7f2811a06f3
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2016-01-28 08:08:19 +00:00
hjk
5a090230a1 Debugger: Use StandardRunnable in StartApplicationDialog
Change-Id: I5f8936d887c43ee644ad175d9d4c53857bc00436
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2016-01-28 07:04:04 +00:00
Christian Stenger
09bc4baf3c AutoTest: Fix source file construction on Windows
Task-number: QTCREATORBUG-15667
Change-Id: I4d0e81a39a5031403d77fb3e2179ed17451346b4
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2016-01-28 07:03:53 +00:00
Sergey Belyashov
82693c8abb Update Russian translation
Change-Id: I20b894139b8d21b3c90c018a4866f96b6c45ac33
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
2016-01-27 19:07:10 +00:00
hjk
f2012bca8f Analyzer: Remove explicit working directory storage in run control
Instead, use the one in its (Standard)Runnable.

The change is mechanical except to the fallback to the project directory
which was introduced in 8150209f to keep some compatibility with the previous
setup of the Android runner which created and copied the fallback value around
and ignored it in the end. Not producing the fallback value is less effort.

Change-Id: Ie04da570f0f9fbc1d048f2eacaed522f7253afa3
Reviewed-by: hjk <hjk@theqtcompany.com>
2016-01-27 16:34:01 +00:00
Nikolai Kosjar
06a99af0f6 Revert "Clang: Fix text format for completion details" from 3.6
This reverts commit c5f70a3bad1ee2457741459cafb6419c67c417ad.

We will set the rich text unconditionally in a follow-up change to
simplify things.

Change-Id: I59aad8e33011ef68aa7c32ec80bb02edfd29c6a6
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>
2016-01-27 16:31:10 +00:00
hjk
61709e9266 Analyzer: Use a StandardRunnable instead of an AnalyzerRunnable
... with a lot potential to code consolidation.

Change-Id: I4d3a7fcc1cc6ae8763799f18cf9701695f387791
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
2016-01-27 15:29:11 +00:00
Tobias Hunger
fa17e27b7f CMake: Delay initialization of CMakeTools
Do not run cmake 5 times during startup. Delay that as far as possible.

Also add a supportedGenerators() method while visiting the code anyway.

Fix up and simplify the other cmake help output parsers.

Change-Id: I6622d552ffe559bf099b4b278618676a045e350e
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2016-01-27 12:43:45 +00:00
Eike Ziller
acdfb09687 QmlJS: Use Utils::runAsync and add some more progress information
runAsync avoids the globally shared thread pool.
updateCppQmlTypes missed some kind of progress information.

Change-Id: I8739761326c2f2a5364c0c1552b3c43b00f1ff28
Reviewed-by: Marco Benelli <marco.benelli@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2016-01-27 12:27:59 +00:00
hjk
7be3eb85e1 RemoteLinux/Qnx: Use StandardRunnable
Change-Id: I73331985eb68065b5fb123ff4491888d824de766
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2016-01-27 11:20:12 +00:00
Nikolai Kosjar
bfa292cdc9 ClangStaticAnalyzer: Tests: Fix failing runner tests on Windows
Both runner tests fail on Windows at

	QVERIFY(st.expectStartedSignal());

because QProcess::started() is emitted before ClangStaticAnalyzerRunner::run()
returns and thus before QSignalSpy::wait() is reached.

Watch out for the signal manually before calling run().

Change-Id: Ia786bfc6c859a4a4b420aeccc7e7f7bb0b4c47c0
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
2016-01-27 09:47:07 +00:00
Tobias Hunger
cfa9dd4c03 CMake: Use pragma once consistently
Change-Id: Id164dea5e7047b87c3d11c53ebd044d567129e9c
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2016-01-27 09:15:45 +00:00
Eike Ziller
a2e19ba1be QmlJS: Exchange unsafe meta calls with QTimer::singleShot
Change-Id: I5596c3f506f1fb873536c03ed5b8f5df88f5ea06
Reviewed-by: Marco Benelli <marco.benelli@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2016-01-27 08:24:14 +00:00
Orgad Shaneh
f26a4c2954 Git: Default to * file pattern in Grep
Change-Id: I5f763b7b2f8c0bc2373bf1151691b3e8b4cff757
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
2016-01-27 08:19:24 +00:00
Orgad Shaneh
048a012d21 Utils: Minor cleanup in ShellCommandPage
Change-Id: I4991caf2b96ccbcfe3ef763370c68678cd2e1424
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2016-01-27 08:19:15 +00:00
Christian Stenger
9ff5786d53 AutoTest: Fix parsing of file/line information for gtest...
...this was wrong in cases where we have additional output before
this information.

Change-Id: I6f55c48815217da98078d40e5a0f1f4ce4ad8a77
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
2016-01-26 16:27:43 +00:00