It is expected that user manually specifies all necessary light baking
related properties, including exposing them from subcomponents if
needed.
qlmdenoiser that is used to denoise generated light maps is a third
party application. It can be found here:
https://git.qt.io/laagocs/qlmdenoiser
Fixes: QDS-9403
Change-Id: Ida6fc142440b9ffa8cc97d578f85d8b76cb4b43f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
The backspace icon used to be drawn by painter lines, and this method
is replaced by an icon-font symbol.
Task-number: QDS-9513
Change-Id: Iaa19f286bc961d71ddc182bd2c431bc024c7aa79
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
In doTransition we start and stop animations.
Therefore the lookup for anim has to be done separately.
Task-number: QDS-9621
Change-Id: I608799a997d48acef7496a985505f896113068d1
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
When the "target" of the PropertyChange is set, then evaluating
the expression has a side=effect that stops the binding from working.
Fixing this specific corner case.
Task-number: QDS-9612
Change-Id: I0859433ff5b2c10dd1d3a6c02e5c133e5d55fdcd
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
For the case that Qt Creator is configured with a Qt that misses
QuickWidgets.
Change-Id: I7683ce091bd9f8fb6d95694484ba23c68efc19f6
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
The watcher notifies the updater if files or directories are changed.
The updater then does minimal updates to the project storage. Common
cases like that the qml documents or qmltypes are changed are handled by
an extra path. Otherwise we trigger a directory update. If the directory
is in 'strange' state like the qmltypes file is removed but the qmldir
is not updated the changed file ids are saved and used additionally in
the next notification.
Task-number: QDS-9479
Change-Id: Ie82fd914b2e229f0315bf60df398c85477ce5a26
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Use string views instead of strings to avoid copies.
Change-Id: I4649a3c87a0b58cc3f87d01e4fa047f459f52603
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Qt 6.5 doesn't support 10.14 anymore, because it
uses std::filesystem.
QmlDesigner also wants to use std::filesystem.
Change-Id: I36c14c6efa439c9372eb0d8bf90d1024e8b532eb
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Added a new Qt for MCUs macro and modified a number of related topics
accordingly.
Task-number: QDS-9609
Change-Id: I6506a9cb6671c29d5b164d53cb01c827639ecb16
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
- StudioStyle is implemented as an independent style dedicated to
QmlDesigner.
- QmlDesigner style part is removed from ManhattanStyle.
- Buttons are handled in StudioStyle.
- An standard palette is defined for StudioStyle.
- StudioStyle is applied to the application by QmlDesignerBasePlugin.
Task-number: QDS-9274
Change-Id: Id0a9040d82b6228a8fb215a416a916be116542bc
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
We very often want to remove a Qobject in a scope but because it has a
parent it can be deleted earlier. So using std::unique_ptr can lead to
double deletion. UniqueObjectPtr can track if a pointer is already
deleted. So no double deletion is possible but we still delete the
object in that scope. UniqueObjectPtr is based on std::unique_ptr but
uses a QPointer as internal pointer representation.
Because QPointer is not convertable you cannot cast from one type to
an other(QTBUG-112464). Because of that UniqueObjectInternalPointer
derives from QPointer and adds a conversion constructor.
Change-Id: I2c7707489f6db836cc5db2463efa8c33932b6455
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
If we cannot resolve an expression in the proper context,
we fallback to the root context.
The current context should be always a child of the root context,
but there are issues reported to be fixed by this.
Change-Id: I3f91641ea10fd0fa3bf22a93455e291013f5acc1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
When a user created a new folder with the same name as an existing
folder in that same location, the folder was not automatically
expanded.
Task-number: QDS-8866
Change-Id: I82ec4303a30d8f810417deea68b487e1b55833d5
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Also, now delayed the finish part by 200ms so that 100% progress would
be visible to the user.
Task-number: QDS-9562
Change-Id: Ie8f87ff70770b206256d4dbf0c08227723067eeb
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
The parent of the tool and status bar are widgets in icore. So they are
not deleted at the same time as the rest of the qmldesigner plugin. So
the connections are still there and you get dangling pointer. Deleting
them with plugin prevents this dangling connections.
Change-Id: I489d18c037c67ce34326651e693e74c4d951c261
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
When QDS starts for the first time, and there is no internet connection
(to download the materials bundle and the textures bundle), tell the
user that the problem might be the internet connection.
Task-number: QDS-9539
Change-Id: I81311bf00c830b76019e0edb53eeb980362a1339
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
When clicking outside any view that has sections and a section's
context-menu is visible, it is now closed.
Fixes: QDS-9564
Change-Id: I73cd3a9754c5a18360427525a2a943c2c549e83f
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
After the changes that made the texture icons downloadable, hovering
over the download button of a texture no longer showed metadata. The
reason is that the structure of the json metadata file changed a bit
-- now we have a top item with children "version" and "file_items".
Task-number: QDS-9575
Change-Id: Ib41d7871e3b3c0a0c759de5d0277c3ee7c974d4f
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
If internet is down, or, for some reason, the URLs are inaccessible,
then we should still show the existing materials and textures.
Task-number: QDS-9582
Change-Id: Ic9516c7bc00a37d1c3cd31643749f51a217bf317
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
The file node can be null if a new file was just added.
This worked before the 10.0 merge, but could be timing related.
In any case the check is good practice.
Task-number: QDS-9584
Change-Id: Ic01b763c6ba4466832316a454a12ccbdc1a6cc64
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The nullptr does crash. We can use a proper QmlJSQuickFixAssistInterface
created from the editor instead.
Task-number: QDS-9573
Change-Id: I5ea2792acb311c37e1005ff039ed7110503dfb4f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
We try to access projectStorageData but it does not exists. Now we
return a dummyProjectStorage() instead. Because it is never accessed if
we don't use the project storage we should be fine.
Change-Id: Ic36a27472e95012b29b15ad33d2abe01507d64b4
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Do not count code model issues as build issues when checking for them.
Fixes tst_build_new_project on the Linux machines which fail for unknown
reasons.
Change-Id: I2cd77b0208019fc902742197c0def6d3811cfced
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
Miikka Heikkinen
Samuel Ghinet
Thomas Hartmann
Ali Kianian
Burak Hancerli
Alessandro Portale
Marco Bubke
Tim Jenssen
Esa Törmänen
Mahmoud Badri
Mats Honkamaa
Eike Ziller
Brook Cronin
Leena Miettinen
Christian Stenger
Sivert Krøvel