Commit Graph

61895 Commits

Author SHA1 Message Date
Robert Loehning
4a17ac7760 Squish: Update tst_rename_file
Change-Id: I1b7e8ef7c112e01ed2403c348234a482b050cf49
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-11-20 16:04:03 +00:00
hjk
5c64d59d8a Debugger: Fix copying stack content to clipboard
Change-Id: I41240e15235a4906439a514fcf56fa1f7ddc8a80
Fixes: QTCREATORBUG-23199
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-11-20 14:55:32 +00:00
Nikolai Kosjar
57239aaf22 C++: Fix build with BUILD_CPLUSPLUS_TOOLS
Change-Id: If55b14f82752e19f536429ee44688156cd0a84da
Reviewed-by: hjk <hjk@qt.io>
2019-11-20 13:01:46 +00:00
Cristian Adam
da25ac6322 CMakeProjectManager: Add ability to specify path to ninja
Task-number: QTBUG-79885
Change-Id: If0c5efc534e2fc6f0041b9407e2ae24ed671ac8a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-11-20 11:37:00 +00:00
hjk
e8fe082bf9 Debugger: Swap BREAK and unused() in most dumper test
To avoid optimizing.

Change-Id: I43b39746811a822a0b5677920f9dc2f149291bc0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-11-20 11:31:57 +00:00
hjk
95ba85c86e ProjectExplorer: Use a Kit to initialize KitInfo
Change-Id: I70a83ff9a9da814b4e1ad9ce5e0b626105c09ca4
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-11-20 11:31:14 +00:00
Eike Ziller
15b2765dff Update Qt validity in options when changing Android device settings
When changing the Android device settings and pressing "Apply", the
information in the "Qt Versions" tab is no longer correct.

The Abi information is parsed from the mkspec, and that depends on the
NDK setting in the environment.
When the NDK in the device settings changes, it updates the toolchains,
and that triggers a re-validation of the Qt info in
QtOptionsPageWidget::validInformation, but since the Android Qt version
already has tried parsing the mkspec, and got (possibly empty) Abi
information, it never is parsed and updated again.

We need a way to force BaseQtVersion to update these things again.

Fixes: QTCREATORBUG-23095
Change-Id: I9cb55ad1a73db942804637344e4c856c7e95afd3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-11-20 11:28:47 +00:00
Richard Weickelt
20f050303a Update Qbs submodule
Change-Id: I4a3fa1924b61fac55026cf0004c6e6468de57471
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-11-20 11:07:15 +00:00
Cristian Adam
b6ab85a440 Android: Fix debugging on Windows
The pid script was wrongly quoted on Windows resulting in not having
logcat ability, and no debugging.

Change-Id: Ica40d033b61b69bb2372f54f0eba19ae1d2e3c9f
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
2019-11-20 11:00:15 +00:00
Volodymyr Samokhatko
264185245d EditorManager: add GotoLastEdit action
Done-with: Guillem Miguel <guillemmr@hotmail.com>
Done-with: Andre Hartmann <aha_1980@gmx.de>
Change-Id: I5059ea4ba8e9aa115cf4d0a90b80a4606779039a
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-11-20 08:21:36 +00:00
Eike Ziller
748e5bd5b9 Update platform requirement for binary packages
Since these are now based on Qt 5.14

Change-Id: I36167ec73fcedc99f57d1dbc16d6e8efeca8e830
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2019-11-20 08:07:34 +00:00
Mitja Kleider
889f0f4cec clangbackend: Fix typo
Change-Id: Ibc4a97e31f77423f6c2f046d83d4cba3a6d1f9c8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-11-19 17:24:27 +00:00
Christian Kandeler
58da82835b ProjectExplorer: Add shortcut for switching active project
... when in project mode.
We re-use the "GotoPreviousInHistory" action, which is semantically not
equivalent, but still seems like the most natural fit.

Fixes: QTCREATORBUG-19719
Change-Id: If00a90ce93ac3bd7e079d47eefa69e4f4aeb30cb
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-11-19 16:43:05 +00:00
hjk
e097323817 ProjectExplorer: Fix compilation with MSVC
Amends 2758682723.

Change-Id: I005c6aa848cd15fef8b59e05681c6b49b1453202
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-11-19 14:59:30 +00:00
Christian Stenger
09b358cf72 CppTools: Fix compile for gcc 5.3
Change-Id: I4b0da43dc835de1bc523a52be53da05e2237318c
Reviewed-by: hjk <hjk@qt.io>
2019-11-19 14:55:56 +00:00
Eike Ziller
9f21f59e68 LanguageClient: Support markdown tool tips with Qt 5.14
Use Qt::MarkdownText if language server returns markdown and it was
built against Qt 5.14.

Change-Id: I75787cfcb32480cb37bc0dadc4be12d005005099
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-11-19 12:26:04 +00:00
Andre Hartmann
1766832918 DiffEditor: Stage and unstage selected lines for Git
Fixes: QTCREATORBUG-19071
Change-Id: I560ba208e68e477ea865e499847d819cfdfeb6f3
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2019-11-19 11:19:43 +00:00
hjk
2758682723 ProjectExplorer: Move BuildSystem owership to BuildConfiguration
... or Target.

This patch moves build system from conceptually "one per project"
to "one per target (i.e. per project-and-kit)" or "per
BuildConfigurations" for targets where the builds differ
significantly.

Building requires usually items from the kit (Qt version, compiler,
...) so a target-agnostic build is practically almost always wrong.

Moving the build system to the target also has the potential
to solve issues caused by switching targets while parsing, that
used Project::activeTarget() regularly, with potentially different
results before and after the switch.

This patch might create performance/size regressions when several
targets are set up per project as the build system implementation's
internal data are duplicated in this case.

The idea is to fix that by sharing per-project pieces again in
the project implementation once these problems occur.

Change-Id: I87f640ce418b93175b5029124eaa55f3b8721dca
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-11-19 11:05:52 +00:00
Denis Shienkov
9073c46c9c BareMetal: Don't create default GDB server provider
... if a BareMetalDevice doesn't have any configured
provider yet.

Reason is that a 'Default GDB' provider does not means
that it is default. It just means, that this provider
can be attached to the remote running GDB server (it is
equivalent of "Attach to Running Debug Server").

Besides, in future, it is makes sense to remove this
provider at all as it is useless.

Change-Id: I2c5c59595dc7d724ac6e05177bbc6ae85cf67e2e
Reviewed-by: hjk <hjk@qt.io>
2019-11-19 10:47:57 +00:00
Denis Shienkov
cab228d05a BareMetal: Continue minimize dependency from GDB engine
The BareMetalDevice and the BareMetalDebugSupport classes should
not know anything about the specific implementation of the providers.

For this purpose, we just extend a providers by a new virtual methods
which are should be overridden for a concrete provider.

Change-Id: Ic5fef49f6b79e0ee7e8c4c386b4ed36cb5346dc1
Reviewed-by: hjk <hjk@qt.io>
2019-11-19 10:47:44 +00:00
Christian Stenger
4797111a4d AutoTest: Fix detection of GTEST_TEST
Googletest allows specifying tests with the
GTEST_TEST macro which was ignored until now.

Fixes: QTCREATORBUG-23228
Change-Id: I7dffab890e002000b32f7cd5b7444dc06fabe35a
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-11-19 05:46:11 +00:00
Christian Stenger
26e2572852 AutoTest: Fix font for results pane
Use a correct font on macOS as well.
Beside this there had been strange observation made
when zooming the command line output.

Change-Id: I8b8cdd0d76e415da4bc792b0d646154cfc8fde9d
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-11-19 05:45:48 +00:00
Sergey Morozov
78012fcb66 Core: Fix wrong current view after session restore
Fixes: QTCREATORBUG-23233
Change-Id: I4e5a854769d6aa00f5601b8bd8282523681d0458
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-11-18 16:29:42 +00:00
David Schulz
02b7a529dd LanguageClient: request link from active server for the document
Instead of sending the link request to all reachable server send it only
to the server that is currently used to handle this document.

Change-Id: I27a8d0e4573f734baa2931a0af771e60665a4532
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-11-18 14:40:28 +00:00
hjk
cc85cdf8d1 CPlusPlus: Use a namespace instead a dummy class for functions
Change-Id: Iaa364ef5fcd6f635fa07f0c43719b7b8feb1a428
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-11-18 13:07:58 +00:00
Miikka Heikkinen
49f7cfb7a1 QmlDesigner: Implement proper helper grid for 3D edit view
Change-Id: I9e33218d4b1528610155c5fb9bf94a9597ee23df
Fixes: QDS-1204
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-11-18 08:40:00 +00:00
Miikka Heikkinen
db54919798 QmlDesigner: Finalize camera visualization in edit 3D view
Added the UX approved camera icons, which will now turn transparent
and ignore mouse events when camera is selected so they do not
interfere with transform gizmos. Frustum visualization also changes
color according to selection state.

Change-Id: Id77066d9abb2b54696fae833201236afa238486a
Fixes: QDS-1208
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-11-18 08:39:38 +00:00
Miikka Heikkinen
20257e1e4f QmlDesigner: Implement RotateGizmo for 3D edit view
Added a gizmo for rotating selected object either freely or locked
around X, Y, Z, or camera axis.

Change-Id: Ib43c7dd3fc0f49f384d5920fce21ea932c4fc90d
Task-number: QDS-1196
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-11-18 08:39:16 +00:00
hjk
3c6c61d1c8 ClassView: Dissolve the internal 'Utils' class
It's regularly getting in my way, and it's rather a namespace anyway.

Also, move the functions that are only used once closer to their
place of use.

Change-Id: I97951aae1b69c04f391afbdd1b491a8a9173a977
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-11-18 08:33:26 +00:00
hjk
3ecf3d9575 Android: Simplify code in manifest editor
Change-Id: I1a54cc1d59b9fdf03083363cc26c25f72e893006
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-11-18 07:47:09 +00:00
Christian Stenger
a87293d1c4 Squish: Update expected tool tips
Change-Id: Ibde199b8f88448c9f0e7b235f7ede57735718201
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2019-11-15 22:58:52 +00:00
Christian Stenger
ebcde98b72 Squish: Re-enable testing Qt Quick 2 Extension Plugin wizard
This effectively reverts commit 4f2f86b5bf.
Additionally fixes the expected kits for this template.

Change-Id: Ie90f113894d331fa4023b8c58f30da5c4886c76d
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2019-11-15 16:01:51 +00:00
Christian Stenger
a08a5499e9 Squish: Fix expected ui elements and page order
The wizard had been transformed to use the
JsonWizard nowadays.
Order of wizard pages has slightly changed to be
consistent with the rest of the wizards.

Change-Id: I841349d3b20dbc03a56a3dc4d15f717d0d21acdb
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2019-11-15 15:48:33 +00:00
Leena Miettinen
65cfdf5699 Doc: Hide links to content excluded from Qt Design Studio Manual
The links lead to strange places or generate QDoc warnings
when building the Qt Design Studio Manual.

Change-Id: Ic8311b54f9d49a8d56572c2f049b84cbe3933812
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-11-15 15:06:39 +00:00
Leena Miettinen
3b57edf272 Doc: Move Using External Tools away from the creator-only folder
...so that it can be included in the Qt Design Studio Manual.

Change-Id: I2ce16d1162211e0f8fdd506fe53067ea3116cff6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-11-15 15:03:25 +00:00
Eike Ziller
349de159c9 FileIconProvider: Load icons and create overlay lazily
If the icon is registered via file path, not the icon directly, we can
delay loading the icon and creating the overlay to until it is actually
needed.

Change-Id: Icfdc30ac0b717ff566a1064e4791e4bb23814958
Reviewed-by: hjk <hjk@qt.io>
2019-11-15 14:21:12 +00:00
David Schulz
b2e1499782 Python: Use native separator in user visible path
Change-Id: I7ef46a2cae7744162a6f9da92a4736d74a029705
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-11-15 14:05:50 +00:00
David Schulz
40612bceee Python: Fix python run configuration
Add the WorkingDirectoryAspect to prevent running the
main script in an unpredictable location.

Change-Id: I1be206261b7983e933b53ccd57c93089154d8417
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
2019-11-15 14:05:38 +00:00
Robert Loehning
775c78eca8 Squish: Stabilize selectBuildConfig(...)
Change-Id: Iba111e8cbbe652dd488b4dc91c58b92f53eccba3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-11-15 12:46:13 +00:00
Christian Stenger
dd93820fdd Python: Restrict creating run configurations
Some upcoming wizards will have other files beside
python scripts. (e.g. qml, ui)
Ensure that these files do not get a run configuration.

Change-Id: I0fe55edc6ccfe2db64537401e6a46fd4bdd7e153
Reviewed-by: hjk <hjk@qt.io>
2019-11-15 12:01:12 +00:00
Christian Stenger
905714274c ProjectExplorer: Fix custom executable dialog
Change-Id: I1c71cda00b8a6bfd80497641c19ce85561e07e64
Reviewed-by: hjk <hjk@qt.io>
2019-11-15 12:01:00 +00:00
Christian Stenger
9ac4e29a20 Move helper functions to more public location
Change-Id: I12a2000bfc82c194d12fb5c25302a06f782aa605
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-11-15 12:00:31 +00:00
Christian Stenger
61fa3e8704 Wizards: Fix Qt Quick2 Extension wizard
Show kits selection page already while configuring
the project via wizard instead of falling back
to the target selection after the project had been
opened.
Regression with 6c9f75ff4a.

Change-Id: I9bf70f306dde3a570ab4ca3e4380040d6c6e4e23
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-11-15 12:00:10 +00:00
Eike Ziller
2c029d8700 Help: Remove hack for fixed Qt issue
The hack was a workaround for QTBUG-51962 which is fixed
since Qt 5.7

Change-Id: Iad76d72359f19febecb98b245a950684e6bba16f
Reviewed-by: hjk <hjk@qt.io>
2019-11-15 08:57:43 +00:00
Alessandro Portale
a2355841f5 McuSupport: Rename internal types
"PackageOptions" -> "McuPackage"
"BoardOptions" -> "McuTarget"
"qul" -> "qtForMCUs"

Change-Id: I209cc82c7516fbf6a960b26c440159dbab02a4db
Reviewed-by: hjk <hjk@qt.io>
2019-11-15 08:07:37 +00:00
hjk
7af9e0e827 ProjectExplorer: Speed up finding subfolder nodes
Instead of building up a temporary list and searching in there,
search the children directly.

Change-Id: Ibf08dad6dbbed3fbda3b93a7df311b9dd6f6e710
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-11-14 16:46:28 +00:00
Tobias Hunger
cca33e2e26 CMake: Do not make the CMake tool invalid on timeout
Do no mark the CMake tool as invalid when it times out when fetching
auto-completion information. This happens the first time a CMakeLists.txt
file is edited in Creator.

Also increase the timeout so that there is less of a chance
to trigger have the information retrival time out -- which breaks
auto-completion of cmake variables, etc. in the CMakeLists.txt editor.

Closes: QTCREATORBUG-18530
Change-Id: I914377a6ece90c6f78ea5eb007da8fbe07785563
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-11-14 16:17:12 +00:00
Alessandro Portale
9c43466485 Use HostOsInfo::withExecutableSuffix instead of if/else
Let's use our Utils.

Change-Id: I8cfbce55d2b41e42e86d050433df2cfd20cebe1b
Reviewed-by: hjk <hjk@qt.io>
2019-11-14 15:17:34 +00:00
Christian Kandeler
b7395e97f3 Git: Speed up the unmanagedFiles() function
Given a list of files, we should not call git for every single one of
them to figure out which ones are part of the repository, because this
job can be done with a single call.
As a test case, I added my whole ~/dev directory with ca 600,000 source
files to a generic project. With this patch, the time spent on
retrieving the list of unmanaged files went down from nine hours to
seven seconds.

Task-number: QTCREATORBUG-20652
Change-Id: Ic04a2b973e14eff549a2642bde7bc269df069fd1
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2019-11-14 13:18:16 +00:00
Christian Kandeler
bb5727de17 Vcs: Introduce IVersionControl::unmanagedFiles()
... and use it in VcsManager::promptToAdd().
This is purely a refactoring. The different IVersionControl subclasses
can (and should) override the naive base class implementation in the
future.

Change-Id: Ifdf49852a98f53a95dad1a89131243b21052bc66
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2019-11-14 12:55:35 +00:00