Commit Graph

83856 Commits

Author SHA1 Message Date
David Schulz
eda0dbd8dd TextEditor: modernize highlighting search results
Change-Id: I365a09dfd9d371119044da5567a1adb397f3ac93
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-10-12 07:58:49 +00:00
Marcus Tillmanns
da03156259 Utils: Allow nullptr widgets in layouts
Change-Id: I33ee85bd809a3388872bee4a470e9439010ed8a8
Reviewed-by: hjk <hjk@qt.io>
2023-10-12 06:31:08 +00:00
Samuli Piippo
e5d0bab0ea sdktool: add line break after clangd option
Amend d79c69918f and add line break.

Change-Id: I5082f0e6339cd161fa9c9030ad257e4246ff051f
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-12 06:01:20 +00:00
Christian Stenger
c6c0971265 Wizard: Fix kit selection for Qt Quick Application
Fixes: QTCREATORBUG-29698
Change-Id: If0d962352096ebcbf2cdca2b85005add06d85d71
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-12 04:45:27 +00:00
Christian Stenger
344ac9813d CMakePM: Fix crash in rstparser
Change-Id: I5a9e456214581800c977e69da01aab1053cc554f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-12 04:44:47 +00:00
Christian Kandeler
e508615243 Designer: Remove unused code
Amends bbbc90ee1d.

Change-Id: I963859c6f38621f0b2d6a21b45078c23c89d99e6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-10-11 15:14:32 +00:00
Leena Miettinen
fbe6c0d977 CompilerExplorer: Fix UI text caps and punctuation
Change-Id: I44fff47e3aef1b2910f22efd05201e81f6995024
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-11 14:53:34 +00:00
Marcus Tillmanns
09d066108e CompilerExplorer: Improve error reporting
Displays network errors as disrupting, instead of just sending
them to the log.

Change-Id: If5a3dbb733f1433dcc2bcd0a52ad12d8ee3b85ef
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-11 14:43:49 +00:00
hjk
6193cb3294 CppEditor: Stop updating things when shutting down
Fixes: QTCREATORBUG-29735
Change-Id: Ic1ee1798e156b5ddf564a721f5a4e8892ae40f63
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-10-11 12:23:55 +00:00
hjk
efc168fb61 Core: Re-order system settings dialog a bit
Change-Id: I853ac869769dd55d118bf722d3cbfa4416a54972
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-11 12:13:27 +00:00
Leena Miettinen
551dde7fa9 Doc: Describe Documentation Comments preferences
- Add a topic for setting preferences for Doxygen-style docs
- Update screenshot for Text Editor > Completion preferences, where
  the documentation settings used to be

Task-number: QTCREATORBUG-29392
Change-Id: Ifb915e78f3d2a5fb97555dd99bfaa5abf12ef14b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-11 12:05:32 +00:00
Marcus Tillmanns
520cbfa39a DeviceSupport: Make errors translatable
Change-Id: Ieccb48cb5335e8eace4990e52f93ea431c7085de
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-11 11:57:59 +00:00
Marcus Tillmanns
2a84b9f02b Utils: Fix FileAccess if device returns nullptr
A device may return a nullptr if it does not support device access.

Change-Id: I302a2c63406268a2ff876c1bf408c5e26137fd9d
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-11 11:57:52 +00:00
hjk
a386b5467a ExtensionSystem: One indirection less for delatedTimer
... at the price of a fatter #include that only ends up in very
few TUs

Change-Id: I983e2082d5b894ee561e7c7ba96731ef6bc58e3a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-11 11:39:00 +00:00
Marcus Tillmanns
c4ea695411 Terminal: Improve color tooltips
Change-Id: Ifc2fdb4369767a65c79a784d1f68caac81497db1
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-11 11:24:57 +00:00
Marcus Tillmanns
f73d288609 Terminal: Fix default colors for dark themes
Certain colors, especially red, were pretty hard to read
with the selected default colors on dark themes.

Change-Id: I9f5a2b5f14113499dbb662e1cbcc2b833952f201
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-11 10:58:56 +00:00
Alessandro Portale
03cca64eea ProjectExplorer: Add non-translatable text options to text edit fields
LineEdit and TextEdit have a couple of text options which start with
"tr". These strings can be translated via Qt Linguist.

In some cases, these text options contain macros or even JavaScript code
which must not be translated. Translation of these fields can
easily break the wizard.

This change adds the possibility to set non-translatable options for
LineEdits and TextEdits "(tr)Text", "(tr)DisabledText" and
"(tr)Placeholder" in the .json files.

Task-number: QTCREATORBUG-29649
Change-Id: I278a0bec848888cf96bdb49306e319c14a09236c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-11 10:34:28 +00:00
Marcus Tillmanns
4aef48de5e Utils: Add AspectList::createAndAddItem
Adds a function to add a "default" constructed new item to the list.

Change-Id: I3d826b6f3e3705ae431efa5d778219f431509ea8
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-11 10:29:14 +00:00
Jarek Kobus
d021f9158b SemanticInfoUpdater: Simplify internal implementation
Change-Id: If9913ccbc66d35608d18286ea3ca12d751ad2115
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-11 09:22:35 +00:00
Jarek Kobus
716c194846 KitManager: Use static methods instead of lambdas
Get rid of kitMatchesAbiOfBinary lambda - use kitMatchesAbiList
directly instead.

Change-Id: Iefd142b97967517b9c5abbd0721470a6ded584ed
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-11 09:10:58 +00:00
Jarek Kobus
7ee0687ad5 SemanticInfoUpdater: Make doUpdate() static
Don't operate on the same SemanticInfoUpdaterPrivate
instance from 2 threads.

Use future synchronizer for quick cancel.

Drop using QMutex, as now the threads are separated.

Change-Id: I33bb1485ff03751ec5a1481f5be5c21a48ac3fd4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-11 09:10:36 +00:00
Marcus Tillmanns
5e65223451 Update change log
With some details on the new features and things that were done in the
meantime.

Change-Id: Ib42447d472b271e70645e0660cc1fa01f99ea224
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-10-11 08:59:42 +00:00
Marcus Tillmanns
692fe58427 Terminal: Add debug button to easily copy theme
Adds a button to copy the current theme to the clipboard
in a format suitable for the Qt Creator Theme files.

Change-Id: Ib302d0544507b3111675a99f0915323d61d684c5
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-11 08:44:04 +00:00
Jarek Kobus
973dbaed98 PyDapEngine: Start install process directly from the main thread
There is no need to start it from a separate thread.

Change-Id: I0f560345ed0f02832176a8986a9fbdd97061d3ae
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2023-10-11 08:06:21 +00:00
David Schulz
adfdf3fe27 Help: make unregisterDocumentation async
Just like registerDocumentation this function can take a considerable
amount of time. As this function is also executed on startup it
increases the perceived startup time.

Change-Id: I43f4bb61293948c78eb7394d202757af83210eaa
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-10-11 07:38:24 +00:00
Jarek Kobus
ab13b7b155 HelpManager: Hide registerDocumentationNow() in cpp
This avoid calling collectionFilePath() concurrently,
which might be potentially problematic.

Change-Id: Ic873b6429b933f2f3359623b1e9cb14409ef3c4b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-11 07:31:08 +00:00
Leena Miettinen
5a715330fc Doc: Describe detaching views
Fixes: QTCREATORBUG-29636
Change-Id: I980d7c523bd40cbc7ad56696987688839baf154d
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-11 07:26:23 +00:00
Jarek Kobus
3391d789b9 PluginManager: Don't delete timer in its signal handler
Delete it later instead.
The startDelayedInitialize() is invoked directly by
delayedInitializeTimer's timeout() signal.

Change-Id: I8813679c5cf150cfe91b6bf48559c83b7e3cd893
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-11 07:13:59 +00:00
Christian Stenger
52ebafda4d SquishTests: Fix handling of arguments proposal
On slower machines or high load the proposal can take a split of
a second to appear. Wait shortly for the proposal to appear.
Amends 1d449ad7d6.

Change-Id: I705ce3819e13116386304994da60ab6660ccfbd8
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-11 06:57:35 +00:00
Christian Stenger
511c706153 SquishTests: Fix handling of clang based proposals
Change-Id: I6e66537ba2a562c835fef4363bdd422330288506
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-11 06:57:28 +00:00
Christian Stenger
b63c0670f8 SquishTests: Fix finding help contents
Fixes suite_HELP.

Change-Id: I57c0b82a758d3c91f29c4c48a8c33672f71afde2
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-11 06:57:18 +00:00
Cristian Adam
c929b71acd CMakePM: Add cache variables to code completion
Change-Id: I5ac4fcf3ca7755ab52ffecafd83922e4e380363e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-10 18:29:06 +00:00
Cristian Adam
524634f124 CMakePM: Add support for "$ENV{" code completion and help
CMake has a few environment variables that are documented and this
commit adds support for them.

Change-Id: Iaa31bdc97b343581fcf519d19e66bc6ce8ace150
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-10 18:08:13 +00:00
Eike Ziller
311fe1bf24 Beautifier: Fix saving of settings
Applying didn't actually apply the new values.

Fixes: QTCREATORBUG-29586
Change-Id: If9416cc18fffd269f6ca3d27523aa138e6f91d7a
Reviewed-by: hjk <hjk@qt.io>
2023-10-10 14:38:21 +00:00
Eike Ziller
839f737946 build.py: Apply additional config to all builds
Not only Qt Creator but also cdbextension & wininterrupt.
Otherwise there is no way to pass additional configuration to these.

Change-Id: I2bd4894f212df9795e1d66577bb25a26b29224a4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-10 14:38:07 +00:00
Eike Ziller
b14e7d0cb7 Fix the name of Win/ARM/64 wininterrupt executable
Just differentiating between 32 and 64 bits isn't enough anymore. Do the
same as for the cdbextension.

Change-Id: Ic5acc256641b5b63568d1ef4df825aea0724d756
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-10 14:37:53 +00:00
Jarek Kobus
4e649a0ac9 RefreshTranslationWorker: Call RunWorker::stop from main thread
Amends dc78c8faa2

Change-Id: I7254d6ea275f84e8e39fa4b21c4f33d24f81a3ae
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-10 14:35:32 +00:00
hjk
fa01c8029a CppEditor: Keep track of FilePath instead of QString
... in CppSourceProcessor::mergeEnvironment().

This is functionally equivalent as the scheme/host bits are identical
within normal projects.

The temporaries for path() were responsible for 10% of the time in the
function, in total ~0.5% of the C++ parsing in my Creator-in-Creator setup.

Change-Id: I7f4f163f0f4b46ebf876d631a8dc5fae667e9fd2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-10 13:16:44 +00:00
Christian Kandeler
f723b59bfc ProjectExplorer: Do not follow recursive symlinks
Also fix some inverted logic along the way.

Fixes: QTCREATORBUG-29663
Change-Id: I7a5027d4536e6a05e5d91a4d2d24780bae3ca259
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-10 10:41:56 +00:00
Christian Stenger
87856470f7 TextEditor: Suppress warning in QFont
Change-Id: I2ffaa8f9ebebc048c298c84143e9bf3d55520554
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-10 10:41:45 +00:00
Cristian Adam
afc6d555b3 CMakePM: Do not copy the PerformInputData structure
I needed to add more members to the structure, and will get static
analyser to complain that the number of bytes is to high.

Amends 3984108c0c

Change-Id: I162b9ef615dc7f6f76b08c5599eed24488bf7e88
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-10-10 10:04:14 +00:00
Jarek Kobus
6899e0cfae BuildManager: Add a progress label for awaiter task
Change-Id: I01d70a9dc4115407c33e171e44943935825a6ac9
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-10 10:00:24 +00:00
hjk
c90a6df6ef Revert "Utils: Fix BoolAspect::action"
This reverts commit 4c5e3aa6ba.

Not needed anymore. The action likely ends up in a menu or such
where it is effectively 'autoapply'.

Change-Id: Ib02cba871028fa1422e10622d263218089226c56
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-10 08:46:04 +00:00
Eike Ziller
8ca6890814 QmlDesigner: Quiet messages from find_package
The information is available via the CONDITION and FEATURE_INFO

Change-Id: I0da6338736316e5976c1addad6c25d083e7d772d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-10-10 08:22:42 +00:00
Marcus Tillmanns
f1c3482e0d CMake: Fix default cmake tool
If Boot2Qt devices are registered, their CMake tool would often end up
as the default. Instead now we only auto select a cmake tool on the
local machine.

Change-Id: I677ab06ae88ff36209e691ea0fadb356436e973c
Reviewed-by: hjk <hjk@qt.io>
2023-10-10 08:20:14 +00:00
Marcus Tillmanns
c9cf86856c Terminal: Add support for Windows Terminal schemes
Change-Id: Ic6911bdcd2152a5fec8be54a515c5df13c3c08d7
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-10 07:51:53 +00:00
Cristian Adam
45fb2c0986 CMakePM: Remove pointer check for null
The pointer contains the parent class passed with "this" and will never
be null.

Coverity-Id: 1568097 Dereference after null check (FORWARD_NULL)
Coverity-Id: 1568100 Uninitialized pointer field (UNINIT_CTOR)
Coverity-Id: 1568111 Dereference before null check (REVERSE_INULL)
Change-Id: I40e32d162689c749d498c4a63c073c0e336a3626
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-10 07:30:36 +00:00
David Schulz
6c9a710036 Utils: remove Q_ASSERT in comment detection
Change-Id: I076397ee56887c8b402d4c2b97838ceade165412
Reviewed-by: hjk <hjk@qt.io>
2023-10-10 07:11:32 +00:00
David Schulz
01dc62b019 Editor: Fix loading color schemes
When the user switched to another builtin color scheme the full paths
check do not match anymore if the user starts a Qt Creator with a
different install dir.

Change-Id: I4692c85a23a7d524497786db4dd8e1a00bb7a9fe
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-10 06:53:22 +00:00
Christian Kandeler
e607c5530e Wizards: Fix "pragma once" check
Obviously, boolean functions return a string that you need to compare to
"true" and "false" explicitly.
Amends 8e75381fce.

Fixes: QTCREATORBUG-29713
Change-Id: I19966555badd67f95f51ea1c1757d8b86e727010
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-09 15:26:08 +00:00