This was only meant as part of a safety net, but in the case that
the situation this was guarding against actually happens we'd also
notice by simply not seeing the effect. This is not different to
any other place in the code where we e.g. create objects/widgets/...
and don't put them in the right container.
Change-Id: I0700fd3ca235662b718cf01229211a4eebec8a9a
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
In KitManagerConfigWidget, plus a bit of style cleanup.
Change-Id: I6e28f697267c5e51d95a734cb2fe989346ac016b
Reviewed-by: David Schulz <david.schulz@qt.io>
Add another environment variable whether CMake should check for ccache
and adjust the compiler options accordingly when building Qt Creator.
Change-Id: I796f29d7f6ad4a1f054f978d50dbd0120b873aea
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
For easier testing a docker file is added. You can start
"buildandrun.sh" in copilot/tests/proxy to get a simple
proxy server up and running. The argument "PWDMODE" in
buildandrun.sh can be set to "with" and "without" to get
a proxy server that needs a password or not. The username
and password are user/1234.
Fixes: QTCREATORBUG-29485
Change-Id: I3859c9ad04ebd4f9349e25665ba710e23fb64dea
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
QLatin1StringView ist ein alias fuer QLatin1String, aber erst ab 6.4
Change-Id: I9b04d39722bf2707c327c6596a4bfe9ee719bae8
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
We are not yet making use of the integrated DTOs as this will happen
in a future commit along with the network requests to fetch the data.
Change-Id: I72cf9005cae052c41a7e906e0fae5dbe176e0882
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
runSceneGraphTest() did nothing but create an opengl context and
offscreen surface. It did nothing with the provided QSGNode.
The only thing it does is make the test fail if the opengl context
can't be created for instance on test machines without opengl.
Change-Id: I376c3565f5afcee6e123a7ef8b9832e679e645a0
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
The FilePath based one seems to be called primarily, so make that
the primary implementation, saving a FilePath <-> QFileInfo round trip.
Change-Id: Ib3427a5168e559b8a583570ac1c82dfe658644da
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Only emit changed if the current interpreter changes.
This is more in line with the other aspects.
This fixes the pyside detection since the changed signal was not
emitted in all relevant code paths.
Change-Id: I53409b17f260b35914e39de894b48d7bd1ce27c0
Reviewed-by: hjk <hjk@qt.io>
Slightly nicer code and works well with settingspages nowadays.
Change-Id: Ic12ff58f4b0f8db226843961eb2ab6fb8879429c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
In order to prevent any possible further conversion.
Change-Id: I0f8be7558affb36b3015144fe9c640a7bfcab295
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Mostly local variables and KitManager::kitAspectFactories() to
match closer what they are.
Change-Id: I8f837357528f9e1110888898077f82b5097003f0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Just re-organization relate to, but not a fix for the linked issue.
Task-number: QTCREATORBUG-29494
Change-Id: I0c5413b2dc97738a03b737e764194c4d90d3f086
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Make it implicitly threaded.
Get rid of ThreadedParser.
Don't move QTcpSocket instances, received by
QTcpServer::nextPendingConnection(), into another thread,
as docs says it's not safe.
Use wait condition for waiting for new data.
Don't potentially leak the Parser in loadXmlLogFile():
store a unique pointer to the running parser.
Introduce Parser::setData() method and use it with
QFile device in loadXmlLogFile().
Pass QAbstractSocket into the parser instead of
QIODevice and get rid of downcasting. The QIODevice
couldn't really work with non-socket and non-file devices
(like e.g. QProcess), as it lacks general error and finished
reporting signals (it has only general readyRead() signal).
Change-Id: I9352aec694564d4d2a26898841ed964bed470d82
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
If CMake version is lower then 3.27
- Shows the warning in general message
- Starts CMake without debugging
- Stops debugging correctly
Change-Id: Ibb13555c20ae2961c0a3c2ef6ec0fcc25930dddc
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
None of the functionality it provides is actively used.
The QObject inheritance itself is left as the factories act as
guard objects in some connections.
Change-Id: Ia6f2707a3a0a4e2810acdb4dd566afee855468b4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... and split out the static interface.
Change-Id: I5f9e3ed1e0c75fe26fa843858014070cb6cc0e6f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Added warning when current clangformat major version does not
match with version what checks was generated for.
Change-Id: I818c9a4f79385cba4e492ea5428bb051f329a9d4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
