... for the edge case of a lone carriage return occurring in the output.
Amends b0cad9e9c7.
Also adds missing adaptations to the unit test.
Change-Id: I219b24b8fb41bb0fcea9f677cd79286d03b130c2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This basically continues / amends work done
with e1c88116b3.
Change-Id: Ia8b3a4694e7fea4c15e344839f87c11fbe8fbbf4
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
We accessed a reference after removing the value from the container.
Change-Id: Idfb97093b7a23ba04e5cb0582c81031f431dce88
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Single chunks exceeding the limit were truncated and then shown
in a single line, potentially resulting in only a few chars if there
was a newline close to the cut-off point.
Now, don't restrict to a single line in that csae.
Additionally elide in the middle, assuming this is a better compromise
than truncating at either end.
Also, make the truncation more obvious, and mention the amount of
elided characters.
Change-Id: I850e2833e7f1f8be0f584d8e4439dd1a64f851d0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
When pressing Ctrl + Shift + F in design mode the OutputPanePlaceHolder
is requesting its splitter, which isn't set with ADS. To avoid nullptr
access a check for the splitter before accessing.
Change-Id: I3085bba23d4cf9bddcfec154e4557000d880600d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The coreplugin/id.h header is kept for downstream for now.
Change-Id: I8c44590f7b988b3770ecdc177c40783e12353e66
(cherry picked from commit 430a33dcd9)
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Was changed to an alias for Utils::Id.
Change-Id: Ib1b166a27b16939f8b6c3e5888dab8248660658a
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Checks if there is a library file which is a Qt Creator plugin
that is compatible with the version of Qt Creator that is running.
Change-Id: Ic5284e3803c45b8e2ef0d30afccb1680fabf43f3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
We can ignore the Archive result when the user goes back, and we need to
reset the warning label style when she checks another archive.
Change-Id: I76ce07d1a46875ac72696bcf7ab6c804d63b906b
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
The intermediate "category" nodes where never filtered out.
CategorySortFilterModel was changed to use filterRegularExpression() and
setFilterFixedString does not set that (it only affects filterRegExp()
which we need to get rid off).
Set a regular expression directly instead of a fixed string.
Amends 47e576528e
Change-Id: I6f844027b83d66ca2d5088d83e6e84b01b9eda45
Reviewed-by: hjk <hjk@qt.io>
Not in Qt 6, and I don't see a difference.
Change-Id: I4556e48f9ab60b4024ca46a7ed1389b54744c891
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Current implementation requires each VCS to connect to the referenceClicked
signal. Only Git does it, but this is conceptually wrong. If other VCSs
would connect to the same signal, all of them will act upon clicking a
link, which can result in multiple editors, most of them are likely to be
invalid anyway.
By default executes vcsDescribe. Can be extended or modified by subclasses.
Change-Id: Ib953009efd77446a4b2963f0aa8a2f3f3d26509f
Reviewed-by: Artur Shepilko <artur.shepilko@nomadbyte.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Change-Id: I1d4fc0f25f1882a34058c66c51376982cc70238e
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The only reason it was required to be in Core plugin, was its use of Id,
which now is available in Utils.
Change-Id: I66ce863c24924e6448d339b3422538a7fe167336
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
And add a compatibility wrapper for Core::Id, so we don't have to rename
all occurrences from Core::Id to Utils::Id.
This allows us to use Id also in Utils, which makes it possible to e.g.
move Core::InfoBar to Utils without work arounds.
Change-Id: I5555d05b4e52f09d501dbfe5d91252a982a97c61
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Already exists in all implementations, but there was no common declaration.
Change-Id: Ieb3d10d1936c207722b5001712bce41e8114dcdc
Reviewed-by: André Hartmann <aha_1980@gmx.de>
All implementations return true unconditionally, and the return
value is never read anyway.
+ Remove superfluous function with the same name in Perforce.
Change-Id: I83f361ec7fd8be3177cb4be52e6276e295cd4279
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: hjk <hjk@qt.io>
This fixes a double delete of the new debug mode menu.
Change-Id: I633ab9eb319554d4fc2da158b83f6611ab10ce45
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
So far that only moves unarchiving and the check if that succeeds to
within the wizard.
To be extended with additional checks for the archive content's sanity.
Change-Id: I6798937826fbe9cb584d83a920e67b6cfcc119ed
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Set a menu for switching perspectives on the debug mode icon. When icons
& text are shown for the modes, there is an additional arrow to the
right of the mode that can be clicked to open the menu. This
functionality was added in 4.1 for that purpose, finally use it.
Do not show and arrow in "Icons Only" mode, so it stays small, but make
it available on right-click as well.
Change-Id: If19877b5231b7f01f0b3fd98cf65e8eaf9da1a5f
Reviewed-by: hjk <hjk@qt.io>
Turned out it was easy to overlook and didn't reduce the list of
visible plugins to a degree that makes a difference.
Change-Id: Ib261066b215b66ffb683a87b8592570d895917ac
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The default for non-packaging build is OFF.
Fixes: QTCREATORBUG-24128
Change-Id: Id422babe197e215d6cb33807a78ba1ee3aaabb32
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
It will become more complicated, so pull it into its own files.
Change-Id: If362f0775cc9d97a3c715c046d32d6a20c30a1f9
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
There are very few reasons to use mainWindow() directly.
Especially for modal dialogs, using dialogParent() is important, since
that guarantees the stacking order in case of other dialogs currently
being open.
Change-Id: I7ad2c23c5034b43195eb35cfe405932a7ea003e6
Reviewed-by: hjk <hjk@qt.io>
