... at line start and end.
Fixes: QTCREATORBUG-31020
Change-Id: I3b26089ef72a34dedfe8846119f672e75bf03215
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Don't try to start qmlls if the found path doesn't exist.
When there is no Qt version found in the project (this happens
when you open a qml file without providing its build folder, or
open it without the project info so no linked Qt version is found)
we might end up with incorrect path where no actual qml executable
exist for that path. Check the existence of the binary before assigning
it as the path for qmlls.
Fixes: QTCREATORBUG-31207
Change-Id: I626ace796401e72462eb850d4bd88c1ef51cf53a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
Replace QMap with a list of FileToPull struct.
Rename gatherFilesToPull into filesToPull and make it a static
getter.
Simplify for loops.
Change-Id: I74208a60efb8f00676c1b72c807ba9c7bd6ef587
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
If a tab is re-used for a different application, the output file name
must change too.
Fixes: QTCREATORBUG-31099
Change-Id: I3413fca3a99757777db8cb771f0947f655d20ea4
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Enabler need to get set after reading the settings.
Silences soft asserts.
Change-Id: I7e70279537a87462e607e51a40d9fef565b46fa8
Reviewed-by: hjk <hjk@qt.io>
The message result type was checked, but the promise
was still finished without an error.
Change-Id: Ib5ba5f48202073a82bfbcb871e0d5a5277ea9f2a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
On some platforms/configurations the popup for switching documents does
not close when releasing the modifier key. Add some debug output to try
to find out what happens.
Task-number: QTCREATORBUG-27378
Task-number: QTCREATORBUG-31228
Change-Id: Ia882ce6be1bd235601f9c869b79fb8c15ab72a3a
Reviewed-by: David Schulz <david.schulz@qt.io>
This change remove the AndroidQmlPreviewWorker which was only used in
QDS and is now (QtC 15 development cycle) obsolete in that context.
Fixes: QTCREATORBUG-31221
Change-Id: I2e361c8245f70178fb0f0e3e1c0a9499d783856d
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
As a drive-by, lower some timeouts from 2s into 1s.
Change-Id: I495ad20058b0f97b6cdd5271a390b779c66b4864
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
These can be more descriptive than the index integer.
Change-Id: I0d992fdcfa13258c62f66056d61d9a4659272563
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
They do not work with CMake projects
Fixes: QTCREATORBUG-28467
Change-Id: Ic656c28d0e6bdde976bf7ffd75796b51c1aba06a
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
Explicitly add the options button to make sure that is at the correct
position, and do not use multiple conflicting methods to specify tab
order. This adds the various buttons back into the tab order.
Fixes: QTCREATORBUG-30791
Change-Id: I5d1fbcd213b57bf4d7af98ba5d21b09e408e84b7
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Improve code readability by requiring iteratable Group
to be named For.
The For's c'tor requires an iterator element as a first arg.
The For's c'tor allows for passing exactly one iterator element.
It's not possible to place iterators inside Group element anymore.
Change-Id: I9dfe2c0da058abac161f66c4e336da2417c383f1
Reviewed-by: hjk <hjk@qt.io>
... and use it for edit mode.
There's currently no real effect as the mode bar population in
ModeManagerPrivate::extensionsInitializedHelper() accesses all
IMode::widget() and triggers the creation, but in principle we
could pass the functor instead of the widget down to and store in
FancyTabWidget and only use it when a mode gets activated.
Change-Id: I4c4a276bc025abce1ff47c68b060c67b5c8e5170
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
As in all the other wait() functions.
This makes sure we never hang indefinitely in tests.
Change-Id: I119cc0d6d6146f193ffde37207a94f61b3c70d87
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Since the git repository is removed on coin, go cannot fetch
version information from the git repository. We need to tell
go to ignore this information.
Change-Id: Icd1066efc7eabfdf82aba41b4f3a06202b581518
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
... when enabling/disabling an environment variable via the buttons.
This was forgotten in 8ef85e481a.
Fixes: QTCREATORBUG-31222
Change-Id: I02f2840cd0dadc628120275585245f8d1c23cec8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
A step towards having delayed mode widget construction.
Change-Id: I1d400e058d17aaebfc784000d8b2705debea6a51
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
