This "edit-copy" icon used for source folders is very confusing. The
linked bug report has screenshots comparing Qt Creator and Xcode. Xcode
just uses consistently a folder icon for all nodes that are actually
folders.
This change will make Qt Creator also display a folder icon for the
source folders.
Task-number: QTCREATORBUG-30012
Change-Id: Ibfcc4f55e779ed368edd30bfbc711bd81a4aa499
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Add a comment on how to quit a Qt console application.
Fixes: QTCREATORBUG-31212
Change-Id: Id5dc5b6c4eba807e41fc589d16f44d133c94c6b3
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
No need to bump this all the time, just use the current year
Change-Id: I3f2abf6a0a54185b7b47e68aacb3cee2f27aa675
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
CopyAskingForOverwrite got passed around as value, thus it got copied.
The messagebox results were stored into the fields of such copies, and
therefore had not the expected values across the recursion.
This change wraps the copy helper function into a lambda and the lambda
is passed around instead of the object. It may still be a bit much
decoupling architecture for a single use-case, but it works now (for
me).
Fixes: QTCREATORBUG-31174
Change-Id: I5444d18d7bf4ef59ab879e31e5233eadf1c935e4
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
It's conceptionally const, and would be useful to use as such, but
the current implementations often modifie mutable state.
To ease the transition pain, rename the previous non-const version to
addToLayoutImpl() and call it after const_cast'ing.
Change-Id: Ic8ca38e40f5df69c3d11121f96ea37648cf4feb7
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
The menus that are available from the back and forward buttons in the
editor toolbar could show empty items, because some editors are not
backed by files. When they are closed, they are no longer available. For
example: open a file, trigger a git diff (regardless of whether that is
empty), switch a fill times between file and diff to fill up some history,
close the diff.
Just do not show history items with empty display names.
Change-Id: If7e966e55ada407ed03069027b352d12f053751f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
We want to minimize backtracking in OutputFormatter.
Change-Id: I114472d761ddbf0a2c3e6b42c87a531206fb1473
Reviewed-by: David Schulz <david.schulz@qt.io>
... when generating compilation database.
This can happen in session mode.
Fixes: QTCREATORBUG-31186
Change-Id: Ieb081932ac2c562bacae995c7d05a3e0e96c9153
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Amends 104ea4acc.
Hidden friends don't work when declared in the wrong class.
This here happened to go unnoticed as it was nowhere used.
Change-Id: Ie26d5c777c85e143a6b7189ccbd87aedd2502df0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
If qmake -query fails for some reason then %{Qt:QT_INSTALL_PREFIX} would
evaluate to an empty string and CMAKE_PREFIX_PATH will not help CMake
find Qt packages.
By using the path to qmake itself we can safely determine a valid
CMAKE_PREFIX_PATH and CMAKE_FIND_ROOT_PATH.
Fixes: QTCREATORBUG-31194
Change-Id: Ib649dd57bfe3a97ef93a42603d83331922f99612
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Qt (or its MarkDown parser) cuts off the link before the ..
Enclosing the URL in angle brackets helps with that and is also valid
practice in MarkDown.
Change-Id: I06e33ec9edb42f80cd020b9b65a7bc2a32345e75
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Qmlls client was still alive eventhough it was turned off via the
settings page. This was causing both qmlls highlighter and the embedded
highlighter do the job at the same time. Disable qmlls client
appropriately.
Fixes: QTCREATORBUG-31148
Change-Id: I9577a78f9c861cf2fe718ffe58f3d7f77a916b9a
Reviewed-by: David Schulz <david.schulz@qt.io>
At some point the LOCATION target property of Qt::Core must have changed
from
<fw_path>/QtCore.framework/QtCore
to
<fw_path>/QtCore.framework/Versions/A/QtCore
which broke the code that tried to infer the `fw_path` from it.
Instead of constructing a relative path from the LOCATION, just
cut off the `/QtCore.framework/` and anything after it.
Change-Id: Ieed8ade6318c602d9cb4ff9685a084e4f8194086
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Before Qt 6.8, the versionnumber-less targets of Qt were interface
libraries that linked to the actual versioned Qt target. Since then,
they are actual targets in their own right, so the code that determined
the header location for Qt on macOS failed.
Change-Id: Icb2d2fcb075b9b4c2808d7edc0a7ec3fb7be49f7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Gets in the way of simplifying IContext handling.
Change-Id: I30961202164062743d9b9ddad34f95b25360f395
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
It is now 8px big and has a corner rounding of 1px.
Task-number: QTCREATORBUG-31080
Change-Id: I7b50707f021160b9de76185aad357000398bf5d2
Reviewed-by: hjk <hjk@qt.io>
Apply new design and images from the UX team.
Task-number: QTCREATORBUG-30248
Change-Id: I202288f0dccedc65e47cd8bdfa49915d47cd79cd
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
... to simplify the user code.
Some, but not all, potential beneficiaries are adapted.
Change-Id: Ia7d514a0114a4f99f8ee745523435f5b990bd095
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This is never called, neither directly nor indirectly via the
IEditor/IContext base classes.
Change-Id: Ie68595598c36dbbc6d0e3eb84aea756ed0e66029
Reviewed-by: David Schulz <david.schulz@qt.io>
The current code silently failed to add the description text to the
search role. This change fixes it.
Change-Id: I33e5554ac1ff2b11f9610843b566698551a6e0a1
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
- List the available device definitions
- Add information about the other fields
Task-number: QTCREATORBUG-30604
Change-Id: If22f8bfae916bafed7f1153fec7fd5962e406d5f
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
This sets no context, i.e. effectively does not do anything.
Change-Id: I5f2e30f61fd5547f71cd69a43667c21ea4d06c77
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
IContext::context() returns a copy by value. Adding to that does not
change IContext's internal m_context, i.e. these lines are effectively
no-ops.
Assuming that it currently "works", the setup probably happens
elsewhere, and this code is superfluous.
Change-Id: Idf33c769eed98bfa34a6def7649c8280f1551716
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
