Commit Graph

84014 Commits

Author SHA1 Message Date
Eike Ziller b519ebf1c9 ProjectExplorer: Do not use Yes/No as buttons in dialogs
It is clearer to name the "accept" button after the action that is
performed when clicking it.

Change-Id: I1153169d48082e95722150a4cfcd92939ba92889
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-18 11:28:37 +00:00
Christian Stenger 9f7203b0d2 PE: Allow skipping of compress on specialized folder nodes
Fixes wrong handling of multiple qrc files when having just a
single prefix.

Change-Id: Id5ac357d4ab6a7f7556b36a9fc44da398ede093c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-18 11:24:39 +00:00
Eike Ziller 8f3e77a3ae Tr: Re-fix plurals
The number for the plural must be given as the 3rd argument
to the tr() call, not as an arg().

Amends 1359e9c84f

Change-Id: I45241a6acd82041c320bbe476cd2b4cc92247ef3
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-10-18 11:22:11 +00:00
Eike Ziller a253a2aa95 Tr: Fix lupdate issues
Add missing `Tr::` and use some fully qualified namespaces where lupdate
fails to resolve it correctly.

Change-Id: Ied4ac7bf0438a9080d0b76a9a1f5033dbc94a163
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-18 11:21:52 +00:00
Eike Ziller 15d31610ee Tr: Use more arg() and move tags out
Change-Id: I80e28de3add81d0569b87dbb1712229cda5fb42a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-10-18 11:21:10 +00:00
Eike Ziller 64550e1339 Tr: Small fixes like full stops, whitespace and typos
Change-Id: I4d1edba6d28661af3c2255add35141f1e73fc304
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-10-18 11:16:03 +00:00
Eike Ziller cee8309998 Tr: Parametrize some application names
Change-Id: I5222455d895aecb94c9a96d0a0f4fd7c279a7388
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-18 11:14:39 +00:00
David Schulz 74cf082ee9 LanguageClient: properly deactivate documents for closing Clients
Deactivating the documents resets all client specific data and objects
in the document like the formatter or highlighting information.

Fixes an assert in the LanguageClientFormatter.

Change-Id: I7069abb273749ae335fed11010a5055eacaf58b2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-18 10:58:13 +00:00
David Schulz 18c00cd381 Python: reduce freezes in settings page with remote interpreter
Do not check the existence of remote interpreters when opening the
settingspage since we could run into device timeouts for unreachable
devices.

Change-Id: I5d0d1316961fc4ecbd2be55f6df70091ff65ecd5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-18 09:53:45 +00:00
hjk 499a786053 Utils: Be a bit more verbose in debug output
Change-Id: I0fd7bc92784efa184bac1cdbd5ae4c2d0158fb28
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-18 09:48:32 +00:00
hjk 2886b2b383 Debugger: Robustify gdb stack frame extraction
frame.older() might run into invalid debuginfo and throw.

Change-Id: Iba1d395f21719bf28184302427c7ab2435c6a663
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-18 09:48:23 +00:00
Eike Ziller 22c1d34e64 Copilot: Use normal checkboxes in settings
We usually do not use the "Label [ ]" style, at the very least it looks
different to other places in the settings. And without a ":"
("Label: [ ]") it also looks different to other lines in the same page.
Just use normal checkboxes like we do elsewhere.

Change-Id: I7f7d7aab399bef50dacb1efd83a5da460237e044
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-18 09:47:11 +00:00
Eike Ziller e6ecfa0517 Tr: Move some line endings at beginning and end out of tr
Change-Id: Ibb0aba4d6e58bfe4684a818a894876c1f8f7df15
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-10-18 09:33:25 +00:00
Alessandro Portale 5336fd83a0 QmlPreview: Tell users how to preview single files
In order to preview a specific (QML) file, a QML Preview process has to
have been started, before. The "Preview File" context menu action was
therefore disabled until at least one QML Preview was running. This
precondition is neither documented nor evident to users.

This change removes the disabling/enabling of the context menu action
and shows an explanatory message box for the case that no running QML
Preview is available.

Fixes: QTCREATORBUG-29300
Change-Id: I643c57cab15ef4893a8efa6ac8839a3c00e956fb
Reviewed-by: hjk <hjk@qt.io>
2023-10-18 08:21:13 +00:00
hjk 0e77cdcc2e CMake: save a few cycles
Cheaper checks first.

Change-Id: I7487862abf409ef0a885d6ac9511066a6f814039
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-18 08:08:00 +00:00
Marcus Tillmanns 755eefcbb2 Core: Refactor logging viewer
* All log categories that were ever used are captured.
* Fixed various small issues.
* Allow disabling individual logging types.
* Add Splitter between messages and categories.
* No longer needs to interpret or change QT_LOGGING_RULES.

Change-Id: I33be4754d550064bc66274f655a59e7af67ae487
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-18 08:00:33 +00:00
Leena Miettinen 5d79b010bf Doc: Describe the Markdown editor toolbar buttons
Task-number: QTCREATORBUG-29392
Change-Id: I390e2c525f9c1c6cadf874cfc313b17429f1f52a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-18 07:35:36 +00:00
Leena Miettinen 865b6d5777 Doc: Add paths to options and links to docs to the change log
Change-Id: I1c9ae020a7af9a0a88c7204cb90569b2f37f2c67
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-18 07:35:21 +00:00
Cristian Adam 70e9c2685f vcpkg: Set VCPKG_ROOT environment variable for Qt Creator process
This way CMakeProjectManager's auto-setup.cmake would pick it up and
find vcpkg.exe

Change-Id: Iafa84f13e0f50321ce771fc687ecc9e2df148de7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-17 18:10:52 +00:00
Alessandro Portale df9808562f Vcpkg: Fix a vcpkg detection regression
Amends: ec7abcf98c

Change-Id: If1e8c124208b2d8eeea22b1b88f80b325c4d2efb
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-17 16:35:57 +00:00
hjk 53b3255256 CMake: De-noise fileapidataextractor.cpp a bit
Change-Id: I1ed8b18e394246cbfd14394c7f9b79fd90f680d2
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-17 15:22:02 +00:00
hjk b5dec80d6b ProjectExplorer: Don't create Replacement kits for Design Studio
It's not wanted in this use case

Fixes: QTCREATORBUG-29717
Change-Id: I04ccd4c9e8bfe15e76294a42f3f0bd9d879599e5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-17 15:05:12 +00:00
hjk 8845a7f896 CMakeProjectManager: Use a few FilePath::path() instead of toString()
... when appropriate.

Change-Id: I2c23e4688ec69f78b0ce873e578139d5c4e89c35
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-17 15:04:57 +00:00
hjk b38c7a452e CMakeProjectManager: Fix path construction of pch files
This triggered soft asserts in FileUtils::copyIfDifferent() when
opening top-level qt.

Amends 246f33c20d which introduced a unwanted extra .parentDir() call
which removed part of the path.

Change-Id: Id0475a74a589372d37b7ec65d33d3faf6194013c
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-17 14:52:35 +00:00
hjk 058a931d27 ProjectExplorer: Manually check whether a runconfig has a creator
This is used in ProjectConfigurationModel::data()

Constructing the full list is comparatively expensive, and the extra
decoration is not needed.

Change-Id: I5b6c76376f806ea92444916a87d1f2e671e16d5f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-17 14:35:36 +00:00
Cristian Adam 879692381f CMakePM: Fix conan default profile auto-detection
CONAN_COMMAND was not available for `conan_profile_detect_default`
function.

Change-Id: I03df06aa88e6588101bb5ec54b3ce2cb64dee2c8
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-17 13:54:17 +00:00
Marcus Tillmanns fdeff13ca3 TextEditor: Don't export KSyntaxHighlighting
Change-Id: I84fa8c758af412d8847391a628deac60279b9448
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-17 13:25:50 +00:00
Marcus Tillmanns ab23ee98f9 PackageManager: Search for vcpkg in project root
Change-Id: I467476e6897f36558afc76a262f631cdaa47320e
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-17 11:43:57 +00:00
Cristian Adam 2e2248e80e CMakePM: Allow invalid file characters as part of preset names
The fact that Qt Creator uses the preset name to create a directory and
then import the directory is an implementation detail.

This changeset will allow characters like ":" to be part of the preset
name.

Task-number: QTCREATORBUG-29643
Change-Id: I84a224b78eb3d2233f80d9bdb8bf4478471349b0
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-17 11:37:57 +00:00
Marcus Tillmanns e13c1a1239 CompilerExplorer: Fix display of selected library
Change-Id: I44085ef914930a16f14a2fc79e2941852dc2e4fb
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-17 09:24:22 +00:00
Christian Stenger effe73024f AutoTest: Avoid duplicated logging category
Change-Id: I6b8b56176f4f5e919badd87e7603f1b05a0f0245
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-17 09:09:33 +00:00
Alessandro Portale 30e8a1db55 ScreenRecorder: Switch from Experimental to DisabledByDefault
Trivial plugins may apparently skip the experimental state on their
introduction. At least according to the mutilple request towards me to
do so with the ScreenRecorder plugin.

Change-Id: I1e3d911ee79548d0fd72d3af0e3a568f6ab88d5a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-17 09:06:34 +00:00
Christian Stenger 2119ef72b0 AutoTest: Fix creating test projects for cmake and qbs
...if the respective kits have no Qt configured.
GTest and Catch2 get fixed with separate patches.

Change-Id: Ib3eb92e97fd683f42e3666bd41728a3824e230ec
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-17 09:06:13 +00:00
Leena Miettinen 66f77f749e Copilot: Fix UI text for proxy settings
Change-Id: I36854db711d697bd1cb0ffc8a646e00c97979e2f
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-17 08:59:27 +00:00
Marcus Tillmanns 1891c37b46 CompilerExplorer: Fix restoring library selection
Change-Id: Iae64cf8629495457e423d9e635b2ffcf912d89b8
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-17 08:58:43 +00:00
Marcus Tillmanns e3f33962e3 CompilerExplorer: Fix highlighter for assembly
Change-Id: Id58546d99232b19252c99da5018c1ce45a2e8dc5
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-17 08:53:45 +00:00
Leena Miettinen 5b97cb375b Doc: Describe new C++ refactoring actions
- Convert Comment to C/C++ Style
- Move Function Documentation to Declaration/Definition

Task-number: QTCREATORBUG-29392
Change-Id: Iae48cd752c909a0007929e0111aa149fbfea02ee
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-17 08:48:20 +00:00
Marcus Tillmanns d8a75d48a3 TextEditor: Add selecting highlighter by name
Change-Id: I5c706dd151173bf08c5fbd4dacbf6e5d6416b87b
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-17 08:47:45 +00:00
David Schulz f2934f8497 Utils: avoid another assert in FileSystemWatcher
amends f77635883b

Change-Id: I2b0f92db3218192457a08ff8a473444fd2f811a8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-17 08:01:41 +00:00
Eike Ziller c2a470e853 Revert "TextEditor: Hide LineNumberFilter implementation"
Fixes missing "Line in Current Document" locator filter.
Locator filters need to be created during startup.

This reverts commit 8af6d16b6c.

Change-Id: I53ec1c1079b4a719169e8db95b6d77f703264b65
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-17 07:46:02 +00:00
Christian Stenger 54b841f789 QtSupport: Store Qt versions after autodetection on startup
Restores old behavior. When QC is started with a Qt in PATH but
without existing settings it ran the autodetection and stored
the Qt versions to disk. This made it possible to restart QC later
with the same settingspath, but without having Qt in PATH.
Without this patch the Qt versions of QC only got persisted if
the settings dialog had been opened at least once and closed with
Ok (or an explicit Apply).

Change-Id: I74bd9bc0b96d5ff66e5a81200d6a269a5411a5ea
Reviewed-by: hjk <hjk@qt.io>
2023-10-17 07:39:31 +00:00
Eike Ziller 3363d71888 Build: Fix handling of (s)ccache support
So it also works when building individual projects like cdbext

Change-Id: Ibb9cac77146a9f19cbbe22f2c7257b951f38f3fc
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-10-17 07:30:51 +00:00
Christian Stenger 67ad0cf556 AutoTest: Improve Catch2 wizard
Since version 3 of Catch2 it is recommended to use the
approach to link against Catch2 instead of using a single
include.
Make both variants work. There is still a third variant of
using a single include for version 3, which is left out
here, but can easily be fixed for Catch2 users.

Change-Id: I2c25837cb1df4b460b662466dde68563fa7d713c
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-17 07:28:47 +00:00
Christian Stenger bded214791 AutoTest: Improve GTest wizard
It is possible to use the header-only approach as well
as linking against googletest, so make this explicit
inside the wizard and fix the projects for the
respective choice. The old approach could work, but
mostly coincidentally.

Change-Id: I5b1c0b8dfd9a2ffac3268fc4c724ba47c2bf124c
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-17 07:28:38 +00:00
Marcus Tillmanns 98d3508baa Docker: Fix deadlock
The blocking queued connection could block the main thread
if the main thread was blocking for an action that would access
the docker device.

Change-Id: I79c0c74688ac77f2763b9aa748386f27be011304
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-17 07:25:09 +00:00
hjk b26e12e199 Debugger: Add a dumper for Utils::Key
Change-Id: I7e586b622160d5b06a3971fec825521231c09522
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-17 07:11:14 +00:00
Cristian Adam 16b147d563 CMakePM: Expand macros in cmakeExecutable CMake preset value
The specification allows this, so we need to support it.

Task-number: QTCREATORBUG-29643
Change-Id: I8bd0a91ba05d2ed27b7a7af2d268539de020826f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-17 06:36:29 +00:00
Cristian Adam 12a6d9e5dc CMakePM: Update CMake conan to latest version
Url: https://github.com/conan-io/cmake-conan/blob/develop2/
conan_provider.cmake
sha: 451fa97d2c59c07b13fb4812a64b2a6391f9e781

Change-Id: Ia52f5d856cf045d7a1d1871d6d43fd1d014439c4
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-16 20:05:21 +00:00
Eike Ziller d62f368ceb Tr: Adapt to source string change
Amends 0634f9259b

Change-Id: I4fd8a3e8d7503d14676380a2c0eac958f99814ae
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-10-16 13:19:44 +00:00
Eike Ziller 1359e9c84f Tr: Fix some plurals
Change-Id: I9d7a52a64536e6e1c0a9da4f3cb2f3a116afb6cd
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-16 13:19:28 +00:00