There is nowadays a hard dependency on QmlJSTools as there is
need to access its QmlJSModelManager.
Beside this adapt the tests to reflect the Key / QString changes
happened inside the settings to avoid crashing the tests.
Change-Id: I71cd0457e5f567da28cc089b514655418bd60b7d
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Don't use a copy of m_files for mkdirTask(), as m_files is
modified by the running recipe. So, when the recipe is prepared,
the m_files doesn't contain the right data, yet.
This is going to be refactored in master, as it seems the
isDeploymentNecessary() operating on mutable internals
is confusing.
Fixes: QTCREATORBUG-29609
Change-Id: I3f34584ffd9486322e8b26f95ac72b96a9306f8b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Windows only: When toolchains get restored on startup,
WebAssemblyToolChain would try to add MinGW to an environment. That
env is used for querying the compiler version. In order to find MinGW,
the MinGW toolchain is queried from ToolChainManager. But since the
ToolChainManager is not yet loaded at this moment, we get a QTC_CHEK
assert from ToolChainManager::toolChain.
This change prevents querying the ToolChainManager before it is loaded.
The compiler version can successfully be determined without MinGW in
path.
Whether we really need to query compiler versions that early is another
question outside the scope of this change.
Change-Id: I46edbb80edc58d7465e90e99f7f8381708f704a1
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Qt Creator will display the header / source files based on the
sourceDirectory of the target as base directory.
The source_group(TREE <dir>) will result CMake in making a source group
named "TREE" which should not be displayed in the project view.
Amends 9280f7f757
Fixes: QTCREATORBUG-23942
Fixes: QTCREATORBUG-29105
Change-Id: Ib71ffcc559376ea1596a5b21cb7e7fa779bd8d79
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
The "proper" build directory is required during different stages of the
Android application deployment. For example in order to determine the
input .json file for the androiddeployqt launch.
If the CMake target has a modified LIBRARY_OUTPUT_DIRECTORY property, an
incorrect build directory was determined. This change adds a hack which
in such case (and only for Qt6 + CMake) tries to find the right build
directory, which also contains the .json file.
Fixes: QTCREATORBUG-26479
Change-Id: I24342f696aed7a322030eb9310d3ca71bcada81c
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
We now support Catch2 in two different versions which means
we need different include directives depending on the version.
Let the user choose the correct version instead of providing
a fixed one that may be correct or not.
Change-Id: I0199070b4f4602b8e08b7ac60731071f0cd33141
Reviewed-by: David Schulz <david.schulz@qt.io>
This is not handling the respective role correctly, just
silencing the warning. No change in current functionality.
Change-Id: Icd904941d5fc496d66b8e1eb7eec0031840f519d
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Since Qt 6.5.1 QPlainTextEdit::selectAll emits correctly
cursorPositionChanged on selectAll which calls some multitextcursor
update code on our side. Avoid setting the cursor back to the
QPlainTextEdit in this update code by setting the expected
MultiTextCursor before calling selectAll.
Fixes: QTCREATORBUG-29763
Change-Id: I77f05ac40a9dd126efcd72089a699c908c68da21
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Remove the period from the file extension .so because the completeSuffix function of the FilePath class does not return the first period of the extension.
Change-Id: Ifd850e54337c399d6440b6ad765c3b23df9ed330
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Qt Creator 11.0.2 changed the default DPI rounding policy to
"PassThrough" for Windows. In QtC 12, there is now a setting that allows
the user to chose the policy. The default was changed to "PassThrough"
also for Linux.
This change sets the default back to the original policy "Round" which
Qt Creator used from the beginnings of HighDPI support.
Amends: 3726f0d6c1
Change-Id: I74f2310f1b5379c8dea0bf86aee965374ca2732e
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
When using the "Close" and "Cancel" standard buttons, it is no longer
possible to change the button text on macOS. Additionally, the behavior
on pressing <esc> is broken when using QtC in german (it should just
close the dialog == cancel, but in german it triggers "close").
Task-number: QTBUG-118241
Change-Id: Ia35e6a29cd97fb91552dc5600f91be8b8e443f39
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Don't use exclamation marks!
Add "the" articles (conforming to the other source texts).
Finish error sentences with dot.
Change-Id: I1faa547e2c3bae90ea900b781eccf327ea810326
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This is allowed by `find_package`, and can be tested with the `fmt`
package provided by conan.
Change-Id: Ib9bf2a6cbd80b8eb322cb6d8a1a9c25af0ca4031
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
If no preview is running there is no need to process anything.
In theory the basic connections inside the plugin might be
better properly done and explicitly connected and disconnected,
but I wanted to avoid an intrusive change after the beta.
Fixes ongoing message box displaying when editing a qml file.
Kind of amends 5336fd83a0 as it
revealed this misbehavior.
Change-Id: I5081e1c7d2154e3cc75ad9da32af1b0c7f86dff2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This fixes the synchronization on early shutdown, e.g. when
Creator is started with "-test Ios".
Change-Id: Ia18215a090809b6095d51ee3647728b4b2ad2d5f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
It already under a title "Language Server", no need to repeat
Change-Id: Ib0da722dfdaede194e48fa5f0ff3948ec0f16842
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
- Change link to Neovim plugin installation to point to the Readme.md
- Add instructions for macOS users for finding the About Plugins and
Preferences (using the \preferences macro)
- Describe proxy settings
- Fix a changed check box name
Fixes: QTCREATORBUG-29734
Fixes: QTCREATORBUG-29613
Task-number: QTCREATORBUG-29392
Change-Id: I2b392e805322fd95a7b87295756d5df76015bbbc
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
In the worst case scenarios we either track unregistered files or do
not track the files that had been registered. Both are less intrusive
than a crash.
Change-Id: I880d80dddc401fd996ac1f18e82414665510fd30
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
If multiple recordings were made in a row, the crop area was reset each
time and had to be reselected by users. This change implements the
retaining of the cropping area during the lifetime of the Recording
dialog, as long as the clip size does not change.
A potential trap is now, though, that the cropping area remains the same
even if the screen gets changed or the screen recording area was just
moved. But I believe that the new convenience outweighs this corner
case.
Change-Id: I0326dfcad6827b2d504a4e309891824b16b6a47c
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
The macro can be used to show the path to Preferences
on Windows, Linux, and macOS. The current value expands to:
"Edit (or Qt Creator on macOS) > Preferences".
We can now change this in one place if we so wish.
Task-number: QTCREATORBUG-29734
Change-Id: I9afe4f7093dbcc8e62a2b18e1ae3f6f243bbb72b
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
It is "menu bar", and use placeholder for shortcut instead of
concatenation.
Change-Id: I60094a5fac3893663180f7ef573b6dece7670111
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
- add missing colons
- rejecting unauthorized certificates is the secure option, turning it off is
insecure
Change-Id: Ia09994ea75460fd5ebdd8354412d3122bd32eeed
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Qt applications are built with "-mno-direct-extern-access" these days,
which throws off clang-tidy.
Change-Id: Ifaaef84f6da37a0abb7b7a68296723fa41b572a7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
