If the current project is Git managed, but the user opens a header from an
unmanaged directory, don't try to run blame.
Change-Id: I563f7a687b2ea03f4c03bf97c8f5c27c1f8411ec
Reviewed-by: André Hartmann <aha_1980@gmx.de>
The starts with CppDocument::filePath(), plus a bit of the fallout
This is one patch of potentially many. It is hard to draw the
line where to stop this kind of chunk, this here converts a few
additional functions for which including it in the patch looked
like less churn than without.
Converting is mostly fromString/toString, with a few exceptions
for "already seem" like caches, that use cheaper "path()" to
avoid likely performance regressions (on Windows FilePath
comparison is currently case-insenstive, and more expensive).
There should be no difference for local operation with this patch.
Change-Id: I7b35f98a0a6f0bfed4ea0f8f987faf586f7a8f2b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Remove undefined and unused handleStdErr() and
handleProcessFinished() methods.
Remove cleanup() and finishDeployment() methods
and move the implementation into stopDeployment().
Change-Id: I983e4513c4bcba45638eb054b389783ec4f73367
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Instead of creating the actual command in two places
this change moves everything into one function.
Instead of sending the environment and working directory
into the shell as arguments, we send it via the correct
docker exec cli arguments.
Instead of creating QStringLists and adding them
to a CommandLine we directly add them to the
CommandLine instead.
This also fixes an issue when the working directory
contains spaces.
Fixes: QTCREATORBUG-28476
Change-Id: I4f5b39a2dd4c86d20717dbb53003f1eb60f6c089
Reviewed-by: hjk <hjk@qt.io>
addCommandLineAsSingleArg allows to reliably create commandlines
like "bash -c 'echo ...'"
addCommandLineWithAnd combines two command lines
by adding '&&' in between
Change-Id: Ic5af34c90fd5271dced40ba1341a3df019ededb8
Reviewed-by: hjk <hjk@qt.io>
It's being done implicitly by QSharedPointer d'tor.
Change-Id: I058dd3e1c06eb92fad4ea8b5d43ee4d1da9182c4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... when destructing a qmljseditor. Just let the updater continue and
delete it once it finishes.
Fixes: QTCREATORBUG-28206
Change-Id: Icabe10f17b7bf326bb15e5ee622504c477d83acf
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Apply to selected model/material, delete, duplicate, and
create new options are available in the menu.
Fixes: QDS-8342
Change-Id: Ib9bdc1738500a87361000bcd3e89403e3b8ccef8
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
If material library is missing, material browser and editor UI should
be disabled, except for material editor main pane in case of root
material node.
Change-Id: I3d2bd545de0649fb90d3fe1f751d46b7c7054bbf
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Call stopDeployment() also when process didn't finish with
FinishedWithSuccess.
Change-Id: Ibeafecb9e06a02650de35d635c1acfaa5af22870
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Don't call QtcProcess::close() from QdbStopApplicationService
destructor - this is done implicitly by QtcProcess destructor.
Remove cleanup() method, since it's used only by stopDeployment().
Change-Id: I6e82fe83f31f7dd8eb4fd69174c1aebc636de53d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
It was used only by handleDeploymentDone().
Change-Id: Ie294b4c2adf28a5b086941106d1c360e2f8992df
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Create effect node needed to be added to a transaction
There are other fixes to the effectmakerplugin
Task-number: QDS-8152
Change-Id: I37eac416e7664ae4a28a0a3362f98080ca29fd17
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Use FilePath::refersToExecutableFile() instead.
This makes it better re-usable for remote setup.
Change-Id: Ic69739b332f036ed791adbbc8092a139b4c83c2d
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
A file that is in the repository directory, but not managed by Git should
not attempt to run instant blame on every cursor change.
Change-Id: Ia7daa2ae9980cea4363e010a98fb1e2f2a3ec05f
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Also simplifies the code.
Change-Id: I5da0aeb86ba5a28c9016cde11aab9dcee922d908
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
The workaround that fixed the drawing of arrows after a change between
6.4.0 and 6.4.1 broke the drawing of arrows with Qt 6.4.0.
This change add another enforced detachment of the palette (leading to a
modified cache key) that works with Qt 6.4.0. It still works with 6.4.1.
Amends: 9d32093421
Change-Id: I8917c99488cec4fb17ed148bb3b0f95d4ed7127c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
... until launch time. More central, less duplicated activity.
Change-Id: I7d0e380c43e0f2cdbc1b50ac10f6739c65adb9bf
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Part of an attempt to disentangle streamline environment creation/setup.
Searching is expensive and needs currently the proper environment.
Change-Id: I95d93abf6c0cedeb8ba0b7a447345cd033ac2f25
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Using the reported range to create a usable placeholder if the
cursor ('|') is placed on the end of an identifier like in:
int global|;
Change-Id: I2ebacf3b9b54cff8f8887526479792374f67c881
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... to replace Environment::isSameExectuable().
New code is a filepathified copy of the orginal.
Change-Id: Iebf61cd183c9a5c03a5b8a90a33b5e074af9ecbe
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
The original change introduced emitError() function in
place of bare emit error() in order to record the last
error emitted inside m_errorString. Apparently all
emit error() usages were replaced with emitError(), even
the one inside emitError().
Amends 3a1f94ec28
Change-Id: I298ee7c04506d45d2a0cf176739cad02da0d302e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Inspired by the Visual Studio Code plugin GitLens.
Add an annotation to the editor line the cursor
is currently in. A tooltip contains the commit
data and allows to invoke git show for the commit.
When the automatic annotation is turned off, it can
still be forced for the current line with an action.
The default shortcut for this action is: Alt+G,Alt+I
Task-number: QTCREATORBUG-23299
Change-Id: I58eef9efcf531afb11470e5f5456e19f282b18d0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
If a build preset doensn't reference a configurePreset, the preset is
invalid but Qt Creator crashes.
Task-number: QTCREATORBUG-24555
Change-Id: Ibf5dd7f1bb165d8b7f392e6a1aaa043548bb0f7a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
- Do not hide, but just disable currently non-applicable actions.
- Properly group the closing-related actions in the project context
menu.
This makes for more stable menu entries and reduces the chance for
accidentally choosing the wrong one.
Task-number: QTCREATORBUG-28211
Change-Id: I26ddc71839d124ec92212971f2facea82cf8d199
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
