Commit Graph

68765 Commits

Author SHA1 Message Date
Marcus Tillmanns
4aef48de5e Utils: Add AspectList::createAndAddItem
Adds a function to add a "default" constructed new item to the list.

Change-Id: I3d826b6f3e3705ae431efa5d778219f431509ea8
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-11 10:29:14 +00:00
Jarek Kobus
d021f9158b SemanticInfoUpdater: Simplify internal implementation
Change-Id: If9913ccbc66d35608d18286ea3ca12d751ad2115
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-11 09:22:35 +00:00
Jarek Kobus
716c194846 KitManager: Use static methods instead of lambdas
Get rid of kitMatchesAbiOfBinary lambda - use kitMatchesAbiList
directly instead.

Change-Id: Iefd142b97967517b9c5abbd0721470a6ded584ed
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-11 09:10:58 +00:00
Jarek Kobus
7ee0687ad5 SemanticInfoUpdater: Make doUpdate() static
Don't operate on the same SemanticInfoUpdaterPrivate
instance from 2 threads.

Use future synchronizer for quick cancel.

Drop using QMutex, as now the threads are separated.

Change-Id: I33bb1485ff03751ec5a1481f5be5c21a48ac3fd4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-11 09:10:36 +00:00
Marcus Tillmanns
692fe58427 Terminal: Add debug button to easily copy theme
Adds a button to copy the current theme to the clipboard
in a format suitable for the Qt Creator Theme files.

Change-Id: Ib302d0544507b3111675a99f0915323d61d684c5
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-11 08:44:04 +00:00
Jarek Kobus
973dbaed98 PyDapEngine: Start install process directly from the main thread
There is no need to start it from a separate thread.

Change-Id: I0f560345ed0f02832176a8986a9fbdd97061d3ae
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2023-10-11 08:06:21 +00:00
David Schulz
adfdf3fe27 Help: make unregisterDocumentation async
Just like registerDocumentation this function can take a considerable
amount of time. As this function is also executed on startup it
increases the perceived startup time.

Change-Id: I43f4bb61293948c78eb7394d202757af83210eaa
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-10-11 07:38:24 +00:00
Jarek Kobus
ab13b7b155 HelpManager: Hide registerDocumentationNow() in cpp
This avoid calling collectionFilePath() concurrently,
which might be potentially problematic.

Change-Id: Ic873b6429b933f2f3359623b1e9cb14409ef3c4b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-11 07:31:08 +00:00
Jarek Kobus
3391d789b9 PluginManager: Don't delete timer in its signal handler
Delete it later instead.
The startDelayedInitialize() is invoked directly by
delayedInitializeTimer's timeout() signal.

Change-Id: I8813679c5cf150cfe91b6bf48559c83b7e3cd893
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-11 07:13:59 +00:00
Christian Stenger
b63c0670f8 SquishTests: Fix finding help contents
Fixes suite_HELP.

Change-Id: I57c0b82a758d3c91f29c4c48a8c33672f71afde2
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-11 06:57:18 +00:00
Marco Bubke
100ea34060 Sqlite: Make SmallString::number locale independent
std::to_string is locale dependent. std::to_chars it not. Because some
of our supported compiler(libC++) don't support std::to_chars for float
we use the QString.

Change-Id: I9a8f5d1d9b769faca0a7ac2d0798b91ee6b814d2
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-10-11 06:54:01 +00:00
Cristian Adam
c929b71acd CMakePM: Add cache variables to code completion
Change-Id: I5ac4fcf3ca7755ab52ffecafd83922e4e380363e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-10 18:29:06 +00:00
Cristian Adam
524634f124 CMakePM: Add support for "$ENV{" code completion and help
CMake has a few environment variables that are documented and this
commit adds support for them.

Change-Id: Iaa31bdc97b343581fcf519d19e66bc6ce8ace150
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-10 18:08:13 +00:00
Eike Ziller
311fe1bf24 Beautifier: Fix saving of settings
Applying didn't actually apply the new values.

Fixes: QTCREATORBUG-29586
Change-Id: If9416cc18fffd269f6ca3d27523aa138e6f91d7a
Reviewed-by: hjk <hjk@qt.io>
2023-10-10 14:38:21 +00:00
Eike Ziller
b14e7d0cb7 Fix the name of Win/ARM/64 wininterrupt executable
Just differentiating between 32 and 64 bits isn't enough anymore. Do the
same as for the cdbextension.

Change-Id: Ic5acc256641b5b63568d1ef4df825aea0724d756
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-10 14:37:53 +00:00
Jarek Kobus
4e649a0ac9 RefreshTranslationWorker: Call RunWorker::stop from main thread
Amends dc78c8faa2

Change-Id: I7254d6ea275f84e8e39fa4b21c4f33d24f81a3ae
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-10 14:35:32 +00:00
hjk
fa01c8029a CppEditor: Keep track of FilePath instead of QString
... in CppSourceProcessor::mergeEnvironment().

This is functionally equivalent as the scheme/host bits are identical
within normal projects.

The temporaries for path() were responsible for 10% of the time in the
function, in total ~0.5% of the C++ parsing in my Creator-in-Creator setup.

Change-Id: I7f4f163f0f4b46ebf876d631a8dc5fae667e9fd2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-10 13:16:44 +00:00
Amr Essam
5cfc9734d6 QmlDesigner: Create temp files for generated shaders
Also some cleanups regarding usage of QShaderTools

Task-number: QDS-10811
Change-Id: I655189e53a39e8342d849d3ffff0f89de9beb5e5
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-10-10 12:40:47 +00:00
Christian Kandeler
f723b59bfc ProjectExplorer: Do not follow recursive symlinks
Also fix some inverted logic along the way.

Fixes: QTCREATORBUG-29663
Change-Id: I7a5027d4536e6a05e5d91a4d2d24780bae3ca259
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-10 10:41:56 +00:00
Christian Stenger
87856470f7 TextEditor: Suppress warning in QFont
Change-Id: I2ffaa8f9ebebc048c298c84143e9bf3d55520554
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-10 10:41:45 +00:00
Cristian Adam
afc6d555b3 CMakePM: Do not copy the PerformInputData structure
I needed to add more members to the structure, and will get static
analyser to complain that the number of bytes is to high.

Amends 3984108c0c

Change-Id: I162b9ef615dc7f6f76b08c5599eed24488bf7e88
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-10-10 10:04:14 +00:00
Jarek Kobus
6899e0cfae BuildManager: Add a progress label for awaiter task
Change-Id: I01d70a9dc4115407c33e171e44943935825a6ac9
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-10 10:00:24 +00:00
Ali Kianian
c63caa5a39 QmlDesigner: Remove the selected row/column
Task-number: QDS-10948
Change-Id: Iefaa658bef20bed5f8ecb9f7f288871b7d0ee83a
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-10-10 09:05:56 +00:00
Ali Kianian
c12fce7570 QmlDesigner: Add rows to a collection
Task-number: QDS-10619
Change-Id: I37a2b7ebdc3abd8f72a5fe3e7e5fd82e173cd9ea
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-10 09:05:49 +00:00
Ali Kianian
e3159b3ec4 QmlDesigner: Make collection row selectable
Task-number: QDS-10920
Change-Id: I8d3f34b62b03b0890183c325e89818d578fe449e
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-10-10 09:05:04 +00:00
hjk
c90a6df6ef Revert "Utils: Fix BoolAspect::action"
This reverts commit 4c5e3aa6ba.

Not needed anymore. The action likely ends up in a menu or such
where it is effectively 'autoapply'.

Change-Id: Ib02cba871028fa1422e10622d263218089226c56
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-10 08:46:04 +00:00
Amr Essam
93ba99f019 QmlDesigner: Prepare the process to compile shaders externally
Also added customValue for Uniform

Task-number: QDS-10811
Change-Id: Ie47ad41d0c80da149bdab9cae542297d59abcee6
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-10-10 08:39:45 +00:00
Ali Kianian
82be17c2c6 QmlDesigner: Add row id to the collection table
Task-number: QDS-10621
Change-Id: Ib41f7b9a8ce8d19c24b7580887f7c44a7f87fbdc
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-10 08:33:45 +00:00
Ali Kianian
8d4e103eac QmlDesigner: Add columns to a collection
Task-number: QDS-10619
Change-Id: Ifa38b2ec8210e7ca7260d3307d3906fd609f3c62
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-10-10 08:33:30 +00:00
Miikka Heikkinen
9712d4ca04 QmlDesigner: Replace AxisHelper with OriginGizmo
The new gizmo is more intuitive.

Fixes: QDS-10880
Change-Id: I8d3f1723ae0fb748d1b96c31b10e6753e0e2c709
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-10 08:25:27 +00:00
Miikka Heikkinen
32b68b296a QmlDesigner: Add enter and leave event support to 3D view
Fixes: QDS-10917
Change-Id: Iefcf92bd4a747d35f44e47c438548338fccfc4a2
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-10-10 08:25:17 +00:00
Eike Ziller
8ca6890814 QmlDesigner: Quiet messages from find_package
The information is available via the CONDITION and FEATURE_INFO

Change-Id: I0da6338736316e5976c1addad6c25d083e7d772d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-10-10 08:22:42 +00:00
Marcus Tillmanns
f1c3482e0d CMake: Fix default cmake tool
If Boot2Qt devices are registered, their CMake tool would often end up
as the default. Instead now we only auto select a cmake tool on the
local machine.

Change-Id: I677ab06ae88ff36209e691ea0fadb356436e973c
Reviewed-by: hjk <hjk@qt.io>
2023-10-10 08:20:14 +00:00
Marcus Tillmanns
c9cf86856c Terminal: Add support for Windows Terminal schemes
Change-Id: Ic6911bdcd2152a5fec8be54a515c5df13c3c08d7
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-10 07:51:53 +00:00
Cristian Adam
45fb2c0986 CMakePM: Remove pointer check for null
The pointer contains the parent class passed with "this" and will never
be null.

Coverity-Id: 1568097 Dereference after null check (FORWARD_NULL)
Coverity-Id: 1568100 Uninitialized pointer field (UNINIT_CTOR)
Coverity-Id: 1568111 Dereference before null check (REVERSE_INULL)
Change-Id: I40e32d162689c749d498c4a63c073c0e336a3626
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-10 07:30:36 +00:00
David Schulz
6c9a710036 Utils: remove Q_ASSERT in comment detection
Change-Id: I076397ee56887c8b402d4c2b97838ceade165412
Reviewed-by: hjk <hjk@qt.io>
2023-10-10 07:11:32 +00:00
David Schulz
01dc62b019 Editor: Fix loading color schemes
When the user switched to another builtin color scheme the full paths
check do not match anymore if the user starts a Qt Creator with a
different install dir.

Change-Id: I4692c85a23a7d524497786db4dd8e1a00bb7a9fe
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-10 06:53:22 +00:00
hjk
6620add7df Debugger: Use device env of gdb for its own use
Fixes: QTCREATORBUG-29556
Change-Id: I966d4f226c4eee08ba35e1b3dfc6fcd1d771ce6f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-09 14:58:35 +00:00
Cristian Adam
a5f8214c23 CMakePM: Consider local CMAKE_PREFIX|MODULE_PATH for code completion
If projects are using a local "cmake" directory containing
Find<Package>.cmake modules the common practice is to use something like
this:

  ## Add paths to check for cmake modules:
  list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")

This commit makes sure that these packages are taken into consideration
for code completion.

Change-Id: I152ccce0c97ab2385eda93ff6bc5fc4e7cefb6c4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-09 14:41:45 +00:00
Cristian Adam
ad13144cc0 CMakePM: Search after packages in CMAKE_PREFIX|MODULE_PATH
This way code completion will have Qt6 package suggestions for
find_packages.

Change-Id: I9ab64425f850a0d990e77a559ce9f121bc9cf2d7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-09 14:41:35 +00:00
Marco Bubke
9236b1b019 QmlDesigner: Modernize the code a little bit
Change-Id: I24dffa459ad8a948fd58d83249cb07c827a6343f
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-10-09 14:05:03 +00:00
Marcus Tillmanns
8169e233c0 CompilerExplorer: Add Toolbar button to add source
Change-Id: I0d8fb50fe1ce5305a93b524a9807997124ab119b
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-09 13:02:31 +00:00
Xavier BESSON
23908b283e Bookmarks: goto on double click + drag & drop on view
Change-Id: Iec21843fb6679d156e9839f84e56005b8eef7f32
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-09 12:47:26 +00:00
David Schulz
6adaa850e8 LSP: rename Create/Rename/DeleteFile classes
Since they clash with default windows functions and cause issues with
PCH build.

Change-Id: Ice0339c7dad14b40e172c885ffb71d923469614a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-09 12:30:08 +00:00
hjk
8af6d16b6c TextEditor: Hide LineNumberFilter implementation
One of the two non-standard items exposed in the TextEditorPlugin class
interface.

Change-Id: I89755c6a2b168f31b69d3904d6d043273b462ea6
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-09 12:23:25 +00:00
Jarek Kobus
d278923dd4 CMakeParser: Ensure the details list isn't empty
Amends bda5c6a228

Fixes: QTCREATORBUG-29732
Change-Id: Iac518227df42c4d22b808028958210485a9c02ff
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-09 12:15:22 +00:00
hjk
04ee682bcc Core: Remove SessionManager::isStartupSessionRestored() mechanism
Apparently not used anymore.

Change-Id: I0ea8f70979450799c979ca5cd3314c834560b336
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-09 12:14:38 +00:00
Jarek Kobus
222bae949f BuildSystem: Remove unused signal
Change-Id: I5d0d58f749633dd2a00448868fc6068f9866972c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-10-09 12:12:15 +00:00
Eike Ziller
3b516524e3 Fix QmlProfiler when built with Qt 6.6
qrc:/qt/qml/QtCreator/Tracing/TimelineLabels.qml:29:5: Cannot override
FINAL property
         property bool dragging: false
         ^

Flickable has a `dragging` property itself, and in Qt 6.6 that leads to
this error.

Fixes: QTCREATORBUG-29719
Change-Id: I882e944035141622c0bdf65ee4fcb3cf145aef0d
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2023-10-09 11:15:51 +00:00
Christian Stenger
d4e7dfca76 Utils: Add compatibility for older settings
Adds compatibility for older settings - likely only relevant
for settings of snapshots or development QCs.

Change-Id: Icb6a9c054dea4deac5adbc4255bc60dcd6c14ea7
Reviewed-by: hjk <hjk@qt.io>
2023-10-09 10:57:58 +00:00