The warnings produced by these checks have always been somewhat broken.
Ever since they were added people users complained about the M325
warnings because they were confusing or because of false positives.
Fixes: QTCREATORBUG-29601
Change-Id: Ifac1ed0819a05251b3c4b583627cc45553e3d680
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Task-number: QDS-10681
Change-Id: Ide92c93c85f0d61b48c4c1cb0096cd8db201238d
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reuse it in CMakeEditor and CMakeFileCompletionAssistProvider.
Amends d04585b519
Change-Id: I8dbd59c815e017404ff215ca1ff68740d6653e91
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Seems to work on my GCC but lets see if older GCC can handle it.
Change-Id: I2932798da3691201f7dd4c8c981ae0dc29d01a86
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This is also the only case that triggered the short code path in
findCompilerCandidates().
Change-Id: Id8a88a275655526733e80c30250800db66ac6653
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
While parsing for Qt Quick Tests it may happen that an internal
map is accessed concurrently by different threads.
Guard against this. Minor drive-by optimizations.
Change-Id: Ic3b62c27feddb9a5ac5588a6c9643fc0e623ce19
Reviewed-by: David Schulz <david.schulz@qt.io>
The Key encapsulates now a QByteArray.
Plan is to use QByteArray::fromRawData on literals, but that's not
active yet due to an unclear ASAN report, see the gerrit discussion.
For now we also paddle back when interfacing QSettings, instead of mimicing
writing a QVariantMap (and fail in some corners), always convert
the Store. This is meant to go away in the future when code paths
are better controled.
Change-Id: Id1206a434d511f8003903d5322c7c9bd5f5fb859
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Not the big win yet, but doing the activity just once instead of
previously nine times.
Change-Id: Ibe8a782e1261228ef1ea8891878c45ea19e9bcf2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
- initialize opacity (was never used uninitialized though)
- fix include
Change-Id: Ic3a9f8154f1c4bd77e759b6b45ee06b20a394c8d
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
* LCA function accepts generic containers as the argument
* LCA returns an invalid node as the result if a node belongs to a
different model
* An additional condition is added to check the validity of the parent
nodes for the cases which a node has an invalid parent
Change-Id: I9d9c1891e75a3a6a84e797deed5210c02fd92522
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reducing the expected executable extensions can improve the performance
for search in path on Window. Especially if PATHEXT and PATH has a lot
of entries, since we collect file attributes for PATHEXT entry count
times PATH entry count file paths. Use this optimization in the android
toolchain to search for java.exe on windows.
Change-Id: I2c2865d685c2de0c03a0fa1fbe7e8afd283174da
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Show Live Preview can be triggered with key sequence Alt+P even if you
are not in the designer view which results in access to invalid
pointers. To fix this, replace the check in action handler with
safer isValid which checks the validity of view and initialize live
preview for valid contexts.
Fixes: QTCREATORBUG-29642
Change-Id: I9dd1741f1de2722a7ac715a2726b6effbe91529c
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Split up EditorWidget constructor into member functions.
Change-Id: I4c762671263b802612a750568f608ac1823b41a4
Reviewed-by: David Schulz <david.schulz@qt.io>
Also include "src/plugins/**/wizard.json" into .gitignore.
Change-Id: Ib0576df15af4c112a4a27101d337522db6c19f25
Reviewed-by: David Schulz <david.schulz@qt.io>
So far the main window acted a bit like ICore's pimpl.
Aim at making that a bit more similar to other places.
The files are kept for now to not have to adjust #includes
all over the place and there's some hope to move code back there.
Change-Id: I150e2dd0971bfab44cba89e0c51bb3f37062b8d3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
If the main window un-maximized size is small (below the threshold for
hiding the side area) and the maximized size is large, the resizeEvent
is called twice - once with the original size, and then on show, it is
called again with the maximized size.
The second call (with the delayed QTimer::singleShot), is called after
delayedInitialize() is done, so the side area remains hidden for a few
seconds before it reappears.
The commit that exposed this behavior is 0b85fc5aa0, which changed the
expensive toolchain loading to happen in delayedInitialize.
Solve this by emitting the signal only after the widget is visible.
Change-Id: I0ad2c16a42742046da6847a5f108b797f91fabff
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This replaces the four classes from the GccToolChainFactories
hierarchy by a single (parametrized) GccToolChainFactory, but
makes the "RealGcc" one responsible for all autodetection.
This is a hack to move closer to a "scan only once" setup, and
temporarily necessary as there is currently one factory creates
one type of toolchain, so we need four factories for the current
four gcc-ish toolchain types.
Change-Id: Icbecb1be6e89cf5efad76baf92ef38ac63be074f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Previously the undo state was not updated when the value
was set from the outside before the gui model was setup.
Change-Id: I380916f888edd120f512089bdb94762977c11978
Reviewed-by: hjk <hjk@qt.io>
... to base as preliminary step to merge the factories. Combining
the code paths is not part of this change to keep it mechanical.
Change-Id: Ia1a43000a1e3978eae85be36493a67a18ba0c3e6
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
ModelNode is already quite big and there is no need add more utility
functions.
Change-Id: I5e81c320c4934fc452c05f21b3c878354f857424
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This would always result in no hits, contrary to NoFilter.
Change-Id: I22591581373eed10fb1d1f660f705992e9653d5a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
