Commit Graph

68765 Commits

Author SHA1 Message Date
Amr Essam
4978cbc5f6 QmlDesigner: Fix missing forward declration
Change-Id: I8969153ec6bb531c2c5bcfa47bf99b15aefbd552
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-06 16:11:18 +00:00
Thomas Hartmann
c254ba7106 StudioWelcoome: Fix help url
Change-Id: I3566d09e884b661d58795178fd97e4c9ae345a9d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-06 14:08:08 +00:00
Marco Bubke
94003d76af Utils: Disable warning about unsafe buffer access
There is a compile time check for the size but it seem that clang is
missing that information.

Change-Id: I53ea97cd2a56f11e7ff4428a13b39d19a7d73cf1
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-09-06 14:00:10 +00:00
Amr Essam
1474afe8db QmlDesigner: Add more shader compiling support functionality
Functionality for adding default shaders, tags, and varying variables

Task-number: QDS-10499
Change-Id: Ib32e558510fb37c29765d2467cfc4c047a446a87
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-09-06 12:12:36 +00:00
Marco Bubke
99cabee246 Sqlite: Add hash operator to BasicId
Because QHash is supporting std::hash we don't need to add a qHash
function. That is saving us an include to qhashfunction.h too.

Change-Id: I457051c828d25771028f3f28bf19ecb65c51edd1
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-06 11:32:40 +00:00
Eike Ziller
7082d2a89b QmlJS: Delay loading of default QML type descriptions
We definitely do not need to do this during startup of Qt Creator, delay
to first use.

Change-Id: I5942b5346aedc3d6b677918ad28a6c2924d09493
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2023-09-06 10:52:36 +00:00
Marco Bubke
250b2cd7bd Sqlite: Introduce implicit transaction
Sqlite adds an implicit transaction if no transaction is used. That can
be problematic if you use multiple statements but it is okay for one
read statement.

Write and read write statements should use immediate transactions
because the acquire the write lock. Otherwise the write lock is only
acquired as you try to write. From there it is much harder to recover.

Change-Id: I04b0be7447f2b82b6921738d789c33cbbaa8de6e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-06 10:28:43 +00:00
Marco Bubke
d04f08e320 QmlDesigner: Hopefully fix strange MSVC fail
Change-Id: I9677a85269a7496d557e7e3e9127604e48f668a4
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-06 10:24:59 +00:00
Artem Sokolovskii
68d12f0724 DAP: Fix python debug stoping
Change-Id: I49ac6d9d7164a7f74fe683840734d903643b3561
Reviewed-by: hjk <hjk@qt.io>
2023-09-06 09:50:17 +00:00
Artem Sokolovskii
1b67da6558 DAP: Show variables for different scopes
Fixed displaying several the same variables.

Change-Id: I848113de3a5e142394fbdb4efd40230f43c2417f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-09-06 09:49:58 +00:00
hjk
e0ebce5379 QtSupport: Split QtVersionManager in a early and late constructed part
Change-Id: Iccf3f0e6c927fba1d5a9065978cc545d96185060
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-06 09:46:31 +00:00
Marco Bubke
b8f97713c5 Utils: Exchange std::span implementation
The old implementation was not supporting iterators. Which made it a
little bit complicated to use it together with algorithms.

Change-Id: I99cf43dffb4bcb83a953ca1c68ebc65722142ad9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-06 08:37:05 +00:00
Christian Kandeler
cf9846ba77 ProjectExplorer: Sort toolchains in settings widget
Change-Id: Id7acb146e23863b38920bcc9e4508113859568af
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-06 08:28:32 +00:00
Eike Ziller
63927a8d6a ActionManager: Centralize ActionContainer update
Each ActionContainer used to schedule an invokeMethod on the event loop
when it changes, which creates an unnecessary amount of individual
events, especially during startup.

Instead schedule that update through the ActionManager, which then can
schedule a single event that handles all updates up to that time.

Change-Id: Ia193606adc4cfda88df8e45f2027662ca16f2ad3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-06 07:52:55 +00:00
Christian Stenger
a59a8d123f Terminal: Add qrc to qbs build as well
Amends e17866e283.

Change-Id: I24d1933da364dc13933da94e1af09146367b4a3f
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-06 04:24:39 +00:00
Marcus Tillmanns
e17866e283 Terminal: Show key when input is hidden
Change-Id: I5fca6a8c4f43ea2b95bad4df247b5df0abad521c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-05 13:18:36 +00:00
Aleksei German
14b96533fc QmlDesigner: Fix Binding Editor for When Condition
Task-number: QDS-10537
Change-Id: Icc996fe3a52f66d5e16dd2aa840032b9687a7f1d
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Aleksei German <aleksei.german@qt.io>
2023-09-05 12:49:49 +00:00
Marcus Tillmanns
c32b7067fe Android: Don't unnecessarily test toolchains
Change-Id: I19046800c4fce6e7d2cd8d66381ac74ae41aa620
Reviewed-by: hjk <hjk@qt.io>
2023-09-05 12:37:03 +00:00
Alessandro Portale
fedf99b037 Introduce the Screen Recorder Plugin
The screen recorder plugin allows a user to record the contents of a
screen (or part thereof), and in a second step to export the result as
various lossless or lossy animated picture or video formats. Before
exporting, the recorded video can be trimmend in length and be cropped
in size.

All functionality relies on the ffmpeg/ffprobe tools, which need to be
present on the user's system.

This initial version of the plugin introduces a settings page, and a
recording/exporting dialog with sub dialogs for recording and export
options.
Some autottests for ffmpeg/ffprobe output parsing are included.

Task-number: QTCREATORBUG-29366
Change-Id: Iaf16d369fd9088d69b1bd130185ca920d07b34c6
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-05 12:36:21 +00:00
Marcus Tillmanns
640a4f0c9c QtSupport: Cache Qt Version information
Change-Id: Iabdd4f880e492fe5ab7ee6d633c8f1f70b4c2cb8
Reviewed-by: hjk <hjk@qt.io>
2023-09-05 12:36:11 +00:00
Artem Sokolovskii
19aeb45abd DAP: Remove redundant source field in breakpoint structure
Change-Id: I30c952971353ab316791cd68cf91f192bd398b84
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-09-05 12:35:14 +00:00
Marcus Tillmanns
1c5aa22257 Utils: Add PersistentCacheStore
Change-Id: I952e0271afcc0fd4b03ef75fa5acb219be153290
Reviewed-by: hjk <hjk@qt.io>
2023-09-05 12:22:06 +00:00
Mahmoud Badri
9bbe78df8b QmlDesigner: Implement effect maker node drag to reorder
Also small relevant tweaks

Fixes: QDS-10411
Change-Id: I332482d4726c79786edbc0a5fa1e8f6489d77f11
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Amr Elsayed <amr.elsayed@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-05 09:12:33 +00:00
Miikka Heikkinen
6251730f8f QmlDesigner: Refactor 3D view background and grid color implementation
The new implementation doesn't require these colors to be stored in
external dependencies anymore, as auxiliary properties are used for
them instead.

Fixes: QDS-10496
Change-Id: Ie71408617259d1af73a45f327d4bdfa4f2fa3a2b
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-09-05 08:49:34 +00:00
Cristian Adam
e892a6224f CMakePM: Save document before doing file operations on the CMake
Fixes: QTCREATORBUG-29550
Change-Id: I5ec360a48adce0d51a7fbe1704c7d4a9125bd913
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-05 08:41:43 +00:00
Christian Kandeler
7adeaafd93 QtSupport: Use natural sorting for Qt versions in settings widget
Change-Id: I4ef14a575c536e9f789fedf24937bd0f9e118f91
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-05 08:27:55 +00:00
Marcus Tillmanns
0c7e7c545a ClangFormat: Fix compilation with Qt 6.2.4
Change-Id: I71f28a258ad9f3b2e745c409edb6d2fe1a5bfea3
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2023-09-05 08:25:05 +00:00
Marcus Tillmanns
c14c021e45 Utils: Use QtcSettings
Fixes compile errors with Qt 6.2.4.

Change-Id: Ia97d5fcbeb80ee1242fd4c2425bc7f325dad8953
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-05 08:24:31 +00:00
Marcus Tillmanns
7ad4589f5d LSP: Fix compilation with Qt 6.2.4
Change-Id: I1f81d35529317107c63727a92d940a3991ddc59d
Reviewed-by: hjk <hjk@qt.io>
2023-09-05 08:05:55 +00:00
hjk
a475632c66 Utils: Make TreeViews use setUniformRowHeights by default
When applicable, the flag makes a significant difference in
performacnce. However is easily forgotten in cases where it
is applicable, and cases where it is accidentally used are
easily spotted visually. So arguably, opt-out is a better
default than opt-in.

Change-Id: I88aeb05b42533ba4e23c39573a3ddd016343cd55
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-05 07:24:21 +00:00
hjk
b9188fb747 QmlJSEditor: Remove unneeded indirection via qmljsicontextpane.h
Change-Id: I39989fdb697dc7078a01f9582b790ee91021e3ab
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-05 07:14:18 +00:00
Marcus Tillmanns
76a95ff0ee Utils: Switch to QtcSettings
Changes a few remaining QSettings members that popped
up when trying to build with "apt-get" Qt 6.2.4.

Change-Id: I3caa8545cf02d6453b802559c2f65279e1fb63fd
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-05 07:02:24 +00:00
Ali Kianian
0d04bf9560 QmlDesigner: Prevent the dynamic property from being overwritten
Change-Id: Ia0bd78e0b1293b6d61251a68d7b4cf4ee234603e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-04 16:52:08 +00:00
hjk
837fadafbd Android: Use a bit more LayoutBuilder in AndroidApkBuildStep
Change-Id: Ic783a528c56849d02f828013683ed58d9fd575be
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-09-04 14:07:50 +00:00
Christian Kandeler
eef56c79b9 ProjectExplorer: Use natural sorting for kits
As used in settings page, target list, target setup page.

Task-number: QTCREATORBUG-29509
Change-Id: If7f7c5fabb8fc7f26e0c864a221c9cc0c594279b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-04 14:03:27 +00:00
Christian Kandeler
c8ecacb335 StringUtils: Use natural sorting in caseFriendlyCompare()
Seems to be the right choice in the contexts we use it in.
Supersedes db1d12f69a.

Task-number: QTCREATORBUG-29509
Change-Id: I3816ec57d8484404420c7bee1c2b12e8df224cb8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-04 14:03:09 +00:00
hjk
6888d93385 Core: Rename unusual SessionManager pimpl
Left-over from the PE/Core split.

Change-Id: Iea6bffa5487a43eccb04ec677fc558651a8fa997
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-04 13:46:15 +00:00
hjk
c4f2c14aa2 QmlJsEditor: Delay construction of QuickToolBar
It's now apparently created when the first .qml file opens.

Change-Id: I4bcd84d29da268565ee6e771f8c56c8b07ecdaf3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-04 13:40:06 +00:00
hjk
3170973723 Android: Lump apk build step creation together
Just moved code for now, will be better for LayoutBuilder.

Change-Id: I722f08b8efa13c3df8ffced3d87f8ad2870345d4
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-04 13:27:56 +00:00
hjk
4d89183268 BookMarks: Hide some BookMarkManager implementation details
Change-Id: Icfc2ca62fb66ff6be6f1f07bbe3e99b35b4c146b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-04 13:13:44 +00:00
hjk
c655c1733b Clean up some navigation factory implementation
Change-Id: Ibbff643daf88200d50fb0343dd40b03803074081
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-04 13:13:28 +00:00
Christian Kandeler
6847d69008 CppEditor: Consider comments when extracting a new function
That is, do not place the newly created function in between the function
and its comment.

Fixes: QTCREATORBUG-6934
Change-Id: I79f564a90c7e3c45188f5d694cbde47029651324
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-04 12:45:23 +00:00
Christian Kandeler
429da62c1a CppEditor: Consider parameter comments in "apply changes to decl/def"
That is, when a function parameter name is changed in the declaration,
apply the renaming also to the function comments at the definition and
vice versa.

Task-number: QTCREATORBUG-12051
Task-number: QTCREATORBUG-15425
Change-Id: I9104512ef8cdca8c37e4f8ac87117476f850117a
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-04 12:44:20 +00:00
David Schulz
4ee863060a Qmlls: only update latest qmlls if the setting is enabled
Change-Id: I0adb24db3a944c6a400cfd84e10974f9bdc0d560
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-04 12:29:26 +00:00
hjk
2e5805d4b0 TextEditor: Hide part of OutlineFactory implementation
Change-Id: Ifb1c743ba53e2e55605b78336b57c993c12ead3e
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-04 12:13:05 +00:00
Amr Essam
23a61ca926 QmlDesigner: Add syntax highlighter data for shader tags
Task-number: QDS-10499
Change-Id: Idbf99f1a86055085c53adaaed15af6058e39b39c
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-09-04 12:08:22 +00:00
Christian Kandeler
817d72df7f ClangTools: Always print stderr output
E.g. clang-tidy prints error messages for invalid config files, but then
continues to run and finishes with exit code zero.

Fixes: QTCREATORBUG-29298
Change-Id: Idbfb7998994ac8197cd863f4bbb2c64ac1bd5525
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-04 12:08:16 +00:00
Marcus Tillmanns
705232c737 TextEditor: Allow overwriting undo handling
In preparation for CompilerExplorer undo / redo handling.

Change-Id: Iefad5cc497c8e439f626e375fe8862526b52a36e
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-04 12:04:14 +00:00
hjk
37022ff0df CppEditor: Remove an unused member
Change-Id: I6bf26bbd2f1c8542ae2d645f7db9e2eba3f7a33f
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-04 11:26:46 +00:00
Sami Shalayel
79cc12ab8c qmljseditordocument: fix quickfix shortkey
QtC shows qmlls's warnings, but does not apply quick fixes to it when
using the quickfix shortkey. In quickFixAssistProvider, use the base
class implementation to detect running language clients and apply their
quickfixes, and fallback to the builtin qml code model quickfix if no
language client is running.

Fixes: QTCREATORBUG-29557
Change-Id: I75262d13ab229f8d3b4069fc0003574d41cabab0
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-04 11:08:07 +00:00